From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A403C433EF for ; Tue, 5 Oct 2021 10:36:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 083BD61131 for ; Tue, 5 Oct 2021 10:36:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 083BD61131 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 7486F900002; Tue, 5 Oct 2021 06:36:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6F82D6B0071; Tue, 5 Oct 2021 06:36:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5C045900002; Tue, 5 Oct 2021 06:36:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0148.hostedemail.com [216.40.44.148]) by kanga.kvack.org (Postfix) with ESMTP id 4C8086B006C for ; Tue, 5 Oct 2021 06:36:19 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id EE6451802DE12 for ; Tue, 5 Oct 2021 10:36:18 +0000 (UTC) X-FDA: 78662029236.12.DE679CB Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf12.hostedemail.com (Postfix) with ESMTP id 69C531001512 for ; Tue, 5 Oct 2021 10:36:18 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 1F2F2223D4; Tue, 5 Oct 2021 10:36:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1633430177; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WDN9V/BeLKiMrD/NI8A/rmkR0bzQ+C++6QXeRdaaYE0=; b=oA3nljbIC/pdvSjSnrz7YNsY0WuV1FIdyTQeaopxKgA6982NbAlTK5yNADNxfiQp6kOgju p2JE2R4TF8RDIEvhpjbQ9qcqZ9NToZmRmSkHeUQUOXl2XpT7mKr0uJNg1N1ymfyFYiQLLg jSKEL/c1AOLFPiKl/E1nIufeEeDV//8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1633430177; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WDN9V/BeLKiMrD/NI8A/rmkR0bzQ+C++6QXeRdaaYE0=; b=71FMYGcWvcmw0sGzEsYP4E1jrTuz5NfQBhdP/YnVwklCYQlb6FUWz5Fj+D2mOCjYbJoCLp yK2/E3sch7y7HnBQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id CA02313C2B; Tue, 5 Oct 2021 10:36:16 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id b3cYMKAqXGHcIwAAMHmgww (envelope-from ); Tue, 05 Oct 2021 10:36:16 +0000 Message-ID: <81ba4693-2928-931c-ab92-17359277f018@suse.cz> Date: Tue, 5 Oct 2021 12:36:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.2 Subject: Re: [PATCH 4/5] mm, slub: fix potential use-after-free in slab_debugfs_fops Content-Language: en-US To: Miaohe Lin , akpm@linux-foundation.org, cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com Cc: gregkh@linuxfoundation.org, faiyazm@codeaurora.org, andreyknvl@gmail.com, ryabinin.a.a@gmail.com, thgarnie@google.com, keescook@chromium.org, bharata@linux.ibm.com, guro@fb.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20210916123920.48704-1-linmiaohe@huawei.com> <20210916123920.48704-5-linmiaohe@huawei.com> From: Vlastimil Babka In-Reply-To: <20210916123920.48704-5-linmiaohe@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 69C531001512 X-Stat-Signature: r9wryudobrtuqnitpqkus9drcgcy9xh1 Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=oA3nljbI; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=71FMYGcW; dmarc=none; spf=pass (imf12.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz X-HE-Tag: 1633430178-602480 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 9/16/21 14:39, Miaohe Lin wrote: > When sysfs_slab_add failed, we shouldn't call debugfs_slab_add() for s > because s will be freed soon. And slab_debugfs_fops will use s later > leading to a use-after-free. > > Fixes: 64dd68497be7 ("mm: slub: move sysfs slab alloc/free interfaces to debugfs") > Signed-off-by: Miaohe Lin Reviewed-by: Vlastimil Babka > --- > mm/slub.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/mm/slub.c b/mm/slub.c > index bf1793fb4ce5..f3df0f04a472 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -4887,13 +4887,15 @@ int __kmem_cache_create(struct kmem_cache *s, slab_flags_t flags) > return 0; > > err = sysfs_slab_add(s); > - if (err) > + if (err) { > __kmem_cache_release(s); > + return err; > + } > > if (s->flags & SLAB_STORE_USER) > debugfs_slab_add(s); > > - return err; > + return 0; > } > > void *__kmalloc_track_caller(size_t size, gfp_t gfpflags, unsigned long caller) >