From: Johannes Berg <johannes@sipsolutions.net>
To: Christophe Leroy <christophe.leroy@csgroup.eu>,
Sabyrzhan Tasbolatov <snovitoll@gmail.com>,
ryabinin.a.a@gmail.com, glider@google.com, andreyknvl@gmail.com,
dvyukov@google.com, vincenzo.frascino@arm.com,
catalin.marinas@arm.com, will@kernel.org, chenhuacai@kernel.org,
kernel@xen0n.name, maddy@linux.ibm.com, mpe@ellerman.id.au,
npiggin@gmail.com, hca@linux.ibm.com, gor@linux.ibm.com,
agordeev@linux.ibm.com, borntraeger@linux.ibm.com,
svens@linux.ibm.com, richard@nod.at,
anton.ivanov@cambridgegreys.com, dave.hansen@linux.intel.com,
luto@kernel.org, peterz@infradead.org, tglx@linutronix.de,
mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com,
chris@zankel.net, jcmvbkbc@gmail.com, akpm@linux-foundation.org
Cc: guoweikang.kernel@gmail.com, geert@linux-m68k.org,
rppt@kernel.org, tiwei.btw@antgroup.com,
richard.weiyang@gmail.com, benjamin.berg@intel.com,
kevin.brodsky@arm.com, kasan-dev@googlegroups.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, loongarch@lists.linux.dev,
linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org,
linux-um@lists.infradead.org, linux-mm@kvack.org
Subject: Re: [PATCH 2/9] kasan: replace kasan_arch_is_ready with kasan_enabled
Date: Wed, 25 Jun 2025 14:23:57 +0200 [thread overview]
Message-ID: <81a8b60be5b99ecd9b322d188738016376aff4aa.camel@sipsolutions.net> (raw)
In-Reply-To: <750b6617-7abf-4adc-b3e6-6194ff10c547@csgroup.eu>
On Wed, 2025-06-25 at 12:27 +0200, Christophe Leroy wrote:
>
> Le 25/06/2025 à 11:52, Sabyrzhan Tasbolatov a écrit :
> > Replace the existing kasan_arch_is_ready() calls with kasan_enabled().
> > Drop checks where the caller is already under kasan_enabled() condition.
>
> If I understand correctly, it means that KASAN won't work anymore
> between patch 2 and 9, because until the arch calls kasan_init_generic()
> kasan_enabled() will return false.
>
> The transition should be smooth and your series should remain bisectable.
>
> Or am I missing something ?
>
Seems right to me, it won't work for architectures that define
kasan_arch_is_ready themselves I think?
But since they have to literally #define it, could #ifdef on that
temporarily?
johannes
next prev parent reply other threads:[~2025-06-25 12:24 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-25 9:52 [PATCH 0/9] kasan: unify " Sabyrzhan Tasbolatov
2025-06-25 9:52 ` [PATCH 1/9] kasan: unify static kasan_flag_enabled across modes Sabyrzhan Tasbolatov
2025-06-25 10:35 ` Christophe Leroy
2025-06-26 9:31 ` Sabyrzhan Tasbolatov
2025-06-25 9:52 ` [PATCH 2/9] kasan: replace kasan_arch_is_ready with kasan_enabled Sabyrzhan Tasbolatov
2025-06-25 10:27 ` Christophe Leroy
2025-06-25 12:23 ` Johannes Berg [this message]
2025-06-25 12:50 ` Sabyrzhan Tasbolatov
2025-06-25 9:52 ` [PATCH 3/9] kasan/arm64: call kasan_init_generic in kasan_init Sabyrzhan Tasbolatov
2025-06-25 9:52 ` [PATCH 4/9] kasan/xtensa: " Sabyrzhan Tasbolatov
2025-06-25 9:52 ` [PATCH 5/9] kasan/loongarch: " Sabyrzhan Tasbolatov
2025-06-26 13:29 ` Peter Zijlstra
2025-06-26 13:52 ` Sabyrzhan Tasbolatov
2025-06-25 9:52 ` [PATCH 6/9] kasan/um: " Sabyrzhan Tasbolatov
2025-06-25 12:20 ` Johannes Berg
2025-06-25 9:52 ` [PATCH 7/9] kasan/x86: " Sabyrzhan Tasbolatov
2025-06-25 9:52 ` [PATCH 8/9] kasan/s390: " Sabyrzhan Tasbolatov
2025-06-25 9:52 ` [PATCH 9/9] kasan/powerpc: " Sabyrzhan Tasbolatov
2025-06-25 10:33 ` Christophe Leroy
2025-06-25 12:45 ` Sabyrzhan Tasbolatov
2025-06-26 10:52 ` Christophe Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81a8b60be5b99ecd9b322d188738016376aff4aa.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=agordeev@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@gmail.com \
--cc=anton.ivanov@cambridgegreys.com \
--cc=benjamin.berg@intel.com \
--cc=borntraeger@linux.ibm.com \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=chenhuacai@kernel.org \
--cc=chris@zankel.net \
--cc=christophe.leroy@csgroup.eu \
--cc=dave.hansen@linux.intel.com \
--cc=dvyukov@google.com \
--cc=geert@linux-m68k.org \
--cc=glider@google.com \
--cc=gor@linux.ibm.com \
--cc=guoweikang.kernel@gmail.com \
--cc=hca@linux.ibm.com \
--cc=hpa@zytor.com \
--cc=jcmvbkbc@gmail.com \
--cc=kasan-dev@googlegroups.com \
--cc=kernel@xen0n.name \
--cc=kevin.brodsky@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=loongarch@lists.linux.dev \
--cc=luto@kernel.org \
--cc=maddy@linux.ibm.com \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=peterz@infradead.org \
--cc=richard.weiyang@gmail.com \
--cc=richard@nod.at \
--cc=rppt@kernel.org \
--cc=ryabinin.a.a@gmail.com \
--cc=snovitoll@gmail.com \
--cc=svens@linux.ibm.com \
--cc=tglx@linutronix.de \
--cc=tiwei.btw@antgroup.com \
--cc=vincenzo.frascino@arm.com \
--cc=will@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox