From: Vlastimil Babka <vbabka@suse.cz>
To: Oscar Salvador <osalvador@suse.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Michal Hocko <mhocko@suse.com>, Marco Elver <elver@google.com>,
Andrey Konovalov <andreyknvl@gmail.com>,
Alexander Potapenko <glider@google.com>
Subject: Re: [PATCH v3 3/3] mm,page_owner: Fix accounting of pages when migrating
Date: Tue, 2 Apr 2024 14:39:29 +0200 [thread overview]
Message-ID: <819252eb-0ad5-4464-87d5-bbf13661c379@suse.cz> (raw)
In-Reply-To: <ZgvqWoZsYJLenSE_@localhost.localdomain>
On 4/2/24 1:22 PM, Oscar Salvador wrote:
> On Tue, Apr 02, 2024 at 12:26:51PM +0200, Vlastimil Babka wrote:
>> Can the migration still fail after __folio_copy_owner()? That goes again to
>> the comment you changed in patch 1/3. If it can, this will kinda create a
>> mess with the old folio's handles not reflecting reality? (although
>> refcounts will be ok)
>
> According to my research (I replied in patch#1), no, migration cannot
> fail after __folio_copy_owner(), so we are safe here (Tm).
OK then,
Reviewed-by: Vlastimil Babka <vbabka@suse.cz>
next prev parent reply other threads:[~2024-04-02 12:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-26 6:30 [PATCH v3 0/3] page_owner: Fix refcount imbalance Oscar Salvador
2024-03-26 6:30 ` [PATCH v3 1/3] mm,page_owner: Update metada for tail pages Oscar Salvador
2024-04-02 10:13 ` Vlastimil Babka
2024-04-02 11:19 ` Oscar Salvador
2024-03-26 6:30 ` [PATCH v3 2/3] mm,page_owner: Fix refcount imbalance Oscar Salvador
2024-03-26 6:30 ` [PATCH v3 3/3] mm,page_owner: Fix accounting of pages when migrating Oscar Salvador
2024-04-02 10:26 ` Vlastimil Babka
2024-04-02 11:22 ` Oscar Salvador
2024-04-02 12:39 ` Vlastimil Babka [this message]
2024-03-29 4:54 ` [PATCH v3 0/3] page_owner: Fix refcount imbalance Kefeng Wang
2024-04-02 14:20 ` Oscar Salvador
2024-04-03 3:19 ` Kefeng Wang
2024-03-29 6:39 ` Alexandre Ghiti
2024-04-04 22:56 ` Palmer Dabbelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=819252eb-0ad5-4464-87d5-bbf13661c379@suse.cz \
--to=vbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@gmail.com \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=osalvador@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox