From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97A05C74A5B for ; Thu, 16 Mar 2023 21:22:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6F858900003; Thu, 16 Mar 2023 17:22:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 68134900002; Thu, 16 Mar 2023 17:22:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 52275900003; Thu, 16 Mar 2023 17:22:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 3F858900002 for ; Thu, 16 Mar 2023 17:22:04 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 1465E1A0929 for ; Thu, 16 Mar 2023 21:22:04 +0000 (UTC) X-FDA: 80576034168.24.79F5262 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf07.hostedemail.com (Postfix) with ESMTP id CE3C840012 for ; Thu, 16 Mar 2023 21:22:01 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=C+I7j9bI; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf07.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679001722; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nOiJMs6jGjsIK5mURzzO91u2urF7NRidfMKLLbVDxmI=; b=kxP9HdsfMftpKjxtL3CsxZ3Ek8hD30HhAxXK9AbIcDjZ/1sn98FLLyKfCEtLJKpCZhwNOk ISuD0odhYdt8QhqexQc+h79TWYNVw8Rk/Xpdv8lbD2fYeNMppYMyDkGuZqG7UnNgt8rxVX KbMmzCWjHBAs3h4PQNCDe/TS9qzeVPE= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=C+I7j9bI; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf07.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679001722; a=rsa-sha256; cv=none; b=66eLWUmsHU9KtDSjFQu2Cz4lCv8x3TvK2SDhry+zt2JcUPaPs9ccn6ZYioMmZzsqOOoL0u n8HX5u9/e/o2JMkRrEk+VjdKiA54hUWgw98Ic6MkJMuMnJLKBmK8p5rYbMNcxsZ2BiSbGs Fn/mis/C47i3Xx7lrtL5jk28CT12oto= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679001721; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nOiJMs6jGjsIK5mURzzO91u2urF7NRidfMKLLbVDxmI=; b=C+I7j9bIeKlLyyx3jWxhavIvNeJ9wavZ4lQbETlVJT9PLmNWPMZarFycfRErYLwPtUk2Fs QpPqJC8NdfIKnd1VsrHDwvHGcwruzPm/YzCY4r37VYeeTxTXxZLslncOEux1+piS05BJd6 5/nL7PkKx2g5DQTrWPoG4gBk3BEea+M= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-444-U1vkmoP_NjKzPR5dpAkY1w-1; Thu, 16 Mar 2023 17:21:56 -0400 X-MC-Unique: U1vkmoP_NjKzPR5dpAkY1w-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D4ABE185A791; Thu, 16 Mar 2023 21:21:55 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id 95B8C140EBF4; Thu, 16 Mar 2023 21:21:53 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <4EDC79DC-0C32-40FD-9C35-164C7A077922@oracle.com> References: <4EDC79DC-0C32-40FD-9C35-164C7A077922@oracle.com> <20230316152618.711970-1-dhowells@redhat.com> <20230316152618.711970-28-dhowells@redhat.com> <3DFBF27C-A62B-4AFE-87FD-3DF53FC39E8E@hammerspace.com> To: Chuck Lever III Cc: dhowells@redhat.com, Trond Myklebust , Matthew Wilcox , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Al Viro , Christoph Hellwig , Jens Axboe , Jeffrey Layton , Christian Brauner , Linus Torvalds , "netdev@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , Anna Schumaker , Linux NFS Mailing List Subject: Re: [RFC PATCH 27/28] sunrpc: Use sendmsg(MSG_SPLICE_PAGES) rather then sendpage MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <818649.1679001712.1@warthog.procyon.org.uk> Date: Thu, 16 Mar 2023 21:21:52 +0000 Message-ID: <818650.1679001712@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: CE3C840012 X-Stat-Signature: 5sdgp536edc8xpyx7z9j5umsky8zhwoj X-HE-Tag: 1679001721-184695 X-HE-Meta: U2FsdGVkX1+rHOgOOqZaGfzy6MMrOZsTfSKrEPd8tMCECQbGeka6dkoegL4xJWPjyxZHltNgZhNIPw+PexrvLVpMijVKMHimO0tSbLeCA0jvGtR0lZro9rVP7+mgkBVcJAuzRRjP8onC+76JWOKaMfoQV1/5kMIolMu5tB/FWL1zclUqqmeOBc1+iC/fG3kueeA+ihI20H+bADp1HYz9K+0Hl2+8Zo9yMvSVR+nBEZd6fJ6vdZZOU4M8RgWrH4qDRCkrWKt1ba3ePOho5+LbYAWP3x95giBdB4I3g9zLUTMTPTXAMyfLj6h0mT4ivDdyHr0DHtiO915T4KIwi5NF0A6a2qdUATUfPqMNrpcGm9Gg8eYMdIHW+oN2QQJm/NzbHlEKilQE6XZZMvB5CQqaEdxpzyv7ivENf5XeMjCdJZdMbZjOBKdBIXS4AsNJApDkr3MoEDeY15GYGc1sfd1+gbJJeA488VFvs/Llps9d98RPe1D2hbwAXvPdV02nWCIOeVe3M0YQCBdlSSBa+xQh719Pv0TxwLDwtLJiuJwq1/s0JNa/Znc2IMb4qWHW+MzImrDE7ZZYvaU2JBnkg3ftV03CwJ2HlbcwlLPaN/wGoRogONE2zLqXp1zqIEjGk9GW37hEAscO0FpnvMht4kGWu4XOPAnWxGewfTTQEJF5mA8bOMif6uFVMOioDX2mQUCTQjrqZVAm6uCPsJ+qEKTI27jAzH/jakqFacCDfqsd+W4JiGyvSMn4ZSSZabYS9DMGLDbRfGcc/TX3IU1FMvjVVYRBnrA8L6lnNsAl7RrN4GTwsP+hYzR00piaReAI/d4xmWC9gDZHUeV50Ua/zu8Wxrfnx3GsHyB02Y4G6/xQSYhh7PErzf6UMdh7uW4yhTC/9ffY34MMWNz93JHSMrflfmO4tKenA1gvMqcPxXJ7zGuhtgvU2duNiUjR3hg95J8OFP4XXZ2tdNttLMcKPpY VOWK322G dXMaFb/v0xKoSGnQlCZtGQf73FkV7bty3LHOqjqiAzfaGv9+Kmt3Bwfgu99NJyzjZWcgj0yy1pAUAJ5N/voXp4Z7g+0NPA36PM/FA06uCidficeWlHg5wngaJ+RYSgy5ZCNfHt3FyZ+3Byda0EFKY6O59XuO2HIKBjN/w6iZHeHQAJiCKBM4l50OeJoi0mIEf6da0Ut7c1/byYp0tFZzu0R215h8+3x+ZXwRD87hWA/ZRxvuVK3uv6UPDsyy+O3PCT81mFCMORtrKaixOb85Nb5RL918frAZTyiNAH0IQxK6sAxKqNd/xm/aAyQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Chuck Lever III wrote: > Therefore, this kind of change needs to be accompanied by both > benchmark results and some field testing to convince me it won't > cause harm. Btw, what do you use to benchmark NFS performance? David