From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E98E5C27C4F for ; Wed, 26 Jun 2024 04:57:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6DFFC6B008A; Wed, 26 Jun 2024 00:57:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 68FCE6B008C; Wed, 26 Jun 2024 00:57:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 531B16B0092; Wed, 26 Jun 2024 00:57:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 32D896B008A for ; Wed, 26 Jun 2024 00:57:55 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id A0C13140A38 for ; Wed, 26 Jun 2024 04:57:54 +0000 (UTC) X-FDA: 82271832468.02.6A5048A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf04.hostedemail.com (Postfix) with ESMTP id 71FAE40002 for ; Wed, 26 Jun 2024 04:57:51 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=b5qNpj0F; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719377851; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=w3nj0me0lpXR5Y+zvweyhz8mA6M+FGnHzV7qpm+MqT0=; b=gLSNbx32CP041Kqb65P421L3aoLEZ34MuVA3g2/1LOJT6W/up/sudWYID8Wu7G3/Nm6tRg iKeU4Lbe3hWX0g7acXqBZ1xGrS+pTlZ0b+wwxpHkId0dbX6bsxTYbP/QnFb93xVwKXCOVx uMcJbYWyOBvYKiiT/Jo0sXNocYEucts= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=b5qNpj0F; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719377851; a=rsa-sha256; cv=none; b=wXu2unuZPQ+oOSdsU3O3XFA2bkCq4WcF2YefpRwtGBVtNfn5GiNOMHKS6lw6NLhe6jPjdc 1y52LwRvAbiBdXuYp5KukG7XkJ/paIIFEn/PEZYprw+qUEndZQCQu5iDhpNufDCO4QCEB0 Zd0gyohK15x5wBAdf+OgunSnkyiHSvo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1719377870; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=w3nj0me0lpXR5Y+zvweyhz8mA6M+FGnHzV7qpm+MqT0=; b=b5qNpj0F8LSGWtEGYFRd63KmoAlcUCCAdYLytNluujhUrjovsSnzqiYOzXdb1pvczHmSlK u1muHw+/gGOoVycU7DRqBXeYuoi8Ez6dr+u0hmklMcYhGwaHycucuPyLzTJ7ZMeoduphIH i3MQ8nw+Ko/iaofgJSU78o7B5B13VBU= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-628-rBhhgPtPPGae6bsTothCwQ-1; Wed, 26 Jun 2024 00:57:47 -0400 X-MC-Unique: rBhhgPtPPGae6bsTothCwQ-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-366fb7d007aso1434684f8f.0 for ; Tue, 25 Jun 2024 21:57:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719377866; x=1719982666; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=w3nj0me0lpXR5Y+zvweyhz8mA6M+FGnHzV7qpm+MqT0=; b=gMtx6Z9eu/DzzxCYw+BMO57YF1NaWjKpeG8ILtrPIPg+g7fimaKv+u1ocAM+TtMt48 f/yyS2WHC0p29R/tniIOJb3Pz5775Hf4FUHdUWyYEigXDqji82NBO8Q2G9DkV76GXXB5 MfYCkBU8hbb2BwO/KrJPXWmwGX60ZsPoTxlo6LTYnS+yk6YNhGIaEr+Nmk3Sf9x8E8IS LMpUsO66ddhDTTwfisAD3MM4mRP+esBN3SV5MBcZllgR5ZgakENAeciX+NxcFJ2HjZL/ dww8hqlDaDM7JzGF3fbqe7ZPyTHgjoOs1y6Lo9ZjW5mk5L1fQW5zYLlgS55e+b92nMM2 cTWg== X-Forwarded-Encrypted: i=1; AJvYcCVHv1L/NvkI50mShgq2C9jOvhMsOPR9o+JTFTwHpciafMnTsEdL0dS4YciP+VBgJN9lcYQPmAUN1O+0Vzo5+RYcyRM= X-Gm-Message-State: AOJu0YwMN+xZsZ8fvsU8QRdrzk/vV+QdoqQmsWaileJmZBb3JIPTxGQ5 bYp6EhX1LUd28BvbslbkP08I0c8eGOWwSJjFaapzwsW+ItQTGL/FxBabPj4Wa2yjN6vwecyUAoo AY743lXATzVBeMI1HwwV8zufve/1ou21UGlQdArKwEMp4VgMJ X-Received: by 2002:a05:6000:1863:b0:366:ec30:adcd with SMTP id ffacd0b85a97d-366ec30ae93mr8940553f8f.7.1719377866248; Tue, 25 Jun 2024 21:57:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHgoI1xBvUMJx0UKlKv5ABGzriy4HkFk4Xt/K0TXy2Rkf5VYprhDkL3K2WNE9RMfaSzcCMYkw== X-Received: by 2002:a05:6000:1863:b0:366:ec30:adcd with SMTP id ffacd0b85a97d-366ec30ae93mr8940540f8f.7.1719377865841; Tue, 25 Jun 2024 21:57:45 -0700 (PDT) Received: from [192.168.1.34] (p548825e3.dip0.t-ipconnect.de. [84.136.37.227]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-366e88c0c38sm10215347f8f.32.2024.06.25.21.57.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Jun 2024 21:57:45 -0700 (PDT) Message-ID: <817fe841-a071-43c4-9df5-806f6ec351e0@redhat.com> Date: Wed, 26 Jun 2024 06:57:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] fs/proc/task_mmu: use folio API in pte_is_pinned() To: Andrew Morton , Kefeng Wang Cc: Helge Deller , Daniel Vetter , Matthew Wilcox , linux-mm@kvack.org, Jonathan Corbet References: <20240604114822.2089819-1-wangkefeng.wang@huawei.com> <20240604114822.2089819-2-wangkefeng.wang@huawei.com> <70ce5e9a-ddd7-4e21-9ca9-cd0e72e1df60@redhat.com> <5ec7f8b0-777c-44d2-874f-9332432129b4@huawei.com> <20240625153823.b59bbee937fc3cde28bddbab@linux-foundation.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240625153823.b59bbee937fc3cde28bddbab@linux-foundation.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 71FAE40002 X-Stat-Signature: i19z586fiiqkhwudbbyretqw3aqgmpeo X-Rspam-User: X-HE-Tag: 1719377871-828996 X-HE-Meta: U2FsdGVkX18yfprZ9I9yqxmYbzAgeT6SuYXwM6qHwt0XexTNwNvqRnU6qKJpPIcrySsvfxmihAx7jdhUbDMhu/EdxelromE/K/nnKAmeStMG5RPvHM+4IJ7V8T6FprhNVQMP99ALpuEQ2Me8VSchqfjhA8TMSoyGYxwx9TwFpcUNs8gQDNGKokkHdE2KvjVD38dLWLGhC4lUTPpsfE5BGKEgXSNGVAbEWw18DV6wdt7NAlMLE4+Im20ZnRhhDapky0PQ7+xJD6xR60qSGBWUAArGRpcQDwrVrK1aZEwN8cGZcACsWt62nOj5PTHpC/xMbOcIA2nurNfMUShHRTK6AUVj0Mxj2HWyZf2kepmpeOObtJ5y2uIrl18Z5/PU2+7wwg8rZzQcfzJBmKl6s4rckHSyS+RAW8VbCLfvkeYKaowF/wHNzCBnN4KMn3TkvHjb3kiS+MX7t6zdWvk/p5L4DsWrF8pQB/ocfR1UCCdDSMhJtIKFAMEL567+y2t4V2PBQ/wMNQid3vKX5VSj384WhJYlQNKPvXLjtQKV38oKG8HAba5roS/UFCHh5NHKWYMYpA5evGjF+L90avGGKBQFMZEibHMsQKSGm4e1W81O8Z2hbsade6V3K8wlB2GKTRq5pWzaqgEBfe6tFD098jCid5ZWHunIh4XOC5mWLD7ymNC1eAzvrhDbK6CXqj4vviNDLol8wAbKElBJJzFBk04D0WKFUJ42/ZCSBDlKdDAH+cznG5Kl7GgSWyLYzPD2UTna/Hk+2jADEbDoE9eSjdHOPXRA9Y+6P0HUcvS0QE6MUV9FNl7cBc5UAXCNeN0qfMlhQGO8iQbHu7xFS2xlQn45HPqg9Y73A0iFOkVzjA/ZkRFe/97C6bbzT4t1VuvDHYP6yYkbqFN7nA9wE6UY+syFEeXsVpWp9VFT4Hpd8NZvjcMjEmfWKqhEfji1V08lAm/wRwj9gPpIQGYF4fyBvSw AusswZgM NunZpIvFIKiUb2h0LEyMn98Lxwr25ZkRD7sSvAiLpPXdYJoTO40BajlN0l1jxKSbxIaZg9t41SGFne9c24htX5iE4yRMfLfmhdbqZThBCtfbmwk5ppDpmo5pSBcHX1LU09L6a4CQ2Qa/Y56m3KsdlR+S3Rbym+4eMXOWDwrfPu+DL5N45bCcjIuRordppvA3aLY/rzNqe0wj0PYyI0o9VDsfEsSw63OJjHuLuZ9h821V44LA924j9tNgMFECYYvt9npW3TBIFAd/LRadI8aEyGnBD1MehG8GwSHIykAchxS+BXJoCmDYJw8XSAMN8jbtzG/zQLVRNRgJ16o+SCPmR6aGskVPLRv8Nw0ESjDMlDkQP1BczV1XBxi32B3JYQkYbNSOkD/9S45OQ1uzTnuFELlHKGdMMiId+MjfpRIpac9TTGl+33BoMLeU1F3M/mQNvFu4M4YwDOWOKS8lNoPSJlzb+6HF05hmiTCbtt2HJeb78tbckXiv2di/CK/Rcztr7aiWzUKVaczhBvrkb3SLlssTAtOKBGLkGz0TYlmAoNotpayyiLuXkrgGIg5p4Jv+pb/DeJi3MMPgxmXztQUkjEnuVNGsuPrNY/mz0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 26.06.24 00:38, Andrew Morton wrote: > On Wed, 5 Jun 2024 09:30:59 +0800 Kefeng Wang wrote: > >>>     protection to catch successive writes (mprotect, uffd-wp) -- and >>> they all >>>     face the same issue regarding R/W access via GUP (FOLL_PIN and >>>     FOLL_GET). >>>     User space better be aware that using read-protection to catch >>> writes to >>>     a page can miss writes via GUP. Softdirt tracking cannot reliably >>> catch >>>     modifications via GUP after clearing softdirty and returning to user >>>     space. >>> >>> But I understand if you want to be careful :) So I might send that patch >>> out at >>> some point myself ... >>> >> >> Thank for your detail explanation, let's wait it out. > > Did we wait long enough? Should we move ahead with this change > or should we drop it and have another run at it? The change is fine, we will revisit removing this code (instead of cleaning it up) separately. -- Cheers, David / dhildenb