From: Thomas Meyer <thomas@m3y3r.de>
To: kbuild test robot <fengguang.wu@intel.com>
Cc: kbuild-all@01.org, Johannes Weiner <hannes@cmpxchg.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: [mmotm:master 230/317] arch/sparc/mm/extable.c:16:1: error: conflicting types for 'search_extable'
Date: Sat, 17 Jun 2017 13:56:46 +0200 [thread overview]
Message-ID: <816EAD4B-89D2-4F88-A920-BBCC640CFE16@m3y3r.de> (raw)
In-Reply-To: <201706170814.FBlKIbl6%fengguang.wu@intel.com>
[-- Attachment #1.1: Type: text/plain, Size: 2820 bytes --]
> Am 17.06.2017 um 02:07 schrieb kbuild test robot <fengguang.wu@intel.com>:
>
> tree: git://git.cmpxchg.org/linux-mmotm.git master
> head: 8c91e2a1ea04c0c1e29415c62f151e77de2291f8
> commit: ad8aa0a41610e2b5225067c38a9020f6def8a940 [230/317] lib/extable.c: use bsearch() library function in search_extable()
> config: sparc-defconfig (attached as .config)
> compiler: sparc-linux-gcc (GCC) 6.2.0
> reproduce:
> wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> git checkout ad8aa0a41610e2b5225067c38a9020f6def8a940
> # save the attached .config to linux build tree
> make.cross ARCH=sparc
>
> All errors (new ones prefixed by >>):
>
>>> arch/sparc/mm/extable.c:16:1: error: conflicting types for 'search_extable'
> search_extable(const struct exception_table_entry *start,
> ^~~~~~~~~~~~~~
> In file included from arch/sparc/mm/extable.c:6:0:
> include/linux/extable.h:11:1: note: previous declaration of 'search_extable' was here
> search_extable(const struct exception_table_entry *first,
> ^~~~~~~~~~~~~~
Oops, of course I only did test against x86_64...
But one question regarding the range entries:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/sparc/mm/extable.c#n60
Shouldn't the range search skip deleted entries? Or does something else ensure consistency?
I'll check all other archs for arch-specific implementation and send v3 then.
Sorry for the fuss and kind regards
Thomas
>
> vim +/search_extable +16 arch/sparc/mm/extable.c
>
> ^1da177e Linus Torvalds 2005-04-16 10 struct exception_table_entry *finish)
> ^1da177e Linus Torvalds 2005-04-16 11 {
> ^1da177e Linus Torvalds 2005-04-16 12 }
> ^1da177e Linus Torvalds 2005-04-16 13
> ^1da177e Linus Torvalds 2005-04-16 14 /* Caller knows they are in a range if ret->fixup == 0 */
> ^1da177e Linus Torvalds 2005-04-16 15 const struct exception_table_entry *
> ^1da177e Linus Torvalds 2005-04-16 @16 search_extable(const struct exception_table_entry *start,
> ^1da177e Linus Torvalds 2005-04-16 17 const struct exception_table_entry *last,
> ^1da177e Linus Torvalds 2005-04-16 18 unsigned long value)
> ^1da177e Linus Torvalds 2005-04-16 19 {
>
> :::::: The code at line 16 was first introduced by commit
> :::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2
>
> :::::: TO: Linus Torvalds <torvalds@ppc970.osdl.org>
> :::::: CC: Linus Torvalds <torvalds@ppc970.osdl.org>
>
> ---
> 0-DAY kernel test infrastructure Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all Intel Corporation
> <.config.gz>
[-- Attachment #1.2: Type: text/html, Size: 4957 bytes --]
[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5334 bytes --]
prev parent reply other threads:[~2017-06-17 11:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-17 0:07 kbuild test robot
2017-06-17 11:56 ` Thomas Meyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=816EAD4B-89D2-4F88-A920-BBCC640CFE16@m3y3r.de \
--to=thomas@m3y3r.de \
--cc=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=hannes@cmpxchg.org \
--cc=kbuild-all@01.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox