From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFEF8E674AD for ; Fri, 1 Nov 2024 07:37:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 48B106B0088; Fri, 1 Nov 2024 03:37:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 43B126B0089; Fri, 1 Nov 2024 03:37:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3026E6B008A; Fri, 1 Nov 2024 03:37:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 10EAF6B0088 for ; Fri, 1 Nov 2024 03:37:59 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id ACF7241AC7 for ; Fri, 1 Nov 2024 07:37:58 +0000 (UTC) X-FDA: 82736721732.11.7BA3F32 Received: from mail-oi1-f175.google.com (mail-oi1-f175.google.com [209.85.167.175]) by imf22.hostedemail.com (Postfix) with ESMTP id 4CD4DC0008 for ; Fri, 1 Nov 2024 07:37:22 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=0DRuPVbE; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf22.hostedemail.com: domain of hughd@google.com designates 209.85.167.175 as permitted sender) smtp.mailfrom=hughd@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730446620; a=rsa-sha256; cv=none; b=navxp7q6vZlFCTFZOqyq8mroLrrPn1Pt94qa9zyGVxtR7vfDejfUqo17oG0Q2RjGLjUzgO 2KpAEu5VFJ10GlrA53JRh5FTk0U+1KmgQOtK28ToksjthWUs1FcyRZtbrQZhpuUw8wBV45 /n6Kqj8XEAW0P2arFK3I0L708Z6jh4Q= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=0DRuPVbE; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf22.hostedemail.com: domain of hughd@google.com designates 209.85.167.175 as permitted sender) smtp.mailfrom=hughd@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730446620; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bnzJeel+BwB3jSttSAy7Q3R1q9VR8g71yrTqyLZrN/o=; b=edGxLUDkVvglCnYcE58eFnCqeigO2QA+LbXhPUVB7FIlvNOOLOmkRHNo/ERMvx319EqXkp IS2jnPF2HuTApSmtS14jeD0yPVTLsXwYy+u4DSkLYrGlSAb5N5tQb+rKbgkXECfw9LADWR SjI+r0qdiRdzdwykvsB4scBVUZWlrsE= Received: by mail-oi1-f175.google.com with SMTP id 5614622812f47-3e5fef69f2eso1029337b6e.3 for ; Fri, 01 Nov 2024 00:37:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1730446676; x=1731051476; darn=kvack.org; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=bnzJeel+BwB3jSttSAy7Q3R1q9VR8g71yrTqyLZrN/o=; b=0DRuPVbEPdYorqHdLWUdlT0oFHV7YbJxbpGacvzWDMLS0ayqUyTp9y7jby/AA2fEXD 6MUet6/YRiHPHxT7tC/gD8D2IZlCxHEG2n/aEZZHUrSO8QnHiKa8SEm2ZBIEHVg9MzMo OiykBmleqJHREILO7PufIqsd76azKeukJt4GBKpLEc7kxuLYYiolWrt8sz7edQWv5AcM ReGmvC9WeL7l9Kto++qdM4Pv87GAPo/+o8yI5sp7CG3+rEe4TggIh8pRYVvzlArsfUwi i0VYGEi/eeU6bv7jX8RZyykyT/J+saMtNJOKgFqJNTb9IzdDouzwWWRjK8g7Yr5jEzN7 q6KA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730446676; x=1731051476; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bnzJeel+BwB3jSttSAy7Q3R1q9VR8g71yrTqyLZrN/o=; b=rX2GD35DmgisQ4pjkJ66aPhC32NsIwY3DLGUAZH+0R+fgukr3YXsdOfyd2wRe9JhyY 3jKJ/Z+cvG1kzBfM3T9fo3WSeZ4nofT/hvg6sqT7GVxwQJNKb89MA/cXnNO3d6ZtIriI gcz/tVZcepAqUux4r+wkjbKYlVECdrt9ysQMZcDpSCYWezlsZ84eg8mj3Wsz9TWXoUgq 24QYl83UTzVnzAFmKeFIivvLGkVrAlHLKz5lKGh97T3G0y/qw+KcDy+VcpKRSJoHWgV0 Qrl8Jpl2P7Zu9RxmZ9uk8OCulQsX0yZfiApV9BtFHWV4kH7Cg89QeLqDJGHWsUqe1zEJ YAKA== X-Forwarded-Encrypted: i=1; AJvYcCWn8oG2gyRG0v3Ukj3Hd1mknPti4wOmOKMm9qgZYrit864yEVzmP+XIEwiegsoZpO7wlPCtrRlm5A==@kvack.org X-Gm-Message-State: AOJu0YyiHhg4+qc6wh/dncYVhIAtkF6SxxGzgAXCDy75m9aO5ftan0WD tOFwwi+qtyRRTXy/t+VGsJFgKV+ao+1dXEXvvj88mPlfchyrjkvGMkD5yBwEwg== X-Google-Smtp-Source: AGHT+IHTxgosQLtMnoC48u/AiElStEQhbPJvPftBxAqrfsbetyIQ0/6qIEuIYWZ3yoCI1o1KMj1DcA== X-Received: by 2002:a54:4e95:0:b0:3e0:7d53:251 with SMTP id 5614622812f47-3e6608c6c52mr4407213b6e.15.1730446675714; Fri, 01 Nov 2024 00:37:55 -0700 (PDT) Received: from darker.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7ee452979e4sm1990326a12.9.2024.11.01.00.37.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Nov 2024 00:37:54 -0700 (PDT) Date: Fri, 1 Nov 2024 00:37:45 -0700 (PDT) From: Hugh Dickins To: Shivank Garg cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] mm: use vma_policy() to get vm_policy In-Reply-To: <20241101071350.402878-1-shivankg@amd.com> Message-ID: <8169912f-82dc-e210-862c-f6eb092db78d@google.com> References: <20241101071350.402878-1-shivankg@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspam-User: X-Rspamd-Queue-Id: 4CD4DC0008 X-Rspamd-Server: rspam01 X-Stat-Signature: ms773w53cixurpnqyup7wudzc5znxddn X-HE-Tag: 1730446642-679492 X-HE-Meta: U2FsdGVkX1/wCeQzWfIX3JQAVe14XTP2kRCBc5reU6EfgbEDE7prT5vutvJ4le3B4tmhCFJvtijhZK7jxzDgTZLx0fGgzFE89mJ++YewwePl+Ca8hHjWli1nNXDikFi/87l+PnEe9ytqRc8tykw1VzfepRtoSDHO5PaPGIZvWt6LdoRdgUp3pL34k+F4fjk3DFQ9jHuo+AkIeWA5+YUp9agigx7sw5lMvmXO7uQUW/uKjsWIJ4LMZcpcWEAj+m3RApwph866t3vXdnaLCcUBmEZJZlbKYYsWaRN8v1cyXsRHxJWLn4eMFSAaWgfjhKVMq7853LzKrVSzQIUVC0oLmdyjyCy2EyTLJghsid4LqVS3EKKGqPxVu18pwoSKcy6oTy5/ZEtvhmixZk5JpXW0dvFOtZ/sSTUCGTRds3h9b8eCNzH0u6Rl4HTZf47JCQYX7/oCNwrP1jHUPzeBCJV7d/6MueIffFo7k91JXc1TODeTTXlKUVXKAtD0StZNIAKnTI+Av73kfIzsfRnUHrpVybz3tljftCp+jsD61TohBbsT4N3yIXvD2COlG4nURoafOdk1FYjixp4NeR3KHY+DiLGw84a5EPkFHwHSs+Yfaw6bYaRxuay01UtUen/T8ScD/2kiTpHjuPVN5zSo1xQCDOqOeZPdr5m0QsIc6YVCDchqewXdy/z3+kSWDjjcK+nixCRsEDrXsNysT67SxFI4iQJTnzD584BUUqcJKPDh0mDxkdnL48nuq3JYvkwMyJcwNcIaXLawpXkM9FF1P/Blwcw5HLuTqJGqUCh5/M82C3SyX7Rl7eRCTlDdIYbHyOHJgy4PKLxfwk9dQ+nUR6y4u+CuZE4Jd0JN300cg+5Jxh53J0FQ6lajxSOFatlsJNbUBl8zpS/mvR3peJUHt6fr3A6rmgMlvNn3/lt3+aUizvXSIv8O43f+cOrPP+DDKbvndmLfeG97pqc5AO0YzBg wJ1boOqh OUGVxQIqnwtnrhF6HDAoEDzlcRf2w8p4oA5eAfZbM2PniBmPu6Dqrv1fUfAtso4tbmgZo6ihVQ1Lnv+avdfgddhDwzye9I0H6tDsZOK9VcZ4/T3JnGwbgI/QX4Ll0Wk7UJr27KfE8Ewtpt79Zom8fSvUdmjClUAdJR55dKMhnGV50GGND5NJ0dK1JIVgb7EAGjhHFeVBPqPU6geJX1Sz/OOrhcABErwmB6uqCvNSQqNV909+/NNPHI2iRNxxT0j8RW69O1rdgKkjynjp5Oos5IHSQE/W6sPfNfkvYw3QX2PrsJ4VDT62OliFGcH5ql5DZ6aZ19U1mltQKzwHpp5WY+Utasj0zJn8k6U5UELruLnY+stTZMR54DyLB6wzH0/yc/R9GVFt/xjU8HhluTRL9iW8uvLwlDVFyax2PdqW/yLoI8O8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 1 Nov 2024, Shivank Garg wrote: > Instead of accessing vma->vm_policy directly, use vma_policy() like > other places for consistency. > > Signed-off-by: Shivank Garg NAK. The vma_policy(vma) wrapper exists to avoid #ifdef CONFIG_NUMAs all over the place; there is no point to it inside CONFIG_NUMA source. Hugh > --- > ipc/shm.c | 2 +- > mm/mempolicy.c | 16 ++++++++-------- > 2 files changed, 9 insertions(+), 9 deletions(-) > > diff --git a/ipc/shm.c b/ipc/shm.c > index 99564c870084..ebd45e48b0d4 100644 > --- a/ipc/shm.c > +++ b/ipc/shm.c > @@ -577,7 +577,7 @@ static struct mempolicy *shm_get_policy(struct vm_area_struct *vma, > unsigned long addr, pgoff_t *ilx) > { > struct shm_file_data *sfd = shm_file_data(vma->vm_file); > - struct mempolicy *mpol = vma->vm_policy; > + struct mempolicy *mpol = vma_policy(vma); > > if (sfd->vm_ops->get_policy) > mpol = sfd->vm_ops->get_policy(vma, addr, ilx); > diff --git a/mm/mempolicy.c b/mm/mempolicy.c > index b646fab3e45e..7ccbeb9966f0 100644 > --- a/mm/mempolicy.c > +++ b/mm/mempolicy.c > @@ -420,7 +420,7 @@ void mpol_rebind_mm(struct mm_struct *mm, nodemask_t *new) > mmap_write_lock(mm); > for_each_vma(vmi, vma) { > vma_start_write(vma); > - mpol_rebind_policy(vma->vm_policy, new); > + mpol_rebind_policy(vma_policy(vma), new); > } > mmap_write_unlock(mm); > } > @@ -805,8 +805,8 @@ static int vma_replace_policy(struct vm_area_struct *vma, > goto err_out; > } > > - old = vma->vm_policy; > - vma->vm_policy = new; /* protected by mmap_lock */ > + old = vma_policy(vma); > + vma_policy(vma) = new; /* protected by mmap_lock */ > mpol_put(old); > > return 0; > @@ -830,7 +830,7 @@ static int mbind_range(struct vma_iterator *vmi, struct vm_area_struct *vma, > vmstart = vma->vm_start; > } > > - if (mpol_equal(vma->vm_policy, new_pol)) { > + if (mpol_equal(vma_policy(vma), new_pol)) { > *prev = vma; > return 0; > } > @@ -1797,7 +1797,7 @@ struct mempolicy *__get_vma_policy(struct vm_area_struct *vma, > { > *ilx = 0; > return (vma->vm_ops && vma->vm_ops->get_policy) ? > - vma->vm_ops->get_policy(vma, addr, ilx) : vma->vm_policy; > + vma->vm_ops->get_policy(vma, addr, ilx) : vma_policy(vma); > } > > /* > @@ -1847,7 +1847,7 @@ bool vma_policy_mof(struct vm_area_struct *vma) > return ret; > } > > - pol = vma->vm_policy; > + pol = vma_policy(vma); > if (!pol) > pol = get_task_policy(current); > > @@ -2559,11 +2559,11 @@ unsigned long alloc_pages_bulk_array_mempolicy_noprof(gfp_t gfp, > > int vma_dup_policy(struct vm_area_struct *src, struct vm_area_struct *dst) > { > - struct mempolicy *pol = mpol_dup(src->vm_policy); > + struct mempolicy *pol = mpol_dup(vma_policy(src)); > > if (IS_ERR(pol)) > return PTR_ERR(pol); > - dst->vm_policy = pol; > + vma_policy(dst) = pol; > return 0; > } > > -- > 2.34.1