From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7A1EC27C4F for ; Mon, 1 Jul 2024 02:49:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4409D6B008A; Sun, 30 Jun 2024 22:49:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3C9C16B008C; Sun, 30 Jun 2024 22:49:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 243AB6B009D; Sun, 30 Jun 2024 22:49:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 04E846B008A for ; Sun, 30 Jun 2024 22:49:24 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id AF38F1C300D for ; Mon, 1 Jul 2024 02:49:24 +0000 (UTC) X-FDA: 82289652648.16.CD6C29A Received: from out-178.mta0.migadu.com (out-178.mta0.migadu.com [91.218.175.178]) by imf30.hostedemail.com (Postfix) with ESMTP id 9179180015 for ; Mon, 1 Jul 2024 02:49:21 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=Ei9mi7B0; spf=pass (imf30.hostedemail.com: domain of chengming.zhou@linux.dev designates 91.218.175.178 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719802146; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7mFxjC1U9/7JygpJdsg86O8Ayb0TyOCDXKOYMsrvCw0=; b=nXqAMGOY4rlJYEfOAuZ3PPDuKCkZ4VcMb9A8+sFVM09sNE+dsOJ1GfzUxIB/jtsGJNOD/R wvd8egAIkZxp8Shyi075IMnzi1PMVyBIlNAUrCfdNSW9gbX/jzbGJawxRuFad64kwCY/8Z r2f8JX4caLVX5GNFHaxtKtycchsXMtg= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=Ei9mi7B0; spf=pass (imf30.hostedemail.com: domain of chengming.zhou@linux.dev designates 91.218.175.178 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719802146; a=rsa-sha256; cv=none; b=rG3ApLTOX2jqQEv88ABhtjIJvYE0wZHRKP9JvkSrR8R//CQeovjvsFGDn7BgIpPNhTpOB4 ct5h8xqIjundlqpyVHvK4Toe9ZuAYKd6ZBmUrINj0X4Mi9z3Dw9pD6VpKTrQjCujwNz0BZ bJpxc16Na+EL56raFNjos5oIl8OZsJ4= X-Envelope-To: senozhatsky@chromium.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1719802159; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7mFxjC1U9/7JygpJdsg86O8Ayb0TyOCDXKOYMsrvCw0=; b=Ei9mi7B0/RVD3/lgBL1ONKhW0K810nMsBJltQ6rAP5LVFw8dP2N3FIgV34ysxAFQj3yIMb jQhuD/i0IcIjuJNuCFFBmLJX/ubb1qTzi5KIZs5Ew9usL2WCH1/AJmMResu6YJzlDbvinQ zySfDA08FINQDopG7cM78XBatmiw8S8= X-Envelope-To: akpm@linux-foundation.org X-Envelope-To: minchan@kernel.org X-Envelope-To: linux-mm@kvack.org X-Envelope-To: linux-kernel@vger.kernel.org Message-ID: <8163966f-d31d-425c-97cb-3d18ab28ac1f@linux.dev> Date: Mon, 1 Jul 2024 10:49:13 +0800 MIME-Version: 1.0 Subject: Re: [PATCH 1/2] mm/zsmalloc: fix class per-fullness zspage counts X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Chengming Zhou To: Sergey Senozhatsky Cc: akpm@linux-foundation.org, minchan@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240627075959.611783-1-chengming.zhou@linux.dev> <20240628005523.GC15925@google.com> <20240628010812.GD15925@google.com> <20240701013731.GA3232210@google.com> <4f2a5cf1-3132-4bc6-965f-8dc5a8ffc05a@linux.dev> In-Reply-To: <4f2a5cf1-3132-4bc6-965f-8dc5a8ffc05a@linux.dev> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-Stat-Signature: 1grknyju7jf68xcmcmkn8euwbsn73mb8 X-Rspam-User: X-Rspamd-Queue-Id: 9179180015 X-Rspamd-Server: rspam02 X-HE-Tag: 1719802161-486410 X-HE-Meta: U2FsdGVkX1/gqQYC9NyyqfDZFR351PwInN1AHyV1usm1fCMCpRwwGnzUBHgUB8VXAn5cvz1NUvl4HPk8gD2UJ9cZ+tJcJnighK9vcCW8RmPV3DwpvplAgL3pVo6KmOdsYq7zhZ//TFfqtCb/xywCc3nv5eL/L8VN5ZCKE8BPtONGvNFolGjaJKaFeyJGQwbktW2NLuI+Gpd7yUydZPWnkr2uWO+MXhvEOCFv/iCCOfrdoRn4M8xYAItfAxU2rw5yvoKVVTNrsltLAHj8c8fFzgnD8ccEWDXqsS7tJlYuFzgAkFxrIR0EcSn476aGhBR/dbqK7Q5jR3N6TOhOyqdzHnt+0FqsTVM9VeiCGi62ThnJ2JE0S7KDqtTVVETyrJ1FNuiq5+cot6QC1YwZKnWoq5dpb4JjBICixVFuCyJHz8d52R2FfeifQdxolciCgZXEE5cjFLJwjAQAIzEZztIGf4MFqdLM11ne5kL68yc+fSgo0KR0lF8UniT0ElXFMEzuvcMiE84NgyJNYhDzzmf7ZdxqVDRfSE8jovZOyEcoVX5BIHSNdrDtktXEEwS4WeChICFUv3q1r4PU6oTA2wOFpW5vVdIf1RtTxEHQGiAYVbLtVvNneSHwVA79MDD4FZhE4/A5bDt625+Q2dR1uK1kkXyW7sUbLdxx9/I5IXkEompOPyPEucGUIjVnw3sIgVxuvUaeIjm9VV71ELxj51u/Rm547SwwFAssf68BbuwiwEaCzaQMQt3qFcA3uwOuupWr/D/ZBUPKqiY872dFzRxLKfDPiylOyz6fHMYXzp7daoq2+n513tJdwe9y36VUiw2o6LAbM5qHyHr9p9YRYfp0Jem/TVZ83dBHKZ7ZKDdxyOSUm0i1fne4l/74t3JvOzBhx4JEwsnNY6jgaDUATewcRHVrg/ULDh+xLBywrnm62oHvb5JUTtVxSGrDky4b+rdhHjvZ4f5nWjh8IYRZ5fj /eeNG9V4 nM1ZdZ0rGH4MVYpEvSUWxrwlDYlt86nIzPUCsMUFDJq5sWbFjU+/VMPCx1OgIc++MtWh+u1WX8Xy4tjlAN81OhfhnuGpfRFR2FEds87xawco/EtAaKQKWrc0uSAvCU+Y/dvDZdclN3ZW5Gpv/BBEUJunFtQu1nx6I8poHTn8BHc1TA8zWPjBFpktXDvhA8cQRqIuV8GfXYOFqGEulWgFNdREC7QJ9fSgUDk0pnXCdp8oUStM2dyhbNEBR9n0xwjQD9ODSVVVoHMjSOaVv21/dFxhvPU+u+5f6ulFEirxEyhv4xDc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/7/1 10:20, Chengming Zhou wrote: > On 2024/7/1 09:37, Sergey Senozhatsky wrote: >> On (24/06/28 11:19), Chengming Zhou wrote: >>> Andrew, could you please help to change the subject as Sergey asked? >>> Sorry, I should have noted these details in the changelog when I wrote >>> this subject. >> >> Chengming, can I ask you to resend these patches with a proper commit >> message? > > Of course, will update and send later. I just pulled mm/mm-unstable and ready to update, but find Andrew has already helped to change the subject and commit message as below, which is great enough! Thanks! commit 84d0abc5905bbdf29dc7ff8083d21145d78a3ffe Author: Chengming Zhou Date: Thu Jun 27 15:59:58 2024 +0800 mm/zsmalloc: clarify class per-fullness zspage counts We always use insert_zspage() and remove_zspage() to update zspage's fullness location, which will account correctly. But this special async free path use "splice" instead of remove_zspage(), so the per-fullness zspage count for ZS_INUSE_RATIO_0 won't decrease. Clean things up by decreasing when iterate over the zspage free list. This doesn't actually fix anything. ZS_INUSE_RATIO_0 is just a "placeholder" which is never used anywhere. Link: https://lkml.kernel.org/r/20240627075959.611783-1-chengming.zhou@linux.dev Signed-off-by: Chengming Zhou Cc: Minchan Kim Cc: Sergey Senozhatsky Signed-off-by: Andrew Morton