From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9591C2BA1A for ; Mon, 17 Jun 2024 11:23:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2E0C76B014F; Mon, 17 Jun 2024 07:23:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 26A266B0168; Mon, 17 Jun 2024 07:23:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0E3E26B0159; Mon, 17 Jun 2024 07:23:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id E13376B0178 for ; Mon, 17 Jun 2024 07:23:18 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 5A061161570 for ; Mon, 17 Jun 2024 11:23:18 +0000 (UTC) X-FDA: 82240144476.24.9755E61 Received: from m16.mail.126.com (m16.mail.126.com [220.197.31.8]) by imf28.hostedemail.com (Postfix) with ESMTP id CE3F7C0012 for ; Mon, 17 Jun 2024 11:23:14 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=126.com header.s=s110527 header.b=nWdJF3OK; spf=pass (imf28.hostedemail.com: domain of yangge1116@126.com designates 220.197.31.8 as permitted sender) smtp.mailfrom=yangge1116@126.com; dmarc=pass (policy=none) header.from=126.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718623392; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gDW0ElYtH3AHdoLevCpq9BAOX76kY4zQdLhZsPYPZGU=; b=l79oZCbGRxfftyhmfQsPtNPEPVoXKz2bT1OrwwSmYTVdExVeqNAFZu5aoDqrYilUU+j8q8 MuBIh/oiR4Yx9ynGFbZH+vV2SebcXJ55l72EWbyyBQoWGWcJbRoFtpR3Vj2M7YJF0XofxN eHEo8anzaxPqLefnEYz+EoMydqXaJP4= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=126.com header.s=s110527 header.b=nWdJF3OK; spf=pass (imf28.hostedemail.com: domain of yangge1116@126.com designates 220.197.31.8 as permitted sender) smtp.mailfrom=yangge1116@126.com; dmarc=pass (policy=none) header.from=126.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718623392; a=rsa-sha256; cv=none; b=d0O19NyxcffZm5dsJtsaeIp2WjLCEgKoZMF/UR5oudGeeJN41FFkf3WPkl/wbnqcMNClW8 JQfETFbEB9aoKBVm6le5xcMCPfZUmFmRPCzBsPPzHygCTHnNmw7IKLG7T9K2y1zWjoNpIe JJf30+UkT3NrmbI8Si9lQbLXzfCNJKU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=126.com; s=s110527; h=Subject:From:Message-ID:Date:MIME-Version: Content-Type; bh=gDW0ElYtH3AHdoLevCpq9BAOX76kY4zQdLhZsPYPZGU=; b=nWdJF3OKpZ5s3twnJL3EvxPDyeQvkm04oX4ikIjnNGo/GvIoin0k5F+j7aYLbP srBRq0mm2290LuC9lbpTm3tIuStKq0E4ovzuCUDU2iveVwZDTUE4ME6AuMpvLaY0 EIwCXaDi5K0Weel9u6P18/Jl4A/ORO/o6FskffARqHYqI= Received: from [172.21.21.216] (unknown [118.242.3.34]) by gzga-smtp-mta-g0-2 (Coremail) with SMTP id _____wDnr7mTHHBmvsVcCw--.823S2; Mon, 17 Jun 2024 19:23:01 +0800 (CST) Subject: Re: [PATCH] mm/gup: don't check page lru flag before draining it To: David Hildenbrand , Matthew Wilcox Cc: Baolin Wang , 21cnbao@gmail.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, liuzixing@hygon.cn References: <0d7a4405-9a2e-4bd1-ba89-a31486155233@redhat.com> <776de760-e817-43b2-bd00-8ce96f4e37a8@redhat.com> <7063920f-963a-4b3e-a3f3-c5cc227bc877@redhat.com> <48150a28-ed48-49ff-9432-9cd30cda4da4@linux.alibaba.com> <11ef3deb-d1e3-46d5-97ed-9ba3c1fbbba9@redhat.com> <697a9bc2-a655-4035-aa5e-7d3acb23e79d@redhat.com> <3a368e38-a4cb-413e-a6d9-41c6b3dbd5ae@redhat.com> <48fb0e58-16d1-7956-cf35-74741826617a@126.com> <617f9e36-9334-4630-a6b9-473f2dd570d4@redhat.com> <8351052a-5c21-c383-544b-3166e883587c@126.com> <7b69abe5-3782-965c-ec82-5baef84e2d06@126.com> <87fc95c7-0351-4b05-b68b-9b9364474cae@redhat.com> From: yangge1116 Message-ID: <813b1141-4050-ead7-ec52-a2b3b8e26fee@126.com> Date: Mon, 17 Jun 2024 19:22:59 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <87fc95c7-0351-4b05-b68b-9b9364474cae@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-CM-TRANSID:_____wDnr7mTHHBmvsVcCw--.823S2 X-Coremail-Antispam: 1Uf129KBjvdXoWrZw1UCF1DXr1rur4xJF43ZFb_yoWfKFb_Wr 1kX3Z8C3Z7uw4rKF15ZrW5Jrs2gryYgr1DCF48XF13A34jyw1kZa1kKF1Yka4UJr4SkFsa 9F15CwsayrnrCjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU5IFAJUUUUU== X-Originating-IP: [118.242.3.34] X-CM-SenderInfo: 51dqwwjhrrila6rslhhfrp/1tbiOhUBG2VEw1R5ZQAAsf X-Stat-Signature: 95swdhka7xxgzinahfrbxydpfw3zz9ma X-Rspam-User: X-Rspamd-Queue-Id: CE3F7C0012 X-Rspamd-Server: rspam02 X-HE-Tag: 1718623394-502979 X-HE-Meta: U2FsdGVkX19cVXMqxmDtuRV8aWEUQCuatoLt+2Lsgy7CAEBmAozvSYouNz3tvfsZGGgcfpAEHXdTebpimWm8nGhOA4paKFFPrDKtEmYyf5HzUEFp1f45DzmRwHoI5l9+TFfj5f5ZUuwx5wjHOc3T2MUpKRI6wklgY6bHURRNkr48MqK7EWr8W1k6zwbMEMH13LH6NayzkhPyJ978S+ihky+AiiW7u9ujD5FzoEtsJrLHjzaujjnOyTXJLKXmV6dYZWhgwFdawPk/JfjdI9LJlV0IgOtIU/9hf0Fn0gD32EFaIP214tSyofGHj2i2G/8dyWGwDWUyPwJ0n3afxzFwCzg6HRMWOJ0OCzMPOrz1z34vkU7Mcg6OQRFKS4giYeQyr3ssa+YmJ9xcdZPDUbWEJXk0JMLCMNjeHAYSzcyCoomn62u/KxT6oX9bo2vpDIvTuPs6KU0dGF+nlV1qLWexo/LBgBlyoXcSdwyMXcoYBEjEAGyUpUNpuU76TaAC8MLqPdROk0tGUFPVxjT5rLJAXLN+3cy+l9+PTnoEYITNv9LAZ7g0/E19vWuAoaSGm3tXy9vcOccZ91c2N9xGcM3zQRzobhcX0XpjqzqXz0nCCcM2ExEd92hj0MJDqFmt5ibMHpMciAPKVDnEpaci3vEltY3LVf3TDxC97kPDC+jqKR9CMMSNPcvxBZ9lx6Xg2y79qoCB5sUNOTQ52WMLQdyh7DIBI/t1kXTjBQ3vA3dQ2fA1lHInTCBm5jFWEfoilKV6dXiXrGQAzaT/Nn9ZAOujZVwvBSWZ1k3P4L7830J9VK+QSW7n44Xx2v4UihiKGhMMkLiqjIQxCyMrLgrUVyJYAcYBBNrLUcHcTnXalmCxtuJZVj6wc3noJP64/vFK1iGAhiPJOwsO0cSsoNn/vkKLKh0B3Ph6axfPFOL9Px2AQJ76aDhCaWn6v0pGJ+YAvmk/JhgGZLR2c6KWR4L45yz 968kLwuM 02y3sWwJ49cqnXyDE5H1doPt82izuUk0ManqqJCB8ZFjlfguB0oJe6iQ38podMFMvqSWU2eW7RbqiI/PCTkbxmhlcZcTLOazv69724lQiqvJScGKYI4IMob6GXmYT3o/b5on8/VDI6wdN027tf90RQ27wudk703a4PxyEsCs+7xczgw0B4ABbc9rKt7KqmhpBV2cfHklZoE4NKOFT1oOGO2lOD3ScwEPzrLzk7ISxR8N9nwatTGSHsMzdSKX29IS4B8i/eElvtwdx/IzVUJVOPAOXWQcjUEAgsUPen23uLYc5s4IBY9v6+bpfqw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: 在 2024/6/17 下午5:52, David Hildenbrand 写道: > Why would we want to make folio_maybe_dma_pinned() detection that worse Just want to fix it using the existing function, seems a little unreasonable. I will prepare the V2 using folio_test_lru(folio) to check. static unsigned long collect_longterm_unpinnable_pages(...) { ... if (!folio_test_lru(folio) && drain_allow) { lru_add_drain_all(); drain_allow = false; } ... } void folio_mark_lazyfree(struct folio *folio) { if (folio_test_anon(folio) && folio_test_swapbacked(folio) && !folio_test_swapcache(folio) && !folio_test_unevictable(folio)) { struct folio_batch *fbatch; folio_get(folio); if (!folio_test_clear_lru(folio)) { folio_put(folio); return; } local_lock(&cpu_fbatches.lock); fbatch = this_cpu_ptr(&cpu_fbatches.lru_lazyfree); folio_batch_add_and_move(fbatch, folio, lru_lazyfree_fn); local_unlock(&cpu_fbatches.lock); } }