From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BB02C48BE6 for ; Wed, 16 Jun 2021 10:00:57 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1D66A61057 for ; Wed, 16 Jun 2021 10:00:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1D66A61057 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A5AF86B006C; Wed, 16 Jun 2021 06:00:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A1E116B006E; Wed, 16 Jun 2021 06:00:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8E5BD6B0070; Wed, 16 Jun 2021 06:00:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0098.hostedemail.com [216.40.44.98]) by kanga.kvack.org (Postfix) with ESMTP id 5B4856B006C for ; Wed, 16 Jun 2021 06:00:56 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id EBAAA10F71 for ; Wed, 16 Jun 2021 10:00:55 +0000 (UTC) X-FDA: 78259143270.30.AB93695 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf17.hostedemail.com (Postfix) with ESMTP id 3F6E34232F60 for ; Wed, 16 Jun 2021 10:00:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623837655; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=v117kTvCI/4L2L6gl5HuZGd1wWAwT2ti0jhBIeID/Fk=; b=Cuidm92eL7Z34pyvu18pGQSMRgojHCqnwQVgphqtr46UMTgdzwZof5K2tZUtoIUhDME4J5 uRoP5eepLRtS7SkUW/FzszBWIaM3uK5S6G/uZO4pldpPt+enueZkUSB9foq4jCjKwrrYUY wv93pED+Yn2M9htJ8AsLZjAe+Kj6+YI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-63-Ut1RbZJMM-WkHsW9vCAZ9Q-1; Wed, 16 Jun 2021 06:00:51 -0400 X-MC-Unique: Ut1RbZJMM-WkHsW9vCAZ9Q-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 57881801AF1; Wed, 16 Jun 2021 10:00:50 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-118-65.rdu2.redhat.com [10.10.118.65]) by smtp.corp.redhat.com (Postfix) with ESMTP id 21BBA60C0F; Wed, 16 Jun 2021 10:00:48 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20210614201435.1379188-12-willy@infradead.org> References: <20210614201435.1379188-12-willy@infradead.org> <20210614201435.1379188-1-willy@infradead.org> To: "Matthew Wilcox (Oracle)" Cc: dhowells@redhat.com, akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Yu Zhao Subject: Re: [PATCH v11 11/33] mm/lru: Add folio LRU functions MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <813936.1623837648.1@warthog.procyon.org.uk> Date: Wed, 16 Jun 2021 11:00:48 +0100 Message-ID: <813937.1623837648@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 3F6E34232F60 X-Stat-Signature: aqnurpf5p7qx4fp1ir84m38edpxbaxxq Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Cuidm92e; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf17.hostedemail.com: domain of dhowells@redhat.com has no SPF policy when checking 216.205.24.124) smtp.mailfrom=dhowells@redhat.com X-HE-Tag: 1623837648-242903 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Matthew Wilcox (Oracle) wrote: > Handle arbitrary-order folios being added to the LRU. By definition, > all pages being added to the LRU were already head or base pages, > so define page wrappers around folio functions where the original > page functions involved calling compound_head() to manipulate flags, > but define folio wrappers around page functions where there's no need to > call compound_head(). The one thing that does change for those functions > is calling compound_nr() instead of thp_nr_pages(), in order to handle > arbitrary-sized folios. > > Saves 783 bytes of kernel text; no functions grow. > > Signed-off-by: Matthew Wilcox (Oracle) > Reviewed-by: Yu Zhao Reviewed-by: David Howells