From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36BF8C48BE8 for ; Wed, 16 Jun 2021 09:55:48 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D1093610CA for ; Wed, 16 Jun 2021 09:55:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D1093610CA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 718E86B006C; Wed, 16 Jun 2021 05:55:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6C7C66B0071; Wed, 16 Jun 2021 05:55:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 590236B0072; Wed, 16 Jun 2021 05:55:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0236.hostedemail.com [216.40.44.236]) by kanga.kvack.org (Postfix) with ESMTP id 253A56B006C for ; Wed, 16 Jun 2021 05:55:47 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id BADCB181AC9C6 for ; Wed, 16 Jun 2021 09:55:46 +0000 (UTC) X-FDA: 78259130292.28.4ACE4AE Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf13.hostedemail.com (Postfix) with ESMTP id C2B38E000254 for ; Wed, 16 Jun 2021 09:55:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623837345; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PW5xGLzUsFmJGFg8n6b8tOo3AhHdABWtaYtdWOZ63Io=; b=K6VYE9gTTotYd/vcmLU3xANlnYj08HKpr07zt3dKJ1LH3Kfbqa/2iwPL5GFoJTPHwc2UqY n1RMWMhWZFNXxKZhfZ/afWnONr8/hBmFTQ4k8i9Qn9EsJhlNcI3PR6AB4WRWhVss2HCiml Xpn51k4oc/ygtp+gAy1nSGeuUeoLsVU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-597-EJSygrDEP-St_lD6GR0wtw-1; Wed, 16 Jun 2021 05:55:42 -0400 X-MC-Unique: EJSygrDEP-St_lD6GR0wtw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EBF898042AC; Wed, 16 Jun 2021 09:55:40 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-118-65.rdu2.redhat.com [10.10.118.65]) by smtp.corp.redhat.com (Postfix) with ESMTP id B4FF460853; Wed, 16 Jun 2021 09:55:38 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20210614201435.1379188-8-willy@infradead.org> References: <20210614201435.1379188-8-willy@infradead.org> <20210614201435.1379188-1-willy@infradead.org> To: "Matthew Wilcox (Oracle)" Cc: dhowells@redhat.com, akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Zi Yan , Christoph Hellwig , Jeff Layton , "Kirill A . Shutemov" , Vlastimil Babka , William Kucharski Subject: Re: [PATCH v11 07/33] mm: Add folio_put() MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <813596.1623837337.1@warthog.procyon.org.uk> Date: Wed, 16 Jun 2021 10:55:37 +0100 Message-ID: <813597.1623837337@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: C2B38E000254 Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=K6VYE9gT; spf=none (imf13.hostedemail.com: domain of dhowells@redhat.com has no SPF policy when checking 216.205.24.124) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Stat-Signature: 1eaobykpdq3hxrr1rqnn4wyrwe6rkd5t X-HE-Tag: 1623837336-274976 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Matthew Wilcox (Oracle) wrote: > If we know we have a folio, we can call folio_put() instead of put_page() > and save the overhead of calling compound_head(). Also skips the > devmap checks. > > This commit looks like it should be a no-op, but actually saves 684 bytes > of text with the distro-derived config that I'm testing. Some functions > grow a little while others shrink. I presume the compiler is making > different inlining decisions. > > Signed-off-by: Matthew Wilcox (Oracle) > Reviewed-by: Zi Yan > Reviewed-by: Christoph Hellwig > Acked-by: Jeff Layton > Acked-by: Kirill A. Shutemov > Acked-by: Vlastimil Babka > Reviewed-by: William Kucharski Reviewed-by: David Howells