From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E235EE0211 for ; Wed, 11 Sep 2024 07:25:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2DE2C8D00FD; Wed, 11 Sep 2024 03:25:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 28DB08D0056; Wed, 11 Sep 2024 03:25:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0DFDB8D00FD; Wed, 11 Sep 2024 03:25:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id DFD528D0056 for ; Wed, 11 Sep 2024 03:25:36 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 7329E1213FD for ; Wed, 11 Sep 2024 07:25:36 +0000 (UTC) X-FDA: 82551622272.28.8CB6811 Received: from flow5-smtp.messagingengine.com (flow5-smtp.messagingengine.com [103.168.172.140]) by imf20.hostedemail.com (Postfix) with ESMTP id 65B681C0007 for ; Wed, 11 Sep 2024 07:25:34 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm1 header.b="VgpE/1U4"; dkim=pass header.d=messagingengine.com header.s=fm1 header.b="u Pd7y27"; dmarc=pass (policy=none) header.from=arndb.de; spf=pass (imf20.hostedemail.com: domain of arnd@arndb.de designates 103.168.172.140 as permitted sender) smtp.mailfrom=arnd@arndb.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726039506; a=rsa-sha256; cv=none; b=eYrC15hXAbiE5gDDZdWMTm/poKKeZWAVpMmPmilAUOpVh7CGXvjEqEPYsq5sID5+VzwRjS EreB/ldwkfwiVF9/TELncc1j4wft67RRJSnXDT+hbJ+uGbXyHOucdBnPw5Y9pxYOkBTyCC o6oWwJq9pomZrYuA8NC1MXq71LDnZgA= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm1 header.b="VgpE/1U4"; dkim=pass header.d=messagingengine.com header.s=fm1 header.b="u Pd7y27"; dmarc=pass (policy=none) header.from=arndb.de; spf=pass (imf20.hostedemail.com: domain of arnd@arndb.de designates 103.168.172.140 as permitted sender) smtp.mailfrom=arnd@arndb.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726039506; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yCULKLzEw1t/f1sPt/nrm6FrZBRX7uDhUSLEPSMpBQQ=; b=OLwFG7/wH3LSDKSE9kv2QVy8+5FY2TOaW9LC+Gm96TNLgVzEGMDHIhHXhI4Hlz6p3JPsgU M9vCeWJH/nBrA5x4X/EnJ+jik79kSA/FopUK7ylnePpmXy1Lg6Uec1bQeZdSAmAVVnOigV vR8gGqqt3DHah6VSnat3kT4TiZRFZCc= Received: from phl-compute-10.internal (phl-compute-10.phl.internal [10.202.2.50]) by mailflow.phl.internal (Postfix) with ESMTP id 5FF0B20031F; Wed, 11 Sep 2024 03:25:33 -0400 (EDT) Received: from phl-imap-11 ([10.202.2.101]) by phl-compute-10.internal (MEProxy); Wed, 11 Sep 2024 03:25:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :content-transfer-encoding:content-type:content-type:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1726039533; x=1726046733; bh=yCULKLzEw1t/f1sPt/nrm6FrZBRX7uDhUSLEPSMpBQQ=; b= VgpE/1U4loJri9LiuX7Zp3kpL8B/8h0OclDS8D2qwbi1j/gV/4Dv0Is+b0/KrUjc bgS87B1lv+q5Ww8OQNHMs7UUCFzhYwqeNEI7qcSCJ5R8Cz6zyi9VQfE3HuT6WlUU IJVyijW60CE0wSdiD0Z5i8cXac4tC2E4XXyQo+BIYzPN/E8AHr+rEYPKjJ2JEj3a pazvkihnp/Gt/CI+rGrCWj7mQ+PxlVRrdD8wErMCd+duga8MvKpYjHS0ASNqV5py eK8pix0YokPCoBvBj7t/5/L7Rr5Y6AZPgl9p66wMb8srBd3P1fQ0YCu+n/12a0kE LQn0BwlFInbl9ta8zMHnGA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1726039533; x= 1726046733; bh=yCULKLzEw1t/f1sPt/nrm6FrZBRX7uDhUSLEPSMpBQQ=; b=u Pd7y278RoZsWfSRrvw+gMVM8jAt7Bbg3GADlLo3PeCstdM+9j+qexh54tdP/gEtN ajwYHFbXXYe6u4iRwBsf0Oz8q96Q3KjMJAv2xJFw6UFoUkBRCBX3RMeTShpc/wyl hNUDB3BLdBBIbAFkMJYs7OB7oV7KwNjpVkNxej7MFuimIz13nRM6ftAd+6d2rZEq ehlnSP5uoes83Td45KcieFiLmMqTPKRVrxnmi0V0urnvUpJ3vhmDr2eY8pEf7uo5 +YsyctX/5nWESrcf7hSGMRlZHk3+LDTt6iyIFhst5Jqlh0c8MLw3YFK54iOERtxj fjHHFbXRHE0yCIbpPAOdQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrudejtddguddulecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefoggffhffvkfgjfhfutgfgsehtjeertdertddt necuhfhrohhmpedftehrnhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrd guvgeqnecuggftrfgrthhtvghrnhephfekledtffefhffghfetteehuefhgfetgefhtdeu feduueeltefghedtjeeifffhnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpe hmrghilhhfrhhomheprghrnhgusegrrhhnuggsrdguvgdpnhgspghrtghpthhtohephedt pdhmohguvgepshhmthhpohhuthdprhgtphhtthhopegsphesrghlihgvnhekrdguvgdprh gtphhtthhopehtshgsohhgvghnugesrghlphhhrgdrfhhrrghnkhgvnhdruggvpdhrtghp thhtoheptggrthgrlhhinhdrmhgrrhhinhgrshesrghrmhdrtghomhdprhgtphhtthhope hlihhnuhigsegrrhhmlhhinhhugidrohhrghdruhhkpdhrtghpthhtoheptghhrhhishht ohhphhgvrdhlvghrohihsegtshhgrhhouhhprdgvuhdprhgtphhtthhopegurghvvghmse gurghvvghmlhhofhhtrdhnvghtpdhrtghpthhtohepmhhpvgesvghllhgvrhhmrghnrdhi ugdrrghupdhrtghpthhtoheprghnughrvggrshesghgrihhslhgvrhdrtghomhdprhgtph htthhopegthhhrihhsrdhtohhrvghksehgmhgrihhlrdgtohhm X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id 466A32220072; Wed, 11 Sep 2024 03:25:29 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface MIME-Version: 1.0 Date: Wed, 11 Sep 2024 07:25:08 +0000 From: "Arnd Bergmann" To: "Charlie Jenkins" , "Liam R. Howlett" , "Catalin Marinas" , guoren , "Richard Henderson" , "Ivan Kokshaysky" , "Matt Turner" , "Vineet Gupta" , "Russell King" , "Huacai Chen" , "WANG Xuerui" , "Thomas Bogendoerfer" , "James E . J . Bottomley" , "Helge Deller" , "Michael Ellerman" , "Nicholas Piggin" , "Christophe Leroy" , "Naveen N Rao" , "Alexander Gordeev" , "Gerald Schaefer" , "Heiko Carstens" , "Vasily Gorbik" , "Christian Borntraeger" , "Sven Schnelle" , "Yoshinori Sato" , "Rich Felker" , "John Paul Adrian Glaubitz" , "David S . Miller" , "Andreas Larsson" , "Thomas Gleixner" , "Ingo Molnar" , "Borislav Petkov" , "Dave Hansen" , x86@kernel.org, "H. Peter Anvin" , "Andy Lutomirski" , "Peter Zijlstra" , "Muchun Song" , "Andrew Morton" , "Vlastimil Babka" , "Lorenzo Stoakes" , shuah , "Christoph Hellwig" , "Michal Hocko" , "Kirill A. Shutemov" , "Chris Torek" , Linux-Arch , linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, "linux-csky@vger.kernel.org" , loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-abi-devel@lists.sourceforge.net Message-Id: <8130e50c-01e2-45c3-a516-45f5499311f2@app.fastmail.com> In-Reply-To: References: <20240905-patches-below_hint_mmap-v3-0-3cd5564efbbb@rivosinc.com> <20240905-patches-below_hint_mmap-v3-1-3cd5564efbbb@rivosinc.com> <9fc4746b-8e9d-4a75-b966-e0906187e6b7@app.fastmail.com> Subject: Re: [PATCH RFC v3 1/2] mm: Add personality flag to limit address to 47 bits Content-Type: text/plain Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 65B681C0007 X-Rspamd-Server: rspam01 X-Stat-Signature: 4816nxpufqkj7px5mnspmgbetyxp36us X-HE-Tag: 1726039534-846772 X-HE-Meta: U2FsdGVkX199qGe6wLCSwJrMPQfHBP2aEUBAcnnOdXn2/k5T+K49+PwnK5WM3mmacNH72p5Pk9KiyvyJAUFZ25klFx2iHgxgN76pH8RshNxEsEg0cMWChHVVz4fiVrKmOPz9uUvuJPUp/e9Tj70iBs8aLS+QtfXB+6wW08gKnzCtqx09wz54q3tKDtzG9h1z/Ng5QHVrhsRzK8s43kuJi6O9Wd1X3JPheFCowjwTgIh3UUBH38lW1voXFAIacczuvVkPIVyJpsLmWHUn436++82G3hmxjMz4vnRLHWwlfpe+qZ/p7mX3VejJUdrdhkvMAuxGvmg6OjSIHCCba3rLrPuYI0lSc9x1VZGxYLzjEcMv9au1KFf76N+ZaR3GncMNWHkuehsn7m4GFrZuHDmVdXZudOxtcN7G0plJWThDPaYojY5tXdV7Pqu2NizExm/jTELKE/Yfap3/BrnLxP/FgHm3nYClbKxYALmrC0dHG3upBuV9i2IoAHXcahcHHA+Xqk9slmSmBSpHQqpKXFaPcBxnZAadMGwd4OrcWIk61tpONw2Of/hgynMLri621cCnf+B1ubWtzTkVkrNIoqy9gRcpUzmvIAGzi6H7V6Y5E+V1LZoC38/LN0SQn56BX6JCHDa0xL+gdf5nQM/mgKwI6pRFj1H4gBMn9rB7h5RjSp64StJXThun0z9mL1jhDY0ANPv5l/SmIsWEp8GUc3JYE8j8kn6flFNBU+4uUK5/jHEGVxd2mnxjGrXLf9MKEUQ8CUie5sWFrNDQFqWFB8CS7S4q+DTlYA9ke+rz20e475xef+SzUAGn3mN05fVjT+teiaOmQiIMWjA4VVddvh9o59jsX/OITH7QKWFrMldjMQqgNtz0yXruUZormbYVwRGRPQLWNezN3jrNb6+Qi+xNeq8qcYKDXMGkunGqChPz6ZaIzQ/tFKfWcFe1n1kRsOgeVjWYatuIjZdm9vAKNCX 9wW0K491 cykU6h8dwR37RX0a4aMrfgxzVnKo+8fLMO0fgUmtR5Kc3PDSL0oWbLKbfN1V3iiF4Gd4h2aj5pJt4APgbWmOfR7AGbOZl7Kbhi56PEXv/PoTBxj+27LTMHO8aMNAeKHuhmyxG1HtWyscdhL5UOMnyeI1o4lGOZ6a2SK3HlSLl+bkrgHvhAtqCdbgJXyrIVbvUEmcpkgtCMoZQkKUtsBNVisx80ly56/kB1Bx3bMsl/PRPdC0El/26FnsG1nYjcGmmDEb2248HOIaUadRyhH27c2yFxSnpb6lRg6uWRgKPrFy31mbrvtmWf/kyZ8Z+bSps1EJwJTyn1DNJR1AZ11ObhUTIGA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Sep 11, 2024, at 00:45, Charlie Jenkins wrote: > On Tue, Sep 10, 2024 at 03:08:14PM -0400, Liam R. Howlett wrote: > > I responded to Arnd in the other thread, but I am still not convinced > that the solution that x86 and arm64 have selected is the best solution. > The solution of defaulting to 47 bits does allow applications the > ability to get addresses that are below 47 bits. However, due to > differences across architectures it doesn't seem possible to have all > architectures default to the same value. Additionally, this flag will be > able to help users avoid potential bugs where a hint address is passed > that causes upper bits of a VA to be used. > > The other issue I have with this is that if there is not a hint address > specified to be greater than 47 bits on x86, then mmap() may return an > address that is greater than 47-bits. The documentation in > Documentation/arch/x86/x86_64/5level-paging.rst says: > > "If hint address set above 47-bit, but MAP_FIXED is not specified, we try > to look for unmapped area by specified address. If it's already > occupied, we look for unmapped area in *full* address space, rather than > from 47-bit window." This is also in the commit message of b569bab78d8d ("x86/mm: Prepare to expose larger address space to userspace"), which introduced it. However, I don't actually see the fallback to the full address space, instead the actual behavior seems to be the same as arm64. Am I missing something in the x86 implementation, or do we just need to update the documentation? Arnd