From: David Hildenbrand <david@redhat.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Julien Grall <julien.grall@arm.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Matthew Wilcox <willy@infradead.org>,
Stefano Stabellini <sstabellini@kernel.org>,
linux-mm@kvack.org, akpm@linux-foundation.org,
xen-devel <xen-devel@lists.xenproject.org>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Juergen Gross <jgross@suse.com>,
linux-kernel@vger.kernel.org, Nadav Amit <namit@vmware.com>
Subject: Re: [Xen-devel] [PATCH v1] xen/balloon: Fix mapping PG_offline pages to user space
Date: Thu, 14 Mar 2019 17:00:15 +0100 [thread overview]
Message-ID: <81175478-d6cf-56ce-587c-87473e79fd50@redhat.com> (raw)
In-Reply-To: <5C8A77FD020000780021EC87@prv1-mh.provo.novell.com>
On 14.03.19 16:49, Jan Beulich wrote:
>>>> On 14.03.19 at 16:40, <david@redhat.com> wrote:
>> --- a/drivers/xen/balloon.c
>> +++ b/drivers/xen/balloon.c
>> @@ -604,6 +604,7 @@ int alloc_xenballooned_pages(int nr_pages, struct page **pages)
>> while (pgno < nr_pages) {
>> page = balloon_retrieve(true);
>> if (page) {
>> + __ClearPageOffline(page);
>> pages[pgno++] = page;
>
> While this one's fine, ...
>
>> @@ -646,6 +647,7 @@ void free_xenballooned_pages(int nr_pages, struct page **pages)
>>
>> for (i = 0; i < nr_pages; i++) {
>> if (pages[i])
>> + __SetPageOffline(pages[i]);
>> balloon_append(pages[i]);
>> }
>
> ... I think you want to add a pair of braces here.
>
> Jan
>
>
Indeed, dropped by accident. Will resend in a minute. Thanks!
--
Thanks,
David / dhildenb
prev parent reply other threads:[~2019-03-14 16:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-14 15:40 David Hildenbrand
2019-03-14 15:49 ` Oscar Salvador
2019-03-14 15:59 ` David Hildenbrand
2019-03-14 15:49 ` [Xen-devel] " Jan Beulich
2019-03-14 16:00 ` David Hildenbrand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81175478-d6cf-56ce-587c-87473e79fd50@redhat.com \
--to=david@redhat.com \
--cc=JBeulich@suse.com \
--cc=akpm@linux-foundation.org \
--cc=andrew.cooper3@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=jgross@suse.com \
--cc=julien.grall@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=namit@vmware.com \
--cc=sstabellini@kernel.org \
--cc=willy@infradead.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox