From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19C6BC48BE6 for ; Wed, 16 Jun 2021 09:31:51 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BDEFC6100A for ; Wed, 16 Jun 2021 09:31:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BDEFC6100A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 535C96B0070; Wed, 16 Jun 2021 05:31:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 50DEB6B0071; Wed, 16 Jun 2021 05:31:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3D5416B0072; Wed, 16 Jun 2021 05:31:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0253.hostedemail.com [216.40.44.253]) by kanga.kvack.org (Postfix) with ESMTP id 0DEF16B0070 for ; Wed, 16 Jun 2021 05:31:50 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 98213180AD806 for ; Wed, 16 Jun 2021 09:31:49 +0000 (UTC) X-FDA: 78259069938.25.B0357A1 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf15.hostedemail.com (Postfix) with ESMTP id 943B0A00025C for ; Wed, 16 Jun 2021 09:31:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623835908; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JXCjlY2RliOquOvoDO8BDnu0gEbkyWt4VmaWrl8nPLE=; b=NW+Qw/+m3b3Esbxe6L7eQKsuswPgdgkDIoz3+N1b4N7cyTjF4X5cuX7iJNmyKZ+1iJ72ng TylCiR82LKa9TrtzUkZI9xjyAUf+cNajQvyWmXDIjTMZvG6hiyLSNVuI41Hdu6m1tAM+y0 ja4F8u3xZX2kUI/g/dTiVGBChDNq708= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-297-AsjWusxGPbiDGdRv14ygrQ-1; Wed, 16 Jun 2021 05:31:47 -0400 X-MC-Unique: AsjWusxGPbiDGdRv14ygrQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A55C11858F13; Wed, 16 Jun 2021 09:31:45 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-118-65.rdu2.redhat.com [10.10.118.65]) by smtp.corp.redhat.com (Postfix) with ESMTP id 034495D6D1; Wed, 16 Jun 2021 09:31:43 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20210614201435.1379188-3-willy@infradead.org> References: <20210614201435.1379188-3-willy@infradead.org> <20210614201435.1379188-1-willy@infradead.org> To: "Matthew Wilcox (Oracle)" Cc: dhowells@redhat.com, akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Jeff Layton , "Kirill A . Shutemov" , Vlastimil Babka , William Kucharski Subject: Re: [PATCH v11 02/33] mm: Introduce struct folio MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <811607.1623835903.1@warthog.procyon.org.uk> Date: Wed, 16 Jun 2021 10:31:43 +0100 Message-ID: <811608.1623835903@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 943B0A00025C X-Stat-Signature: zfot4srnxytwu7do5jtg9m1boas8wycn Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="NW+Qw/+m"; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf15.hostedemail.com: domain of dhowells@redhat.com has no SPF policy when checking 216.205.24.124) smtp.mailfrom=dhowells@redhat.com X-HE-Tag: 1623835904-660084 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Matthew Wilcox (Oracle) wrote: > + * Return: The base-2 logarithm of the size of this folio. You could probably just say "Return: log2 of the size of this folio". Could we also get a synonym for page_offset()? Perhaps called folio_fpos() rather than folio_offset()? "Offset" is a bit generic. Reviewed-by: David Howells