From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1703FC3ABC9 for ; Fri, 16 May 2025 09:45:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B99606B0119; Fri, 16 May 2025 05:45:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B489F6B011A; Fri, 16 May 2025 05:45:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9E8FF6B011B; Fri, 16 May 2025 05:45:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 8110B6B0119 for ; Fri, 16 May 2025 05:45:43 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 87DDABFCB9 for ; Fri, 16 May 2025 09:45:43 +0000 (UTC) X-FDA: 83448288966.18.4AEF6B0 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf10.hostedemail.com (Postfix) with ESMTP id 3AAF0C0004 for ; Fri, 16 May 2025 09:45:40 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=E2LiSY9t; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=fjtGVKr2; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=E2LiSY9t; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=fjtGVKr2; spf=pass (imf10.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747388741; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8WpIKKHmGcTGOMiGo191FHS/rzC9luV4pcbmSleL9Ho=; b=fdFudEdqtDy0xT64aiPenk9QBIlLoTScDUvhozSgIy4kPPIzDfAoc9W5sgej/qOasW5l1u xxMA4Qz4pPmFD5kiyTKT9c6em1Bz97mgjP7mrthb6f0yDsMaqKJ8IM0LpJvV22KiEr8LmR a8VLNlPmjYFA3keh12boYVmaR3T2Qew= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=E2LiSY9t; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=fjtGVKr2; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=E2LiSY9t; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=fjtGVKr2; spf=pass (imf10.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747388741; a=rsa-sha256; cv=none; b=KEggYpbhn5FTjtCZV1tWhJIenPE0ORt9O/gkVzCzupCeUO/aTkWn+/QDTa+shbGfI3CDPT pERH0zUhCzEc1Ivt0ieQZ8Zi9Zy+lYYy6xEvd2ZmmfRonj46k8DjgCrsRixFtnsTGXqNIT OaKOFJQh855mXkPDc8GRo6/Sm0y+Eqg= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 8F1741F809; Fri, 16 May 2025 09:45:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1747388739; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8WpIKKHmGcTGOMiGo191FHS/rzC9luV4pcbmSleL9Ho=; b=E2LiSY9t77zhDLEU1dEtdR2SAbSyz4VGtl58X+O5YgnxrT+1L9rxIHXtgrB0gUYWT1RRqq GnaxN9s4I6VyB3LdBTDrUYchAzxfRs+IWxvrTn7v37CdXe9R6TkzQWZyH2PBmMNtWKnk4h YYX9SJGoyls65x7+RNdnMk6amRaNNMg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1747388739; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8WpIKKHmGcTGOMiGo191FHS/rzC9luV4pcbmSleL9Ho=; b=fjtGVKr2fc1C6/15gm6kiGUDTtJyh0ooLIMWiEZaKh4n3chdDAihT41/TTk4iW//2o/Mbp D6gvzpf0rp2C8SCQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1747388739; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8WpIKKHmGcTGOMiGo191FHS/rzC9luV4pcbmSleL9Ho=; b=E2LiSY9t77zhDLEU1dEtdR2SAbSyz4VGtl58X+O5YgnxrT+1L9rxIHXtgrB0gUYWT1RRqq GnaxN9s4I6VyB3LdBTDrUYchAzxfRs+IWxvrTn7v37CdXe9R6TkzQWZyH2PBmMNtWKnk4h YYX9SJGoyls65x7+RNdnMk6amRaNNMg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1747388739; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8WpIKKHmGcTGOMiGo191FHS/rzC9luV4pcbmSleL9Ho=; b=fjtGVKr2fc1C6/15gm6kiGUDTtJyh0ooLIMWiEZaKh4n3chdDAihT41/TTk4iW//2o/Mbp D6gvzpf0rp2C8SCQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 7181613977; Fri, 16 May 2025 09:45:39 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id ACVmG0MJJ2hGcwAAD6G6ig (envelope-from ); Fri, 16 May 2025 09:45:39 +0000 Message-ID: <8114231b-ec06-44a9-9075-9ccf0809de4a@suse.cz> Date: Fri, 16 May 2025 11:45:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/5] memcg: make memcg_rstat_updated nmi safe Content-Language: en-US To: Shakeel Butt , Andrew Morton Cc: Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Alexei Starovoitov , Sebastian Andrzej Siewior , Harry Yoo , Yosry Ahmed , Peter Zijlstra , Mathieu Desnoyers , bpf@vger.kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Meta kernel team References: <20250516064912.1515065-1-shakeel.butt@linux.dev> <20250516064912.1515065-6-shakeel.butt@linux.dev> From: Vlastimil Babka In-Reply-To: <20250516064912.1515065-6-shakeel.butt@linux.dev> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspam-User: X-Rspamd-Queue-Id: 3AAF0C0004 X-Rspamd-Server: rspam09 X-Stat-Signature: mg7nqdtxoj4e986bfzpwe1cc4jo4qi3f X-HE-Tag: 1747388740-846101 X-HE-Meta: U2FsdGVkX1+AhofqL7+AbVP+SBVicK4Fu/9Uh+KWi353K2EejpxDblQ7Jd1+SahkkbIeVmeiEIEY1n+bhOnat3tRpsWFdV5QKV+o9dlI9nYdcznm70ClL7ElYykdm9IhYCDs82/moL0Va1c2qXsHYQxCOBmzdmVWaYxGAXe+kIGd3aQYxgJLuMJh3WOl0bDKQCK1wBop/VrP9sRsuhPHwEW6ZZ63ziEoS7tpAazVac39UfHenADO4hqo8tRgpO6kaPIxm/pT6viVk3Wrwu5+9kkEAF9ANY1nMquQvVY2nW7Bc4W3K7+m1SsosdgLAdEXdSwl8H7AXQzy5wI14aCOLFH+14hWcHN8R2UyIu11OVAmJPupdX8po1xNai+YnMDBr4WYp4OBnOzRm/UtCkc12guQ2onoom3tgfblg6Hhbq4GHBZAcbDxoCA9WS4mdKQ1Nq0xDHdmvZSvpIZDawqqHuFGGt4L7MJlywssvnflH+Xt+IwtID33hnJbI8puLIjzYXV+IIFD4IY50d68ZxcaxQSFpnvhojsVM068BWBcZ0dyQOsBpmEHCMR6ohD3/FWtu2pNII69F9b3cFZtYSgksCIsKFmmRAiDyMSemX0cIXNvC2EFGIvYsEnhLobr+kLdUgdbwhfFjft2AZQuIvSQNhv1SribhglOua7P96JHf5f6gVRSJCdr6pX5vdE72340kdgImsF+9Uqtq2/sIEmK7hC1loDwsX2M7U7KAFpKa68TZFAWp+SADsQwBaYQ0o55mFuXrX46zuhLfVx9UE0L6AAUIv1DVyr2nRm167IcerCsTn8IPBbHzIZ+3o3voAMY8dIsp6Qb6ehcSOzQ5GVZkPHG1lPMxz4UVgA8nqpXTm2ASJcMQCN78MHSP/ASZYO9/ZnFDQZwbjtPB3qS8o2WyUnyRY+6VIKLx6XyQPe7nqwnSr6To2K0eL2SrL3pDcL8EzblI2QPatByPWdJ51h vDWwtN0/ zEi9tNC3gINVCI28RAd5rPIb7zwc/72bkq7/14nuZEMJDsg5lAo/yp5R4vmWEtpRpApFM9ytXXdDcSl4GV74AsFpxWgcFloQrQE/duXEzFklXZXUYywrBEjXK13xTpK1+IUnHqBpAcoadS02kMvqftBqK/U4D8T9sOgcx2381q9mH6XiQrp5SYM5vJ7L55Au/4r+2eJsxV93XJE1X2rYMdS5HTYIx9QIB9rDZ924omb282wG6BSkdUdgYGhQLLL4C5Sf7sqe+R1pyqdwQUXhGr1lZctse4eUDP+4dk/f9pujQGWe4KmC635AnZZcg2Csk6GqP5hFPCtVoXpkI/Blmi4Gi4A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/16/25 08:49, Shakeel Butt wrote: > memcg: convert stats_updates to atomic_t You have two subjects, I guess delete the second one? > Currently kernel maintains memory related stats updates per-cgroup to > optimize stats flushing. The stats_updates is defined as atomic64_t > which is not nmi-safe on some archs. Actually we don't really need 64bit > atomic as the max value stats_updates can get should be less than > nr_cpus * MEMCG_CHARGE_BATCH. A normal atomic_t should suffice. > > Also the function cgroup_rstat_updated() is still not nmi-safe but there > is parallel effort to make it nmi-safe, so until then let's ignore it in > the nmi context. > > Signed-off-by: Shakeel Butt Acked-by: Vlastimil Babka