From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 596CFEB64DD for ; Sat, 24 Jun 2023 11:17:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CECF68D0002; Sat, 24 Jun 2023 07:17:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C75D78D0001; Sat, 24 Jun 2023 07:17:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AEF748D0002; Sat, 24 Jun 2023 07:17:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 9B2458D0001 for ; Sat, 24 Jun 2023 07:17:32 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 7075B1C7B84 for ; Sat, 24 Jun 2023 11:17:32 +0000 (UTC) X-FDA: 80937390744.20.1B7A728 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by imf07.hostedemail.com (Postfix) with ESMTP id E1A774000E for ; Sat, 24 Jun 2023 11:17:29 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=CYbPeV4z; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf07.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.178 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687605450; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=T15O6xQIwkBwwHtvfiEExn4sWPaOJ+WY8Ww0WTBtsp8=; b=sktFD+ygpEOAP1X4YPBKtOAH50sE5TFmoHfP3RAlLrkM0ks4c76u0hoPI95jDMUAwR9soD Q/8Uf0zGAzGUXjfcwvjMUpW+c/dC7po4g+osfQxY/3SQiCDje+o/Cuh4bCXSVfdj/q2HFc +I1TC02pnIm6/HPiqzT+oc8sLrNmeXo= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=CYbPeV4z; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf07.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.178 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687605450; a=rsa-sha256; cv=none; b=x8ckQuMahCpiaW6unPtoZ9V8U5j9cKnM1DgbGJpjkrjYOOCu3rsrP8vmzU6OjEMUL5T4jO F7TkwiGvdWO9lV2MtO8gX4EVaL464sZ5mPpdljcIY/8Iy2v36bsHU1gH4Nq4YBwFymv/n7 z6ic1RvxzFJSJgbqXYU//WFBGysZ4fs= Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-1b5585e84b4so2535805ad.0 for ; Sat, 24 Jun 2023 04:17:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1687605449; x=1690197449; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=T15O6xQIwkBwwHtvfiEExn4sWPaOJ+WY8Ww0WTBtsp8=; b=CYbPeV4zw+1THiloHL2+ypjCEv/Id/OqdEvK4Gbzyx+byuca+5y6cAMB03scGpNQnd SSB/7Anoxb0IyXh7PuVlGbhgdQdF/LJkm6iAy37RUchzkDnhJHkx6mrv3F5vKgoyQyPy OIasGq/04a4yIeBx66N81aJ+oDLEzr/c57Z4snA4iQkl0+r7Z1fxQw1D3B6O1TLBBXtU +6bRquokuMgWUCPSNTKWaKx0RTO9dV5TrEkx6qXy9qwlyog+mmdaA1jG00RymxjmBaI/ eUJ0hTbMfoOPJPyWkTS38C3ZPCIA3M/x6cjkzBrGwhlDHNcmA3/i0KhFITfJt8SeOUy8 iVYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687605449; x=1690197449; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=T15O6xQIwkBwwHtvfiEExn4sWPaOJ+WY8Ww0WTBtsp8=; b=ilnVS4An+rNI28dA8BNQYSQaiAqCEl8lSSpdOlC7cu62CCwo0X9eD6GBb3DmiCLB+s mL+tTy1tO7QpEgTU1Ni6a05KSyGOoYeKL4TzQpyUmwHOCPPADspWC1khHaP/SvoeJEf1 GHNH6HCl0rrkjMfyydKAcZKLSx8u3z+ymqWhzmiBmmKTUKNsmz5Qou6jw/jEG7VwrF1f 4fkzglkquzUzEBJ62qIExsw7+f3791f+fRZ8zLyFLXDbcynFEQhujF+LU+9kJKggFxZn 8V9CSmv72Bd36Zkt84wMeALtUimNlaIiaDx3tdhyzXCYmwH/ELoSmV0UiO4zMVhMXx9z fGSw== X-Gm-Message-State: AC+VfDws8I3mYhj3Jul/fXeHBJi0g3xYPYj5Ge0Akj9wH+c8L7FULL+Y 5aoXsYegbplFpI/1hofujvzJjA== X-Google-Smtp-Source: ACHHUZ6FdOiaHAk7I6ISkFgljzCcZyK3aCzvXyKEVanrKS23oGi4259EOvC6Ypj8Kzv6/iuF/wHf7Q== X-Received: by 2002:a17:902:ecc6:b0:1ae:1364:6086 with SMTP id a6-20020a170902ecc600b001ae13646086mr29288550plh.2.1687605448727; Sat, 24 Jun 2023 04:17:28 -0700 (PDT) Received: from [10.4.162.153] ([139.177.225.251]) by smtp.gmail.com with ESMTPSA id c13-20020a170902d48d00b001ab0a30c895sm1034090plg.202.2023.06.24.04.17.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 24 Jun 2023 04:17:28 -0700 (PDT) Message-ID: <8107f6d1-2f86-46f1-2b31-263928499ab6@bytedance.com> Date: Sat, 24 Jun 2023 19:17:17 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 15/29] NFSD: dynamically allocate the nfsd-client shrinker Content-Language: en-US To: Chuck Lever Cc: akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, linux-bcache@vger.kernel.org, linux-xfs@vger.kernel.org, linux-nfs@vger.kernel.org, linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, linux-raid@vger.kernel.org, linux-mm@kvack.org, dm-devel@redhat.com, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-btrfs@vger.kernel.org References: <20230622085335.77010-1-zhengqi.arch@bytedance.com> <20230622085335.77010-16-zhengqi.arch@bytedance.com> From: Qi Zheng In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: E1A774000E X-Stat-Signature: 4q5dthga6hg1n5my4xg7bmmzboof8krj X-HE-Tag: 1687605449-485144 X-HE-Meta: U2FsdGVkX19JX/tEJA2qmcfhCgtg3BqOjqaU22S+s1dOabsySUP1w5Bl7UZBTOXeYym5S/jj7CvSWGCvZMGp+qBw63laqAuKcAOEqcJuJNCXn+g+RoxIW1UFEhsYjlU8tpBVd+RCJqMAhhHBcVsQla1/tm4fuKLDtjmAtwJz2r6W4eQHgJqE97TVhnnKMyiUSLx9YaLFT3sFKsp1rzvKu0YnBkntwl7w6H/rjA73kmi3WTzqyzLRerlr4g7I+NVUZwfkjRsINrMSE7NJ/E8s6WYq8dN0e8JNSrssVzdHYLCvTCzuk4vKS75aup1JDGwNfx6N806Qp/Ws9rMsnrGXBMLKAVrSDmBg8aQAr8V2Yxh7LuiiEpED9M2MzoLZvU0ktzJerv7EiPvn4ReVRYrjX2CJxrgn9zSs3Rmv3OfDeKuF8NvfKvDs29nF6DwwCFqEqGMqmxMFoFy8S0H8A442owieRwGwtM+O46G8uNDup8hbG5PFY3eu0IZfckN98YEZkaTMGkE8Uu2ZOw6bU5gXCcsJzehKYZhSOIxo9s2NZWarxbJuxzQYvFp5JlcjbCR2P4looM72EC1L70SosFap0TSO2s54+yOIDuzlm3bqA/4L3UpulC33RviXR/URFzc8L0+38KKd2o+VfpYD8yMotCPV3o7eZz6/E7bG0OgBCLM/eALDSV9BXRCbaYuwohacpwQh2SfMgmM9Y1BsBo0+kcNrXIrjIowlmm3FZ8AklT72IdkSim48E2ZhAwy48VicHOVKEI9Wldgf3H17a4HlEkvFVD1Z51aWa4wOlUmNYNme7kHntOLowElGxs5iciLxTLgIo1vdRIHMPNWspIneY8YOkIoNjs2cYMp0rI40X5BOc+PDMSHS9gPrI7rTUEx/fazp+CyCMMQvmBr0NAJamKDx5IQKCk/LPFzL9JT4zq8obYRdGDlpuGQKHQmo5P5RLKxl3FEE5W7jfH0gYQg 27if2+ex JO96+PeKTbqzIahqUMIYgALnUfCMGPB00e+0T/sxc4LZ/NtrYxB6Jb4cjxKwNGnLw6RclqW/b/tFLcDnxDsAxJ2sNLh415glmQO9RnnGBYaQyMWu3knM3FuZMa33bPNEX4as+tf3uqoFKXjoaXmjUlaAxt+sZRuJZYalTExiQt6xwDpDkWCaYlcvIHDz7EG/0m+c1BPLPwoYAuiqsHiQT5+/4wYTcrhGLeeunfN0MJEKTO96enAoJtuEf5HtRuUMifvvEPBTewAHXZRndoRMHgtAhIhZcUfCOh1WHHdzSQyUepG7L6LEYNVkVMJgbcA2QTr1f/E/mh8ijsS0oeqilqHtI6MSblXiS+eusJooCNAZ/AoBmMA1c9lbMy9vhEYF5u2mmIcpv6nIWk4/nB4dW8tTxWaJjSP9pV+pUZPgVOn0VRkn6MLVExBSrJnQS7ng0B2+x X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Chuck, On 2023/6/24 05:49, Chuck Lever wrote: > On Thu, Jun 22, 2023 at 04:53:21PM +0800, Qi Zheng wrote: >> In preparation for implementing lockless slab shrink, >> we need to dynamically allocate the nfsd-client shrinker, >> so that it can be freed asynchronously using kfree_rcu(). >> Then it doesn't need to wait for RCU read-side critical >> section when releasing the struct nfsd_net. >> >> Signed-off-by: Qi Zheng > > For 15/29 and 16/29 of this series: > > Acked-by: Chuck Lever Thanks for your review! :) And I will implement the APIs suggested by Dave in 02/29 in the v2, so there will be some changes here, but it should not be much. So I will keep your Acked-bys in the v2. Thanks, Qi > > >> --- >> fs/nfsd/netns.h | 2 +- >> fs/nfsd/nfs4state.c | 20 ++++++++++++-------- >> 2 files changed, 13 insertions(+), 9 deletions(-) >> >> diff --git a/fs/nfsd/netns.h b/fs/nfsd/netns.h >> index ec49b200b797..f669444d5336 100644 >> --- a/fs/nfsd/netns.h >> +++ b/fs/nfsd/netns.h >> @@ -195,7 +195,7 @@ struct nfsd_net { >> int nfs4_max_clients; >> >> atomic_t nfsd_courtesy_clients; >> - struct shrinker nfsd_client_shrinker; >> + struct shrinker *nfsd_client_shrinker; >> struct work_struct nfsd_shrinker_work; >> }; >> >> diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c >> index 6e61fa3acaf1..a06184270548 100644 >> --- a/fs/nfsd/nfs4state.c >> +++ b/fs/nfsd/nfs4state.c >> @@ -4388,8 +4388,7 @@ static unsigned long >> nfsd4_state_shrinker_count(struct shrinker *shrink, struct shrink_control *sc) >> { >> int count; >> - struct nfsd_net *nn = container_of(shrink, >> - struct nfsd_net, nfsd_client_shrinker); >> + struct nfsd_net *nn = shrink->private_data; >> >> count = atomic_read(&nn->nfsd_courtesy_clients); >> if (!count) >> @@ -8094,14 +8093,19 @@ static int nfs4_state_create_net(struct net *net) >> INIT_WORK(&nn->nfsd_shrinker_work, nfsd4_state_shrinker_worker); >> get_net(net); >> >> - nn->nfsd_client_shrinker.scan_objects = nfsd4_state_shrinker_scan; >> - nn->nfsd_client_shrinker.count_objects = nfsd4_state_shrinker_count; >> - nn->nfsd_client_shrinker.seeks = DEFAULT_SEEKS; >> - >> - if (register_shrinker(&nn->nfsd_client_shrinker, "nfsd-client")) >> + nn->nfsd_client_shrinker = shrinker_alloc_and_init(nfsd4_state_shrinker_count, >> + nfsd4_state_shrinker_scan, >> + 0, DEFAULT_SEEKS, 0, >> + nn); >> + if (!nn->nfsd_client_shrinker) >> goto err_shrinker; >> + >> + if (register_shrinker(nn->nfsd_client_shrinker, "nfsd-client")) >> + goto err_register; >> return 0; >> >> +err_register: >> + shrinker_free(nn->nfsd_client_shrinker); >> err_shrinker: >> put_net(net); >> kfree(nn->sessionid_hashtbl); >> @@ -8197,7 +8201,7 @@ nfs4_state_shutdown_net(struct net *net) >> struct list_head *pos, *next, reaplist; >> struct nfsd_net *nn = net_generic(net, nfsd_net_id); >> >> - unregister_shrinker(&nn->nfsd_client_shrinker); >> + unregister_and_free_shrinker(nn->nfsd_client_shrinker); >> cancel_work(&nn->nfsd_shrinker_work); >> cancel_delayed_work_sync(&nn->laundromat_work); >> locks_end_grace(&nn->nfsd4_manager); >> -- >> 2.30.2 >>