From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3F11FA3745 for ; Sat, 29 Oct 2022 04:47:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 55ECB6B0072; Sat, 29 Oct 2022 00:47:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4E7666B0074; Sat, 29 Oct 2022 00:47:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3618F6B0075; Sat, 29 Oct 2022 00:47:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 238406B0072 for ; Sat, 29 Oct 2022 00:47:39 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E71D81603F8 for ; Sat, 29 Oct 2022 04:47:38 +0000 (UTC) X-FDA: 80072753796.02.C717807 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf02.hostedemail.com (Postfix) with ESMTP id 333DB80010 for ; Sat, 29 Oct 2022 04:47:37 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 64967CE2FCF; Sat, 29 Oct 2022 04:47:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EA46BC433C1; Sat, 29 Oct 2022 04:47:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1667018852; bh=mAACII8QLXPb+2oghNArcGBgEFrS6aOgUSNOHVDZKPc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=CYsWQpVBnAqxfH9QjR9cAu5rm4qWCaoDoHDMrXu8qeGJPjfInBlhlb4hosNwuCb5y 2/JzqwR6JP/mLfD9pMpYktbhYQ40F+5gyKrX5+LhkAeZVCGACQWLfAJN1MO+F+rPcr pF8cd+2VZwfLQNvSAvq7XUTQh6KwHuX3FKB2+f+TAi2/+GyiiYYojDCj8PoUYR+ZFY DOI0yXq6r/4zM8H+euAL9EjltJmkjxHL7PzH4n9I24I4nBVjmUa8zpgWtf5jD8qY3B fNuxhK1UeMdSTzH7u3Edo7OiEPYEp8TUmTzUuPUUxaMVZZr+PpvXV+EUQRERLh+cl5 knBFlU8Gx7F1w== Message-ID: <80fe1f37-586b-4fc6-f007-1d3e8ec3fdb9@kernel.org> Date: Sat, 29 Oct 2022 12:47:30 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [f2fs-dev] [PATCH v3 13/23] f2fs: Convert f2fs_sync_node_pages() to use filemap_get_folios_tag() Content-Language: en-US To: "Vishal Moola (Oracle)" , linux-fsdevel@vger.kernel.org Cc: linux-cifs@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-mm@kvack.org, ceph-devel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-afs@lists.infradead.org, linux-btrfs@vger.kernel.org References: <20221017202451.4951-1-vishal.moola@gmail.com> <20221017202451.4951-14-vishal.moola@gmail.com> From: Chao Yu In-Reply-To: <20221017202451.4951-14-vishal.moola@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667018858; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KUOB99+eNFVZwcGV53fgw8ytEoA1O6w5bQdwqcMTdN8=; b=pXQU49STJ0h+GcOwOF2EPjuP+MYxGoA/gJ6UrgNWjKUzkhTMs6aN9t0hLdNIe9alft7PUD N+teA/NfI25YekfY5k2HgZcRwiUr+aELFgrW1/9iHlmU7bpdAq9QGoPkYrsbC4xNi87k7n UsTpVhPo5lZwenatsaf3zWlCG46UBtc= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=CYsWQpVB; spf=pass (imf02.hostedemail.com: domain of chao@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=chao@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667018858; a=rsa-sha256; cv=none; b=6TfA1oNyiXV+UX8M9QCIfpj8NL1B2DY/NLCylMyI+ZcIw7+W8KGxV7VtPOy1HtlY5TQiJR R08HsxiD4S8HZDu6KWJHdLQdyv9SR+jJkqabKdTQgxM+Uz6UdyDEtwFmC3GWhe1gpJauRb qZ3WfndTsyqIdooAwqWBLW1eLJo6/kQ= X-Stat-Signature: tqsqtp16itkh6wzbwc7cpagjkaomjrsh X-Rspamd-Queue-Id: 333DB80010 X-Rspam-User: Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=CYsWQpVB; spf=pass (imf02.hostedemail.com: domain of chao@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=chao@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspamd-Server: rspam04 X-HE-Tag: 1667018857-957939 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/10/18 4:24, Vishal Moola (Oracle) wrote: > Convert function to use a folio_batch instead of pagevec. This is in > preparation for the removal of find_get_pages_range_tag(). > > Signed-off-by: Vishal Moola (Oracle) Acked-by: Chao Yu Thanks, > --- > fs/f2fs/node.c | 17 +++++++++-------- > 1 file changed, 9 insertions(+), 8 deletions(-) > > diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c > index a2f477cc48c7..38f32b4d61dc 100644 > --- a/fs/f2fs/node.c > +++ b/fs/f2fs/node.c > @@ -1935,23 +1935,24 @@ int f2fs_sync_node_pages(struct f2fs_sb_info *sbi, > bool do_balance, enum iostat_type io_type) > { > pgoff_t index; > - struct pagevec pvec; > + struct folio_batch fbatch; > int step = 0; > int nwritten = 0; > int ret = 0; > - int nr_pages, done = 0; > + int nr_folios, done = 0; > > - pagevec_init(&pvec); > + folio_batch_init(&fbatch); > > next_step: > index = 0; > > - while (!done && (nr_pages = pagevec_lookup_tag(&pvec, > - NODE_MAPPING(sbi), &index, PAGECACHE_TAG_DIRTY))) { > + while (!done && (nr_folios = filemap_get_folios_tag(NODE_MAPPING(sbi), > + &index, (pgoff_t)-1, PAGECACHE_TAG_DIRTY, > + &fbatch))) { > int i; > > - for (i = 0; i < nr_pages; i++) { > - struct page *page = pvec.pages[i]; > + for (i = 0; i < nr_folios; i++) { > + struct page *page = &fbatch.folios[i]->page; > bool submitted = false; > > /* give a priority to WB_SYNC threads */ > @@ -2026,7 +2027,7 @@ int f2fs_sync_node_pages(struct f2fs_sb_info *sbi, > if (--wbc->nr_to_write == 0) > break; > } > - pagevec_release(&pvec); > + folio_batch_release(&fbatch); > cond_resched(); > > if (wbc->nr_to_write == 0) {