From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13DFEC433EF for ; Mon, 21 Feb 2022 13:19:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8C06E8D0002; Mon, 21 Feb 2022 08:19:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 848A08D0001; Mon, 21 Feb 2022 08:19:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6EB068D0002; Mon, 21 Feb 2022 08:19:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0105.hostedemail.com [216.40.44.105]) by kanga.kvack.org (Postfix) with ESMTP id 5D1CA8D0001 for ; Mon, 21 Feb 2022 08:19:36 -0500 (EST) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 0B41399EB6 for ; Mon, 21 Feb 2022 13:19:36 +0000 (UTC) X-FDA: 79166843952.24.DA50B0B Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf01.hostedemail.com (Postfix) with ESMTP id 1541140005 for ; Mon, 21 Feb 2022 13:19:34 +0000 (UTC) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.56]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4K2NCc5QY4zdZPp; Mon, 21 Feb 2022 21:18:20 +0800 (CST) Received: from [10.174.177.76] (10.174.177.76) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Mon, 21 Feb 2022 21:19:30 +0800 Subject: Re: [PATCH v2] mm: clean up hwpoison page cache page in fault path To: Oscar Salvador CC: Rik van Riel , , , , Andrew Morton , Mel Gorman , Johannes Weiner , Matthew Wilcox References: <20220212213740.423efcea@imladris.surriel.com> From: Miaohe Lin Message-ID: <80df0575-6f61-ccad-833a-b4f5b3d42628@huawei.com> Date: Mon, 21 Feb 2022 21:19:30 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.76] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 1541140005 X-Rspam-User: Authentication-Results: imf01.hostedemail.com; dkim=none; spf=pass (imf01.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com X-Stat-Signature: kgkhikyfompk5yc1nqh9anejfnekwxjq X-HE-Tag: 1645449574-66210 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/2/21 20:54, Oscar Salvador wrote: > On Wed, Feb 16, 2022 at 10:13:14AM +0800, Miaohe Lin wrote: >> IIUC, this could not happen when soft-offlining a pagecache page. They're either >> invalidated or migrated away and then we set PageHWPoison. >> I think this may happen on a clean pagecache page when it's isolated. So it's !PageLRU. >> And identify_page_state treats it as me_unknown because it's non reserved, slab, swapcache >> and so on ...(see error_states for details). Or am I miss anything? > > But the path you are talking about is when we do have a non-recoverable > error, so memory_failure() path. > AFAIU, Rik talks about pages with corrected errors, and that is > soft_offline(). Oh, yes, Rik talks about pages with corrected errors. My mistake. Then I really want to understand how we got there too. :) Thanks. >