From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CFF3C71157 for ; Wed, 18 Jun 2025 13:16:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 411706B0092; Wed, 18 Jun 2025 09:16:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3E83C6B0093; Wed, 18 Jun 2025 09:16:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2D6C36B0095; Wed, 18 Jun 2025 09:16:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 1C1FB6B0092 for ; Wed, 18 Jun 2025 09:16:33 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 8ED195FE46 for ; Wed, 18 Jun 2025 13:16:32 +0000 (UTC) X-FDA: 83568570624.20.3E1C5D7 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf17.hostedemail.com (Postfix) with ESMTP id D46FC40012 for ; Wed, 18 Jun 2025 13:16:29 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cdotbtSy; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750252590; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HF/h5iERcRiAWZcVo6GzXQXrMZ2C+pgVCc623GzbLyU=; b=cTV/clVKTsaBmweFvjNVDO2t28piKWoEcK5hiuU08Qbvb/x11m53R1ifMjE31jaJTxtVW2 h7WU5BeiMa+6r07xgvC5URAG70YxRhPFigpp3cSvQUwa985FTGz62oKscO7OhmQf8xPvXj BrMXpn2LRqNt4JYVCCu6txvic2uNORU= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cdotbtSy; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750252590; a=rsa-sha256; cv=none; b=wTFf80YQA1j97mvNklDKbb8Xo++HYkym8AHD/tzr2yJY2xuKtkYLulLXCa/VJCKSBMWuOM Bcvy+XaCiLvWMiTn1Rx8Ni363EMJqTMOfvaKWfbNyBDIMa2xrbta0t5KMiuC4HE/azqxSF oAe86V7RQt29ETcqH8rOUfq3CCSiSd4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750252589; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=HF/h5iERcRiAWZcVo6GzXQXrMZ2C+pgVCc623GzbLyU=; b=cdotbtSyO8aogRabZEKoae7mp46hReLCyoXxoKQinwdkkPM+/bKPLPT45mXDwZexj97mK0 z+ePm5xVldHdESgQCQ1j5MSFK2Iiyd7zIkvKcHRdiyVXQqGY2VxtvndO6VcSM4R2lPBCpD nZ5rncpoK0BOU/PuxJnhmoQ+kZb2kKI= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-435-TD7P3K3UPRuQtvcWtztrMA-1; Wed, 18 Jun 2025 09:16:28 -0400 X-MC-Unique: TD7P3K3UPRuQtvcWtztrMA-1 X-Mimecast-MFC-AGG-ID: TD7P3K3UPRuQtvcWtztrMA_1750252587 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-450d244bfabso57032325e9.0 for ; Wed, 18 Jun 2025 06:16:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750252587; x=1750857387; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=HF/h5iERcRiAWZcVo6GzXQXrMZ2C+pgVCc623GzbLyU=; b=goQgOnfyF7urrxkap6vSGNRWbe907tbtl69mZ2LCsqlThhiJpm0v1+0TiprKckgBY9 R8yklENt7lIxf1UZVG4XRDUHKJZ3cznNtKHJXftWXUoSr2KJNolHDu0p5NUIItx/+AQs oVOmb5JX4hg6v/tbqcwU1ykg6bSQf6uWLmCi95O5lBbEP/ippgL0GQsxK1bjOVrSKnQi NzZSa7vgILQ/+qLrNdF4c3k29kOMpu4l6DZhS2V4bdYF1XOVpvDZILZRGCytk9hkhdVA pqM7EQ/2KVkIBruez0HcUOxiqPBl+vjamvCjT5jXx56WVnKk+Yxl6oiYK8ixZlgdWIB6 arnQ== X-Forwarded-Encrypted: i=1; AJvYcCXZnt5wBLjKOKV8p1zKN8BUtkdkmPCIdjZ0xXranOck3G6rea/VOFL1BJSI2ngIkZnAWVK5XTGr0Q==@kvack.org X-Gm-Message-State: AOJu0YyxUSiA0nkelseVI6Oau8xjjTQyGVBsMQjlEZfDnbMwFUzLOno8 2//mpYq7XYZICRz9ZQ0o4aiDumM7ZRMADC1KQf2tqJYMAlOohajLbcnROlIiqvDp+MW9qzcwULF lDMZxBn9oepT9s+xGH6D/KjSfPjaR7sAxptngBVUMVq2j6YSwTY2I X-Gm-Gg: ASbGncu5SPUEr5efcfIwXWpfnRwPN64R5hdmW8kTfDDI6P+MWaqbJWOrGSwQm+jGYUh 3UiNklKC70LyNjRTVlnhV1fapzgnXWCSolH20s7ZJ9nP90S6rZ+tuLjDNK74LB5vQv3diRAy8PZ OF+sXs64tlXgbbuFA23JhQo3rCJ3jNtTee+K0QiR0SRI1zupPx37XDU2TnQMdrlL8h4dhjoshy+ MkpvcjeD883/Q+3FGpFPzuJ0kVU1N+rlUqJALAFtBwydglG44X1UmNL6xriEh+1n6UWeMjU1L9+ jcUXomjEzTPvsNCExW7S9DO5THU/SO5RjvOxhv2PnJwpmTEY708Pf1icGrVGeAyXTJRK9TzR/RK nLU6Jk13r+7qTrpS+vzXGdC+QXSvdfEZFz/jICfhO99ZGvOw= X-Received: by 2002:a05:600c:4e02:b0:43d:ac5:11e8 with SMTP id 5b1f17b1804b1-4533caaeb57mr146639595e9.21.1750252586530; Wed, 18 Jun 2025 06:16:26 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFjSUUqdc83WhSU0K6mVnps9+N/GTCXXKIMqt/yKtrTCHClblot/wii0/9onwg7tf1gxoVdxA== X-Received: by 2002:a05:600c:4e02:b0:43d:ac5:11e8 with SMTP id 5b1f17b1804b1-4533caaeb57mr146638745e9.21.1750252586082; Wed, 18 Jun 2025 06:16:26 -0700 (PDT) Received: from ?IPV6:2003:d8:2f2d:2400:4052:3b5:fff9:4ed0? (p200300d82f2d2400405203b5fff94ed0.dip0.t-ipconnect.de. [2003:d8:2f2d:2400:4052:3b5:fff9:4ed0]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4532e232219sm204383145e9.9.2025.06.18.06.16.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Jun 2025 06:16:25 -0700 (PDT) Message-ID: <80cb9936-416f-42c4-96c2-416304bd9262@redhat.com> Date: Wed, 18 Jun 2025 15:16:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v12 08/18] KVM: guest_memfd: Allow host to map guest_memfd pages To: Xiaoyao Li , Sean Christopherson Cc: Fuad Tabba , Ira Weiny , kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org, kvmarm@lists.linux.dev, pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, ackerleytng@google.com, mail@maciej.szmigiero.name, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com, peterx@redhat.com, pankaj.gupta@amd.com References: <20250611133330.1514028-1-tabba@google.com> <20250611133330.1514028-9-tabba@google.com> <68501fa5dce32_2376af294d1@iweiny-mobl.notmuch> <701c8716-dd69-4bf6-9d36-4f8847f96e18@redhat.com> <3fb0e82b-f4ef-402d-a33c-0b12e8aa990c@redhat.com> <5ee9bbb8-d100-408c-ac07-ea9c5b603545@intel.com> <5a55d95e-5e32-4239-a445-be13228ea80b@redhat.com> <45af2c0d-a416-49bc-8011-4ec57a56d6f5@intel.com> <40a5903b-f747-4eab-8959-06ddd6e88f82@redhat.com> <38101158-4475-4885-83e7-654045ca0f9b@redhat.com> <3031b949-c42a-49bc-be0c-f95a62c792e2@intel.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <3031b949-c42a-49bc-be0c-f95a62c792e2@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: f2g5TxeZj-GIiwStv2KxfvvYVkBrSk2moqdXZ3cVwvg_1750252587 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: D46FC40012 X-Stat-Signature: adwjwbf5mic5h3d17en58drmzrcxji9x X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1750252589-740293 X-HE-Meta: U2FsdGVkX184b9dt2343Rcvaa1J7uQiSAfJwfOWauVFvQZrgwTiakQZCw71IAFQCh4cOZakw8cofidGMIc40g+fJuBPJgEtVMlBk967jG+gW6x/pf98p6mMYmRDKuXlVFcSHjvv9VA0xgABmdKHQkp+eKtIJAkkQoaI2hWPqckY9sLsQEviRRqlAV3kgFi8r1ObHb7T9qKBUEqX+hWMk4k887p+Bc42WqskigfiTngVv9aoNDqN2BzzNyvvLJBnIURYtPg3WPCYLK48piz/hTPRvTs3hdgmFdZ5IajktWEaMY8v3TMvE6/0p3QY7nfHbg6lA432KyoffjIjT/V7dEiqkuqKETImgnuomxS6X1Y7tDHBNHoNmH2+7PhkGpxtacitl11PiJxYZOof/mXvLit9LWL7lKTkqBydUBRbNFa/23BL9/8w3jYRpXvGlBFpFJoJYYjgiNl27jXHxHSb8tJ5ftSGWXmITJIRw42/iRN8gJ/QuHQ0vOMDv5YjM1mLSOmWLh4lm7B9WIVRBeajUhKCHHiiPcKDXgJ57SDvu9KTUcA++i60e+uxQovcVKFPTTzo36dLm0a6g8ngiMNPmsjqG0422vPmdOwq8Zkxloy6TsqvG/plK1/UN+BGmgBT27os+isvz+NGxrewrFaqXRxCHSVqIdZ48EgOXJyl808PKW5r70VzLrCMjhCQbeBwEkYQo96oqSsyNsYgV3jVq4TLD4jCultI8kG6r5aREaB/7cJpMNxnWx38FWCOoVzgvOM2CI+r5PCzoSXcSlVUs2FshXmvEeuRQdqzMMFieIFutmj4Fpf68C1/4275yZAqwnkQlQITtbEcu4/A2Y5A63Uh+lm8YFawRVd6sSZ+7jve2IUeRUmaDyXAkdGJxxoiZpkzUDOJRAVoVDHwTH3ax+hbqlC7M0pV5geSFEvf09lsfpqWjLS3OYadpHh/OhiL9jnyBodw0uDuNHryq4nc 77KlTxmy Fdf8EN64BC0CUZ+QYS7yLVpxVwqKim2YCrRKiICVPxWIJoRlxgkEmefcmS4UHr9z488RMDgRQyaPzbNjZSurHNsccSM7py62XnXHLM+68S/x/OfYg6UNZZaGEeApIql+umOG4gqgLlYOxCa43ip/h6mEzATebFuVR5JouZHObR8qnFWJN5sT88M4jcDYLbV4OPvsBS6gSPBKFn842Hs5KdKnN4IT/yoQwJJHTZKF5PizopSmpAjZzGEForbdrldXzKXZ67TWkDhoLUabCvYf/b1kHCK7peasBv1HV7hTzBqOmqwK4w9mMzjbCBunpJmnBegiAIFSnvtZeTEhPnuhD0nJbk5ggcXV0rNuowlXckKReM9hiloNwqHlWokj6TXlnzlMsIiCwBdsawL4g7uQk4ISRguH/KRpTJjs0R/EWDYGCo/c7z7jiTDTCUWcWhbOYPVYCSMxRg3aVMzRy409PWmZNMG3Vs2cJD9RhqptIKuUW/7SNiEupjVhUcNJyQxVWY+D/eLpb/5CIfzVBcqt4P3PWvvP9pMi503X98Hgobo90eek= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 18.06.25 14:17, Xiaoyao Li wrote: > On 6/18/2025 7:14 PM, David Hildenbrand wrote: >> On 18.06.25 12:42, Xiaoyao Li wrote: >>> On 6/18/2025 5:59 PM, David Hildenbrand wrote: >>>> On 18.06.25 11:44, Xiaoyao Li wrote: >>>>> On 6/18/2025 5:27 PM, David Hildenbrand wrote: >>>>>> On 18.06.25 11:20, Xiaoyao Li wrote: >>>>>>> On 6/18/2025 4:15 PM, David Hildenbrand wrote: >>>>>>>>> If we are really dead set on having SHARED in the name, it could be >>>>>>>>> GUEST_MEMFD_FLAG_USER_MAPPABLE_SHARED or >>>>>>>>> GUEST_MEMFD_FLAG_USER_MAP_SHARED?  But >>>>>>>>> to me that's _too_ specific and again somewhat confusing given the >>>>>>>>> unfortunate >>>>>>>>> private vs. shared usage in CoCo-land.  And just playing the odds, >>>>>>>>> I'm >>>>>>>>> fine taking >>>>>>>>> a risk of ending up with GUEST_MEMFD_FLAG_USER_MAPPABLE_PRIVATE or >>>>>>>>> whatever, >>>>>>>>> because I think that is comically unlikely to happen. >>>>>>>> >>>>>>>> I think in addition to GUEST_MEMFD_FLAG_MMAP we want something to >>>>>>>> express "this is not your old guest_memfd that only supports private >>>>>>>> memory". And that's what I am struggling with. >>>>>>> >>>>>>> Sorry for chiming in. >>>>>>> >>>>>>> Per my understanding, (old) guest memfd only means it's the memory >>>>>>> that >>>>>>> cannot be accessed by userspace. There should be no shared/private >>>>>>> concept on it. >>>>>>> >>>>>>> And "private" is the concept of KVM. Guest memfd can serve as private >>>>>>> memory, is just due to the character of it cannot be accessed from >>>>>>> userspace. >>>>>>> >>>>>>> So if the guest memfd can be mmap'ed, then it become userspace >>>>>>> accessable and cannot serve as private memory. >>>>>>> >>>>>>>> Now, if you argue "support for mmap() implies support for non- >>>>>>>> private >>>>>>>> memory", I'm probably okay for that. >>>>>>> >>>>>>> I would say, support for mmap() implies cannot be used as private >>>>>>> memory. >>>>>> >>>>>> That's not where we're heading with in-place conversion support: you >>>>>> will have private (ianccessible) and non-private (accessible) >>>>>> parts, and >>>>>> while guest_memfd will support mmap() only the accessible parts can >>>>>> actually be accessed (faulted in etc). >>>>> >>>>> That's OK. The guestmemfd can be fine-grained, i.e., different >>>>> range/part of it can have different access property. But one rule never >>>>> change: only the sub-range is not accessible by userspace can it be >>>>> serve as private memory. >>>> >>>> I'm sorry, I don't understand what you are getting at. >>>> >>>> You said "So if the guest memfd can be mmap'ed, then it become userspace >>>> accessable and cannot serve as private memory." and I say, with in-place >>>> conversion support you are wrong. >>>> >>>> The whole file can be mmaped(), that does not tell us anything about >>>> which parts can be private or not. >>> >>> So there is nothing prevent userspace from accessing it after a range is >>> converted to private via KVM_GMEM_CONVERT_PRIVATE since the whole file >>> can be mmaped()? >>> >>> If so, then for TDX case, userspace can change the TD-owner bit of the >>> private part by accessing it and later guest access will poison it and >>> trigger #MC. If the #MC is only delivered to the PCPU that triggers it, >>> it just leads to the TD guest being killed. If the #MC is broadcasted, >>> it affects other in the system. >>> >>> I just give it a try on real TDX system with in-place conversion. The TD >>> is killed due to SIGBUS (host kernel handles the #MC and sends the >>> SIGBUS). It seems OK if only the TD guest being affected due to >>> userspace accesses the private memory. But I'm not sure if there is any >>> corner case that will affect the host. >> >> I suggest you go ahead and read all about in-place conversion support, >> and how it all relates to the #MC problem you mention here. >> >> Long story short: SIGBUS is triggered by the fault handler, not by the >> #MC, because private pages cannot be faulted in and accessed. >> > > Sorry for the wrong information and thanks for your patience! No problem. As raised, it would all be clearer if we started out with guest_memfd behaving just like memfd (mmap() support etc) and then added support for "private" memory on top. But that's not how it happened :) -- Cheers, David / dhildenb