From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DC403CA101F for ; Fri, 12 Sep 2025 14:56:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D508E8E0006; Fri, 12 Sep 2025 10:56:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D011F8E0002; Fri, 12 Sep 2025 10:56:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BC8258E0006; Fri, 12 Sep 2025 10:56:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A92808E0002 for ; Fri, 12 Sep 2025 10:56:58 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 4E8A511AEEB for ; Fri, 12 Sep 2025 14:56:58 +0000 (UTC) X-FDA: 83880900516.14.EAD9DD5 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf22.hostedemail.com (Postfix) with ESMTP id B22E7C0011 for ; Fri, 12 Sep 2025 14:56:55 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ijRXSAp0; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1757689016; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1zQFPvxy2+1YP++cSOxn0igG/hT4rPdSgkdxAwV7qG8=; b=o3qj5lYZU3xST5q+tHl2csOJOJGVzvFwjcvmtxOEsOEoWtfjegIV5deXfHOyJNDhrCqu8p ljZcizubzJcY8xNWGhkRKCo4JPjrhgP0raA6JsMl/Z0ssmbQYzAByZRjwBa4App7CYJOBo 5qYihNinUCC0o5gvtMspjjNq0QYtaZM= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ijRXSAp0; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1757689016; a=rsa-sha256; cv=none; b=XTMyWMQkuLoMb6NlGeiy006N84kCZdv4bZnCCxQnlUsc7zMnBFHasuQmf8acsUIKT0ARh4 xm/9gEQS5XH3Qb5x01/1iSWqkU91OZWjRk05cYoIrIFACyOcPhGn7HODXEVqfDncktK8fy Xumuyg7R5leDAj3oxvLLKdjXhOBcviU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1757689015; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=1zQFPvxy2+1YP++cSOxn0igG/hT4rPdSgkdxAwV7qG8=; b=ijRXSAp0rloxn+l6GBDPmTK8N8TQMHKL6j4DBaAxytsT3RGFq1FJsKzgi5g19FqKDQNoSt S+AJMvRlmwNfrnHjy4VMSK4yQdoJ7nSmJ6P1s94kmaTE6EYfGvxqaoUGY3s8+CLI7BECRl nNqPmFdLYEKHZs4rylahN1ELhnNU2Co= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-368-7B5WK0I_On-Ow1CFyUc-ZQ-1; Fri, 12 Sep 2025 10:56:52 -0400 X-MC-Unique: 7B5WK0I_On-Ow1CFyUc-ZQ-1 X-Mimecast-MFC-AGG-ID: 7B5WK0I_On-Ow1CFyUc-ZQ_1757689011 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-45de18e7eccso10876775e9.0 for ; Fri, 12 Sep 2025 07:56:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757689011; x=1758293811; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1zQFPvxy2+1YP++cSOxn0igG/hT4rPdSgkdxAwV7qG8=; b=oQERG5KL9nBIZf3/NIrJQcQg1S2YlR/4WNRQTpf9QKwh0FJdiW/bjiTguGtzUoZAvc fU5QUgcchLHazL5cLN6ixM7ZJj+N9YRg2QLjZ3A7WQQeSimwpE6t9FoIKcXSt0ywiW8q 7yuMWSlLOjzeZ2Heob2jSwaoX4JX9YSoPDjKAuD9A07lReO0z5s9OTyDMEjtZuky3dH6 Z9h9tVC4nU5nC+YLjMiS9hHvbAJT3CC/IVXPuFO5gWBfRC2lED4Sy0OzTDui+Jl3Mtjq 57MYyWCurAd6pe2lus01dgugRZpjgDonkbCofVnbrbytVy6PWSW/q8ne1uZ9j+wf7MBm 9gSA== X-Forwarded-Encrypted: i=1; AJvYcCUBNphhA4Np8G1QB5D675aD9c/MUf++at+iEGv5d0zyl7wuPmpk55HfsJlY8AoradjQdXUmumRynw==@kvack.org X-Gm-Message-State: AOJu0YwTFX2r0SjYjXF5pQtFX22m/R1PldQqwb7UBlZx8pqlyGpFGzrZ xKMLV6ZeJuAZaNDLnLvUGe22KwSVcJTTMtd1xcmR5Ru/aSsSspUXaFMBuVoVYvO/RRtZlTLIH4e 9jesE2BmzGWLkH5PK/ygNMXktr5jCuAIYjYvc6Z0786ijSICBVeri X-Gm-Gg: ASbGncs2mgggrs5nFvAf2EdDAXzpyMKQj1G5/UlYfDzN1s3b3+QjcTvoM40Pr6tfty/ lYQtrxpfj6A9n6ZjV2slEmZLOKGvv76x9xP+29s9Ptut30WMvjDeNiFghcYoJGRuNuw+B9rxAYF /L9Yimy/8Yg1nvQ00vvjTuMM9INY5iepSF/1TE9cwooFj6my20jgy3BbHhFIVq9UJvgcqqPgzXr /0xHNiDZOqgEa8MABhuHM9QzAggaK54HPHRbjc5JrozL4U9vHYyTD6TmG7LH9tUyK+xMP5Smu/v VJTaL7bnFd2I9vMzeANuAAonDmOSZwqPOIW5EresDaw0s+FXFZr/2KCiSEg9oYUtKyhcBDLNHlg KcLAOhRmiowyVPA+ecpF6or5XcLNF+CBx/Lh7ox54Sln2kKqLPuUyvtuCtl7LollSVVA= X-Received: by 2002:a05:600c:1f8b:b0:45b:47e1:ef71 with SMTP id 5b1f17b1804b1-45f21221db1mr33669785e9.36.1757689010898; Fri, 12 Sep 2025 07:56:50 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGGJ1Aw/IAsL+oNlxxyXrPuhksMuIHj7PST3ENH0Asl27SC4zC5fiOjdJn0+QusczB4ps/nWQ== X-Received: by 2002:a05:600c:1f8b:b0:45b:47e1:ef71 with SMTP id 5b1f17b1804b1-45f21221db1mr33669145e9.36.1757689010362; Fri, 12 Sep 2025 07:56:50 -0700 (PDT) Received: from ?IPV6:2003:d8:2f20:da00:b70a:d502:3b51:1f2d? (p200300d82f20da00b70ad5023b511f2d.dip0.t-ipconnect.de. [2003:d8:2f20:da00:b70a:d502:3b51:1f2d]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45e014ac468sm38862175e9.0.2025.09.12.07.56.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Sep 2025 07:56:49 -0700 (PDT) Message-ID: <80c50bf4-27b1-483c-9977-2519369c2630@redhat.com> Date: Fri, 12 Sep 2025 16:56:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v11 00/15] khugepaged: mTHP support To: Kiryl Shutsemau Cc: Nico Pache , linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, ziy@nvidia.com, baolin.wang@linux.alibaba.com, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, ryan.roberts@arm.com, dev.jain@arm.com, corbet@lwn.net, rostedt@goodmis.org, mhiramat@kernel.org, mathieu.desnoyers@efficios.com, akpm@linux-foundation.org, baohua@kernel.org, willy@infradead.org, peterx@redhat.com, wangkefeng.wang@huawei.com, usamaarif642@gmail.com, sunnanyong@huawei.com, vishal.moola@gmail.com, thomas.hellstrom@linux.intel.com, yang@os.amperecomputing.com, aarcange@redhat.com, raquini@redhat.com, anshuman.khandual@arm.com, catalin.marinas@arm.com, tiwai@suse.de, will@kernel.org, dave.hansen@linux.intel.com, jack@suse.cz, cl@gentwo.org, jglisse@google.com, surenb@google.com, zokeefe@google.com, hannes@cmpxchg.org, rientjes@google.com, mhocko@suse.com, rdunlap@infradead.org, hughd@google.com, richard.weiyang@gmail.com, lance.yang@linux.dev, vbabka@suse.cz, rppt@kernel.org, jannh@google.com, pfalcato@suse.de References: <20250912032810.197475-1-npache@redhat.com> <43f42d9d-f814-4b54-91a6-3073f7c7cedf@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZoEEwEIAEQCGwMCF4ACGQEFCwkIBwICIgIG FQoJCAsCBBYCAwECHgcWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaJzangUJJlgIpAAKCRBN 3hD3AP+DWhAxD/9wcL0A+2rtaAmutaKTfxhTP0b4AAp1r/eLxjrbfbCCmh4pqzBhmSX/4z11 opn2KqcOsueRF1t2ENLOWzQu3Roiny2HOU7DajqB4dm1BVMaXQya5ae2ghzlJN9SIoopTWlR 0Af3hPj5E2PYvQhlcqeoehKlBo9rROJv/rjmr2x0yOM8qeTroH/ZzNlCtJ56AsE6Tvl+r7cW 3x7/Jq5WvWeudKrhFh7/yQ7eRvHCjd9bBrZTlgAfiHmX9AnCCPRPpNGNedV9Yty2Jnxhfmbv Pw37LA/jef8zlCDyUh2KCU1xVEOWqg15o1RtTyGV1nXV2O/mfuQJud5vIgzBvHhypc3p6VZJ lEf8YmT+Ol5P7SfCs5/uGdWUYQEMqOlg6w9R4Pe8d+mk8KGvfE9/zTwGg0nRgKqlQXrWRERv cuEwQbridlPAoQHrFWtwpgYMXx2TaZ3sihcIPo9uU5eBs0rf4mOERY75SK+Ekayv2ucTfjxr Kf014py2aoRJHuvy85ee/zIyLmve5hngZTTe3Wg3TInT9UTFzTPhItam6dZ1xqdTGHZYGU0O otRHcwLGt470grdiob6PfVTXoHlBvkWRadMhSuG4RORCDpq89vu5QralFNIf3EysNohoFy2A LYg2/D53xbU/aa4DDzBb5b1Rkg/udO1gZocVQWrDh6I2K3+cCs7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 8_Z3k8TEI_fLR8kVBdumRkXFv1a7T33FxvQVeYrnDLc_1757689011 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: B22E7C0011 X-Rspamd-Server: rspam05 X-Stat-Signature: 6bzbfj8hw3q8u6f9xobcff73bz1qdbgg X-Rspam-User: X-HE-Tag: 1757689015-881106 X-HE-Meta: U2FsdGVkX1+XyFAeucJ3GUAoYDu7Reqx78UpdfX1oNe/HyNnEDKJnD/d3hZkgNIC+YQu0y7nF6Zq7UUQ827TmkGuRASPlyt8TmgDzD5oz+CHO0zQ+5lqx1BBRy7L1JHV1fQ35Pf0JHyLSU8Hv/74BThA0c8DZXy396DCZucfkMie+XkY8tjxsHJ4LBqQd77p5kmwGM/LjGrG0cPZ+1LT8kI9fF5bho9Cq4+K8KwdJP7qn6EKCMwP2ojEZzRURbJXdr6B2kpzpWp2XZ27yeG+IIfsDHAgmSoV063oWF681iqgWsimot5zIWRtxFuGUnnzHedYPyfdCbfUnC+9tAGidJ0IfyoBKe/p18ac9QrbL0ItXL5kaypha0ZymEMpmDw+AJPt2Aj2kOKwnIS/QL+IAK9wdRIOYMzDKw8XU1dPPz+SLZ3sovK/+7Nt1KVkw7h03+2tKnW38HsLI0lDwpH6jVgVIdAv5IJLkK2x1C3sQgfXc65YoAtF0CWg9+gc48ZRvYzcR9iJGC5ZH2Qpowe/qMgqhvrPNHPnkKU3mVK3K5b/rL18Qr55RUK2dMhefQaXaVVZT8lgTMusj7bHmXgcjVZuOhNzLKCtE4rU9BeGmsfVo0O9wsFR4LgDbaUYyt3TfKPBQqkdmA6IYJ0JxXAjAobX1Rc/MPcw4W/u+R+pY9uPyP9BgfUyFM6SzOtYi5/5WpQUvAF1MTPFrLRqC9ZIZnT5zGbrauymT4Zhu8NHysz0Sp6LN3rMPrroCQjPhBQnr435T3MrEP4DJ8QRh3lO9Fv8IlfcrIwEUxhxAp7e7Tq9ifKFDv6C+bAhhcC+WyQjO+dib0Bo2PUS98dp8Jwmgva/x59ZhY5cNkbGE8uhu+wOqyXCPZ6fpVMV4KgO5G2nQrooMztdE0+gXzrHzoOzEdX9NGoghoNEPqD5VRoOxjsTl8vI0ECwq/nrr8SPLfpRflWXlF8C5H2ikRhyNty n3EG1Z0i /nNGvhOUykCpXcZZY/yv/cdRSWG9b9XL9CoxYcam0plPcaL1Y+JhVRNw3Fp/uI9f/cGK8Y1ObTNmCcOFY9JQaMIDDu6pueVFzyxR5+6vu345bZoDNnn4w3c9vstIU1IRAzbl09I0H+wKqGLkNmHi2sXJ4ntMeSTcGj7zBlssHegez2NACLmzF01GNCiPs9KA3FCk4oMe5WUwVgUfZUxmuTZmqJxpgXRT4JYeMJzwTtcZtBRzit/WHEOrzMPcVO5pTv93EaO2ort+QImXcxwNssUow0bKtwbR5ULSZRXjQWpJL+TLNW0yWL6465iQAzz6MkLRdQxkgV2c3vF3nHTLWBAfUe91eQ5EkTKU/59uS/dY2fEMnHF9ZHHWMpF5MEXB1feaXaZzyoCizFkmWkpY9VwaKrAZsPK766t/kdZ+3wtv2B8YpfwWbUmBpWWsB/QFG7or6X2esz2GNWurIeXltYoLgUr+NHHXlL9YGuvkQzjeT1bTK96dQjn7AOw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12.09.25 16:35, Kiryl Shutsemau wrote: > On Fri, Sep 12, 2025 at 04:28:09PM +0200, David Hildenbrand wrote: >> On 12.09.25 15:47, David Hildenbrand wrote: >>> On 12.09.25 14:19, Kiryl Shutsemau wrote: >>>> On Thu, Sep 11, 2025 at 09:27:55PM -0600, Nico Pache wrote: >>>>> The following series provides khugepaged with the capability to collapse >>>>> anonymous memory regions to mTHPs. >>>>> >>>>> To achieve this we generalize the khugepaged functions to no longer depend >>>>> on PMD_ORDER. Then during the PMD scan, we use a bitmap to track individual >>>>> pages that are occupied (!none/zero). After the PMD scan is done, we do >>>>> binary recursion on the bitmap to find the optimal mTHP sizes for the PMD >>>>> range. The restriction on max_ptes_none is removed during the scan, to make >>>>> sure we account for the whole PMD range. When no mTHP size is enabled, the >>>>> legacy behavior of khugepaged is maintained. max_ptes_none will be scaled >>>>> by the attempted collapse order to determine how full a mTHP must be to be >>>>> eligible for the collapse to occur. If a mTHP collapse is attempted, but >>>>> contains swapped out, or shared pages, we don't perform the collapse. It is >>>>> now also possible to collapse to mTHPs without requiring the PMD THP size >>>>> to be enabled. >>>>> >>>>> When enabling (m)THP sizes, if max_ptes_none >= HPAGE_PMD_NR/2 (255 on >>>>> 4K page size), it will be automatically capped to HPAGE_PMD_NR/2 - 1 for >>>>> mTHP collapses to prevent collapse "creep" behavior. This prevents >>>>> constantly promoting mTHPs to the next available size, which would occur >>>>> because a collapse introduces more non-zero pages that would satisfy the >>>>> promotion condition on subsequent scans. >>>> >>>> Hm. Maybe instead of capping at HPAGE_PMD_NR/2 - 1 we can count >>>> all-zeros 4k as none_or_zero? It mirrors the logic of shrinker. >>> >>> BTW, I thought further about this and I agree: if we count zero-filled >>> pages towards none_or_zero one we can avoid the "creep" problem. >>> >>> The scanning-for-zero part is rather nasty, though. >> >> Aaand, thinking again from the other direction, this would mean that just >> because pages became zero after some time that we would no longer collapse >> because none_or_zero would then be higher. Hm .... >> >> How I hate all of this so very very much :) > > This is not new. Shrinker has the same problem: it cannot distinguish > between hot 4k that happened to be zero from the 4k that is there just > because of we faulted in 2M a time. Right. And so far that problem is isolated to the shrinker. To me so far "none_or_zero" really meant "will I consume more memory when collapsing". That's not true for zero-filled pages, obviously. -- Cheers David / dhildenb