From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51BFCC28B2F for ; Mon, 17 Mar 2025 02:03:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6B603280002; Sun, 16 Mar 2025 22:02:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 665E1280001; Sun, 16 Mar 2025 22:02:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 554DB280002; Sun, 16 Mar 2025 22:02:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 3A83A280001 for ; Sun, 16 Mar 2025 22:02:58 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id B376B1412D0 for ; Mon, 17 Mar 2025 02:02:58 +0000 (UTC) X-FDA: 83229394836.14.FAB1B67 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf23.hostedemail.com (Postfix) with ESMTP id B8746140004 for ; Mon, 17 Mar 2025 02:02:55 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf23.hostedemail.com: domain of liuyonglong@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=liuyonglong@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742176977; a=rsa-sha256; cv=none; b=e7dQdAVpDcjxQnqSLfYp2rWadrDdtC6YlmOPzlko2yd7qutzW1a1jfWClVI/mhOYnKfNvm o8N37rv9DJ5oKB62/FxZ7sruPi25Vl1xU5KAL9VRBCqLE8nkC9DtmOdGL0/pRfSuh9dmq9 hbnTW7bDbBaTzOht+mT2WVNa9m3tIi8= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf23.hostedemail.com: domain of liuyonglong@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=liuyonglong@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742176977; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4/ADDOLvR8pDOlX7lVEAJDpBfvrfAP6Z1IFaiCgXw+k=; b=BHRWzVhXsxq3DrY8wDRqsINYrnZqcJooook44NziCd2r7u6onQbCiyNjFvCTcQ3qg98dft 2G52W58OI78gITYSeq/FQHroL3nzMWPBYojdN1r40R+40PEmWJQXv3iWMriJ35bscjURUY 30VWXdAXSOT3aFzMMeFljAWNEODzK6w= Received: from mail.maildlp.com (unknown [172.19.163.174]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4ZGJ9Y4JKwztQmx; Mon, 17 Mar 2025 10:01:21 +0800 (CST) Received: from kwepemf200007.china.huawei.com (unknown [7.202.181.233]) by mail.maildlp.com (Postfix) with ESMTPS id E9F83140391; Mon, 17 Mar 2025 10:02:49 +0800 (CST) Received: from [10.67.121.184] (10.67.121.184) by kwepemf200007.china.huawei.com (7.202.181.233) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Mon, 17 Mar 2025 10:02:48 +0800 Message-ID: <80bb0e6c-99eb-4c8f-ac00-0c048ec7bbb1@huawei.com> Date: Mon, 17 Mar 2025 10:02:47 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 0/3] Fix late DMA unmap crash for page pool To: =?UTF-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= , "David S. Miller" , Jakub Kicinski , Jesper Dangaard Brouer , Saeed Mahameed , Leon Romanovsky , Tariq Toukan , Andrew Lunn , Eric Dumazet , Paolo Abeni , Ilias Apalodimas , Simon Horman , Andrew Morton , Mina Almasry , Yunsheng Lin , Pavel Begunkov , Matthew Wilcox CC: , , , , Qiuling Ren , Yuying Ma References: <20250314-page-pool-track-dma-v1-0-c212e57a74c2@redhat.com> Content-Language: en-US From: Yonglong Liu In-Reply-To: <20250314-page-pool-track-dma-v1-0-c212e57a74c2@redhat.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.121.184] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To kwepemf200007.china.huawei.com (7.202.181.233) X-Stat-Signature: xayzaugdd1cghxrd137qj5xyhbiirhkb X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: B8746140004 X-Rspam-User: X-HE-Tag: 1742176975-694156 X-HE-Meta: U2FsdGVkX19ApntVZ4whk5OV/5ixt7E08XJnSJlt4avjWYeOujVPX0nB0FVEZgYSDmAJ6DB+tpPzDCQNVFuvIWF/GxObGu1KfzLTFhfsAJrI3Yjmq2ObxUhoCHE8bKHXevRI0Pow/Xq4e2mag6XSieRSs+XdLeTxs6Wa9hht2Tj+NY7ck7VEpwEgrv5Ocm5AdF/QjFkhO1hsgsO+4L3cYZf7FXp1XZg55uvC3CHfa3MdfSYq2TyWaCstKero5c8zvJavg7bSfND4TyGktrFGfebj81EAWrK6SQ2mliIM/mrqn57vQ637EMQ5sGb5f+ei/CvrLYqSkRE8H9FlYCSY1fdBcGKGhZXBY8XEeURrPcNaxjprNs020QFV2sLKIhjVUgU/mmi6Iu0s7gQY8AzSVJv+DTA4+CZmof1Ahm1XBKBVjIuRMzIAoBUP4heOMeQf6Mmo81XAB1H5Veyrj+WMtNn1FMVYmcjdPYHbP2M41Kc77cujO7VHvfzida6MdGAwwqaBSWzmJHmXmjIuR3JwVxYeZMvvmKjNdR9QgZ8zVcwP4l4IpT5U1KMSLQG//1ftn5TB4FqOawohxpU0Apm2F6Ye10bwSiKZYwszeDRnG9vDbIXA2GpEJMRdPwIWB1mfINxsIniFk24fqVW0y9q3ZVJWP5FFkKCW9T0tZrnBhAFV4EbHMUcuJGhwF5a1GWKtbZ5+HuhK8hFtpPw4jtIa41t4DYNl51/4j1o5R0aOH542ArP9/WS1qbiX4YgtTeeAoJVly7mlFILfhr7IrJvZMxXMwPnV8CglV/S5KC/+s1lkf294aq9Tf57CPYhP1vtmMuCcxBzKZN0TMn/yeoiyp5DPKrVe2yMFJaahA3eBBcZwJNnizJtNCfcS1NAIRDkBPWW8F+U6yJGN41A5+1nmUNUCLy5w7LQkuUdzI2a81XDCv0Hv07DhCOvnwCojaWXIkmyiB5qRKaJMm4qPKhV 1FecMOeN yCPWkbcKHGa5xWKToLqBBj0PCCYqTdOdwU3BHMqVSz2Tb8mb7u8FRSm8oUF79YI44uzevrXiwqVk8ACpwmhmSjeS59/teN5eEh6oJidiWOlE+SOg4nnNd8O6qfVZaZFWO3nC18DuzsO8IAvlO5GzcvUR2nJMO56vh9b+B2hIFo7N1LrdYzuQkEuAHbr+VFLAj6liA6eMqYy73ury4s2iB9IUYN6zS66IUrK8GqL3RXFZoe040r2AXoFPZ5M2GW24/r560sxxcE/JhR1ZM5ov9Nu69aVO+auxkOdOtfkxGnUhU9zJY5vM6VfltzH9w48dfphWFTU0PTSIP9RENyKBlyyfXicQWLErHHXPr X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: I know this solution is still under discussion, but anyway, I tested the scenarios I reported in: [0]https://lore.kernel.org/lkml/8067f204-1380-4d37-8ffd-007fc6f26738@kernel.org/T/ It seems the problem has been solved. Thanks! Tested-by: Yonglong Liu On 2025/3/14 18:10, Toke Høiland-Jørgensen wrote: > This series fixes the late dma_unmap crash for page pool first reported > by Yonglong Liu in [0]. It is an alternative approach to the one > submitted by Yunsheng Lin, most recently in [1]. The first two commits > are small refactors of the page pool code, in preparation of the main > change in patch 3. See the commit message of patch 3 for the details. > > -Toke > > [0] https://lore.kernel.org/lkml/8067f204-1380-4d37-8ffd-007fc6f26738@kernel.org/T/ > [1] https://lore.kernel.org/r/20250307092356.638242-1-linyunsheng@huawei.com > > Signed-off-by: Toke Høiland-Jørgensen > --- > Toke Høiland-Jørgensen (3): > page_pool: Move pp_magic check into helper functions > page_pool: Turn dma_sync and dma_sync_cpu fields into a bitmap > page_pool: Track DMA-mapped pages and unmap them when destroying the pool > > drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c | 4 +- > include/net/page_pool/helpers.h | 6 +- > include/net/page_pool/types.h | 54 +++++++++++++++- > mm/page_alloc.c | 9 +-- > net/core/devmem.c | 3 +- > net/core/netmem_priv.h | 33 +++++++++- > net/core/page_pool.c | 81 ++++++++++++++++++++---- > net/core/skbuff.c | 16 +---- > net/core/xdp.c | 4 +- > 9 files changed, 164 insertions(+), 46 deletions(-) > --- > base-commit: 8ef890df4031121a94407c84659125cbccd3fdbe > change-id: 20250310-page-pool-track-dma-0332343a460e > >