From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B750C02188 for ; Mon, 20 Jan 2025 08:46:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C5D846B0082; Mon, 20 Jan 2025 03:46:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C0DA06B0083; Mon, 20 Jan 2025 03:46:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A88B06B0085; Mon, 20 Jan 2025 03:46:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 8CF8C6B0082 for ; Mon, 20 Jan 2025 03:46:29 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 3C8171624E5 for ; Mon, 20 Jan 2025 08:46:29 +0000 (UTC) X-FDA: 83027198898.03.188D1F7 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf18.hostedemail.com (Postfix) with ESMTP id AFFBF1C0010 for ; Mon, 20 Jan 2025 08:46:26 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="Y8HNr/xF"; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737362786; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EcZJYBt+kfHbCBrPq6yoGjB/TV1vhufPJ1NBpXI8Qkg=; b=6Re2+uPonH8hO8Y/cLWf0Xmmjr4uowjK3ikLYy/jpDICPrC12fSahOsQp4qKZHIIKik8qM eJEg8yDzNi7+RNY/oVCKZpEY49yKV1p6dcCe/0/55COKLDvfI+oxNLJW/FyI1KQdyG2vfb 4XV9DdYTbiwcqXsfTPC2EZQiz8BSZEI= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="Y8HNr/xF"; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737362786; a=rsa-sha256; cv=none; b=7uyDFFUJZegBNS3ru1LGEzqrgM62ay+w3bj41dCRkI6T/IFHl65vhLThH7XDKTNLhQ8rfW SrKGAoIbjP/XWmL+tRp2CDOMp6IVcO+oPUtJOI3lYrqqX80yffaPQsr4hY9rUoWS0dxAcS FA1Cn9kUWyHgClBxHg0lhT746ivMI/c= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737362786; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=EcZJYBt+kfHbCBrPq6yoGjB/TV1vhufPJ1NBpXI8Qkg=; b=Y8HNr/xFcfOSAmb3vYi1eM0dInQxVe+MMJFbwPLAR54AMEGI4jbSve2wtOx7LaoUpY8c6E z3r+phlH87URFZOBwwmoID1l/dd4eCT1IGGe9jVQAuMZcrw5VlpKuqqlsB1s7cZbWVKHw1 cYzQe/Xqy2nJjb7Dyt7pUNaZmLmn8XQ= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-677-USC-tP1kNmiCGtTpu-0pdg-1; Mon, 20 Jan 2025 03:46:24 -0500 X-MC-Unique: USC-tP1kNmiCGtTpu-0pdg-1 X-Mimecast-MFC-AGG-ID: USC-tP1kNmiCGtTpu-0pdg Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-38a873178f2so2050041f8f.1 for ; Mon, 20 Jan 2025 00:46:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737362783; x=1737967583; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=EcZJYBt+kfHbCBrPq6yoGjB/TV1vhufPJ1NBpXI8Qkg=; b=owNOeDsgViXlgb3TsmuVTftmvmEVmlSRhxu2Gs9TGy0NhYRXX4G+t7KOyTOhTCCA1h ooaZokoBp7kLGRwovBOfPNMAPAUpQK8TBEMKSBjoOBIOI5cjnIo4QOFfunJCmyJgXHgD 9+tJHEY9OSgWOMrEe4l7FwAoUk/Nba+LMzqtciScFqicQsh1RlS00q4QhTaWJvpLpYmQ zzErOJAJFKXC7H1kpDDVLWa3Dkr6Br06+v7CrMIAtJQapcAbYhF3RLQ9BZsPVL0xzka1 S+uESTBIsxdCdwC8jpkNgRNwvkP4nxw4eO8JtMo3w3DLbyuW3EviqNLSng/IfFEnBfZ5 tVUQ== X-Gm-Message-State: AOJu0YzXBgwKZlmqZAppCfrn5/YTjbJVgBI6mkHfFgTnoyxmV2VK51oL xacy6QWZjYcyaGlr+CWa6YAVExmqrgNXS4MPgRYEB6D1anSrTRmfzdxIb5lk+llCLqFAPXpzWKP /htHhSAicJnNSG727Ro+27lfXrMGjpW1DupxX3avhdJbq0aht X-Gm-Gg: ASbGncuLOZytmDWgaZZMxEVHxg9EgCIWBFK3njlzKA0bWQkmdWRmHXXG4l7XF3qTAWr M73cQkR9bOaIYGI7hKIzJDUDgrgNqQKfT+k+3hGiRyuUstrWU71rMkqbPK44/Uu7kIhxPuXzZqe W6Xg2PIa8+kSQ7JMbjzPREOrgqVUr1+h+Z7ihuqUAgxKLYPL4LWwA7u1qLA2v8QMstd8fuLU167 wj0SwcKMKLIvWZ01gC2XiTQdYDDb9l2LVdi76ZidMGEiqwrJdSKc+rIr8IDvL5+DKvLu9iaOQD7 MWiECe4AFmZSwpoly32IK7/5FubMaz118THvsoqlBadJfGZzga950LcRIWnZd6CmTYHVa2H0JBO 6FiPnZ0bpSNKk00DLtH1z2Q== X-Received: by 2002:a05:6000:4012:b0:38a:9f27:838c with SMTP id ffacd0b85a97d-38bf57ce8b8mr10993321f8f.55.1737362783181; Mon, 20 Jan 2025 00:46:23 -0800 (PST) X-Google-Smtp-Source: AGHT+IHEQMS5mdpP/VrXUAomKeHTh7+Ip5YpnfPTakpnnTuYFZI8f5sBYOwjj1pFBHYloWKmZPOfxg== X-Received: by 2002:a05:6000:4012:b0:38a:9f27:838c with SMTP id ffacd0b85a97d-38bf57ce8b8mr10993299f8f.55.1737362782821; Mon, 20 Jan 2025 00:46:22 -0800 (PST) Received: from ?IPV6:2003:d8:2f22:1000:d72d:fd5f:4118:c70b? (p200300d82f221000d72dfd5f4118c70b.dip0.t-ipconnect.de. [2003:d8:2f22:1000:d72d:fd5f:4118:c70b]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38bf3275901sm9826580f8f.61.2025.01.20.00.46.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Jan 2025 00:46:21 -0800 (PST) Message-ID: <80984553-a2b9-46b4-acdc-f7abba3c755f@redhat.com> Date: Mon, 20 Jan 2025 09:46:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/3] mm: memory-failure: update ttu flag inside unmap_poisoned_folio From: David Hildenbrand To: Miaohe Lin , Wupeng Ma Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, osalvador@suse.de, nao.horiguchi@gmail.com, mhocko@suse.com References: <20250116061657.227027-1-mawupeng1@huawei.com> <20250116061657.227027-2-mawupeng1@huawei.com> <21674fcc-bd5d-3e32-6e45-f0a16ab93202@huawei.com> <34ccd133-7623-4cd8-aad7-08526a97c472@redhat.com> Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <34ccd133-7623-4cd8-aad7-08526a97c472@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 9ffbpXUUKSmVVOvTArxyjiNhGx3J0cfGCTXFukO2Bf4_1737362783 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: AFFBF1C0010 X-Stat-Signature: bzypgw1mbakefsq8i8mdfidmry9a34d5 X-HE-Tag: 1737362786-420087 X-HE-Meta: U2FsdGVkX1++Dqmu4c2BMB8Skh8O0G3uYGmNJ4pwncyHZodShGXLU/B2LSwZgFCiKoXuHu3wbE9sCex5TNA8To1KyKpT6BBT09hVpSTQkmOZdBcC+y5oJwyrItkhi5UeOgQDVVkZVQYz1ZoGooo/lHMsfa3xXipdiuit95bRUBIcqYyBviPP9oLBSohrcBY0zd1Z06gga1dI8TZY9bKiZM0JAEqnUU685IrY6OykOMjTx7OpRA71Cle64zQ9cHTsmHjs3A6Fz+2FHuK/9HOKWPNs8EMzYc9GiafSSoxQFewhQ0g4Xh3sIzBM09NS9hcKpcEFpkBMcFND0wi8bJy5eh6egPe636vXyxpsu/sgOTzqHTqWUPsCyU14lpTIbYqtSVJHiukSsV6qSv1uotJpLZD1b8BVLOUDs3McJPWVuXkZnpz4rwz9sm6RnnwmXrDq0VYI4MRTEmXFCPCjhCeMV5PL7Xnvo3CsB56yJcWBA+Qu9A8HgvJO9ndImuD2yKZaCphSn5dPSh64qQJX9GKG03iTnPoFMjfPNcMT84EBpYKQ5SVHOynqXS3NSL44keRKa0k89uUSJl/7zT5MABb/3E9jV5YhNW0Xl5HY8ve0RCQzUSgO+lY8owVlTK4GAXHuDQlJA26n1HBg5FegaQywcjvpr5Dxl9lqSv7qo5fi/ADcH2OJEEgTvjuo4jxtF25BrpJh6osexmxpXpJJi2l4aYG/PIQXQfaGOilncDVvSTqFqXBKy8q/QSy46adLAUP+59IWfdD1hBNk6UKDf4PhnNzy1pV2+iWBGe8TGtd7Gj+36lv5dfkBnEFS3EbxnEjhs8rf0GFxvU56qyW9dwGekTZd2l0PDdrQd0RLhbsiIRZWqyjgCbCzJabyZRcxzIubZNMU9qFgkDU9OJa2GyqcOO230Ody2vr1G0qfIf2HFw2DVyJoAf3khqhHB0irfZOfGIc/eUASySlxyVhkxLV 1tL4TvVz M5va/EzBmHBxs+koV0Hypsw0x68nwD5TK34R6o6hLQoXA/QtdBxc5r1mtn0+G3gaP3C4reQqPANDOzaiKgmMKgDAJeMGNZdEYYTv1PJopHUGyYJN8hknu5AZe1HaUKFXCU4pV1R06/kZ7II9YT1Bp5fuz0fFrm7SDciEXSVnFQqcaOArJG4WQZK+n/4tqJlSSmghsAebil5rU+uVgBtcr/jsTYdc6GpHWrFcF5kxe5tzhWqeiiR0O2Db4JrQCjWDqaoTjcHUTvEAhbgsumS/jBLaI0W0g8SgS2VWwpbgOmoyTTj4GK1Xch7NU6hrBLKBs2+BelA7h1Z5Ayjs5vZ1ARrASpUj/PNi9Zag3F+2sPPIxoeukM/0CsNzZJq7OyufPxIDbGMfOwqCTWctl4VLBJj1ABpCsGw6vPrKD7OLHM/djcE48roUzCoBdJABk60d1VlX6kJvaIdJuCRytdt+rquSghlpfwKkwapI1I2Vd5WOR+dGuJhZvHnhBdwtwp/W+iuQd X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 20.01.25 08:49, David Hildenbrand wrote: > >>> if (folio_test_hugetlb(folio) && !folio_test_anon(folio)) { >>> struct address_space *mapping; >>> >>> @@ -1572,7 +1598,7 @@ void unmap_poisoned_folio(struct folio *folio, enum ttu_flags ttu) >>> if (!mapping) { >>> pr_info("%#lx: could not lock mapping for mapped hugetlb folio\n", >>> folio_pfn(folio)); >>> - return; >>> + return -EBUSY; >>> } >>> >>> try_to_unmap(folio, ttu|TTU_RMAP_LOCKED); >>> @@ -1580,6 +1606,8 @@ void unmap_poisoned_folio(struct folio *folio, enum ttu_flags ttu) >>> } else { >>> try_to_unmap(folio, ttu); >>> } >>> + >>> + return folio_mapped(folio) ? -EBUSY : 0; >> >> Do we really need this return value? It's unused in do_migrate_range(). > > I suggested it, because the folio_mapped() is nowadays extremely cheap. > It cleans up hwpoison_user_mappings() quite nicely. I'm also wondering, if in do_migrate_range(), we want to pr_warn_ratelimit() in case still mapped after the call. IIUC, we don't really expect this to happen with SYNC set. -- Cheers, David / dhildenb