From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A4EDC3064D for ; Wed, 26 Jun 2024 05:37:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8FBA76B00A0; Wed, 26 Jun 2024 01:37:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 884316B00A2; Wed, 26 Jun 2024 01:37:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7257D6B00A3; Wed, 26 Jun 2024 01:37:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 4AD1E6B00A0 for ; Wed, 26 Jun 2024 01:37:41 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id EB9EAA2B5B for ; Wed, 26 Jun 2024 05:37:40 +0000 (UTC) X-FDA: 82271932680.19.DF7FEA1 Received: from mail-ot1-f41.google.com (mail-ot1-f41.google.com [209.85.210.41]) by imf10.hostedemail.com (Postfix) with ESMTP id 29FFAC000E for ; Wed, 26 Jun 2024 05:37:38 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=ZrTLghtI; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf10.hostedemail.com: domain of hughd@google.com designates 209.85.210.41 as permitted sender) smtp.mailfrom=hughd@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719380246; a=rsa-sha256; cv=none; b=klxdkOg4ebVZSVbeKDQsMdtvy1RkRcYjSH0rSPDvPajka3WWoGPypesbzmDxDf1oEeO0Ho UJ9fO9quxpmMTVeG4B+34S00hCxZZfiEfeXub+xjl1gFiYycoXFgJDGbBwkWOXQ8l2pKyT GfGWJ30WTJwni5P9ptmnKBfUTzMSWaI= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=ZrTLghtI; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf10.hostedemail.com: domain of hughd@google.com designates 209.85.210.41 as permitted sender) smtp.mailfrom=hughd@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719380246; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=y4aTud5LWrq6VGyg6i9gcG7sOZFpvQsDUArnq/2QbZw=; b=4lSLdz6hSKGipKFp9ERM+1llkJOPp7XmdkM2qLpobZ9jyX3UGIvNudinHXefAGrz97hqvl k6r0/NUGJwzToEC6/BMJauO3p9PGhVfshLeMY8RVthbbzRNeG3XiXVmyaFu57sCKz1+qA5 C41Spfbt0hAOdJyH4tOyWhFkMJtF8+o= Received: by mail-ot1-f41.google.com with SMTP id 46e09a7af769-700cc8e447aso544399a34.2 for ; Tue, 25 Jun 2024 22:37:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1719380258; x=1719985058; darn=kvack.org; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=y4aTud5LWrq6VGyg6i9gcG7sOZFpvQsDUArnq/2QbZw=; b=ZrTLghtIuL8947ZwMU/GSFTYSO5JJ7QSJrAfJgAzrX5CkHo3c17qWsMsv6ONu7zWnQ Fhl0+XS1a9Jv5YIh9MiVD1Zq9TTEMLtcnsRY99foWk+/NYwYykRm3MGzCjz0QBpLwcMz fuOQp3J9DHjq+OSCBMBBd3JRgYSdz6Hr38O+9Po+0CBiHq9eYtKDF1wOqqFx4HsbEI33 nWeWRNE4e+Sgq4xfirQNUC+e8Zk7NeTPGzFm036AJ2sCT9tlViaozQ7vRd0ztj/60ZdQ P15FHY0PV2UJPmlNVbtY+D1zH/kQZee9BFRD2I3BR4DUTzFjtX6sKfEG2ZabkjpkPCyd 3vig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719380258; x=1719985058; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=y4aTud5LWrq6VGyg6i9gcG7sOZFpvQsDUArnq/2QbZw=; b=lB0FRXZKxfX1/CLC7vqop5mnoWEzBeSkR4xbHyONnBhzPOSQB3rgmR6dhT7ylREqSr 2KzBxAd/HAcUvfpLQ3wBpKvaiJbNc7+zV8rs5puapIaXsuqcC1WGwAq+Ou6umxltdlTu k4hT8O5a4k+25cktjyhK6OGgrMwVHcanS5OCjcoSJVXGHgJbXEDLP1+MG7C/3rBv6aYA cBISa5GtaalkJMkpPJZ800xlIIeKcbQYMlgmLkmV9olU5zLkrw7kJhqYbzfcMfN+y6Vn AcXybH+42MGYbwZjIiNMZlZejeiAZ713FwvJBnmtSAY9dIDhKDF/Rcug+0cwOUDp+aFI vjkw== X-Forwarded-Encrypted: i=1; AJvYcCW+gVoSLD9uJamUT1C6/ntkpUjyAUdu+bLVh2iZonHj6StEe66BBu3/vg+cNVARvpIQTrBn6O1sZyhbjiqvrAtG4SQ= X-Gm-Message-State: AOJu0Yy8v1FjqNE5qCOJifQJ3w0G7D3w81WymLLjeeoz377PTovBi3q/ m9u0bbt2KekPoy4GHfjsic0muxS/muh39MWPwtMjok8c+mVCm3VQhJ+6CNDSWg== X-Google-Smtp-Source: AGHT+IGzu28gP7RE3kh8nzWSReLvlaZjQZy9RuiTduOJQEB1Gnm3oBpqOYZ3JRLji80/43EeKU4AoA== X-Received: by 2002:a9d:638f:0:b0:700:ce1b:9107 with SMTP id 46e09a7af769-700ce1b9273mr2225784a34.25.1719380257914; Tue, 25 Jun 2024 22:37:37 -0700 (PDT) Received: from darker.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-700cb95fce1sm296979a34.19.2024.06.25.22.37.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Jun 2024 22:37:36 -0700 (PDT) Date: Tue, 25 Jun 2024 22:37:25 -0700 (PDT) From: Hugh Dickins To: Sidhartha Kumar cc: linux-kernel@vger.kernel.org, maple-tree@lists.infradead.org, linux-mm@kvack.org, akpm@linux-foundation.org, liam.howlett@oracle.com, willy@infradead.org, chuck.lever@oracle.com, hughd@google.com Subject: Re: [PATCH v3 00/16] Introduce a store type enum for the Maple tree In-Reply-To: <20240618204750.79512-1-sidhartha.kumar@oracle.com> Message-ID: <80926b22-a8d2-9992-eb5e-27e2c99cf460@google.com> References: <20240618204750.79512-1-sidhartha.kumar@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 29FFAC000E X-Stat-Signature: p144w4sqycptrhdu7jnbafn9x68tjdx5 X-Rspam-User: X-HE-Tag: 1719380258-609997 X-HE-Meta: U2FsdGVkX18M8FDEffSQbqYDu5mivy7d/WYQ8lN6CtKMWPqxh/KblH59CcdDdumxbN+DtmhneDT2Pa6tCzQNR/xFT0uFJEyNi2CNrLkq6qBs/lXWxqddi7l+TeqqrrE42MiIAO/7czRO6w0+WJaRV4NS+mQoC6vGCeal73P02Rr63ZssRH0rH/RYZ4pYIyiuMlnZ+UX+oFtiRvjAkfFiSjN63mypb/ua/XsEoh+OXMRyqtdzc5Tw3CZCh16PpxvhNX5QFl7PQ7fd0tiDscqzv6+urs7PGUGxVyBdbbLwOFAA5YTqCYA7Dp1LMOlfaNi3FeNdGr/n9Wtoo9pkNe+qY3OR+usvjEgrtDs81T13XJ0TqhTmzxztG5kfAVrOEbAPEJVEv1HzKjj9XgkAMLswscglA3CXvAztwlPNAjn7CxeDxG3dxRIEeX1rl2dVO1p3hvjv35aJjYblnDU460B44JCphP929lqg/M7c6BCXoLcX5RyvN4OXybkrIlRbOBUP+kn5fjinCP6FuIETANru1K233f+CGcOwUJfo1ul7Y8Dtpb1QLZx7Vno8gK2WgDUNTyyqip/len0lC+iu5nh9J6VdDnW7ZVfhYhhPxZrl7MVWlv2eqrAks6bytmAsv9ycckHHBiuQTTMXFtOEJr/bu54Hf5dk8THw9tmavgr0S+LqatvJfRdyTZSLNU/M9bnIAC6sRuF0V01nhaWLXTkdz1UlGuCKqVaPMSWScI/49D5RnoQ611KpFpD/Ci6i+Cj84o8nIEG89RITaTDVEGOWHztJJIYHp+NpF0OJ5maIDisxZp77GMQhELM8/s/QndX0EBvxg5Rc0rdX0WmmcOw3pSOiP/Hp8nC6SmCoAVZqVE/uogazpLoOt1slyMSlu6UNsPourLWl16URYiQSoE/awuYTNDaqwhzQBLr7F/NtbsfLNLU/JcwdI4r8aOcrXLeERj1Kf288gJ5AMZSF/8G GbK4CpVW V9o3uyc2i31h2M/bmO19qxCNi9O3wT7ljKwM0obkekaqLEJ+352vpbdcgpr8XE1W3opqbYwXZmB50D094HPXK/e1LlMRxLxn9SKHGDzE47h9vk7B1xyuk+tec7qJbsTn/41YNlqlO/yOzMHkBj5034wC/A6GZkcDM68vMSVUGu7ynNwkz6ccL4Fa7HnZDqz8H+AN5cuUkQkAWthdHSFYztADQJFbm1rdClJrl/PucoF8TPCfj9DYeA8yazwxJZE2fQBcmQfhg8HwCBmV/DjI5VxLUUbAlty8ftqOK3qAJsx4gKhPjVljyQ4FjTwBX6vTTVB0MP1J+eeczn6e+vNX5wv7Q0A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 18 Jun 2024, Sidhartha Kumar wrote: > This series is rebased on top of mm-unstable + the patch: > maple_tree: modified return type of mas_wr_store_entry()[1]. Andrew could > you add that patch to mm-unstable before merging this series. > > v2[2] -> v3: > - fix new line issues throughout the series > - remove use of helper function in patch 13 Please give tmpfs a try on the latest mm-unstable, with CONFIG_DEBUG_ATOMIC_SLEEP=y (maybe some of the messages below come from other config options like PROVE_LOCKING, but ATOMIC_SLEEP the main one). To the un-maple-trained eye, this series simply replaces a working maple tree preallocation scheme by a broken one, doing GFP_KERNEL allocations while holding spinlock. But I doubt that was the intention: maybe a line of code has gone missing or something, and you can quickly unbreak it. BUG: sleeping function called from invalid context at include/linux/sched/mm.h:337 in_atomic(): 1, irqs_disabled(): 0, non_block: 0, pid: 63, name: kdevtmpfs preempt_count: 1, expected: 0 RCU nest depth: 0, expected: 0 3 locks held by kdevtmpfs/63: #0: ffff8880008473f0 (sb_writers){.+.+}-{0:0}, at: mnt_want_write+0x19/0x40 #1: ffff8880008a0888 (&type->i_mutex_dir_key/1){+.+.}-{3:3}, at: filename_create+0x8a/0x120 #2: ffff8880008a0650 (&simple_offset_lock_class){+.+.}-{2:2}, at: mtree_alloc_cyclic+0x72/0xb0 Preemption disabled at: [] preempt_count_add+0x54/0x60 CPU: 4 UID: 0 PID: 63 Comm: kdevtmpfs Not tainted 6.10.0-rc5-m25 #2 Hardware name: LENOVO 20XXS3LA00/20XXS3LA00, BIOS N32ET91W (1.67 ) 02/02/2024 Call Trace: dump_stack_lvl+0x5d/0x80 ? preempt_count_add+0x54/0x60 dump_stack+0x10/0x20 __might_resched+0x23b/0x260 ? mas_alloc_nodes+0x71/0x160 __might_sleep+0x56/0x60 might_alloc+0x2a/0x40 kmem_cache_alloc_noprof+0x28/0x190 mas_alloc_nodes+0x71/0x160 ? lock_is_held+0xc/0x10 mas_node_count_gfp+0x2e/0x30 mas_wr_preallocate+0x43/0x60 mas_insert.isra.0+0x49/0xa0 mas_alloc_cyclic+0x9c/0x100 mtree_alloc_cyclic+0x92/0xb0 simple_offset_add+0x3c/0x60 shmem_mknod+0x55/0xb0 vfs_mknod+0x9c/0xc0 devtmpfs_work_loop+0x1c4/0x2a0 ? trace_hardirqs_on+0x37/0x40 ? _raw_spin_unlock_irqrestore+0x39/0x50 ? complete_with_flags+0x40/0x50 ? dmar_validate_one_drhd+0xa0/0xa0 devtmpfsd+0x25/0x30 kthread+0x100/0x110 ? list_del_init+0x30/0x30 ret_from_fork+0x22/0x40 ? list_del_init+0x30/0x30 ret_from_fork_asm+0x11/0x20 and lots more like that. Thanks, Hugh