From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DB69CD1293 for ; Sat, 31 Aug 2024 05:21:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 31DF56B0291; Sat, 31 Aug 2024 01:21:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2CE9A6B0292; Sat, 31 Aug 2024 01:21:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 196466B0293; Sat, 31 Aug 2024 01:21:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id E9AD66B0291 for ; Sat, 31 Aug 2024 01:21:36 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 3B7D3A0943 for ; Sat, 31 Aug 2024 05:21:36 +0000 (UTC) X-FDA: 82511392992.11.C4630B5 Received: from mail-4322.protonmail.ch (mail-4322.protonmail.ch [185.70.43.22]) by imf28.hostedemail.com (Postfix) with ESMTP id 61F82C0005 for ; Sat, 31 Aug 2024 05:21:34 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=proton.me header.s=protonmail header.b="W/YAWbwr"; spf=pass (imf28.hostedemail.com: domain of benno.lossin@proton.me designates 185.70.43.22 as permitted sender) smtp.mailfrom=benno.lossin@proton.me; dmarc=pass (policy=quarantine) header.from=proton.me ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725081603; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=A1VfMnXiPQMxx6pH7IkEaSr4ATlFOI5jIKJBkF14eNU=; b=qOp3/kdEwVh5Diy7GEsp215PPCmVVKFKj6+c76RmVOVI6DxgLx8cS9dYwsgRDCH0ODzSts R8nRhC19D5pX9NzLa6RlAziG8z7epfbn7ceutY8tDonSkJzOhnCdwvD7wJzaD6P1ebCqLH Z1XGEInBlTCpTT4/8owsDe11RZvdViA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725081603; a=rsa-sha256; cv=none; b=CT8m4pr0AgBP7MoJ7dAsh1ioguVFq1Dq5ig5l5KCN6xKHyQTPTBSiPZBMHcj3tII9x/BM4 1YrurPqT4JZKo4NtojYztZXmWuWLfzeg1R549/AaiUHb7K7ODSuC3ymJhQR7ylRfI69Hxr q5lK/DqMprj2ayqt+zfYG81EpgRr4LM= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=proton.me header.s=protonmail header.b="W/YAWbwr"; spf=pass (imf28.hostedemail.com: domain of benno.lossin@proton.me designates 185.70.43.22 as permitted sender) smtp.mailfrom=benno.lossin@proton.me; dmarc=pass (policy=quarantine) header.from=proton.me DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me; s=protonmail; t=1725081691; x=1725340891; bh=A1VfMnXiPQMxx6pH7IkEaSr4ATlFOI5jIKJBkF14eNU=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=W/YAWbwrZSWnf9/vXBG4eoa31RuA45gYISApJakLAWYvGj2QMiLnuBa9nH24CuRV7 n0YTJYctCxt2mQCIFI92rM1RQSx9p+/OBYsywG3KR88RCBUMWUpUvPmM9dl0Q+oNAw +uwUQDMvlioc6OSVUODIInwdCLr+LONc7Rq5KN/OvIu/tBphZJigT6/ymJUakaJTDG 1T7IYMAWdi/UOtxqHupmSVfGE6ZdGewt1rGs2idunt402Sgct/qITFgboSnwKhH/JT Orl571FhGVmolRzfEJLz3ZbBvuOclaOzp8E7KqYjZOvtYlXVg57+9Sky2ddFexXgeU fcrcpCd7acPlQ== Date: Sat, 31 Aug 2024 05:21:25 +0000 To: Danilo Krummrich , ojeda@kernel.org, alex.gaynor@gmail.com, wedsonaf@gmail.com, boqun.feng@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com, a.hindborg@samsung.com, aliceryhl@google.com, akpm@linux-foundation.org From: Benno Lossin Cc: daniel.almeida@collabora.com, faith.ekstrand@collabora.com, boris.brezillon@collabora.com, lina@asahilina.net, mcanal@igalia.com, zhiw@nvidia.com, cjia@nvidia.com, jhubbard@nvidia.com, airlied@redhat.com, ajanulgu@redhat.com, lyude@redhat.com, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v6 06/26] rust: alloc: implement `Vmalloc` allocator Message-ID: <808973f5-2c3b-4373-a41b-29e54f3ca4fa@proton.me> In-Reply-To: <20240816001216.26575-7-dakr@kernel.org> References: <20240816001216.26575-1-dakr@kernel.org> <20240816001216.26575-7-dakr@kernel.org> Feedback-ID: 71780778:user:proton X-Pm-Message-ID: 46553616bdf28661d31b7f7ab2333e02362d697b MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Stat-Signature: sfw3qjpa8q7chgsw7owkorsd49okfsbx X-Rspamd-Queue-Id: 61F82C0005 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1725081694-463456 X-HE-Meta: U2FsdGVkX1//UPBwcJam1hzX4mbuN7CKH9IXmsqEavvUMNHWB1NUM4uNlYAZZOkNzuPBKgNNAJR3fDGUGNl8nrdqEf+l0uR64fDUk2hoobJDGeozYnuPDEq0jr4F0PDFm58NETETZmpTMxA3VbcnyYbY0WDpDB1WdIkjj3eI5SuFwr+XGJfC7b/GFQPVefLzuZzOAGWHbHScm8BqOtj+ufLlnKM4Dwt/KIA7CNXbR0H2yGAGew/ZE0E3j/TSTK3NYDFiNW6ateAEjsIKJusTfDWjCT2pYIXV9dqvkDgMyQOvtuhUigqU89W5gkBmcTER4ml8QOTTtCn9vwxVaL0D/pUtOhO8jsTcCTsRNcRBveTAzdaIMeujUg4N1Xz+sXJiXyvIJ4cW4uGpJvSdDcBx0Sj9ritZU5gY6PhUOthOzjMSuD+rWlF9Eu3bhwutq4Oohvy3IeWZDV8808/u4yHmFR3BI54TAuQ+KLe1y55CemUXMm/HbrW5ja1FK8uMOpAwbhKRH/l8yd9lbwo5Ygkr+CuPYHjf7uDyo9sVCSrfFmdaY/MxYLDTgRXSquHcAXvbK/p1uMY0TO7EzjbcwpKaPus9Uyo7sUSqX2+flWq14thtcC2WyhwW61zC9uOCyHdBKzymjUHpFRNjZ0CXieldmPo84RrgTmQWLhbY1YO9XuBHfpLV3zHxhdsek6RHyWefOXGv0Nf1LQPBlURPCY0f9O7UjakGH5gkm3U/IjgyBccB80a1zwDxTsrZbKT4QH3HuMaNUr/Yp+bbmI5+SZHJ+eqQhtqIHBTXAkNK3e19rF0Db13XGz/mvgBL/tn8BhwSw25o80Rc7feu7eUXdGpYtqgY62gG6KLK7Byf28N6vOpOByIsRgb5wUYP51gmz6pDbI5fsrVqcPWd5h0kh5LIRGZ0SejRF97mxC7cvtFEkpEa6l2CBXvJngBt9IvxBnM2+LluajDfmsuVelZHepB m1qT1lOn lDUKyZLf/Vzdiy9Uu4Pb8FmwhYPLsxZUXQib2bSp718PBE+wBYM3Ou4LO+RjF77RBp+gfkY9TPw3U4WJjwrmn5rX5ZK2xlOH5f7FvLy7X13uM2aVBGrPvAmWgoiNMTyN0nGIRSuyndg5Y3ObYdEVCTvbyS6WHDcgX3HwP/iPAc8s5K3RWV9MI0oF0GIh3nMh7HlZ1ikZvLqom9yodnNNnS3aKuiFpq1PLlB3QS6Nj3qdxHNUSHHjlRfK7MJbMwjvcYIyZe6KBNtPyFe1f6Jh899nUj70bUxaUZYaeietJ1uCBSJmS0zAT85m3n/OtyOU6eRGqzDo2BuoEJRrWMgXyfOT0IkbzD2UCYEAEpX6wAW6nr3zUR9LquNe6HAPPYueNMJWy X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 16.08.24 02:10, Danilo Krummrich wrote: > @@ -63,6 +73,9 @@ impl ReallocFunc { > // INVARIANT: `krealloc` satisfies the type invariants. > const KREALLOC: Self =3D Self(bindings::krealloc); >=20 > + // INVARIANT: `vrealloc` satisfies the type invariants. > + const VREALLOC: Self =3D Self(bindings::vrealloc); > + > /// # Safety > /// > /// This method has the same safety requirements as [`Allocator::rea= lloc`]. > @@ -141,6 +154,25 @@ unsafe fn alloc_zeroed(&self, layout: Layout) -> *mu= t u8 { > } > } >=20 > +unsafe impl Allocator for Vmalloc { The same safety comment as with `Kmalloc` should fit here (and with `KVmalloc` too). --- Cheers, Benno > + #[inline] > + unsafe fn realloc( > + ptr: Option>, > + layout: Layout, > + flags: Flags, > + ) -> Result, AllocError> { > + // TODO: Support alignments larger than PAGE_SIZE. > + if layout.align() > bindings::PAGE_SIZE { > + pr_warn!("Vmalloc does not support alignments larger than PA= GE_SIZE yet.\n"); > + return Err(AllocError); > + } > + > + // SAFETY: If not `None`, `ptr` is guaranteed to point to valid = memory, which was previously > + // allocated with this `Allocator`. > + unsafe { ReallocFunc::VREALLOC.call(ptr, layout, flags) } > + } > +} > + > #[global_allocator] > static ALLOCATOR: Kmalloc =3D Kmalloc; >=20 > diff --git a/rust/kernel/alloc/allocator_test.rs b/rust/kernel/alloc/allo= cator_test.rs > index 4785efc474a7..e7bf2982f68f 100644 > --- a/rust/kernel/alloc/allocator_test.rs > +++ b/rust/kernel/alloc/allocator_test.rs > @@ -7,6 +7,7 @@ > use core::ptr::NonNull; >=20 > pub struct Kmalloc; > +pub type Vmalloc =3D Kmalloc; >=20 > unsafe impl Allocator for Kmalloc { > unsafe fn realloc( > -- > 2.46.0 >=20