From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF65BC27C65 for ; Tue, 11 Jun 2024 19:41:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5C5876B00CD; Tue, 11 Jun 2024 15:41:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 576376B00CE; Tue, 11 Jun 2024 15:41:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 43D366B00CF; Tue, 11 Jun 2024 15:41:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 21F206B00CD for ; Tue, 11 Jun 2024 15:41:57 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 8DF271A1487 for ; Tue, 11 Jun 2024 19:41:56 +0000 (UTC) X-FDA: 82219628232.11.72220C2 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) by imf03.hostedemail.com (Postfix) with ESMTP id ECD0420015 for ; Tue, 11 Jun 2024 19:41:53 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="Txa/O434"; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf03.hostedemail.com: domain of tim.c.chen@linux.intel.com has no SPF policy when checking 198.175.65.21) smtp.mailfrom=tim.c.chen@linux.intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718134914; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MhkW2O8X5I+Ga1WlB/SZjoU4nb26bE0rceGQZam5faY=; b=FXTjjNQBp2MM3hEnUEZ4tl0T5Qx9lOfEPIRGu8G3otV1xlCZbYQWcfRkli/UwSJLJExdqC C3+eSj1W7AiolSq422ZzRaw5dPy83b6j4YbVURpts+rGp/Prv6Mva3v7ZuGOIugqAeOX6J 5MPuxRmBiwl1wkhjPqgxONtsoghAhCk= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="Txa/O434"; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf03.hostedemail.com: domain of tim.c.chen@linux.intel.com has no SPF policy when checking 198.175.65.21) smtp.mailfrom=tim.c.chen@linux.intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718134914; a=rsa-sha256; cv=none; b=mzE/bcWTw8KWa6hN2stvkUzwqKEafqDsJMoBhgIHsedGIurOV2+2P9kLAgrMawJ4H2PrCE GEmF2sJHO6AglwOZ1N0qBVdrbqWVX1giCAls2jmrV5FgcjoZIT+3uCwCzkm3YOrloy7/AH FRXUVvTx9YMFtVEOt9aOkd8B6LA1ha8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1718134915; x=1749670915; h=message-id:subject:from:to:cc:date:in-reply-to: references:content-transfer-encoding:mime-version; bh=3jSJzP/wKvbuiDtG0srhckDI0jqTpk/NVaK27TegDYY=; b=Txa/O434fPtNVN8jejVEK4GQd5KLG/dxr4fJIpUpVMFpyyfy3moEf96o 3t6h70pNz/+OX5tzRNfphI9UzLkxXTDSIdWjFYzkAhYh8YdIkSIq0PxXz NoLZViLbrfbROUfTH8xleCglCnrWw1vvLpRxA8BM3VJcy3ihHWX8fX2dF dA1tFcmdszgqoi477kAhSoi7MvrpLEMefAsRUIta0L8UXsUgzobZtWMit zXi+dHs+HGr+tuPz25BCXunJTRvKFzoLm95mt1uQgPYmndBp0NiTFh3dM uDjJSySMyG2krjc1ltX2bBJ+AqrF1Yivhts05T81/ExByjBmlU8pSEls7 A==; X-CSE-ConnectionGUID: LgGCaWqBRJihILlCQLlVPA== X-CSE-MsgGUID: P4dW82skTbyleAyky7/dQw== X-IronPort-AV: E=McAfee;i="6600,9927,11100"; a="14826584" X-IronPort-AV: E=Sophos;i="6.08,231,1712646000"; d="scan'208";a="14826584" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jun 2024 12:41:53 -0700 X-CSE-ConnectionGUID: RmVZgz1VRteabv7gZ38CIw== X-CSE-MsgGUID: YWjwba72SB6sl89EETJtkw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,231,1712646000"; d="scan'208";a="39643390" Received: from mmasroor-mobl.amr.corp.intel.com (HELO [10.255.231.206]) ([10.255.231.206]) by fmviesa009-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jun 2024 12:41:52 -0700 Message-ID: <80532f73e52e2c21fdc9aac7bce24aefb76d11b0.camel@linux.intel.com> Subject: Re: [PATCH v1 1/3] mm: pass meminit_context to __free_pages_core() From: Tim Chen To: David Hildenbrand , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, kasan-dev@googlegroups.com, Andrew Morton , Mike Rapoport , Oscar Salvador , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , Eugenio =?ISO-8859-1?Q?P=E9rez?= , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Alexander Potapenko , Marco Elver , Dmitry Vyukov Date: Tue, 11 Jun 2024 12:41:51 -0700 In-Reply-To: <20240607090939.89524-2-david@redhat.com> References: <20240607090939.89524-1-david@redhat.com> <20240607090939.89524-2-david@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.4 (3.44.4-3.fc36) MIME-Version: 1.0 X-Rspamd-Queue-Id: ECD0420015 X-Rspamd-Server: rspam10 X-Rspam-User: X-Stat-Signature: gu6ezesuc4p6nd6sz94rs6gzu6kem7au X-HE-Tag: 1718134913-137515 X-HE-Meta: U2FsdGVkX1+FVzevSMb7bh5zPf4Hna+4BE7wzdudtVTn8mWmt7QQW/HoPsZlcvmTTBUBHsJ2sP4juMV6B2P8T+Mdfn9huwqIPIOHO6l+TkPfaLlpiBGB0uc/SLwGGzTnVLq/lfoYb/pXxwrUqjCesuHeyagkJtArAjQ03DE/eQwDHXB3+mK7248uCX37HjvxGKPni2oCdL25Vb1debspZVu8JOkoVSZJFAfsrgotJaXhLILB0H6WbLYFPZYsp/rEYP0AYdhnZX8hFsJN2YJA646YFfBg16wOD4HpXW/+6EZNNgeskBBZoDabG+nebwQAaK/q+ZeDMloRw3PL+NMieOAFJmT930TaVQfEj7Os0QMPFbkBrr76JOAYFI/mCJqjp/LXaeNfCxlpXVuDynEQzumfmQClXdu4oCE4JUctUUWUCGayCO3iV6E7BwwUbB5M0uReSPPKkiHjRZNWAMEpq2tEMBDoWTGHgpc5zeM1sgVXoIZAKPxLUy7wiI5Di4YAych4YjRip3ILX59C5qm59kmtDgpiGmHgjagoIfY7SfgkTp2qfNM0GoqO15Ahv8Hlmd9k9nTrrG4/vMCVFFdeE+pMDAwHLiNcNmwuYIxhmsVVk+ATUGjxhhVf2B4VMUhQC5AdMXGtODeGSkrNESO+d8WZOFeNz6JTcUESUKYs9/XYBNB0nARykfu9O34ibiOY2TzKy0shZZ7qKZx+RQRj/SQisn7bE0GMzYRG8hZX3Xaa15gzywzHfAaPelp38uN+Ck3qJsvRDOIOmY3Hze00+JQOCdf1ik9umy03Pw14Jd6D5n8lV+ymuFhknRCRAV+7cWyhsBrHA+te9oiAws5HuJownGka/8tuO3tRkdgeISzsA1rUFu0W5ioPK+b7/b4ZCY7Mav/RatcWrkQKWPAh7Aq3uql1vnDkLgTWfGXKkO0iFDizv37nLPwmJx9VjK/6//33iiExYihnzIXBSfO EJxjFnEN sGNiWz/lyZc4Jd3miiEsqXYY8jhEqaIT4vcd0lgpR7pkaqwC+tbr5ZHdjRMrmV3AtIZnIzi6ruhazq1UaW0Vu/IweBj85nYjqPWq3WcFUqW56sRAvohJUpkzNweROTsh8Fo3Nbs3MGhKPS9BX7BWQHt/aqIZCZZ/jOwityZXfmvh42ckIZ6cdJk4M/0ykDR0fkNzQE48F4l6PhUQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 2024-06-07 at 11:09 +0200, David Hildenbrand wrote: > In preparation for further changes, let's teach __free_pages_core() > about the differences of memory hotplug handling. >=20 > Move the memory hotplug specific handling from generic_online_page() to > __free_pages_core(), use adjust_managed_page_count() on the memory > hotplug path, and spell out why memory freed via memblock > cannot currently use adjust_managed_page_count(). >=20 > Signed-off-by: David Hildenbrand > --- > mm/internal.h | 3 ++- > mm/kmsan/init.c | 2 +- > mm/memory_hotplug.c | 9 +-------- > mm/mm_init.c | 4 ++-- > mm/page_alloc.c | 17 +++++++++++++++-- > 5 files changed, 21 insertions(+), 14 deletions(-) >=20 > diff --git a/mm/internal.h b/mm/internal.h > index 12e95fdf61e90..3fdee779205ab 100644 > --- a/mm/internal.h > +++ b/mm/internal.h > @@ -604,7 +604,8 @@ extern void __putback_isolated_page(struct page *page= , unsigned int order, > int mt); > extern void memblock_free_pages(struct page *page, unsigned long pfn, > unsigned int order); > -extern void __free_pages_core(struct page *page, unsigned int order); > +extern void __free_pages_core(struct page *page, unsigned int order, > + enum meminit_context); Shouldn't the above be=20 enum meminit_context context); > =20 > /* > * This will have no effect, other than possibly generating a warning, i= f the Thanks. Tim