From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF2FCEB64DA for ; Thu, 20 Jul 2023 15:53:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 56D49280129; Thu, 20 Jul 2023 11:53:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4F55D28004C; Thu, 20 Jul 2023 11:53:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 39739280129; Thu, 20 Jul 2023 11:53:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 25EE228004C for ; Thu, 20 Jul 2023 11:53:58 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id D5B17C01D2 for ; Thu, 20 Jul 2023 15:53:57 +0000 (UTC) X-FDA: 81032436114.25.1507F2F Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf12.hostedemail.com (Postfix) with ESMTP id B11E640012 for ; Thu, 20 Jul 2023 15:53:55 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=f+NQtXBW; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="/7gRpa2G"; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf12.hostedemail.com: domain of hare@suse.de designates 195.135.220.29 as permitted sender) smtp.mailfrom=hare@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689868436; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AoIWfvcodiImdazBtF4GP+aiM7iZUlDUJHwoVwx2l0M=; b=4NmQk5xqQFHTtqep5yN9yfr1ohr4cl05DeJnsg9c/qU8Pqqm3nYC7bHIZXl5F4pE3ib4hu MVC/VEa5bED8UAlcWEmiuwW5ToBQ3rLoMzjg3kkAKt1msJSqMPK52ratfuZ2LkiFCN1SRl /7ExFf10saIXcOOU5ynKfoywHThtJ6o= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=f+NQtXBW; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="/7gRpa2G"; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf12.hostedemail.com: domain of hare@suse.de designates 195.135.220.29 as permitted sender) smtp.mailfrom=hare@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689868436; a=rsa-sha256; cv=none; b=piH1j6YoeHQyy5qexBMUydBXVKT8/7th7kPDEJMcQl2ivEXnBFNRyqJFsNRta9Z99SFZXw OZmGpitfEBNaWvt1L0a55mQqbUx7rPLSL95enINfz/7eHgfdsislA44F+TY5EwY3TiRqlr IQvAfN8Un2maD/OOg1Q/LTNlGj9N/Ro= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 50DCD1F8AC; Thu, 20 Jul 2023 15:53:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1689868434; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AoIWfvcodiImdazBtF4GP+aiM7iZUlDUJHwoVwx2l0M=; b=f+NQtXBWukxnOBTDhSu4fMxYZbJGWo2G92hXZqJKiip03vBFzW0tsuUtbAzkcra1ua0QrZ ekgFv0gWb9JwZj2Ylfejs2aisDz77JLB5BtnaSwE0dXtRZBCTrRTWXVTYws5hZ18jkb5/t Jus7bV+kZA5bV/x2bylo/OHVpL8yltg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1689868434; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AoIWfvcodiImdazBtF4GP+aiM7iZUlDUJHwoVwx2l0M=; b=/7gRpa2GQeDZgmtYTQRDFpsjs2y7Q3HMtLsVINALgujmycG22P+Fzu+ByJ1hn5i0xlMlB/ FZy8w6o8SwtSYADQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 63352133DD; Thu, 20 Jul 2023 15:53:53 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id iOCeFpFYuWRkJQAAMHmgww (envelope-from ); Thu, 20 Jul 2023 15:53:53 +0000 Message-ID: <80507f03-86b4-6406-5ab1-5687b6d12d93@suse.de> Date: Thu, 20 Jul 2023 17:53:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 6/6] fs: add CONFIG_BUFFER_HEAD Content-Language: en-US To: Christoph Hellwig , Jens Axboe Cc: "Darrick J. Wong" , Andrew Morton , Matthew Wilcox , Christian Brauner , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230720140452.63817-1-hch@lst.de> <20230720140452.63817-7-hch@lst.de> From: Hannes Reinecke In-Reply-To: <20230720140452.63817-7-hch@lst.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: B11E640012 X-Stat-Signature: 6ywwe4oyd4ys9j87isye68598nat8dep X-Rspam-User: X-HE-Tag: 1689868435-129235 X-HE-Meta: U2FsdGVkX195NZ0pWzTh5RHfOOswYTB9yVrU7Fn+hWaGuldy4OL3R0+FYv5HrcENsFifSCKZGeap4MlOr9XTiOgKWKUlnjVNV0p9O82X5AFq0Tp53POt6qqHbWopqQl80nvJvEboXgAq4IPDE7ZjjmNYTNHrEcO1eqnmeNVIHu898UV7dVIQA80R3sVJ9udbdWzsWMicdiQhiybAGnkiX9zXFJ5FsjjZv3k3JhWCC/mxVAgLv8Cv/2Qk0/8se4nVeePYH0I3brzCu8Fi3LaCFfDCaUtIBujel4QiojK0yFwl/YWksFooSyetXy9ufnETjYcsaE7Q9ofuyVoWeErBt2hnaeq2NBUURY4eAXGMS57YDhJTckeCh8b1Nqt9SGMLhg7HHp3m/51c+fSqRJkCVvj50g7+0lxCkIeguMT1mHJ+atK/xl9pcAaSEag5bubGz1f/zIaxoEOjn8TM+i7xIVzZ9qqBlnvyIT22TOz5V0psvgv/HlAwF5Njj7JAg8eF6fClZzRjQQRpvfZZKoc74bBTi9jUuZXv5WklakWMZCFd7YJODIXVjo5pRPMZ+OnL3ehbhUp9fe32Krm9CzKpNtw2Khqrq4sRKz2vaEPIhqvGPRrO1PBowj0KsUzUGMKl2Dn0tk6FBCa/bw691KyU4tnCJoOq+iiqerRSSgaI6ojpuPo1hmEJJqT8x2N5TeVQ65psJ+fpcyXaAiITyJ16sDjPLNnUvhV/IvuMWg0Ji2EgHEXpJKMgMWa5TJe30pyVG2rsjp8Hn/RaInYLlDhwx2qAOOoL7ejm4xZokFVBcf/s872M4P2aT02Rc8iQjF/hHMSbBWpLqiNA4IOgng0PKrlN5/jayxzBwxhNSn7kqaav7rkRLPdOgtonLReri6acxnQAHvh/l6darNyN2SSxLZ0kELKBtokOzdXWNYBFTD2mz/RyVH2kTHCWVTXosTw31Inmf1OzHZ2o8GwOIP9 Og/8Jtq8 za0bPy+iD9kyDv4vtuZHl5nSrOXKxTpF6x8FK7IarCtOX0NIT2NaLI7M+ps8BXOkcsui3JueDdZmfJpFPBNnJMvqP5x2gwa3V/LFKZMnVIvt3Yjig7qamGf/XBsBlVrHu1l9xoqNtr54Vq5jnRJYXqntNno4agvo0tKVIFe6nEK8vcsjxgT8CXZXQysRaNbL34gnEqfYKR9kUVCwy+DPn6pP30N6kHI5tvPRAroJfeU3bDah16/nCjHJm7bTLwiNT3BPQ6G+AKFDa0ME= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 7/20/23 16:04, Christoph Hellwig wrote: > Add a new config option that controls building the buffer_head code, and > select it from all file systems and stacking drivers that need it. > > For the block device nodes and alternative iomap based buffered I/O path > is provided when buffer_head support is not enabled, and iomap needs a > little tweak to be able to compile out the buffer_head based code path. > > Otherwise this is just Kconfig and ifdef changes. > > Signed-off-by: Christoph Hellwig > --- > block/fops.c | 71 +++++++++++++++++++++++++++++++----- > drivers/md/Kconfig | 1 + > fs/Kconfig | 4 ++ > fs/Makefile | 2 +- > fs/adfs/Kconfig | 1 + > fs/affs/Kconfig | 1 + > fs/befs/Kconfig | 1 + > fs/bfs/Kconfig | 1 + > fs/efs/Kconfig | 1 + > fs/exfat/Kconfig | 1 + > fs/ext2/Kconfig | 1 + > fs/ext4/Kconfig | 1 + > fs/f2fs/Kconfig | 1 + > fs/fat/Kconfig | 1 + > fs/freevxfs/Kconfig | 1 + > fs/gfs2/Kconfig | 1 + > fs/hfs/Kconfig | 1 + > fs/hfsplus/Kconfig | 1 + > fs/hpfs/Kconfig | 1 + > fs/iomap/buffered-io.c | 12 ++++-- > fs/isofs/Kconfig | 1 + > fs/jfs/Kconfig | 1 + > fs/minix/Kconfig | 1 + > fs/nilfs2/Kconfig | 1 + > fs/ntfs/Kconfig | 1 + > fs/ntfs3/Kconfig | 1 + > fs/ocfs2/Kconfig | 1 + > fs/omfs/Kconfig | 1 + > fs/qnx4/Kconfig | 1 + > fs/qnx6/Kconfig | 1 + > fs/reiserfs/Kconfig | 1 + > fs/sysv/Kconfig | 1 + > fs/udf/Kconfig | 1 + > fs/ufs/Kconfig | 1 + > include/linux/buffer_head.h | 32 ++++++++-------- > include/trace/events/block.h | 2 + > mm/migrate.c | 4 +- > 37 files changed, 125 insertions(+), 32 deletions(-) > Hmm. I actually have a patchset which _does_ allow for large I/O blocksizes with buffer_heads. (And even ltp/fsx is happy on xfs...) Can we modify this to not have a compile-time option but rather a setting somewhere? EG kernel option or flag in struct address_space? Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Ivo Totev, Andrew Myers, Andrew McDonald, Martje Boudien Moerman