From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 258D8C35FFF for ; Fri, 21 Mar 2025 11:28:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C5805280009; Fri, 21 Mar 2025 07:28:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C0856280001; Fri, 21 Mar 2025 07:28:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A8320280009; Fri, 21 Mar 2025 07:28:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 882F0280001 for ; Fri, 21 Mar 2025 07:28:17 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 409B9A8392 for ; Fri, 21 Mar 2025 11:28:18 +0000 (UTC) X-FDA: 83245334676.01.6A65CA6 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf04.hostedemail.com (Postfix) with ESMTP id A1BB34000D for ; Fri, 21 Mar 2025 11:28:15 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Hg3juzud; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742556495; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+/o3ZZovn69lnNkwiyckvlWm9nS8xxkazVg7lWV4M7A=; b=RqOgxiSBm6kurLTRN+uAlxPoUnczJBIS8J3/nFKfMHBIjKoBJDBgOsNcHn2yU8n2zzL33B j6bpGuvjQxmTIYtEwDlve+B2B6ziHXppp5eVJ7g9WqmXCOshSvCi3dbBZjhpDQbOCF20e/ Opsjs90Kbsfa5mXInr5P0r4mbbdscGo= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Hg3juzud; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742556495; a=rsa-sha256; cv=none; b=VRrOfKZ3HAhrLMBvPr7lHzprcSpUbdIyhbwwkrZ+T0TXirgDttN6IrOvkQpKR+PCwwQ6nX 0rUDEdg6oNe5VbIEleP8q8q9tebYGZpF916rksK5+Wx4cqFiZoaz/BWxhRtGnZ/PTtzae6 rRduJnxofNa/CHwTsz4B43K5/ZkSsCQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1742556495; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=+/o3ZZovn69lnNkwiyckvlWm9nS8xxkazVg7lWV4M7A=; b=Hg3juzudnYPheLL3/izQfsm1QMNrlecI31suOWA+dm78u+l4Ns4PscdtJ1MWiOVICbfX+M wAnrRjQAKuLM8mptmFqaakkAx+vUkUvhZMBrYV6+H8Wc8J3AWapdNH06i0zgSSN1paRfM+ UKEMMr702vCz2F6O/4E2bjsLfURYsvQ= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-658-i2RIajucNEeoii4E5_3KPw-1; Fri, 21 Mar 2025 07:28:11 -0400 X-MC-Unique: i2RIajucNEeoii4E5_3KPw-1 X-Mimecast-MFC-AGG-ID: i2RIajucNEeoii4E5_3KPw_1742556491 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3913f97d115so904011f8f.0 for ; Fri, 21 Mar 2025 04:28:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742556490; x=1743161290; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+/o3ZZovn69lnNkwiyckvlWm9nS8xxkazVg7lWV4M7A=; b=vqHxbWgB4QWnTW9kNO35Eg8/VnDP2NF3ptaVRhxT7AqIl+BeDd0iWu0p05WesjBt7k dRIcPEC5RwT7+M7ZPCZfuOeG16Lto4Y/mkvS/DlJmJMP9A82F+LC54o/lG/q+oStf+MM Zb13qF/XuF1pRJM4fB4pYadRTXhOFbs0typfrzJFurqOHX4t59dJJGIfJ8gAGACU5HPC Hjr9I/06uJecdagPD7Q0hlXf5ECVgdHZw9y8Axc/FpnvIRJmAlCzOmQs60KNwROeUgoX wTSDBwUipM9dvWVFWIfF/Pv36iksdnipymZWlUT/nak9O2+tZc8A9hogSSSt7OhU4S5v Vu4A== X-Forwarded-Encrypted: i=1; AJvYcCX3j9g82wCyDCvo98Qf3wQxQ5yViLJqkMCCyA0L67D8FrPnZITWhUUlK1xAI64U5jPBsXMiYR2Dvw==@kvack.org X-Gm-Message-State: AOJu0YyhOIXQ2xMtU5Iz/KllXN9zpH0LchKLBWYMpsOIvUO7F+L2IDY8 e8/vXJevqLH8QuNVENXn/kncPdVpLvMRxT7150UbR531M6j9S9MtbDCV9lL/eTXk9gX7Bz5hVlw I//4dnFmssS2Ec/4po3qOU04Avpr+j8O4xkYJhBLYpjVuSQzi X-Gm-Gg: ASbGncssb2omdBOhlnrkUPwjy4PemZjEnAC4MyzhwHs7VMToeCF6iuN21Ez8mYiRLoD v19XAHuxDKgOP6kcJ86YrOQ2A7UGSUowA0jThBeue2L9BBO1I2v4d09u7TL4VybZ/2u7IPKYT8I oTpjInNIdHa1eXsIsfEGBuqObu/v+7aiMKcO6SOSGvEIKabnwzP8/cZFqV+an1IHkNjIa/PIGBn oJDhvW37E6GO5fA0qP7XhRYn6xG5tFKsFNzBimbCIBZZIsuW6SrAYVH2JqenyPolxPezESJHCiy CDEqSVh6lj5NwAVbnZ0oWYOmMAKfi8zL/2KbIZ9+2d9aU8cfW9MzDnw37LLFmoC2CQ3spwHZe8f h+oM3vyV2D8GnNW653wXO0AaSpKr+In70BeUgAM2H/mY= X-Received: by 2002:a05:6000:4006:b0:391:a74:d7e2 with SMTP id ffacd0b85a97d-3997959ccd4mr7119760f8f.26.1742556490578; Fri, 21 Mar 2025 04:28:10 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHC3StONR8mWibQqKgFRF97Pa4uvGcX7IgZDSet6F/Zqw7Ng5dS90Rejg0NE48fgzpL3XL+1Q== X-Received: by 2002:a05:6000:4006:b0:391:a74:d7e2 with SMTP id ffacd0b85a97d-3997959ccd4mr7119727f8f.26.1742556490102; Fri, 21 Mar 2025 04:28:10 -0700 (PDT) Received: from ?IPV6:2003:cb:c72a:9100:23d2:3800:cdcc:90f0? (p200300cbc72a910023d23800cdcc90f0.dip0.t-ipconnect.de. [2003:cb:c72a:9100:23d2:3800:cdcc:90f0]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3997f9b4ce9sm2146793f8f.53.2025.03.21.04.28.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Mar 2025 04:28:09 -0700 (PDT) Message-ID: <805065c4-b396-43e7-8a9f-f934ec616b31@redhat.com> Date: Fri, 21 Mar 2025 12:28:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] mm: Fix parameter passed to page_mapcount_is_type() To: Gavin Shan , linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, willy@infradead.org, vbabka@suse.cz, osalvador@suse.de, gehao@kylinos.cn, shan.gavin@gmail.com References: <20250321053148.1434076-1-gshan@redhat.com> <20250321053148.1434076-2-gshan@redhat.com> <908c37d2-2da7-4892-bd07-4ec7ffb8fc3f@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <908c37d2-2da7-4892-bd07-4ec7ffb8fc3f@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: rMFxS__I64zq1O9M30-HOiuCW4j7K_tImrD6t1xPKYU_1742556491 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: A1BB34000D X-Rspamd-Server: rspam05 X-Rspam-User: X-Stat-Signature: f14p9c45wrn46z8pce8y5zfibnx8367t X-HE-Tag: 1742556495-361851 X-HE-Meta: U2FsdGVkX1/348cD2IO4l31gMyHvwjZ+e60KNDlaDt2w0Fi4B9+bbRncQx6dHm6t3Y3L5sbfvNrYYdy2eVciyRAhkgcLpZ9ext/SfJ8Z3Juesv92Ff15A30vRwMLrie5MarV2r91HheSHGFb9MFX9YpNuDdMKeRcvJZlaQNQiJXmIU/b/cfmpnJ9EDgLmk2DVLyd96kS1w2Jmfk0lyPyd5lv/UaoIOr6uZTDN49EBuVGdCZQcuFbm23I99dLyoSVpvMKE2aNMgeqzmK00if7QgZ/tzdVKDRZhf1ie8s16vSa6IEaFNlAvJz/SNKRR3V4I2K7ExIVyqB1WigXFkxDSXgMp1y7Jh45jCJSWgvxaPJAP7Xe8FDjoZbeA3zPIH320KehG5FgES7KfHtdX445m/cG98Cs1nMvwIPzb5aF+gQtEvHV33Jk/BMKm5mXMkycnzBNMw+ha3+Y4KelHWMhrryKc3x9rS40gOjt/EVdXhYQcPdguG4i4W4N/1uzfyPduRfoxTugaD1quCWz5D4YpqlwBkosuOo+10g3zBYgNS4B0vgg6ObPtqSDlmirOd7MYPzTBzZuUDxtXrtqO3sUk81Px4+3RpqK8Qv6EQzV23091QnZwRTh4s/VPqFP/tieysa6jyvi8q0HQDX4k521FCmy3egEW09hPi2cjdWoQOkxQOCPEzzaXQzIcCJCmVQ06Xtjn/ePs9XwMNCSq7o+MnKq9CYkR/6lCnVve7s8rOc+5bdJACoYCq0coz9LJFUSpWKtStggInLeSfyG5umDfUvVKW31QhIJuciU7PrpOsmTWG2Edh6U9HadRtl5B28aB0F50Gz52pmvJcArJkOBL45Q4xixlLAaep/GASUpnNwSho88NDrNB9VsLqP4GGzyKYaw8kc/3t7KSTO0gFqwdVRK7r4fQwuJ88X55/B54AQmEP+qs1P+iDEGIGjKwun1IIlx55bw2xJjEw9FA4t 8/prNZnj 58T2lLEC5ybz2IvebP7bhGMrnlH0PRwsYed++xpBt+/1JqODusobgJUaEdUMObHOCXdgzDMuWoWjv0Nhy4KSPiRMH0OzX92Jw1dYSW870wlPoy52DjMDQECoBXK+VZwuwmmbqo+kCN6F8D0BXhbERVc/gf8k9mv5wvfS4k4B4S3ivcWWS7bvageBdHznj9hsCp6DnhdSALJEPy6ntgq7fCDzZ4OboW6WdP1hn85ONfG0kwyyYCpUAjK4yWU1/188rYwWjkCiPH+GB6Pwu+pGArp8uQeWWguVw3q7d67ZaE07dYyU8Gzr8F2/Cn9S1YIfaQUQytLdh6DKHkJ5sdGjCrn5wODR00rMxBzg3QL8fkGFbnbyCypu6iCyyAA3wJo1HsqyuDHw+WeDJZ+HjZWYOTNhZ9K4Ev4lCVHFv84LBGq1JTMgin8hlIQoRGnkhnFDcP+IQY9DZulkaUo/KcoCmtJXCnNBufUoVrPT6xaZso4xe+YBVOydMwOMit8LculAo6oTKHNisLEnY9eQLvD5vNE59jy+zqVkfrDNV2o3KTw0pkAL5aq0+E72rKQFUuRGKPSDIHw9OZD8GoD3DUwnEcIIYcA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 21.03.25 12:26, Gavin Shan wrote: > On 3/21/25 8:13 PM, David Hildenbrand wrote: >> On 21.03.25 06:31, Gavin Shan wrote: >>> As the comments of page_mapcount_is_type() indicate, the parameter >>> passed to the function should be one more than page->__mapcount. >>> However, page->__mapcount (equivalent to page->page_type) is passed to >>> the function by commit 4ffca5a96678 ("mm: support only one page_type per >>> page") where page_type_has_type() is replaced by page_mapcount_is_type(), >>> but the parameter isn't adjusted. >>> >>> Fix the parameter passed to page_mapcount_is_type() to be (page->__mapcount >>> + 1). >>> >>> Fixes: 4ffca5a96678 ("mm: support only one page_type per page") >>> Cc: stable@vger.kernel.org # v6.12+ >>> Signed-off-by: Gavin Shan >>> --- >>>   include/linux/page-flags.h | 2 +- >>>   1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h >>> index 36d283552f80..ad87b4cf1f9a 100644 >>> --- a/include/linux/page-flags.h >>> +++ b/include/linux/page-flags.h >>> @@ -950,7 +950,7 @@ static inline bool page_mapcount_is_type(unsigned int mapcount) >>>   static inline bool page_has_type(const struct page *page) >>>   { >>> -    return page_mapcount_is_type(data_race(page->page_type)); >>> +    return page_mapcount_is_type(data_race(page->page_type) + 1); >> >> Probably we should just call page_type_has_type() instead? >> > > Yes, page_type_has_type() is better. It will be used in v2. Feel free to add my Acked-by: David Hildenbrand -- Cheers, David / dhildenb