From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 023ADC61DA4 for ; Fri, 24 Feb 2023 04:00:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3256C6B0072; Thu, 23 Feb 2023 23:00:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2D57A6B0073; Thu, 23 Feb 2023 23:00:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 19DBB6B0074; Thu, 23 Feb 2023 23:00:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 06AA56B0072 for ; Thu, 23 Feb 2023 23:00:36 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id CA59A120E1F for ; Fri, 24 Feb 2023 04:00:35 +0000 (UTC) X-FDA: 80500833630.09.F89C95C Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) by imf11.hostedemail.com (Postfix) with ESMTP id D67A640009 for ; Fri, 24 Feb 2023 04:00:32 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=fSL1J8po; spf=pass (imf11.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.215.173 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677211234; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5eD9zEwmmAkNC6ATMDdCuPdbKJ4KCUVQlsQH4qsPnDo=; b=aqgoB7L4W0/uS1wsYve57EkE7ZUylpf9qa5862fR/Vzz8X5P5fHhEZAbOlTzWn8wLqTY9h OsN+ckpSEGSqESge0+wrrec2sUgU3EYh6DbNiNXZFUE0gtQ8M22CTwQd+Zl3tmu64KMH0L 6DtEr7u4US4XZ6eK3Z+h612XE6oJzqU= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=fSL1J8po; spf=pass (imf11.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.215.173 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677211234; a=rsa-sha256; cv=none; b=zC7HI7a2l+stFRjCwtBAGPT2qIVjDpEh8iL3CKv26zw6XwzMTsarHE++U17+LZ4amRPg5q /jtgBVukg7eAc2q6XtKmwIconmVpmVQl/eeA4zBP7mcWSnUmxsfog9kxBsD6mZz1UzsTYX 6F4ULLp60jSqVZKh4jwebyH2dWsk/UE= Received: by mail-pg1-f173.google.com with SMTP id bn17so1204141pgb.10 for ; Thu, 23 Feb 2023 20:00:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=5eD9zEwmmAkNC6ATMDdCuPdbKJ4KCUVQlsQH4qsPnDo=; b=fSL1J8poLcazrBUjwmdlp570ATEm31cE7WZL9gYApJOWM7AD1scwfB9x5NYiRQy5TR 2xV637EdXaMnY3rii9Vf07vutuwhUEhO25jkwTlIzJ/2dzr2ZFu4zmavEjZ3/fj13tIy 64G8c8uTsFBuLAXGo8CisUkhGtQEb1O9HI6sEs3sf6WryGKk8192r3aQMYfhsGdKwAay ZhheENLW496UIcBl1av+UnA2600AkmsO6HnL0SzDuZh6wspF8f7Wkw8fIQI2hWF881O8 mFRMwoCzkkoedqZ8NnjQqMY8RUBDkK0+34lCoKNgMIium68hZhPJMj0XjqH1JXzkBUr3 grWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5eD9zEwmmAkNC6ATMDdCuPdbKJ4KCUVQlsQH4qsPnDo=; b=q/AUh3ffvlkDCCVLhocF7yh2xE35Hdw3/r/E7qXGx4U8Ay7skEipuiVipP3WoqVaxu gHi8GSQakv/GQAZSExNdkNJ+YKNb29/3hWbPdMou64HFtAFwCxjmxGlp1hyDgagSiiQJ b6viyuvZS3+A66ofitUIAp3U1GvYiqQVN5Qrp78tRY5kkjgk8JZr++a5s7/wT1qvg/cz H8cz34xW7w03mollxI9mLwtkv6xMcbAiWgJ8QP+lq2iAs79NO8d1STOKcHy3zrZfphGr oeZShuq9JMCA0v4AlPs9lFd38C3xcEa3eMiwjMXXKPPxzpdjvrfDUpBYZJBPkRBZC02b o1XA== X-Gm-Message-State: AO0yUKUPCdV+oIk6XSimLkpbV9dUcXUhApgC/R0OAA+0hmv6uTnWp48+ 8QYj9lzee2c5paWq27zvsmDSCw== X-Google-Smtp-Source: AK7set+gQLoGEiUOsKGrQxpoGv+t7v9CDtaScqYlE6ztuTB52Elx80xF+jnfqPGnQIDUV04N12pWXQ== X-Received: by 2002:a05:6a00:1d20:b0:5e4:f141:568b with SMTP id a32-20020a056a001d2000b005e4f141568bmr7772pfx.3.1677211231368; Thu, 23 Feb 2023 20:00:31 -0800 (PST) Received: from [10.70.252.135] ([139.177.225.245]) by smtp.gmail.com with ESMTPSA id j10-20020a62b60a000000b0058e1b55391esm2464187pff.178.2023.02.23.20.00.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Feb 2023 20:00:30 -0800 (PST) Message-ID: <8049b6ed-435f-b518-f947-5516a514aec2@bytedance.com> Date: Fri, 24 Feb 2023 12:00:21 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH v2 2/7] mm: vmscan: make global slab shrink lockless Content-Language: en-US To: Sultan Alsawaf Cc: akpm@linux-foundation.org, tkhai@ya.ru, hannes@cmpxchg.org, shakeelb@google.com, mhocko@kernel.org, roman.gushchin@linux.dev, muchun.song@linux.dev, david@redhat.com, shy828301@gmail.com, dave@stgolabs.net, penguin-kernel@i-love.sakura.ne.jp, paulmck@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230223132725.11685-1-zhengqi.arch@bytedance.com> <20230223132725.11685-3-zhengqi.arch@bytedance.com> From: Qi Zheng In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: D67A640009 X-Stat-Signature: nthaznfgo9dqeuyjg8aen149z6nygwco X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1677211232-720970 X-HE-Meta: U2FsdGVkX18EnUVOCwTl+N13uvhOMCHfV+NrQlg0CkHE+c3eOoECk32KpBmlEzOafEmxcP99vPrw/3G7isVkYVo3XA+0N8GX5BbF0mIPhYGZT5nysjsYdXyYlM+Zy3Ajf6EPfElBTIcbKCvUHlDJEEbsp3v8M+lbFrULjTwc15PiQqyyelNV2hVu57M4MgMdS5GzvSNLAoe6+8+WGoUcuJDjXUCXbguUy2qS6jm1QEGFsPdm5BWNm/KsON/eaaHI7P3mEMt4BvMQjis0z2HbI8GwCPzuH5xxECZbOaqtuF+IucR05nsoK32ZXr76omyoBzwd3TGgVOAK4z2XyuaD7MfLDJ/h4Oa7VtctV9FDmXVDO6XmUC3A9pEAEJVU4dS5S8EKfO0OZjuF13gw5xoMX4/y31pqtlzhS17vNUmtbO01TTZ1pqmdkv1l0K4HTQzWKBSUjFzkZkGyN9HYe0U/qWEZ+zy0mlKgoElLyj1q81xXb/r/22qFQfj3j3mtAyOUe9AN5xT/FVtTePBLzYn+UDN4+wmpiYIqMLpFH8b1DRTboJ/dLEsiThefG0Yw/niBNe5ydsI7NxtTZ8J2dd30aCXl7i/pwwNafkmbbfPvqIhvw8vfRGtS8gcsiFD0psezoYm0JR3N36ztG5ru+LToVznb/puKH+0+HVkBf+6qeVi6937pBDXPCrwx2ptmOFv8fq5Kt33rUG8V3HQcDBuHG6JukjXlhsNxr7P1nH9DqUg1zqoBaUmKgZhjtbqDHKxgZupfkT1QwR1/TmgChDr1nrMqqzxw1RnR3WgwUJWaVgP36SB4BUSCzpi2j4+hBaBM77q5BStwgUxmXKxGfJzQ5cbN8EIS/Z06LdDHOYknV/43uq6X9a09CCMXMfH4jnuCsMrKznNBMqbSOPh6Cn8R1RAy+9N3JoP4hn8VrJXA7+QbClp82//5+WDjI8Gd8gxfxle1JvokSbI62BXnkjP gMILlhR5 5JvIwLKvk9b+jX4DBjbcSaCe28hp7PipqG18UerQMKeIxzeqQeXoXiEJxmWquc/DpjjoopYPTZIQ5YXxWn2RoTGaf1LLoSfMA+Hz+tLc88HYLHoO5B1h/14/JVGBqkfQdQce5f7QsoeT4zIrC6cOSCEEw0O3OhV9OvF/dQ/M849/5UNsxItYxcVyQOE9u7o90lOdkczg0xOQl6PleoZRTRK6shGG4HBSjvKJDtIx8K6184ygdD83HB4i/gQMk/JTgCS2VKYho6fKzidWBrVJcVRX7yIl7a/d+9LcjyMs0P1+JiSDn0EnaIM/6S8Acyl7xcbx2pReGlxu3tZgze9PSaAoGrwdtpycke2OTf3+GHdOuiLRW4pXU77hHPlHcWN3U96VrZwjbXYt4ttCqV3tlvrfYXBn8la96stx/+Mji65tIeMN6rtHhmgFJA+vf3LFeMpQX63r+Ndx4+/oouGVR/cypVSZnPCifGvc6cNpg1O/cTRDCltiTAekUIa2PoWw2+GHseTNp3C7EhE2A+7zDRqYmu2XgKOtHopCJgDzYEs/SQUuIFt6PBDz2htlXivED8HSjOFZ229N6D+E+6uausu/4ltiv63EBK8ZyY/hvvaSwmKLekcetElSYY5ylF1YieW9ELfo1evzjaHPElQ2JPME+mC7NylvONOnv3xRW7rUcMePcaaryoOdXcsimy/LNLMX/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/2/24 02:24, Sultan Alsawaf wrote: > On Thu, Feb 23, 2023 at 09:27:20PM +0800, Qi Zheng wrote: >> The shrinker_rwsem is a global lock in shrinkers subsystem, >> it is easy to cause blocking in the following cases: >> >> a. the write lock of shrinker_rwsem was held for too long. >> For example, there are many memcgs in the system, which >> causes some paths to hold locks and traverse it for too >> long. (e.g. expand_shrinker_info()) >> b. the read lock of shrinker_rwsem was held for too long, >> and a writer came at this time. Then this writer will be >> forced to wait and block all subsequent readers. >> For example: >> - be scheduled when the read lock of shrinker_rwsem is >> held in do_shrink_slab() >> - some shrinker are blocked for too long. Like the case >> mentioned in the patchset[1]. >> >> Therefore, many times in history ([2],[3],[4],[5]), some >> people wanted to replace shrinker_rwsem reader with SRCU, >> but they all gave up because SRCU was not unconditionally >> enabled. >> >> But now, since commit 1cd0bd06093c ("rcu: Remove CONFIG_SRCU"), >> the SRCU is unconditionally enabled. So it's time to use >> SRCU to protect readers who previously held shrinker_rwsem. >> >> [1]. https://lore.kernel.org/lkml/20191129214541.3110-1-ptikhomirov@virtuozzo.com/ >> [2]. https://lore.kernel.org/all/1437080113.3596.2.camel@stgolabs.net/ >> [3]. https://lore.kernel.org/lkml/1510609063-3327-1-git-send-email-penguin-kernel@I-love.SAKURA.ne.jp/ >> [4]. https://lore.kernel.org/lkml/153365347929.19074.12509495712735843805.stgit@localhost.localdomain/ >> [5]. https://lore.kernel.org/lkml/20210927074823.5825-1-sultan@kerneltoast.com/ >> >> Signed-off-by: Qi Zheng >> --- >> mm/vmscan.c | 27 +++++++++++---------------- >> 1 file changed, 11 insertions(+), 16 deletions(-) >> >> diff --git a/mm/vmscan.c b/mm/vmscan.c >> index 9f895ca6216c..02987a6f95d1 100644 >> --- a/mm/vmscan.c >> +++ b/mm/vmscan.c >> @@ -202,6 +202,7 @@ static void set_task_reclaim_state(struct task_struct *task, >> >> LIST_HEAD(shrinker_list); >> DECLARE_RWSEM(shrinker_rwsem); >> +DEFINE_SRCU(shrinker_srcu); >> >> #ifdef CONFIG_MEMCG >> static int shrinker_nr_max; >> @@ -706,7 +707,7 @@ void free_prealloced_shrinker(struct shrinker *shrinker) >> void register_shrinker_prepared(struct shrinker *shrinker) >> { >> down_write(&shrinker_rwsem); >> - list_add_tail(&shrinker->list, &shrinker_list); >> + list_add_tail_rcu(&shrinker->list, &shrinker_list); >> shrinker->flags |= SHRINKER_REGISTERED; >> shrinker_debugfs_add(shrinker); >> up_write(&shrinker_rwsem); >> @@ -760,13 +761,15 @@ void unregister_shrinker(struct shrinker *shrinker) >> return; >> >> down_write(&shrinker_rwsem); >> - list_del(&shrinker->list); >> + list_del_rcu(&shrinker->list); >> shrinker->flags &= ~SHRINKER_REGISTERED; >> if (shrinker->flags & SHRINKER_MEMCG_AWARE) >> unregister_memcg_shrinker(shrinker); >> debugfs_entry = shrinker_debugfs_remove(shrinker); >> up_write(&shrinker_rwsem); >> >> + synchronize_srcu(&shrinker_srcu); >> + >> debugfs_remove_recursive(debugfs_entry); >> >> kfree(shrinker->nr_deferred); >> @@ -786,6 +789,7 @@ void synchronize_shrinkers(void) >> { >> down_write(&shrinker_rwsem); >> up_write(&shrinker_rwsem); >> + synchronize_srcu(&shrinker_srcu); >> } >> EXPORT_SYMBOL(synchronize_shrinkers); >> >> @@ -996,6 +1000,7 @@ static unsigned long shrink_slab(gfp_t gfp_mask, int nid, >> { >> unsigned long ret, freed = 0; >> struct shrinker *shrinker; >> + int srcu_idx; >> >> /* >> * The root memcg might be allocated even though memcg is disabled >> @@ -1007,10 +1012,10 @@ static unsigned long shrink_slab(gfp_t gfp_mask, int nid, >> if (!mem_cgroup_disabled() && !mem_cgroup_is_root(memcg)) >> return shrink_slab_memcg(gfp_mask, nid, memcg, priority); >> >> - if (!down_read_trylock(&shrinker_rwsem)) >> - goto out; >> + srcu_idx = srcu_read_lock(&shrinker_srcu); >> >> - list_for_each_entry(shrinker, &shrinker_list, list) { >> + list_for_each_entry_srcu(shrinker, &shrinker_list, list, >> + srcu_read_lock_held(&shrinker_srcu)) { >> struct shrink_control sc = { >> .gfp_mask = gfp_mask, >> .nid = nid, >> @@ -1021,19 +1026,9 @@ static unsigned long shrink_slab(gfp_t gfp_mask, int nid, >> if (ret == SHRINK_EMPTY) >> ret = 0; >> freed += ret; >> - /* >> - * Bail out if someone want to register a new shrinker to >> - * prevent the registration from being stalled for long periods >> - * by parallel ongoing shrinking. >> - */ >> - if (rwsem_is_contended(&shrinker_rwsem)) { >> - freed = freed ? : 1; >> - break; >> - } >> } >> >> - up_read(&shrinker_rwsem); >> -out: >> + srcu_read_unlock(&shrinker_srcu, srcu_idx); >> cond_resched(); >> return freed; >> } >> -- >> 2.20.1 >> >> > > Hi Qi, > > A different problem I realized after my old attempt to use SRCU was that the > unregister_shrinker() path became quite slow due to the heavy synchronize_srcu() > call. Both register_shrinker() *and* unregister_shrinker() are called frequently > these days, and SRCU is too unfair to the unregister path IMO. Hi Sultan, IIUC, for unregister_shrinker(), the wait time is hardly longer with SRCU than with shrinker_rwsem before. And I just did a simple test. After using the script in cover letter to increase the shrink_slab hotspot, I did umount 1k times at the same time, and then I used bpftrace to measure the time consumption of unregister_shrinker() as follows: bpftrace -e 'kprobe:unregister_shrinker { @start[tid] = nsecs; } kretprobe:unregister_shrinker /@start[tid]/ { @ns[comm] = hist(nsecs - @start[tid]); delete(@start[tid]); }' @ns[umount]: [16K, 32K) 3 | | [32K, 64K) 66 |@@@@@@@@@@ | [64K, 128K) 32 |@@@@@ | [128K, 256K) 22 |@@@ | [256K, 512K) 48 |@@@@@@@ | [512K, 1M) 19 |@@@ | [1M, 2M) 131 |@@@@@@@@@@@@@@@@@@@@@ | [2M, 4M) 313 |@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@| [4M, 8M) 302 |@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@ | [8M, 16M) 55 |@@@@@@@@@ I see that the highest time-consuming of unregister_shrinker() is between 8ms and 16ms, which feels tolerable? Thanks, Qi > > Although I never got around to submitting it, I made a non-SRCU solution [1] > that uses fine-grained locking instead, which is fair to both the register path > and unregister path. (The patch I've linked is a version of this adapted to an > older 4.14 kernel FYI, but it can be reworked for the current kernel.) > > What do you think about the fine-grained locking approach? > > Thanks, > Sultan > > [1] https://github.com/kerneltoast/android_kernel_google_floral/commit/012378f3173a82d2333d3ae7326691544301e76a > -- Thanks, Qi