From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42BBEC27C77 for ; Tue, 11 Jun 2024 15:33:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AD5216B0099; Tue, 11 Jun 2024 11:33:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A85E26B00AD; Tue, 11 Jun 2024 11:33:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8D79E6B00AB; Tue, 11 Jun 2024 11:33:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 703A76B0092 for ; Tue, 11 Jun 2024 11:33:25 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id E60FC1C2567 for ; Tue, 11 Jun 2024 15:33:24 +0000 (UTC) X-FDA: 82219001928.03.0AABECD Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf13.hostedemail.com (Postfix) with ESMTP id ABE782000A for ; Tue, 11 Jun 2024 15:33:22 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=P2ExqmkO; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718120002; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dO3XeXY+JI0Vowo94JdLCb+4j0Cttva0vSP/n5bA6I4=; b=JFPbaDbiLCxKU5rcN6Y8j83MePR+Wotz2FFWJnCRRJGm7Yytv7B2Br+8f3VBNcvUs9mnKp 0/+lRGk72f+avTZqys2ckV/GIZmjbi3Q3400sifLImV5Ih3rhd5nFazwJ5COei+OJekPU+ cn45t+n6A2FvhPrTui5T1qRvfguH1RQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718120002; a=rsa-sha256; cv=none; b=tZtI3/ACq+P7BU0HzZcXskfcBYnRY+dCabH50am1MIlWO+nhXjm5Of8O5zDG6u99fgDtqH 8qNVc4nDt+jiuAcGLU+v+FvehOUP+sZqLQzhOnkf9BdM+YkIz5ZUlerrSOqz+up49RND0E 6uqYKOhzkgJE8+YR8FwnyidnWPK7cJY= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=P2ExqmkO; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718120002; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=dO3XeXY+JI0Vowo94JdLCb+4j0Cttva0vSP/n5bA6I4=; b=P2ExqmkOfEmA696eV/Z1ixCNt6V8Z9rfeQz9zvHLtzQ96sRLRA/uRgycqrEn0xvN6FeA0q lgzE82loeVaw/bzExQuccgTZyH+IKZg3TDJhYIwTJ9nSU1bVAIrEjfEHyrdk1Foqma/yEP +Z6aQo3X2ZsdBMtQ7EpcJwcuLCWg1BM= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-656-uD_8OgHkMYy8IdmIzZ9TNw-1; Tue, 11 Jun 2024 11:33:20 -0400 X-MC-Unique: uD_8OgHkMYy8IdmIzZ9TNw-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-42117a61bccso42199715e9.0 for ; Tue, 11 Jun 2024 08:33:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718119999; x=1718724799; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dO3XeXY+JI0Vowo94JdLCb+4j0Cttva0vSP/n5bA6I4=; b=HZusw1sCQGIjjag/WdyiK0vD4UU9uKzr6QeEC+rfo/eerKMHJL7FoeTEaanVSdehkl o/y1GkRwoGXRCvm335w4LCaHlwgrugqutRirG2ssULKkhOxYIWeyDPhTv1tb7a8btbTk XTfNcmzgqKe0ELi0loVBBVYBMhS94z7JYyKl+gmIg4CUq+LYkGNlfuDa7XspQ06bDG5G HrwPv4h6KgLf6Xo1/fpssoNnv+vLzmKKzpi+mDAZSNki4gbGDJdNIsjdQkLJV2pUVTtJ b8vjgqFlery8AyouzDxRAWuUZxPx0z6J/qp+o+JEQJFDRUHuVkXXAgyr59xWxDYO8k49 9BEg== X-Gm-Message-State: AOJu0Yx6NQRW2g8q496vaoG0yQ+nk/8vevg8vzKphAqFr9fO6yI7GekP MMC3OzALNZapSgJBVSLf8+Sc+X9diETPfUVJjDWMR/xKSTPwj2BWSZ23/L+RgIbSvC9FkxwS90w ug8IeoLtKWX+DdUHVwcsAnjjpv25vgrYTLTM1eukyNZ1cAxMH X-Received: by 2002:a05:600c:1f91:b0:420:139e:9eda with SMTP id 5b1f17b1804b1-421649f0f98mr105394845e9.12.1718119999211; Tue, 11 Jun 2024 08:33:19 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHNx0PgiAvDuHhT7ZWTkLM/vclPFjoJSNPZMCxmqUF/QamezwwUKbiwNRUW8RPFKCRqidXObg== X-Received: by 2002:a05:600c:1f91:b0:420:139e:9eda with SMTP id 5b1f17b1804b1-421649f0f98mr105394705e9.12.1718119998793; Tue, 11 Jun 2024 08:33:18 -0700 (PDT) Received: from ?IPV6:2003:cb:c748:ba00:1c00:48ea:7b5a:c12b? (p200300cbc748ba001c0048ea7b5ac12b.dip0.t-ipconnect.de. [2003:cb:c748:ba00:1c00:48ea:7b5a:c12b]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-421580fe3cfsm214052765e9.9.2024.06.11.08.33.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Jun 2024 08:33:18 -0700 (PDT) Message-ID: <8040793f-e9e9-4a2e-807c-afcb310a48f5@redhat.com> Date: Tue, 11 Jun 2024 17:33:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] mm/memory: Don't require head page for do_set_pmd() To: Andrew Bresticker , Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240611153216.2794513-1-abrestic@rivosinc.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240611153216.2794513-1-abrestic@rivosinc.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: scmybht447fi39pa84w6htazkdknjof9 X-Rspamd-Queue-Id: ABE782000A X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1718120002-475393 X-HE-Meta: U2FsdGVkX1/+lAUrURJtuJL6GkZy7h+SdXaHPwQbZiu446fE24krret/j0MlMf73Eig4PLTn4IhDNVB3q50WyIW1O5up8pSwTUnm4YWQuHEG6f8mAiE2NtAHryjM/4G1mkfljm5jVen+jOOmsn31jsN8EfVfpE6uLmoENZP8oBgkBfnlInSR3jxwLaowvlmdxLlsb7f2G/bzsmFwOEhpChwnV6vKr7A33gBks0ngJSjbc7J2YHdddZJl7qapcelUTrkGhx8LrRMkB/7A5SPE2EuctuoGbBlZQpaRZds5IX4DGieKj5Prg0Ke6zhBSPkQCu5k+sQm3KDLONLSg7euiykyhPHcqbsdTyQsHDT62NXqAcLI0rIT3Mn07YxqpdAMtW9xI5QSY7dS2HmEnnJpYKzQXTSKWCgx8SjAOQWmENSd09nyksBZ1Sw1ThpidL3MaknQq+r15VjAYVMdmsOfVCGfnsjIIwqasRW7fZKtkTsJQ6xOlBHySidNbAZ/281NAmqioJm8FinRALezxYvG69pAt5Hmr+yTsJuG66v/Pj2N6dlbIxUR2VC8/eKQ693aPsJc8JZpSr6qDJxcalUco75S4CPo53lJgZi+zdNfUodHdSziHU0gyBw9V1WxJHjrHiNflJcX3fUJ4g5wXP6ymzhYtsT58M/t68/eZCE45ZcJg8helgopp6eiw0R1O1lOxl3ORVYOT7VoVwSXd4P+bV07lleRgRFsKN7jnpA01VX7rf16otKjbvFumxiZn7L2kM0Zj3WM5/Khh6fLL+MjmFavGvRYmZ98ToeFkqlav+gUjq/2ML/ECVuDZnSNw4hc9/ymQyrk+l5Ogt1uSFf0nWPQQuouR/JDRi+VtI4zaXhjCT+jnn1z7tERgM2TuabNgu+RAb3Ove9EycFHxHNcgq2cN1UrgfXo0ilWqwG4R4rl2YkcR5edW8CPq1l67UgbQzYAb1FON+bwbiObaEC 1z1SlmJS oJpdPlP2DwFddoxHj37IZVRuQgcfvE/uNaG0hEvDiuA8JOR0ZyKCDgU3BvFhop90Cl/5qQoFDOrOCPPGtO2k9q1bMGY2lCDo8q8BY3ypw7dMesmxs+0JsYMNxGZRx71BzhDlywrhhwaH6cIOKM3TxnYEI7obC6gPDWNmgFEvLSgbErQU5zTJF4X4FX0oEVtFFuoq32n3uxblsYL0DxSoD9OTaURPfUBfLc1pyI7/Lgu2EIBZtC+iTz7U8g/pL5RIrxwyQMrudF8OkHjafJV4Op6ONm9MJaKZvENkOS+Vn7DzIM934hWvb4iJFqLoBPYKLcp1YEFhJfXo+QO+z8I1LdBUk1ZfGiWk4Z2TyOIAN7kcmOb5U9SPnLgjjks3hMh8urVG0wloOB2de3NWOLxEbby7uGIZuzgakY1C9Wp/0XnQxtgjgvkToGfcJ4/QkExbwVXdGN6iy4LmKow4e/rTwP5sT8nEnQn5Zf6oage/QDJzIRnB/c2w20TJ4MDl+DhCWu0nNq/1GJgaEz70ZXm2agHiLcJ1Nm9T5CAjT+ppLsTnLrNEh+R8bRVKLyt+vqIBWmeRFoX1PpAryKm6ZC7BlL5zjrI1hRYpkTJammDEOrkD7U/zjnpI0qaC6ZA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11.06.24 17:32, Andrew Bresticker wrote: > The requirement that the head page be passed to do_set_pmd() was added > in commit ef37b2ea08ac ("mm/memory: page_add_file_rmap() -> > folio_add_file_rmap_[pte|pmd]()") and prevents pmd-mapping in the > finish_fault() and filemap_map_pages() paths if the page to be inserted > is anything but the head page for an otherwise suitable vma and pmd-sized > page. > > Fixes: ef37b2ea08ac ("mm/memory: page_add_file_rmap() -> folio_add_file_rmap_[pte|pmd]()") > Signed-off-by: Andrew Bresticker > --- > mm/memory.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/mm/memory.c b/mm/memory.c > index 0f47a533014e..a1fce5ddacb3 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -4614,8 +4614,9 @@ vm_fault_t do_set_pmd(struct vm_fault *vmf, struct page *page) > if (!thp_vma_suitable_order(vma, haddr, PMD_ORDER)) > return ret; > > - if (page != &folio->page || folio_order(folio) != HPAGE_PMD_ORDER) > + if (folio_order(folio) != HPAGE_PMD_ORDER) > return ret; > + page = &folio->page; > > /* > * Just backoff if any subpage of a THP is corrupted otherwise Acked-by: David Hildenbrand -- Cheers, David / dhildenb