From: Mike Kravetz <mike.kravetz@oracle.com>
To: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Michal Hocko <mhocko@kernel.org>,
Andrea Arcangeli <aarcange@redhat.com>,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
Mel Gorman <mgorman@techsingularity.net>,
Davidlohr Bueso <dave@stgolabs.net>,
Andrew Morton <akpm@linux-foundation.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH] huegtlbfs: fix page leak during migration of file pages
Date: Mon, 11 Feb 2019 18:37:57 -0800 [thread overview]
Message-ID: <803d2349-8911-0b47-bc5b-4f2c6cc3f928@oracle.com> (raw)
In-Reply-To: <20190212022428.GA12369@hori1.linux.bs1.fc.nec.co.jp>
On 2/11/19 6:24 PM, Naoya Horiguchi wrote:
> On Mon, Feb 11, 2019 at 03:06:27PM -0800, Mike Kravetz wrote:
>> While looking at this, I think there is another issue. When a hugetlb
>> page is migrated, we do not migrate the 'page_huge_active' state of the
>> page. That should be moved as the page is migrated. Correct?
>
> Yes, and I think that putback_active_hugepage(new_hpage) at the last step
> of migration sequence handles the copying of 'page_huge_active' state.
>
Thanks! I missed the putback_active_hugepage that takes care of making
the target migration page active.
--
Mike Kravetz
next prev parent reply other threads:[~2019-02-12 2:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-30 21:14 Mike Kravetz
2019-01-31 14:12 ` Sasha Levin
2019-02-01 22:36 ` Mike Kravetz
2019-02-07 18:50 ` Mike Kravetz
2019-02-08 2:31 ` Naoya Horiguchi
2019-02-08 5:50 ` Mike Kravetz
2019-02-08 7:31 ` Naoya Horiguchi
2019-02-11 23:06 ` Mike Kravetz
2019-02-12 2:24 ` Naoya Horiguchi
2019-02-12 2:37 ` Mike Kravetz [this message]
2019-02-12 22:14 ` [PATCH] huegtlbfs: fix races and page leaks during migration Mike Kravetz
2019-02-14 1:32 ` Mike Kravetz
2019-02-15 15:48 ` Sasha Levin
2019-02-18 21:14 ` Sasha Levin
2019-02-21 6:09 ` Andrew Morton
2019-02-21 19:11 ` Mike Kravetz
2019-02-21 19:47 ` Andrew Morton
2019-02-26 7:44 ` Naoya Horiguchi
2019-02-27 0:35 ` Mike Kravetz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=803d2349-8911-0b47-bc5b-4f2c6cc3f928@oracle.com \
--to=mike.kravetz@oracle.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dave@stgolabs.net \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@kernel.org \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox