From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE4D7C0015E for ; Thu, 13 Jul 2023 15:46:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 936F4900043; Thu, 13 Jul 2023 11:46:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8C030900037; Thu, 13 Jul 2023 11:46:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 761EC900043; Thu, 13 Jul 2023 11:46:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 6159F900037 for ; Thu, 13 Jul 2023 11:46:39 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 003601402E4 for ; Thu, 13 Jul 2023 15:46:38 +0000 (UTC) X-FDA: 81007016118.19.B55D9BC Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf02.hostedemail.com (Postfix) with ESMTP id 2E7A180008 for ; Thu, 13 Jul 2023 15:46:35 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf02.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689263196; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6ogrB6ROi1B1LQLwQbAx4v8uo4pwx+8cWEyGCTL5iXg=; b=w8Yu4GLxcyA5e/qcQzvaAsPJ+Bdw3vnPzTJG3IC5+0FqcTU0bcLBsGeFDkqkjuCJRDuV0M fF3TDrRTiMT3SOgm7Moil7xH5HUf/LO08DxsjVGujW/llHw29SFpwAPlAhjEoyAsfHzO9T TExm/mO/Jt7rzhitN+Ai14a/fx7YzPY= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf02.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689263196; a=rsa-sha256; cv=none; b=WzOIrE7BIcJu52WcUDhWITgseYkd5JdH0tSdOm/Pmu08OEZzvBGZ2fLTyrU1Dk1QlUxMjn aYkdrzIZK20OKuV7dIXLSjSh6IA8nVXQIimIIR8dh857p2MEPNiIJ+n/P2B7qBEH6A3O39 N+35cdW/aVjSMPdjg1LPOBNS8VtZdAY= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A68F71570; Thu, 13 Jul 2023 08:47:17 -0700 (PDT) Received: from [10.1.30.48] (C02Z41KALVDN.cambridge.arm.com [10.1.30.48]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C5A0F3F73F; Thu, 13 Jul 2023 08:46:33 -0700 (PDT) Message-ID: <803bb28b-b25c-510d-bc70-b6726f750538@arm.com> Date: Thu, 13 Jul 2023 16:46:32 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v1 9/9] selftests/mm: Run all tests from run_vmtests.sh To: Mark Brown Cc: David Hildenbrand , Andrew Morton , Shuah Khan , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , John Hubbard , Florent Revest , "Liam R. Howlett" , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org References: <20230713135440.3651409-1-ryan.roberts@arm.com> <20230713135440.3651409-10-ryan.roberts@arm.com> <2b586ba2-7522-a823-afd6-7b4d978f18c2@arm.com> <97742685-e026-417b-8c8f-938330027636@sirena.org.uk> <8d2e75e7-0d38-6e6c-a02a-b66a18515dfb@arm.com> <5b4fcf62-98c3-458e-a0e7-8e86ec354cb9@sirena.org.uk> From: Ryan Roberts In-Reply-To: <5b4fcf62-98c3-458e-a0e7-8e86ec354cb9@sirena.org.uk> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 2E7A180008 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 8f1gssz9sxjpkcp8oy1pih1zsn8gh5ga X-HE-Tag: 1689263195-735354 X-HE-Meta: U2FsdGVkX1/ohFDlkgrEatyqTgzokRZPt2xv1C1wrBoJ/A2/d9I3wFPxTr8TOH3Z4p1i+1a6kw99oT2xAvVo9nkmplk1MfYYihd/toSF8iDa4ioI2RlxlQBgQgcKwlkimsG9FDjRIuHJJCc5RQMQUE5WCSdRSxvUXJA5my47CzoYQkKI1rudda9iPQFYPfASeKJj8cTGvNHzdu0x0tXf2mzebi6F9JndWtGrHYXS+9Fe3ln1BRi2MQMskdR2cASiat6GbwT2aFLAjxA4cQwOiN5Y127sw+zSNFqybKBIjvvPJ1psxNf7Kpzc/wZjEboDwkqoaNaVqlOqsnyeX5aKZyRuQ1oyaM+XRrMZPgWCH8T2CT0BCVJav3g81/h24QzG6GoB5GSnaXun58De4R5z/QCuxswJBOV4fDKc2p1GxxqV/zfzXwKmdcBt4Su1yEmO2sZ33BNpz7WbbOHuKFrscvoChV1MFDjwhVCxFlDSizCRmNYgop1N4EzFfT1cNOlmfTiM3OaN23VlIsY8ndJyD03EKz26J5AC9TADtYPL6wUVr3cL2gehaXC85k77VUJ8ocoK16cLinurFbp6ep2XD3/mBUQ0U0m9L8RI9IT5mgCxLFLmBu7vLhWrWADgUoP1mJqXG5eQy3qOmOlr/4MsTmMmOsHG+DzttO5blUOt9jV08eORBYEhiQPahQCmxAS0ib7aVLxLfj7j4lfATEsdCz2w5Q6sVkfpkhcuaCDoHfTVB2GuB2PLPt75ZXU1nwody9R3VlbFmXy4x0A9LCU/Qx02u+1SOfEMOo2JBBT2w/aG0Svf+sOup0mB03klTY+TzCsZ0GV7zyBG9Kw2e3SpAP0Xo6Uj1yvYEbaYfKlmO4dZX8v4EwIVP9lpXPJ8gFtM0Btc9dzyNtPVrK1lO/cxi0gKEBF1IHWO+pX0j+0E+wfnkb6eP5rbqpBbbZqYfzqjr+R2kQ0dBVYSdbldH8t bL5VgsDf 6o21XhR5/M4eT+V9wkZD/8PMgYIDoOFnMOL5BUe4sMxH/dmUI7d+letw+sLZ9l+1P1/g3C2QU2F56zN35OA3bZ0wdtxUqaNOqMdWTueRSbrCCDxLuY/iwbjV/CrDDDiMm0e9xAnmPiXjJIp8QAa7Fgn5seNgjRKh0fZqC X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 13/07/2023 16:43, Mark Brown wrote: > On Thu, Jul 13, 2023 at 04:36:18PM +0100, Ryan Roberts wrote: >> On 13/07/2023 16:30, Mark Brown wrote: > >>> The results parsers I'm aware of like the LAVA one will DTRT with nested >>> kselftests since that's required to pull see individual test cases run >>> by a single binary so it's the common case to see at least one level of >>> nesting. > >> That's good to hear. But bear in mind that run_vmtests.sh does not use TAP. So >> you end up with a single top-level test who's result is reported with >> run_kselftest.sh's TAP output. Then you have a second level (run_vmtests.sh) >> using custom reporting, then _some_ of the tests invoked use TAP so you >> sometimes have TAP at level 3. But those tests at level 2 that don't do their >> own TAP output probably won't be parsed by LAVA? > > I think that should mostly mean that all the tests that don't > individually produce KTAP output get ignored by parsers and those which > do produce KTAP output will be seen as nesting one level up from where > they are (ie, the individual cases will run directly from vmtest), > though there's likely to be confusion about expected run numbers for > things that actually pay attention to that. I suspect it wouldn't be technically dififcult to add a --tap option to run_vmtests.sh, which would switch the output format to TAP. If people are amenable. > >> Since you agreed to put this into the CI, I was going to call this part "your >> problem" ;-) > > It'll run, the results are a different story. :P