From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 424F0C43334 for ; Tue, 12 Jul 2022 03:00:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8CED8940038; Mon, 11 Jul 2022 23:00:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 87D36940033; Mon, 11 Jul 2022 23:00:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 79319940038; Mon, 11 Jul 2022 23:00:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 6A4A9940033 for ; Mon, 11 Jul 2022 23:00:58 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id E1BC0120C38 for ; Tue, 12 Jul 2022 03:00:57 +0000 (UTC) X-FDA: 79676945754.05.179DF20 Received: from out30-131.freemail.mail.aliyun.com (out30-131.freemail.mail.aliyun.com [115.124.30.131]) by imf26.hostedemail.com (Postfix) with ESMTP id CF31E140060 for ; Tue, 12 Jul 2022 03:00:55 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R901e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045170;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0VJ6IizN_1657594851; Received: from 30.97.48.63(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0VJ6IizN_1657594851) by smtp.aliyun-inc.com; Tue, 12 Jul 2022 11:00:52 +0800 Message-ID: <801e4f05-6097-4537-9715-2e00a3990f7d@linux.alibaba.com> Date: Tue, 12 Jul 2022 11:00:55 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] hugetlb: fix memoryleak in hugetlb_mcopy_atomic_pte To: Miaohe Lin , akpm@linux-foundation.org, mike.kravetz@oracle.com, songmuchun@bytedance.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220709092629.54291-1-linmiaohe@huawei.com> From: Baolin Wang In-Reply-To: <20220709092629.54291-1-linmiaohe@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657594857; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vdQ83+o8qtic6jp51nwGcn2rM8y/QYudwrjYrzpCVrM=; b=wu9fFa6rHkllhCIbMVdQ77/zvU3ruK92h3HS1vj1sjvkl6MR2iGW15s2sGwf8YvomyA1rs lYob9gfndx0OqsB8hR7uljF55UBoaohyiCWgSeDmZY6uO1MN86n+E1+cOsAVgHaDQOgEez fiv1TBHKg1iKUjlBroAtLzoGsjrywBs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657594857; a=rsa-sha256; cv=none; b=Do7q3Z3LsJZ7l5gmD1LmMiz1SaZNDdj00BEOzu0cYVHm2s22kKcNDnedgZ6CRvXNti4teG mS8jQrSBL9cuZ9A2fchlXwa36NixRPAn5YJhjw+OFVErqXJtVQUHMJk+NeaYvQWGHJhJ5w ZwLS3rf6AwJsC9zi0sBhAy8ZTKyitPU= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=alibaba.com; spf=pass (imf26.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.131 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com X-Stat-Signature: j5tmph6th9bh3e7oroa7apdi71hza776 X-Rspam-User: Authentication-Results: imf26.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=alibaba.com; spf=pass (imf26.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.131 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: CF31E140060 X-HE-Tag: 1657594855-992549 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 7/9/2022 5:26 PM, Miaohe Lin wrote: > When alloc_huge_page fails, *pagep is set to NULL without put_page first. > So the hugepage indicated by *pagep is leaked. > > Fixes: 8cc5fcbb5be8 ("mm, hugetlb: fix racy resv_huge_pages underflow on UFFDIO_COPY") > Signed-off-by: Miaohe Lin Reviewed-by: Baolin Wang > --- > mm/hugetlb.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index 06c2d86b1ba3..598c37279fee 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -5962,6 +5962,7 @@ int hugetlb_mcopy_atomic_pte(struct mm_struct *dst_mm, > > page = alloc_huge_page(dst_vma, dst_addr, 0); > if (IS_ERR(page)) { > + put_page(*pagep); > ret = -ENOMEM; > *pagep = NULL; > goto out;