From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC081C25B7E for ; Tue, 4 Jun 2024 12:30:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 73B5D6B00C0; Tue, 4 Jun 2024 08:30:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6EB406B00C1; Tue, 4 Jun 2024 08:30:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 564936B00C3; Tue, 4 Jun 2024 08:30:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 398076B00C0 for ; Tue, 4 Jun 2024 08:30:38 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id CE3F1C09CD for ; Tue, 4 Jun 2024 12:30:37 +0000 (UTC) X-FDA: 82193139714.28.58BCAE0 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf08.hostedemail.com (Postfix) with ESMTP id 48695160010 for ; Tue, 4 Jun 2024 12:30:34 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=qrgTBynk; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=0Ec+ki0y; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=qrgTBynk; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=0Ec+ki0y; dmarc=none; spf=pass (imf08.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717504234; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zErFyVpOm9HQgw1H14A/R9liqIrw91yZmlqc+PJt83g=; b=60jIoR3WtweU2ZOuJnXrGAgkAEGk4wUebduqhSwhiRe0jB90CCB0TWThocvTg5Oyq2gHk3 59TbBXL4h+3AeepAUtF4ZyTm0U1u44XMALFCWRj9JeBFZk1P2DVFJuX5PRtwN8YeacA+LP BCrZQExZvJWJPkUAhVkGxO2nWt98K9s= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=qrgTBynk; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=0Ec+ki0y; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=qrgTBynk; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=0Ec+ki0y; dmarc=none; spf=pass (imf08.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717504234; a=rsa-sha256; cv=none; b=tRT6Hv/5rjHkgXYbdG6zI8BBWGQTeJx/kWsxBNhdOLI0LszBHanDrXzuuv8RQ4Rw7LufVG 7XapzjW9N916r2N7qk5Sn944Ix8qpxIvSLtnjT3uIet7zLbmOP5WPMvHQmGhpOEdkSHgai eTsCrpAvLKplqy2INbutt6/RWc+y1dA= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 40CA521A2D; Tue, 4 Jun 2024 12:30:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1717504232; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=zErFyVpOm9HQgw1H14A/R9liqIrw91yZmlqc+PJt83g=; b=qrgTBynk1rz+bSGZ0AN7gFs+BGPSxINZN2NUZllTQbQPweDztAp1VcAxYfYyUSFMqt7o3Q LbOvAH5y0RfkfgA6w1CwcZ2QJ4EKlWDuLX6Ex5e28W/xGolgOZBe2h43uA+WCma9+kRO9Y 0XM59INl5I0UdJDh+836iA+8iMkQtXc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1717504232; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=zErFyVpOm9HQgw1H14A/R9liqIrw91yZmlqc+PJt83g=; b=0Ec+ki0yVEX9DlPztOXV01BcnTwUlK5qtkDLP9WNHN0dz6q+wtmE/Gcrt64UGCcX9B60Ti W9862t943M5F1DCw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1717504232; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=zErFyVpOm9HQgw1H14A/R9liqIrw91yZmlqc+PJt83g=; b=qrgTBynk1rz+bSGZ0AN7gFs+BGPSxINZN2NUZllTQbQPweDztAp1VcAxYfYyUSFMqt7o3Q LbOvAH5y0RfkfgA6w1CwcZ2QJ4EKlWDuLX6Ex5e28W/xGolgOZBe2h43uA+WCma9+kRO9Y 0XM59INl5I0UdJDh+836iA+8iMkQtXc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1717504232; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=zErFyVpOm9HQgw1H14A/R9liqIrw91yZmlqc+PJt83g=; b=0Ec+ki0yVEX9DlPztOXV01BcnTwUlK5qtkDLP9WNHN0dz6q+wtmE/Gcrt64UGCcX9B60Ti W9862t943M5F1DCw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 16BD51398F; Tue, 4 Jun 2024 12:30:32 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id OocIBegIX2auaAAAD6G6ig (envelope-from ); Tue, 04 Jun 2024 12:30:32 +0000 Message-ID: <801d4833-6a29-4134-8ed6-5006d157af88@suse.cz> Date: Tue, 4 Jun 2024 14:30:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/6] mm/slab: Plumb kmem_buckets into __do_kmalloc_node() Content-Language: en-US To: Kees Cook Cc: Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , jvoisin , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-hardening@vger.kernel.org, "GONG, Ruiqi" , Xiu Jianfeng , Suren Baghdasaryan , Kent Overstreet , Jann Horn , Matteo Rizzo , Thomas Graf , Herbert Xu , linux-kernel@vger.kernel.org, netdev@vger.kernel.org References: <20240531191304.it.853-kees@kernel.org> <20240531191458.987345-2-kees@kernel.org> <8c0c4af3-4782-4dbc-b413-e2f3b79c0246@suse.cz> <202406031539.3A465006@keescook> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <202406031539.3A465006@keescook> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspamd-Queue-Id: 48695160010 X-Stat-Signature: b7wrr936ijc3bis7369495zkmxmjnndi X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1717504234-511831 X-HE-Meta: U2FsdGVkX1+zybLS1day+pjgOUtTIoPIfbrak9AlU03wYQnnx/AxGFxuOAIfsbm0c0coraliJbBBNtdhLvogJl9yAe1gDI5qSEysMYEWTi/l1AgxJLxcP6UmxkUZMIU+wa+V/ey0iEZFnVBH1Yna3ATyZdtspkTWFP8u0pCXtQ3rLOmU8vJBHojPtNvROAgWcSYxRyb/+tYH1Z/4qdISQPuKeh1QCT15K4HeL7TxF0l83g5L9WwVHYzw+08kVKdHaOkFAv4hK1rEpua3G2LwBFu7C5rDWgFbthUHvVtftLc0sxT+0wHaRic8jj6SjxV+HjB4yIAk2nPUbcqENy9Df7g2gTVEF6hEE/g8hv0BkdNqvDB0/ewH8tgCtWhGKHD3949AOAbBkpY+187753Q5EYtI2npvFaaK9b1f7fpm81Xxdz1qaJp/yICc5Y6gEsXxJOFEBgtlKYOUJyxmAMOnsnKn6CsyM321zaVzVBSI8dz39o1G9rWdt4eYXXdXx/9MVLSOeuMKeWBQa2K+hYJUWotO3uoRHi4CzU70o9uD0PhcgDWgeksPRIKDbZ6pG12Z8VkbsnLIbjYzc/MhcdYyxNmS9M+Gsh4mltS7/X/00NuvYai17XCmnmYuw7LG1OfIUWBy/PFeUg9r6Z1UxNEdkxr0HZD9TsAsaZFa+6qBs15Ft0J/aFKqAJJK9wv9wW+Y93TcTzFIWBgm96rfwIkMI06E9TrBekilukL+urM4/nxlX2UEzZOjS0hOHvkoJed0H9bdmSd+Nh6w1qvH80dz/TSgHwlzcy56rxaWcBTvdqArd6sQuSjIQJBLOFkj7xuefQly0NHy2tKYLYuQ9n9oN/vD2xEA94K0eguoktByU0Uji/n8x11hpEtqKoSBGpT0OA53ePP5QLXw5ZjtIYoH+gZptLC5XV/9hGmTmBCG5yuwF5iT4gIaCZ4gtw2Zb3v7xd0JdH7zbzThGdysqDm giGqwr1C nR6Z/asaPun8AI/ptL03o7puFb0X6Faj1iN6+MOXKn/Q3CxDw6e+VuBvh4nLa5hamMhXqbSY2bUjGxBu5uRcmwV7KhbvvatBd1sAvUWdoF4ygKFtXmIUPhS3jeQJWsohuUeZjG0ZWb+b4hB3izlXsKykClTgLoxXktgW7z4Uigug4AzM4CQ5CzAxs9bSuMqzBu3LWU4olhoMG/ovR4o8xLOLG8OUv0dLhOwtpwheXCMQGoh4ItS/O2GsyVtWC9lLpxpFy+9vUENKcLu7CVLsVmqcwdrf1F4ZjvSbtIlWZzJx00xGRLRgptnQeK8sxODjwThbhHwOuZ2xRgiabM6RGmc/3AsaLgEeIKG1AzNJWVF/Xv4E19fvoXBxIXG/BXm2dJI7n X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/4/24 12:44 AM, Kees Cook wrote: > On Mon, Jun 03, 2024 at 07:06:15PM +0200, Vlastimil Babka wrote: >> On 5/31/24 9:14 PM, Kees Cook wrote: >> > Introduce CONFIG_SLAB_BUCKETS which provides the infrastructure to >> > support separated kmalloc buckets (in the follow kmem_buckets_create() >> > patches and future codetag-based separation). Since this will provide >> > a mitigation for a very common case of exploits, enable it by default. >> >> Are you sure? I thought there was a policy that nobody is special enough >> to have stuff enabled by default. Is it worth risking Linus shouting? :) > > I think it's important to have this enabled given how common the > exploitation methodology is and how cheap this solution is. Regardless, > if you want it "default n", I can change it. Yeah, I'd just recommend it in the help, noting it has a bit of memory overhead. Defaults are not that important anyway IMHO, either it's distro doing the config, and individually security conscious people should know what they are doing. > > This looks really nice, thank you! This is well aligned with the codetag > followup, which also needs to have "size" be very easy to find (to the > macros can check for compile-time-constant or not). > > I will go work from your branch... Great! > Thanks! > > -Kees >