From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDA2CC2BD09 for ; Sat, 13 Jul 2024 01:21:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7EADE6B0089; Fri, 12 Jul 2024 21:21:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 772B16B0098; Fri, 12 Jul 2024 21:21:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 59F156B0099; Fri, 12 Jul 2024 21:21:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 325706B0089 for ; Fri, 12 Jul 2024 21:21:04 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id C6A3DA415F for ; Sat, 13 Jul 2024 01:21:03 +0000 (UTC) X-FDA: 82332975606.27.FBD7A48 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf03.hostedemail.com (Postfix) with ESMTP id 9197D20016 for ; Sat, 13 Jul 2024 01:21:01 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="H/8qeVwW"; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720833628; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/iL0dvijJhywJqZhh6YxHqmlU8neDjGAit2qrbamF7g=; b=6bAobFsZIGj9S9MNSmYwCou/74JIurynY2hcOjRNouxyMCqCWioUQu0um0WtLYwWPXc6T7 0bfhSOR+QXOcUCQ9lt/LKECtXucn+3elE/ovNFlnophiIM6mrTotWpJRaiVNKuhXufDuzs VlMiBj7/5Uq5QO+02L5XP4C2Y4slEJI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720833628; a=rsa-sha256; cv=none; b=6WdXB8nXzLTyt4peJoQ+NKhROY5bDlHqBxl8GZXibMC6DcASmRL9aqMj6hU8GVBaRb6es1 BoRetDw8240lSPcNSCtvtWstkMvV1bdgS5zYJShP/DKBlPKdJ6D7hU64Gj135FuPaxt67I pQuhcuGqlgNRwFjikdEr5t9KITwpcgQ= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="H/8qeVwW"; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1720833660; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=/iL0dvijJhywJqZhh6YxHqmlU8neDjGAit2qrbamF7g=; b=H/8qeVwWF+gH9Y4/VjvH19R07AOc5+N2si6P0JSrindelMG0kTaVa7OS+E22NT9BZhWYm9 uLWCM9KmCwrT05DKhm96qdH4iYgzeBT7VAeCOJ6uVPo4qvvavRGG6d5CpfXuyIpJs4Hcco 92LzPC3A+MEH9Jk1JqjCEt+aks0zPpc= Received: from mail-oi1-f198.google.com (mail-oi1-f198.google.com [209.85.167.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-355-Q4o4i5f7MAGjpVg2CEf1Sw-1; Fri, 12 Jul 2024 21:20:59 -0400 X-MC-Unique: Q4o4i5f7MAGjpVg2CEf1Sw-1 Received: by mail-oi1-f198.google.com with SMTP id 5614622812f47-3d936a102acso1564154b6e.2 for ; Fri, 12 Jul 2024 18:20:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720833658; x=1721438458; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=/iL0dvijJhywJqZhh6YxHqmlU8neDjGAit2qrbamF7g=; b=jjWszPzJCYPpqKDhMkJeco3MzIQdkAOGMmOVm6jndPdaCGQUqFTDdqWEZ789Ym6Gn1 TX3opmk/Amdc4j1uRMrZTVQASYywR+Y5adveRYyJCvINp9d/Ff0C5funrkP5MeMIa0bX PqV5mUC/H/WpwHjwkwvkXneUKfLijYnKxyFWy4jYNZhH1EWmLS/LE0TsGG5TjCg7mDTz U1KSIMb1ewoG8qjEdI6XKzMq4FF4dU+DLtgK9WMtctxMjC17C7YWz5QiQIsFKnp9SbZ3 lm1HKW3SKJUbWYtMwxizlDvXundVsCpfNbdNl7DKqReAYh531qrzidlsE22tEMM2/TyA otow== X-Gm-Message-State: AOJu0Yzy+ag9dQAc7uxLcajyt+rfbS6wENpxZI1d/lwuIAMvK56s6J9t WfWdlNGTvZzW4TNX+RiBe1CxEONpXpE1fWTiG+iAF1WRV5IyQGefL7mgaeAhL0yFop+298CXIpi ENYeYkDFTdcsg7n7DkzdteYQ9CUqRi++wJBBo51KX75Jiw0zW X-Received: by 2002:a05:6808:16a8:b0:3d9:1dfd:d79a with SMTP id 5614622812f47-3d93c014e65mr14870367b6e.20.1720833658630; Fri, 12 Jul 2024 18:20:58 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHwM1KZ3Ckytuh5q+rnuDDvKzvS9TWQso2ZWcE9TuCoNXLEdoSIGRCCXm3q/1jvM2uAYdKVfg== X-Received: by 2002:a05:6808:16a8:b0:3d9:1dfd:d79a with SMTP id 5614622812f47-3d93c014e65mr14870348b6e.20.1720833658226; Fri, 12 Jul 2024 18:20:58 -0700 (PDT) Received: from [172.20.2.228] ([4.28.11.157]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-78e34d2c4edsm66714a12.49.2024.07.12.18.20.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Jul 2024 18:20:57 -0700 (PDT) Message-ID: <801b3438-92e6-4b34-8238-cce67f1899f1@redhat.com> Date: Sat, 13 Jul 2024 03:20:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: huge_memory: use !CONFIG_64BIT to relax huge page alignment on 32 bit machines To: Yang Shi , corsac@debian.org, willy@infradead.org, jirislaby@kernel.org, surenb@google.com, riel@surriel.com, cl@linux.com, carnil@debian.org, ben@decadent.org.uk, akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20240712155855.1130330-1-yang@os.amperecomputing.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240712155855.1130330-1-yang@os.amperecomputing.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 9197D20016 X-Stat-Signature: 5yn1rk5f4cakak41ccpg5gz8cmozyadz X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1720833661-687799 X-HE-Meta: U2FsdGVkX18FJDWYbYXFUENGzfX1ube/RxcHi/Vs+UZgmEzrZwI5ykcNswSOm1v8x0OFR3ZRW7E2+QneFoDdTcuadavORuAi7b7pClEOPaz4gyedQfb+0vcJwbXq8uH0ZDFF2KtdbvqIEugoT4eTy/lIZaj38LFwadkd6XT+xG3t7PffM2QqGFLaEdhLtPk9GwMjNwbJZtpR49zphPKxNSiS0Oo8ut4GGEcwyP9WAQUkrAufPIvNDWIzgLmjTYAMbQNxBR7OYYlZRw1jLK4R3m1hqCcb5STwOyXrgVxkBakBUOViBMPw+iAiD1S6M1nQixDieQRsiSNa2uvY+CQTG+NBfcU7D3QoZ4EDj94n+clU6569tUQfsrVQQMlPVU4PV4M1HOSINcueoAgh0UKrxIZO23cDu9zveVtL9pssshdeAILzD4BgsHPhx7qaJaINPCfULH8OWAQ3bCkkWBR+0q55d+3HR1h5FpX3VFu9aVzWvJ7r2SIPsZH9gLg31b+3jMj06L43YW/VjJqvipMu+eFyVzAj53Z24XZ8zuTTljID/Zot0x2gTtA9B14C31ICNgizTiLI21pFHUeQimeUZ6yMyHfGkzc8zAg5zo6Be/eJDkr2oZAxUvFDEtTtRgRH+hyop6b/zshnZZh50HpC54wsgoBgMJuAkJjv95PbIxsymuQVbc2oBFAeYXAGKI6RQyzjQiaAdJZdK4lpTiJV863ttSn8I/PPGoUOv/o+dtlI8Z+WdzYt00NfaRlNCsQGeQaQ4tpuMN0BtY4oCtAE+PU+JT46kPo3TI0OXLPztPNB2UnvATJW5YMISY3y9mZUoqnANqqodU0pNBPvw/7BXNNuGDaMXdjteoRCytstzGVgo5QXYJa9hHCAnsy0dufg83OBPezalNw2DHxiOlYdkdMME5hzHVQ5SZYDVFw1uhZ0tWV/QY32CiI4d/Qfja46jLVqL3cetr7lSEEz54c qVhY/Ots yC8aMxs41v3KJFsPeQZohsM5V6nk1jzcP+Mu/etLs0Zwsh/0jGjypDUcr/Wiv5ZBfdNRHKWxip54GnzCRd5hmXp94g4hBCVLu3UcHhLMJe+mVsO+gntVBB6cm/jPnvl5ReZAR34D/QxC4lMijmDWRaSPe5csW5ARaGne6rrgETtK+8Xzs2bIoX4Umb67i5LWlEEwhbxHZ4J04RS/G3D1BgpsWpvXa5A4EOR8v6L0QrL4Ec+UXRMXhomzF6nAcTVn1MX+SqWYMVGbGCDxzeEOC1CR7fLLY06tUIbwTKZ5mBQCxGb356xjmYgM99lUwyDjkM+zStiRDMNRR74BYsdD8P+JLIycbkCE7lEbbFIbDXWBJhX/w/NovfWg3QxteSKCHpZ79IjSXA4ctbIj1cJS/B+s4u4XoFreZ1SdOPH1xJVdouHUIW6V7rmtBdm1XYKB0XwhMVMWuLUlfgEVXBAcbRIzEhzxPJH6wLeUjTuT5pf1JwORhE41DUbADk2orJvCACL0/XGGBzGbJUgS+qGHDtN36+fGIKBtyYqdfJSfilWdBqN2Cas17D8Fwo8VHQaduBSg/zAGVYbbpkU5x7i7ywWZJI5AM691W0GK7WyWF4uOwDxUf1isKSb8nHEiHcf7D5YrTw+MSPvBLbqt/C2tPGRqk2vKfTGAthiwk2sy9Ka1wLPpGKJubGRMu/1vKmnFrhP9ZxAAkFI4upXY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000132, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12.07.24 17:58, Yang Shi wrote: > Yves-Alexis Perez reported commit 4ef9ad19e176 ("mm: huge_memory: don't > force huge page alignment on 32 bit") didn't work for x86_32 [1]. It is > because x86_32 uses CONFIG_X86_32 instead of CONFIG_32BIT. > > !CONFIG_64BIT should cover all 32 bit machines. > > [1] https://lore.kernel.org/linux-mm/CAHbLzkr1LwH3pcTgM+aGQ31ip2bKqiqEQ8=FQB+t2c3dhNKNHA@mail.gmail.com/ > > Fixes: 4ef9ad19e176 ("mm: huge_memory: don't force huge page alignment on 32 bit") > Reported-by: Yves-Alexis Perez > Tested-By: Yves-Alexis Perez > Cc: [6.8+] > Signed-off-by: Yang Shi > --- > mm/huge_memory.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index 2120f7478e55..64f00aedf9af 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -857,7 +857,7 @@ static unsigned long __thp_get_unmapped_area(struct file *filp, > loff_t off_align = round_up(off, size); > unsigned long len_pad, ret, off_sub; > > - if (IS_ENABLED(CONFIG_32BIT) || in_compat_syscall()) > + if (!IS_ENABLED(CONFIG_64BIT) || in_compat_syscall()) > return 0; > > if (off_end <= off_align || (off_end - off_align) < size) Acked-by: David Hildenbrand -- Cheers, David / dhildenb