From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9660BC6FD1F for ; Wed, 22 Mar 2023 16:27:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 393CD6B0071; Wed, 22 Mar 2023 12:27:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 36AD66B0072; Wed, 22 Mar 2023 12:27:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 20C3C6B0075; Wed, 22 Mar 2023 12:27:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 101546B0071 for ; Wed, 22 Mar 2023 12:27:06 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id D5DCF1401A1 for ; Wed, 22 Mar 2023 16:27:05 +0000 (UTC) X-FDA: 80597063610.15.D4D0BC5 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf01.hostedemail.com (Postfix) with ESMTP id CF19B40013 for ; Wed, 22 Mar 2023 16:27:03 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="c+U/k0zN"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=miZ1lUmF; spf=pass (imf01.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679502424; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sPf3gy+C+ST6lBwKBIf0DHjU4XxrVv5WH4FZzVHoFDk=; b=PRbC5kOGpGfWEQPoIUOvmWOss1XBUcvvDLXzZ1PCLzqPn356b9hx7Qa5qZ7dxPCFpN/Uo8 EMj2OL/xL4IJSASYZMW95JjtBS4ZzMrZFVVM1CLQeppYcPcgczurArQJbyDavVT0jcIcNZ WRHLmdoAkPezUf0vTvoUb6/Q0udNoYc= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="c+U/k0zN"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=miZ1lUmF; spf=pass (imf01.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679502424; a=rsa-sha256; cv=none; b=6th/VFsAe+QUsBifb7yRt00BucmjravYyL90fy+Ncu3/Zf0oJnuVamAtUwf6JfkGQShRIS 7lTzMQCl1aWq4NR/gf5ahh4NVjTsv3RYE0JoMzaPY20J8YwTjr5JfeHCGosyAzIB7QutAv KEXi0DA/I77v22eNn6y7LdgCR6V1xSU= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 928B720FDA; Wed, 22 Mar 2023 16:27:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1679502422; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sPf3gy+C+ST6lBwKBIf0DHjU4XxrVv5WH4FZzVHoFDk=; b=c+U/k0zNjArhSJC4nSLOEObzjJsvBepOGZeXLsL9ClGbyB2nIHnKL96CDjQT4E6Jgg50BB PloBLci0Ve21wU9cW9BDRyQBeu7kNuTkzDh2VJ7YbkV8/pzmTQFp9DAZqFX7jr3GLVoFmi IeB9Njluar6A9zouxCzjYjqVDqNvWjc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1679502422; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sPf3gy+C+ST6lBwKBIf0DHjU4XxrVv5WH4FZzVHoFDk=; b=miZ1lUmFk0SrifduUnebSgEbatvkjCRDyXQY8tbyBjtLPq+tb+6cXpJwM9bjGfM0P3Q6KI fGCxLsSi8OmYrYAQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5C51213416; Wed, 22 Mar 2023 16:27:02 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id pFWXFVYsG2TibgAAMHmgww (envelope-from ); Wed, 22 Mar 2023 16:27:02 +0000 Message-ID: <801211fd-558c-a07d-e84a-aa7f997d8c92@suse.cz> Date: Wed, 22 Mar 2023 17:27:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v2 08/14] mm: call {ptlock,pgtable}_cache_init() directly from mm_core_init() Content-Language: en-US To: Mike Rapoport , Sergei Shtylyov Cc: Andrew Morton , David Hildenbrand , Doug Berger , Matthew Wilcox , Mel Gorman , Michal Hocko , Thomas Bogendoerfer , linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-mm@kvack.org References: <20230321170513.2401534-1-rppt@kernel.org> <20230321170513.2401534-9-rppt@kernel.org> From: Vlastimil Babka In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: CF19B40013 X-Rspam-User: X-Stat-Signature: hpaw8n9ehtp66k33y3umpdzi7h8zzjcj X-HE-Tag: 1679502423-479074 X-HE-Meta: U2FsdGVkX18hD44PdBv8rQ8iHZ9HlcomrT3wpsD/xh0lX9/Dlj0HvXgoXQKiAHt2AZS32obXWVP8B/s3Et6zPm9KlBdfz7XSAegMkQQgXtHO4ueUg6pmqT++6Ok2YVxkDIiKsFyTFPtZ4lM8gPVEzBkZMdACb40TXZs7rm+zCZRQgC8nd0OXkzkdPNfoOhz79xwjAK+PKunVvCRSvMQnZhBhZ04hoMRxDRy7QCflxyHdGtozw8lyjg3a6UyJpKx1cw6qtNn8hxHMkYJNCM3C+jE5IJsjy1sWTW9mzmh+pF2d+fKY9WgmXVUh0Qa2nZPzqdVFKebhahruSu9hDlD7Xp07leDPP/fj8l0mUcxBu7BVxkELKBcoybDcow0gLnl9/Uy9FIZGfmB+wdS+B3sj+O4SOqvPmG/EjtD9vj173yvebliZKahbetfwBxdkhSl+p+cvvVsfuxGvNYBY/0e6s0lajVH9+mIqJ6U5KviDmxOkF8TMmPZsCqV1XErEkMecdeBYajvabYWbmfwCxMcy/c+CmNVtWT85TM8JxWnNMl7urQwSK42A6FIiHmrwJ/z/3TF6TXkmtbNT+lmq5036jMu0zjuAQ/+DitDIx93pRH/bEHze8beFV/Y2jqh1F8rpkFa3myb/oDIcsf4wzQze7aHkBSRskKEmYw9hYvUMeYybmA9Jxm50/Jtz5hnmKO2RyJDjtAOATlFE8Xyq7JndduTEJgf4aN8ghRdwx60ctz0lk2rzQT3zt/Slrbit0e8TFb6MxVp0ODrRl6AbnaV140zNAwx1DqMSqX8Duz9rAEh5LtoJMmII9DybkZwx/huqh3Bd/YonUg8DF16mjsShRKkCC43OEzeiCsxt92GXAnQJ0nDqnacCHeKxsoZ4IkFQY3vIIHwp112ABRlA/bfjnYpOQRGnr1Sz6xdGNu9b4ABiakYjU4477b2qKzq4/3DhHWR8pxSvJBSRnhnj6M+ hJjNezVJ 58/fXPmiUAFNBWq+Y16H80hEok6Ee6O9C/ZV80bItn2Gt6a3M1WyCGDFlOpxQ8zwKEk/g+QtDlyquqAzM6Q+q2Mc4Iq3M/XyMUQE13wSc82rNP2uxHD+8eA+iZwFej7nBz+yHjcxDf3gB9BsNKiUvql8Kav5UBxgfF5pF7D25RHfd7KHXpRkiumyLEj2ltQqX20B1EsJ9A6hQiuer+ng5xC1rXF2X6K52NxPyajzntL7FmfN4xbMO+OfGbv3eXLaiOoep7KRhOgfVnO8uUv5yLIqP7glc0p0ZUnY/mdZwg7b78NStoEbsY9+xPVyd3PEggfE9C7nS42au2ZNOTUsd8UnsJPKkYsyez4nzF+3jN/0/gzHSoKC1RlovPIDPLqfwI1hH9w4tcAwhrvQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/22/23 11:08, Mike Rapoport wrote: > On Wed, Mar 22, 2023 at 12:06:18PM +0300, Sergei Shtylyov wrote: >> On 3/21/23 8:05 PM, Mike Rapoport wrote: >> >> > From: "Mike Rapoport (IBM)" >> > >> > and drop pgtable_init() as it has no real value and it's name is >> >> Its name. > > oops :) > > Andrew, can you replace this patch with the updated version, please? > > From 52420723c9bfa84aa48f666330e96f9e5b2f3248 Mon Sep 17 00:00:00 2001 > From: "Mike Rapoport (IBM)" > Date: Sat, 18 Mar 2023 13:55:28 +0200 > Subject: [PATCH v3] mm: call {ptlock,pgtable}_cache_init() directly from > mm_core_init() > > and drop pgtable_init() as it has no real value and its name is > misleading. > > Signed-off-by: Mike Rapoport (IBM) Reviewed-by: Vlastimil Babka > --- > include/linux/mm.h | 6 ------ > mm/mm_init.c | 3 ++- > 2 files changed, 2 insertions(+), 7 deletions(-) > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index 2d7f095136fc..c3c67d8bc833 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -2782,12 +2782,6 @@ static inline bool ptlock_init(struct page *page) { return true; } > static inline void ptlock_free(struct page *page) {} > #endif /* USE_SPLIT_PTE_PTLOCKS */ > > -static inline void pgtable_init(void) > -{ > - ptlock_cache_init(); > - pgtable_cache_init(); > -} > - > static inline bool pgtable_pte_page_ctor(struct page *page) > { > if (!ptlock_init(page)) > diff --git a/mm/mm_init.c b/mm/mm_init.c > index bba73f1fb277..f1475413394d 100644 > --- a/mm/mm_init.c > +++ b/mm/mm_init.c > @@ -2584,7 +2584,8 @@ void __init mm_core_init(void) > */ > page_ext_init_flatmem_late(); > kmemleak_init(); > - pgtable_init(); > + ptlock_cache_init(); > + pgtable_cache_init(); > debug_objects_mem_init(); > vmalloc_init(); > /* If no deferred init page_ext now, as vmap is fully initialized */