From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4AE9C433EF for ; Tue, 8 Mar 2022 12:17:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7CC268D0002; Tue, 8 Mar 2022 07:17:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 754048D0001; Tue, 8 Mar 2022 07:17:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5F56D8D0002; Tue, 8 Mar 2022 07:17:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0147.hostedemail.com [216.40.44.147]) by kanga.kvack.org (Postfix) with ESMTP id 487D98D0001 for ; Tue, 8 Mar 2022 07:17:07 -0500 (EST) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id EE1FA824C443 for ; Tue, 8 Mar 2022 12:17:06 +0000 (UTC) X-FDA: 79221118452.30.8DCC40A Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) by imf21.hostedemail.com (Postfix) with ESMTP id 76E111C000C for ; Tue, 8 Mar 2022 12:17:06 +0000 (UTC) Received: by mail-ej1-f47.google.com with SMTP id r13so38819124ejd.5 for ; Tue, 08 Mar 2022 04:17:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=OFA2/eM8lwGnQdw8L8HYozWRTs8bN4HRmWhwr7+OpfQ=; b=dZxiz91cR9d8+CC4dJkv0i2jFfJ9CP0b3NlEsXD6TPHMGYacNdhru2mSELTl8O+6T+ FkPBsspyt6yrQV1UNk0fLDyvuyTBbsyYl6/T/V6x+ZilvnI0NzYTKb6PgY7cnu5zGc3W z8u6cgybLElr2aEZQqTCU+yd3hjzgyX32dfmIm7l1uFqFRVNXPWDahWbmtxQMKSxUF6t mDip2hxkD1fj4trIskXiu0dLQGix1y5LAmHMsfX0r/TW2pyZZX5NoWOICWOAFwOo7IeO jpGsIE8IKRoh4awk7E5UsjXtaPmC6jPN5sC8oetFJ5PMyH0bpwZVfBbDUpiUazI2kL/w rFpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :subject:content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=OFA2/eM8lwGnQdw8L8HYozWRTs8bN4HRmWhwr7+OpfQ=; b=xT5+7MP+Jvvu+zztV+J5WbZlMfsNsn0I3AhPchraKcHzw6DO0bOp/44Tax4iEnWJj7 nSRvZWZDUDjCiHE+cfOHpzyQJMYVxUfDGV+6PyRLqgafxo0jdSI2m1lXaznjS4R/lY+u vupuYKvENH1SIrgKOYsBGJfVbJ2TlrUTj4FjEJwa4S8IU9tCmqvzveJPR//OIqp0Ltdc cWlqu9oomiTK54R8JQ0q9M05a4kECwPX7miGWHM59eswKWWYAjyaf8De8OFr8+ZdwHwm ydni969j6SZyAyDaR9ZFpgSw74HXlrVoV+z3mLIb11DZ0noTADffuvwn2KRE5qt8Xu45 rN5g== X-Gm-Message-State: AOAM530NffvoDhm6De23wKuDDMkZQrcDgOs6CnDvWgZlk9tYgb4WWhwZ S5AF/FbOI97I5B6plbu0SfY= X-Google-Smtp-Source: ABdhPJwE9PU5xJ81uImIisWcDcAXQ3ECFtBqwX9p5ItDnR0zlR5H81k8PeGbgOyJEUFk90ZFZol5QQ== X-Received: by 2002:a17:907:97cc:b0:6da:a8fb:d1db with SMTP id js12-20020a17090797cc00b006daa8fbd1dbmr13315004ejc.267.1646741825187; Tue, 08 Mar 2022 04:17:05 -0800 (PST) Received: from ?IPV6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.googlemail.com with ESMTPSA id r19-20020a17090638d300b006d6e4fc047bsm5886872ejd.11.2022.03.08.04.17.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Mar 2022 04:17:04 -0800 (PST) Message-ID: <800a68f8-fbe0-5980-4290-bdc0ed4d05bd@redhat.com> Date: Tue, 8 Mar 2022 13:17:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v4 01/12] mm/shmem: Introduce F_SEAL_INACCESSIBLE Content-Language: en-US To: Chao Peng , Andy Lutomirski Cc: Steven Price , kvm list , Linux Kernel Mailing List , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, qemu-devel@nongnu.org, Linux API , Jonathan Corbet , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Thomas Gleixner , Ingo Molnar , Borislav Petkov , the arch/x86 maintainers , "H. Peter Anvin" , Hugh Dickins , Jeff Layton , "J . Bruce Fields" , Andrew Morton , Yu Zhang , "Kirill A. Shutemov" , "Nakajima, Jun" , Dave Hansen , Andi Kleen , David Hildenbrand References: <20220118132121.31388-1-chao.p.peng@linux.intel.com> <20220118132121.31388-2-chao.p.peng@linux.intel.com> <619547ad-de96-1be9-036b-a7b4e99b09a6@kernel.org> <20220217130631.GB32679@chaop.bj.intel.com> <2ca78dcb-61d9-4c9d-baa9-955b6f4298bb@www.fastmail.com> <20220223114935.GA53733@chaop.bj.intel.com> <71a06402-6743-bfd2-bbd4-997f8e256554@arm.com> <7cc65bbd-e323-eabb-c576-b5656a3355ac@kernel.org> <20220307132602.GA58690@chaop.bj.intel.com> From: Paolo Bonzini In-Reply-To: <20220307132602.GA58690@chaop.bj.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 76E111C000C X-Stat-Signature: 5t3xrohoru6t4b3wyu5dq73aqt37ae1h Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=dZxiz91c; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (imf21.hostedemail.com: domain of paolo.bonzini@gmail.com designates 209.85.218.47 as permitted sender) smtp.mailfrom=paolo.bonzini@gmail.com X-HE-Tag: 1646741826-876688 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/7/22 14:26, Chao Peng wrote: >> In pseudo-Rust, this is the difference between: >> >> fn convert_to_private(in: &mut Memfd) >> >> and >> >> fn convert_to_private(in: Memfd) -> PrivateMemoryFd >> >> This doesn't map particularly nicely to the kernel, though. > I understand this Rust semantics and the difficulty to handle races. > Probably we should not expose F_SEAL_INACCESSIBLE to userspace, instead > we can use a new in-kernel flag to indicate the same thing. That flag > should be set only when the memfd is created with MFD_INACCESSIBLE. Yes, I like this. Paolo