From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB8BAC3DA49 for ; Fri, 26 Jul 2024 17:18:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1F3726B0095; Fri, 26 Jul 2024 13:18:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1A36E6B0099; Fri, 26 Jul 2024 13:18:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 06A9E6B009A; Fri, 26 Jul 2024 13:18:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D98E76B0095 for ; Fri, 26 Jul 2024 13:18:43 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 905FDC19EA for ; Fri, 26 Jul 2024 17:18:43 +0000 (UTC) X-FDA: 82382563326.20.47606F4 Received: from out-184.mta1.migadu.com (out-184.mta1.migadu.com [95.215.58.184]) by imf12.hostedemail.com (Postfix) with ESMTP id 3A3644000E for ; Fri, 26 Jul 2024 17:18:40 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=xqC8vk6N; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf12.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.184 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722014265; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wxH9k/ZdxavpXvNcMlt8l3fpPkI8Dw8TBK+Fgx//zY0=; b=0xotx8lFlRylxzU4vvKCBssDcaw1DhqHR6fEB/cn/0AM2BBtHhkiC1IE7nvNGtiLfZ60xD L32WYqpvBhlTqdyHEAdWBkEg+1SeTokhvwlcf0qRuP3hAx39ZD4LwX8dC8CdwtNVWgkIS9 68jLWz/cGSLDUvzvsYwkwvdIjJbwo14= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722014265; a=rsa-sha256; cv=none; b=uN1//TT9HMkNUJjGT+O3xnrW7LwDCZ/6Y0mHcCbZLOKIj1uq8/iMUM3yogbS9Q8EpzH5W/ WhZh3sL3pVheYSDT9evEykxQxm1CQsIyN/gj6aRKwCFTsfc2pzSKDoZsnyUQYiIjr0jAsy Lo3kKrwxxzQ4uzM+MwUoKFPRGnS9aC8= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=xqC8vk6N; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf12.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.184 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev Date: Fri, 26 Jul 2024 10:18:31 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1722014318; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wxH9k/ZdxavpXvNcMlt8l3fpPkI8Dw8TBK+Fgx//zY0=; b=xqC8vk6NBpFlPewvvHB0ZVk3Ew/8c7mGK9PL26TplWIca9ZXsrpGMVJda2Qq6U0rV6GiS6 VuZA+52rNnEl4eZ/fv4fVGyh67/eCuFn0pfMZFHCUuX7JHk7WtKX5/Fl744LLCA1lO5HAQ 3d4rZm/8K1cYCLpX5FhpU0P9uAo62pA= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: "T.J. Mercier" Cc: Yosry Ahmed , Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Greg Thelen , Facebook Kernel Team , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH] memcg: expose children memory usage for root Message-ID: <7zijk3p3uw6esihry6d3qqrsahhnxnvvw6aqb56ocgujrj7qwc@f7bileo5sl6x> References: <20240722225306.1494878-1-shakeel.butt@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 3A3644000E X-Stat-Signature: 61rbdhxrhw3qw49ocgtpu7qdktgbwpqb X-Rspam-User: X-HE-Tag: 1722014320-582149 X-HE-Meta: U2FsdGVkX1/AyGKXF4qepdvjgzgNtYV+ZsdtLIEmm5AAZkpoWGR59rNd+E2tPmVtK17Nfp/7emAnblN5rzrDf15w/0SfHRaLOJ6CvAePOTfxLoh6kJFzeIFSXyxAdqJuI3U9UD8kdRXCIRUl6+BqSUYKRBS4oKdQKZtTElkpDuOQIVp/mmYYB4dvVCEJUzRa7Jgb8GM00rzhBQZP2dmL8o+Mlql8nzKFnZY3EOvc9XoL6C0x08hZAGiGAPEa8AJ4pS4SrF+8vTqUjRrp6uC60dvgPzdv8p6m7vwQcdbqJPrNoElcloy19kjeC9V1M9upwX9atENctL6cmav/u6whNcQbyU7BVWFxh8hCQ8FtccxTsc7NZIhnm14EjVLu4kVeqLp4gskCivqoJcUUNRG4g93ATQeOtYBesjp2PoHasSbT80VzZM2TzLRjjcbywOrcl+t8p07kSGmbdyA4bOWwLSHAGCYzIZ/RdBybwI17FHSLSRjHkar4O0EaqmKyaToSrDqF4pWfgCbE7oGm6iCTdqNvXCPKBTnawk6FWvhNltbt4VayNegHFQjDhHMdb1dWnXB5rEkwDctatEhRho/+nlIYB29ZLnbncm/brEbamoUDo9A6feHoii2SFJebgz3tySwQIqJ7IAjCjcmZf4SXbM1nxkPrG0SO5D5SXJCpQBJ+3WIoY9gP/ie+wLjiMu6r1t+WDN+ZfyUQOeCsEymv/3+hRKKQ+PJV6fERlHbqC3r3/MNnOxQlGGXgkWiWoP6qNfM3cFSstKNCW/K/94jRCkbl+QkIwBgq8J2RvQtbS6c+PMLPZNFXirebUDkhtPVE2SAXsq2cqfHBspNA8MNutqDZ9lYvgme+zBPthXq4ECLU4349b0MO1GvW2HILHSigWf9yRIf8k10KrATpnKOHoocluHySNFrTdFw+MckgPXYv441AGMsmtTLCHcItr1DLVG0abLRwAehCUqSQSYK M+yT4HNS whjyz9kn1TPbOWzQC26lv4d1US6WMvzV8+XcdYF0EH414lZgLm0f1yYpvcd69ItyEBU14OQT4e2y4HbXm9IlrnVL5N50Dd9XcupTZb94kL4tjf0NCGOYYg/7WBe46PTRoegxWz/eTczEGwNAZG6ujrp6iX5x9jnZrfF59ToCKS88D1Ts= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jul 26, 2024 at 09:50:49AM GMT, T.J. Mercier wrote: > On Fri, Jul 26, 2024 at 9:26 AM Yosry Ahmed wrote: > > [...] > > > > Oh yeah we already charge the root's page counters hierarchically in > > the upstream kernel, we just do not charge them if the origin of the > > charge is the root itself. > > > > We also have workloads that iterate top-level memcgs to calculate the > > total charged memory, so memory.children_usage for the root memcg > > would help. > > > > As for memory.current, do you have any data about how much memory is > > charged to the root itself? > > Yeah I wonder if we'd be able to see any significant regressions for > stuff that lives there today if we were to start charging it. I can > try running a test with Android next week. I guess try_charge() is the > main thing that would need to change to allow root charges? > It would a bit more involved like allocating objcg for the root and changing memcg_slab_post_alloc_hook() to use root memcg if account flags are not present. There might some changes needed for list_lru and reclaim but I have not looked deeper into it yet.