From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90715C83F17 for ; Mon, 14 Jul 2025 22:48:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1BDEF6B0093; Mon, 14 Jul 2025 18:48:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 195B86B0095; Mon, 14 Jul 2025 18:48:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0ABA36B0096; Mon, 14 Jul 2025 18:48:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id EA36D6B0093 for ; Mon, 14 Jul 2025 18:48:55 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 6E7981D97F5 for ; Mon, 14 Jul 2025 22:48:55 +0000 (UTC) X-FDA: 83664361830.23.5B98BA6 Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) by imf14.hostedemail.com (Postfix) with ESMTP id 7EED8100005 for ; Mon, 14 Jul 2025 22:48:53 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Xs9++ayX; spf=pass (imf14.hostedemail.com: domain of klarasmodin@gmail.com designates 209.85.167.50 as permitted sender) smtp.mailfrom=klarasmodin@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752533333; a=rsa-sha256; cv=none; b=LudMe9GmhTkZi73A5kkQFEU+OoWSrkMQbPYcLAGgt3qdeEsAT5wD/YXr70ec6DdnJ9QE1b 0HZkb1Xd/Vd8mP6R3fafbtGrWJwA1Ye1fkwI80eXxq8588Ascfm15MN0oJWVw/J4RTrQpz vyXgvpnWEpj6E02LNgUuytnkSqwkA8Y= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Xs9++ayX; spf=pass (imf14.hostedemail.com: domain of klarasmodin@gmail.com designates 209.85.167.50 as permitted sender) smtp.mailfrom=klarasmodin@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752533333; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=T92uQF0Sbtu86irFu+lw6khoAaH7Wb2TKMFFWqJI07I=; b=AAHuObyDrn9zmZMP//28lvbtMo8pQqeiyjV1rpB8m4p5Ygjg+iG03L0Jr+Ta6JiwUYgXb+ apY2BzZJ2iZ1EY798EfjTD09FSzuTX2D1HpGY2/5HokPYAs8e0Lq4Aa6N6DTygfIcSPAYz ZfzRlJMPgu823FyNWOFuMyyAlI3mor8= Received: by mail-lf1-f50.google.com with SMTP id 2adb3069b0e04-553be4d2fbfso5355002e87.0 for ; Mon, 14 Jul 2025 15:48:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752533332; x=1753138132; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=T92uQF0Sbtu86irFu+lw6khoAaH7Wb2TKMFFWqJI07I=; b=Xs9++ayX/aUquClE9m0FwOtCEU37/n9Zff93jofDkkMAz+UglXAmohDrg+9gebHWy2 lZXROXfw1OeAymLzWzs9eMCWvFtFLdjBbAxgM9ns3PO3M5hr2cLv+uJlC10t2MrshA0e El9UE9Ig3PmiEHhR3sZnNEYWzcnE+miheMQIVJq56m/Hx3jb3EzrpyE7HtgzDgOfmn53 S3Q8o+n6YXAtuzVQzQR/MAl/4EGjWj4f4YKKiSyRR79DDuOwa6Ccmed+zQvaQbGK0k/o Jr+Ro1FN6Ztfxr4CMJkt4ZR0kI9bdXS7NxsKg4/cXmQtr6nalohhlwYb4h5mgmnxnZ1b Dhgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752533332; x=1753138132; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=T92uQF0Sbtu86irFu+lw6khoAaH7Wb2TKMFFWqJI07I=; b=VzFbB8UzY3AvI21/vL69sJnr4lsVFD64WtP34SUSCI6y/m+rwijnSZJQCcCTv/hSx/ Reac4An25vtRrGvhW0foVfRkljL/WMzb8pXsQWzGdTAYNJZIP5dikGA0RH0JWO70jEN+ HmNaqMDKDPwOaUh43Y/ZeAdektWIcuTlrt+jc37pvUf+mimYVLcT8W51UMxSgMDd9/Ie JnvwdRt55az6XcRyi9OYGgzvOm4PvF1kw3tod0BPAtm3RdFYKZ0gNHEvimlaa7uaLgwo 8rw1RQgydmQrODBKmxOhwA7GYSiZOVryvf/47Ps9bw8bcXf5CiGYLlD/gvdDHGjLPXoB 1wYA== X-Forwarded-Encrypted: i=1; AJvYcCULbyQ1PeLEeMhjRD57yyZ8WFFKYDvthXfdP203250GDFz2AN3QE3Xx53wt3XX+c9uISjaGLGcIKw==@kvack.org X-Gm-Message-State: AOJu0YzUnGxubRvCP5zcRKUuRpBvwdDBD15JO+n97d2aDqT5N/d53z6C cxddusXVK1NmUuVTWX6rDdOpVBaBf5WuRxcmOn2rNs8IBRWTPflmzx7O X-Gm-Gg: ASbGncsrQOP6D/Aj0V2zOhSYL8GSqL9Xfmkel6tVyAqPL+qtHTitqOAcfmfPBWwuOFs GV4RXW3uWoFS/Wo8qCvw5GGSWuf6GI/u+b4gdnsNVhkEfosH2+5u3D17BnxuF93IhTR8rAU3DUL NqiaFDX0rmsO2Og79dYvPwFiReJAu3LKst0bz/jc+aStoGI4YQupOigOwCFgZpbb3p9YzVmPIVr mz4NTig5ghFxTOfDYw1kiNj6l1y6eUo6ns8gRBK9AJmjrWSu2HSgqA/hWq+wQoHnh3RZ9WnTgQn Z6SGkJOHwgoF100yDHB0wRld4ZQk2oVozo/Io0ibdlSKHvsOBtJVJR/f0bVpFV3TkCWNSEphvPp 9ZaLa2+TrTSpsBfYOM+KRRQYZmJgz6EcrwCq+jk36U2zvBB+y X-Google-Smtp-Source: AGHT+IGBUSppvNFOdCzI9M0WJqy9nhMbI/cp4rl4D8ZljJ9yckzvVxpPP3lre5cM+jmiZNJbUr8xUw== X-Received: by 2002:a05:6512:2316:b0:553:35ad:2f2d with SMTP id 2adb3069b0e04-55a044cc87bmr4115868e87.18.1752533331307; Mon, 14 Jul 2025 15:48:51 -0700 (PDT) Received: from localhost (soda.int.kasm.eu. [2001:678:a5c:1202:4fb5:f16a:579c:6dcb]) by smtp.gmail.com with UTF8SMTPSA id 2adb3069b0e04-55943b8c5absm2085832e87.257.2025.07.14.15.48.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Jul 2025 15:48:50 -0700 (PDT) Date: Tue, 15 Jul 2025 00:48:50 +0200 From: Klara Modin To: Andrew Morton Cc: Youling Tang , Matthew Wilcox , Jan Kara , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, chizhiling@163.com, Youling Tang , Chi Zhiling Subject: Re: [PATCH] mm/filemap: Align last_index to folio size Message-ID: <7weonxk3sdq4ysipns5mnv2lmqlb5froca3cblv7ndkv3gzsf7@ncs2qp22tg55> References: <20250711055509.91587-1-youling.tang@linux.dev> <20250714154355.e27c812d71b5968bdd83764c@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250714154355.e27c812d71b5968bdd83764c@linux-foundation.org> X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 7EED8100005 X-Stat-Signature: ysd8bmkof748ddrmimco184m5kh85koo X-HE-Tag: 1752533333-579860 X-HE-Meta: U2FsdGVkX18kbwIzYE7LMjxMELsH692eXZ+4YR+WJNBhJfJPeHZ4UYM4IINjnhlJWzfj+mwnAbTBsDxCSh0G7A6GckDEIMYVqkiHtMvr8nfo6iFzY86vLR/YFEeG+tvmyoC0o6CJc0ySEcwyhZEJHaw+D+ZYEbjrdCOTAQ92wLO18Q7dJ/fryK72Xd22uT+AWGUPgXxEpsuD+EnW39SW/5BTUVi2YQsCLdsMHwqnA+AG2VtFCXyn/nODrmciW0hm6PkOltJgtt0kt3n/iOoAfL0+LRUCvNbSoakRvV42/P7FTYm90KjKJ+igQ6CcE3FSOcVcXpAYAshHMpqwJgZuilx+X/rTTWFRlYYq0vL7BzJT7RmiXWM+VhX02oZPsg3TqsuyQKxJrqC5LigWJBeiKGYs45kB+3HaC2/PikiY+XxYW98yi3ztDtq0erXb2Jh9pjxEHMtHVIb7cuIdG+j1LXywieBk4QR373QCQhCwWiKayqr9MDagCTF/j4eKKKEYQdotXXpfHUfYyxVW8ST3Parhto6DXIVbonH6X7V4L1FtODARQnQHySeDLVDPs9lpXIVN0S+GsUeIwPPhoCO+FF3x/8pbaWn7EdWrqU8m5DHUggEMHdPA7I8Nmk3JnFURB3ydHghCULGHih1Nm+dgfPxT3tP56vHE7IEaTnlHOq1+XFLHMyYLwPnoYProqfoaTrECyYgNP4x4RsvrPov0ZX+SiSGUQEOJUYaYcuVJtJJSj7ZA/BEQHjNU7QqgEPoxvXs2HIDo6Ie+IZAGDQMdohhf52ybd9YR6mw2BvIOus+qcC9dku3vVvJOBb8f8S+gfAqWWazpVHEogyIkE/hXfdHQbOEl9roETuBX9fLPS0cIt6n32VSCnH/C/xBY2MqhaJY+JeNH/KKxdcJCZL7CRMNQppLCZFpX/kNJy+DL6v96Ms7aWoPYYxh+jZlwPjHSRAFDuUXdeZqS6EUTVlF +64/uyva I9rFpeUf/czjHZsHVsD7/UIWpeLo8d5NA5HbfN0UjVr0+hm86S78w4OHTTSDswaT4MQrbMMBbGUNGrz3L9Now1Dnw89OdOu8xj3BPXbrmDswCrjQC0LtXDb3U7+BrTL/+Y1jSj9eRWF0EyMMpkQejJrhk8u60/eUM3xx8CcUPL5c0XH5XlDOglTVypIakIiCAK+w1SuJjhotEs2qKk9KvNiM08lLtBpXo5/rm1tk+5ZSB9z0ZxHcb76yP4dgtAQIQlEsUDJrvaPSqoHXqQllg0MvQ+zf1jfvsrQwMjx4+LkC0a9OnzUZ9/C3nRKGF8SQsT3ZOMWPgXDaiIzdRTX3uDeKIzao5yDKyBFLSYXTUkNU8nCOkzj9loCIUkitLmkFZnH6ElwX6G/4+wdCDmwYOgRTgIA97d05QOE2Z7dK3in5wmQIHFXxXVqP49UUfq/QKBec3iYCfk4h5KSe6lhtA/BvHniIGT5A3KdAmyozG06lf+1x0c755qTJuCWyIdWSZCx+cqzUPt3uqi+7Unxv+IBs7e+qlPybC8UJuwJP5wleTb40= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025-07-14 15:43:55 -0700, Andrew Morton wrote: > On Tue, 15 Jul 2025 00:34:12 +0200 Klara Modin wrote: > > > iocb->ki_pos is loff_t (long long) while pgoff_t is unsigned long and > > this overflow seems to happen in practice, resulting in last_index being > > before index. > > > > The following diff resolves the issue for me: > > > > diff --git a/mm/filemap.c b/mm/filemap.c > > index 3c071307f40e..d2902be0b845 100644 > > --- a/mm/filemap.c > > +++ b/mm/filemap.c > > @@ -2585,8 +2585,8 @@ static int filemap_get_pages(struct kiocb *iocb, size_t count, > > int err = 0; > > > > /* "last_index" is the index of the folio beyond the end of the read */ > > - last_index = round_up(iocb->ki_pos + count, mapping_min_folio_nrbytes(mapping)); > > - last_index >>= PAGE_SHIFT; > > + last_index = round_up(iocb->ki_pos + count, > > + mapping_min_folio_nrbytes(mapping)) >> PAGE_SHIFT; > > retry: > > if (fatal_signal_pending(current)) > > return -EINTR; > > Looks good, thanks. I added your signed-off-by (which I trust is OK?) > and queued this up. Thanks, that's fine: Signed-off-by: Klara Modin