From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20A98CE8E9A for ; Thu, 24 Oct 2024 17:26:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ADAE96B00AB; Thu, 24 Oct 2024 13:26:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A8BAA6B00AC; Thu, 24 Oct 2024 13:26:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 97A5B6B00AD; Thu, 24 Oct 2024 13:26:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 78DC76B00AB for ; Thu, 24 Oct 2024 13:26:25 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id F15CDC13E5 for ; Thu, 24 Oct 2024 17:26:04 +0000 (UTC) X-FDA: 82709174184.22.B394547 Received: from out-171.mta1.migadu.com (out-171.mta1.migadu.com [95.215.58.171]) by imf03.hostedemail.com (Postfix) with ESMTP id 4C7F620007 for ; Thu, 24 Oct 2024 17:26:14 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=pCmhJlLo; spf=pass (imf03.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.171 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729790629; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8R1hlFXC1iEAhNiTAY04zaD5qomPk8wLiMSHdfUvjQA=; b=HMUAr7GKkw1OwuTO4dkpYyp9LNqd6KjoeRONIJu+RSfHqLgDIYZoRu6iWoDpZ5ebN9sV5x hZwpzzWnG2CNiCfum4T57LL0brH7AZnfn6rngKI4UGLjheYRv/f+gVrgsq8XJI1D8evIDJ dAP/san7tuUdisxfU9Vnq5Al+3VdBCo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729790629; a=rsa-sha256; cv=none; b=jlP/bQN2rHuoHuAevQM4Zg/i4bzbFd0/fbKIKHi4tr02vsm1aP8TaLgbe4xScXKTooUejo FVJQbZpylEpjhoQCPEqdQIvk5kyqY315D+6J7ZWMP0wCuvv/LJJHrrXUT1uCeEvoCrKvGU xdW3IXhEb1etyO9F0VPxpytDXgLC44g= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=pCmhJlLo; spf=pass (imf03.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.171 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Date: Thu, 24 Oct 2024 10:26:15 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1729790780; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8R1hlFXC1iEAhNiTAY04zaD5qomPk8wLiMSHdfUvjQA=; b=pCmhJlLo+awlJ1B+3t7IW8LaVA2tC/Qps/pAgSG+bCpusILq+Ruj7SJ7JKPnGAqKrv5PS+ 59E6MzrcspYqHjiGVg8MNQzKvH6jXBn5h4scJe0DSYcr0dPkbgO96SYo2O7IR0U5Bl9L5J BY8u54XjMBQQspmHOK1gwT1Tm9bKv8Q= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Roman Gushchin Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Muchun Song , Hugh Dickins , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org, Meta kernel team Subject: Re: [RFC PATCH 3/3] memcg-v1: remove memcg move locking code Message-ID: <7w4xusjyyobyvacm6ogc3q2l26r2vema5rxlb5oqlhs4hpqiu3@dfbde5arh3rg> References: <20241024065712.1274481-1-shakeel.butt@linux.dev> <20241024065712.1274481-4-shakeel.butt@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Stat-Signature: hnrk3dyf3z6t1kwcb71kn3dja5yisbzz X-Rspamd-Queue-Id: 4C7F620007 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1729790774-654609 X-HE-Meta: U2FsdGVkX1+oPseg+IQKqvAvmTViv6Zlm/CLKUJA08mCiXebWidNyrDEaa3Af18pDiIyQD50U5xctTj0caGXLA05+5NFGymuaffUfntBUsihTRmAmbBcoPceuyC9OEW06ZgL6i5QMr2oWt0dUnMDXw1ZCaEgz7tKigXmkyT9juAOVYB3DbM+EP50LEyYosKQLmDoMNdsv3wEFhRXdpXpmQaHSjfEOela7C/+P60LUUFkZxnQmho2a5Zsi+ZfoWrLt57pqFkGVVte1y4svcx+mMjRaWCFk3FlnwB7ndtmFhD/t1snYQhSzJm4rYZBIF9l5SIGXygVaaOiXEqelZu/Haf+kQYgeVEAIKYkcus7CPgMjMaF6bnCGSk7AAf2RJqruWpB4nB45XRV6/Ay4gN51iIB1w7iTTlOwTCU0+elRaI/GeEZ5mrfNDrGNwik+yKM3o1Y+2ED8eCYQghu2XKXYEaYEIEA0vpq6XBsA60qic7ZrtgV6hZq04UeXn3eac9jgmUzfSbxQ/1kqTfc+wr43EZwJUIxJXt8isK2OLBo4Qezl+IUoGEo11osmaZA/JnETsA0NSw6ScVjr3Sg4SqtZUbk1CEtpdo6CSAt9zA/+0M42SifDCA8d7DV6IndBdHl3jfBCdUhvzkkHFJzhFau6WLbKVViMVZoduZO9HBw/bY7InzX5mfQky5CRAhjDjaWMEsWK97kO3Gh3/NsCrWmTo2ay7RZnCvTNM1mMeDfeon6mUn9EtIwRoq7OPpA27wY2GkKR3CDN2YADsL191TPNx8b+tVuLyxCogY7/5PNJlwPwuVlI7ULf+DHnNG62b5/+TvJF4wJCJviR+vbj1DZe+47avPwJdlg7fzzPCsra07wPXPTpYpG0CrkW702U+0JIxCBuLlTRnbRequ0apboNQd5WIQ7b96/gwXAW3AkQVnbUrUm8hSAPgY+mc/xKMIrQAOo2DIt/7o8yiiW3V1 +UyG45OT Q1nNN3dQuj64pYcBrd8kzeZ2tPgLVKZ2MlgqembIsEI5LRl6e7BsGHvuTfHrG38OvN1/WH/TGXJHp2zM98/2Vpm3L1ZLBKuqDmjlSLFfFF7T1cwqEjXlYp6AQ13FqwxJ+EGXS+FjlrMRtgAXmKU0AhtNqGQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Oct 24, 2024 at 04:50:37PM GMT, Roman Gushchin wrote: > On Wed, Oct 23, 2024 at 11:57:12PM -0700, Shakeel Butt wrote: > > The memcg v1's charge move feature has been deprecated. There is no need > > to have any locking or protection against the moving charge. Let's > > proceed to remove all the locking code related to charge moving. > > > > Signed-off-by: Shakeel Butt > > Reviewed-by: Roman Gushchin Thanks Roman for the review. Based on Michal's question, I am planning to keep the RCU locking in the next version of this patch and folowup with clear understanding where we really need RCU and where we don't.