From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F3AFCA0EDF for ; Fri, 30 Aug 2024 04:15:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B266F6B00B3; Fri, 30 Aug 2024 00:15:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AD5AD6B00B4; Fri, 30 Aug 2024 00:15:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 900846B00B5; Fri, 30 Aug 2024 00:15:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 683646B00B3 for ; Fri, 30 Aug 2024 00:15:39 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 1A609140C98 for ; Fri, 30 Aug 2024 04:15:39 +0000 (UTC) X-FDA: 82507597998.11.45A8321 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf29.hostedemail.com (Postfix) with ESMTP id AAEDB120009 for ; Fri, 30 Aug 2024 04:15:35 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b="ozK/Dm10"; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=UB78ir6u; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=reject) header.from=oracle.com; spf=pass (imf29.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1724991263; a=rsa-sha256; cv=pass; b=10s9wsMxSnv2PMIzR+tvWHxRcX2RFRQGrPU+7nPA6HypZ1536a+awLObN9V07vWjEVrR9N WI9cZGgbKq9qD7ijsoLetFX838qmRQghrGRBIcRmKHPMy/ysnVNg38LNFQu/N0oEZG+f9j YkPN2/n4DKN4j0EhaEW30gLP12R0l4k= ARC-Authentication-Results: i=2; imf29.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b="ozK/Dm10"; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=UB78ir6u; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=reject) header.from=oracle.com; spf=pass (imf29.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724991263; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=d+m/0h3eVQ86HWP4KAEoBaoQiP+Rnsw53uXZG304kzs=; b=cvJQU3QlPbqfNlSua5NZmyVdGwe8vnwCMXvnIzf7DlilpZt3akzBnhe+5erFXpf8Sc16bn E1QznQA15aG6X9FKsLp69aPNZ89BOhyBZyPhKV8X7liY/ouRiY5O7QbgP4WhtMKzlT8XO1 fgZT0tbw1v4eOBmUBCWrSPjUNeu7s/0= Received: from pps.filterd (m0333521.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 47U3LAAv021747; Fri, 30 Aug 2024 04:15:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h= date:from:to:subject:message-id:references:content-type :in-reply-to:mime-version; s=corp-2023-11-20; bh=d+m/0h3eVQ86HWP 4KAEoBaoQiP+Rnsw53uXZG304kzs=; b=ozK/Dm10rKE0d7L0kMSRDoILoE50qEv 9MlyPWtO5sokPuVP7Pv2kL3sZ0Oelu5kLg982Cse8/9l+0x4eydAdfRNSvLnnUKe ThfFZl9EcMFxsqeCu3q6iOL9ifpEPlg7ikBSi1erFgcQ+rvespfDRmUPNU+bclzy FMCzsSlAronq4UIZb8e0dZufMQn6tFsKqeRLJiwkqBF39rnHqBrjADKq40MySE7k 0WTvDWk7h05YWpl/QZIOWzN6dBaV/2RJ5qnA1M6hAzSl25TfTKyIamn0pH4iJdWo OSBKKaYHfzGl4ATAAmKiztEunY5HESwDuS0R+eYB4uYlIUIKYFXy5Lw== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 41b3myr5m3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 30 Aug 2024 04:15:33 +0000 (GMT) Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 47U1QuE2020101; Fri, 30 Aug 2024 04:15:32 GMT Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2172.outbound.protection.outlook.com [104.47.55.172]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 418j8radfk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 30 Aug 2024 04:15:32 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=bTgz4sO9Qi+qD3IFhtmAvzrC3tmSvd4AuhrCstclsCZheMI0LgM1Kh1/s74/ndxxE1VSAtHXgJr3w7dPxl9q2GiHEyfQgReRZgm1aTKAOnSGxkOrj/QJH05FqW36M4dWAInz2JzJ4xXc8HjXiuF/Ya7zKG3I+/1RdMX0shbNtUgpHCsffGdqEUbBijM89+m6K+EqRxDTCsoHr+fwZR+vF4BTMtEj6qJp9iCroWZ1X0te9TLBh/IRkgG+oJLV/MvrowLCrcSZE2FOQzmMLbCDMCOo/sACYvhvcbez27N+4s/8pXwxN1Eq4/5L0l5JS9EndJIHTMP8lvX4bAzVgQ2HLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=d+m/0h3eVQ86HWP4KAEoBaoQiP+Rnsw53uXZG304kzs=; b=kA23bd9ZEjyunuAxhmSPxRn8tQFE88Hu8tDQPG8+FHA/Oo8PtAKHoXYhmqIqaswfp/ydq6FtUmC7laz/3vUlJmxnS/zr+kwjNOwQQI5RHN/s4Y76GtSRqvSBXygFhlcL0Y+hmYBzHX/1jKcqfDfkD6PjEjgCfb2ykfAVKzyDF34uWcZaqpU31/QDBwQ9jl6jrzE0FJGKb0F17WQy4WD1Vf0FxJYGP9cxGkjHWaSuP+xhILCKtpxmqUSwUg2rrpQzzmpd7s+AIFqoMrdKx56Fe7hZuTUtYA5I8XQwlgK4Ajd6vFTrKG4lEagV0UFsKiKkp/SaDRwExduNVaInY3pI3Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=d+m/0h3eVQ86HWP4KAEoBaoQiP+Rnsw53uXZG304kzs=; b=UB78ir6uHUC2LwbzSVfk7CAFx874N2H9dquMbDoJ4HgeiN6RE1G0TxhGNDusmI8QY8apmfci3h6DPRulne2gp0oTCZFyqGAeIXpdU/UyRslhxJbbvA0W0x2pbtaMgJiciM9kjXJS6SmvwIEeBuxMEjwe7ggdoI1cL3flbBRbtEo= Received: from DS0PR10MB7933.namprd10.prod.outlook.com (2603:10b6:8:1b8::15) by LV8PR10MB7752.namprd10.prod.outlook.com (2603:10b6:408:1e7::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7918.20; Fri, 30 Aug 2024 04:15:29 +0000 Received: from DS0PR10MB7933.namprd10.prod.outlook.com ([fe80::2561:85b0:ae8f:9490]) by DS0PR10MB7933.namprd10.prod.outlook.com ([fe80::2561:85b0:ae8f:9490%3]) with mapi id 15.20.7918.019; Fri, 30 Aug 2024 04:15:29 +0000 Date: Fri, 30 Aug 2024 00:15:27 -0400 From: "Liam R. Howlett" To: Wei Yang , akpm@linux-foundation.org, maple-tree@lists.infradead.org, linux-mm@kvack.org Subject: Re: [PATCH v2] maple_tree: cleanup interface descriptions Message-ID: <7vkkt5d27hfv4ff2smdqwom5og6rijwbyc3mnvtlgkqzxgqx4a@dh7cvopzl5mx> Mail-Followup-To: "Liam R. Howlett" , Wei Yang , akpm@linux-foundation.org, maple-tree@lists.infradead.org, linux-mm@kvack.org References: <20240830025648.22224-1-richard.weiyang@gmail.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20240425 X-ClientProxiedBy: YT4PR01CA0019.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:d1::10) To DS0PR10MB7933.namprd10.prod.outlook.com (2603:10b6:8:1b8::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR10MB7933:EE_|LV8PR10MB7752:EE_ X-MS-Office365-Filtering-Correlation-Id: 4fc35e3d-0414-444d-6b48-08dcc8aa61c5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?sQvmTfvP3XeIzax2H9+bb505NMiS1G6C9PjiG7/ru/xWm7hVivi4uRIHsZFE?= =?us-ascii?Q?Jp6ZUHVeZBuMi72iqyPkCvjE3U5zqVQS/rax3wgdgmGnQBshQpL/swGRjJKZ?= =?us-ascii?Q?+KbQHcNGMl069tjg9bJZUgt6oDgtazh13mB5nGv7Hzo+pZcpnZQzgmLNWRG9?= =?us-ascii?Q?PDkJRQmQi5gmoL12gKMrShYjRbuTGIKP9HTeGIdfXpO7o97/LhtpmlFnVxL9?= =?us-ascii?Q?FVRSAWczFkYkwP8VFUZO0dRkxPk2O3KkAtPtsoL6HUSI6acuk9snjcni2HJz?= =?us-ascii?Q?oSkuGlu6BKKShwQGLbyExDSPLOEECl3VkI7632ZEO4q0SgBSJGkA3yGwsQPa?= =?us-ascii?Q?79C2tBF9yiNrts3oP5W78YwMHNL4gr3UvbDidHJbleW6PJBQMpleouL/mpmb?= =?us-ascii?Q?Kf3gh6RqGPwzOxenQzBzqpIooRxiltxqNzUqEzcn/Z4qOG5XRYSH6QqYCDml?= =?us-ascii?Q?1RUEXv03/7s/5sa1eNL1zF34iDlttG1rKjBZ/jyQszmvnzHJToJEZSUNr4aQ?= =?us-ascii?Q?edYkiPGlSi65KdNBWVtYpmuBx25kSGfpWXWivOdFDLvMijB4bM2K2RMo5OAP?= =?us-ascii?Q?cgY3IvvtCQtiMTPpf9J5FDlyEawnkqTcI3oGNfW1fzJfPD3NDdW+KnjYQ4Og?= =?us-ascii?Q?l+xMd4H9wjkTr+d2p2JBXEOfjIoBgSTiT6s9rKCgvtEQjAajfafLlOcIOLi+?= =?us-ascii?Q?wqoCgEXKFRk7vCXf+/BTRQSCsG/nuU09ljk7dR8N9WhYbnCkP879lXCiWtxV?= =?us-ascii?Q?F+WdCRDhUrR10nknlbcOr+w1dVrp4+p59SnKPIqp5eep/UucgXnk86/ESDU4?= =?us-ascii?Q?UGBNavk1vvQIW2BU7Jy21QSpxLUlfM5uG9bbfn27sUm2CUWRVkKofZ/poLtf?= =?us-ascii?Q?P5KMJQH8aq6KyX/TBhZTaeJUTAv+5R+E2oXkmnYGXKBIjU2AAWkMR5GeZ52D?= =?us-ascii?Q?mZ434N9MGoLfI2C0gD3ay9cTFNS74DfqKM8dxBi8J0shfIrGHdAisHJOSU1+?= =?us-ascii?Q?x73DWVFOsc554nsKW/Sv435BOhbEZHvjimUGAt3vvvbIhmHoI1wvNeGvhYFj?= =?us-ascii?Q?1O3kVgqrLXxW06S3NzeURdDtJ4ChzebfobR7UYYC5H2Oz90B+R3H6uFJy6yq?= =?us-ascii?Q?WHgMHXGQvJs1az3t6e8ubKZDGgPsmswv34nQUd1kVe2Ox/p9EX5cn3ghSET8?= =?us-ascii?Q?mL4DkC+uCX5Dg2jELR3sbERZfGfFEtD4AKduwgIOCvwUUJjE12bfOvh4mF1T?= =?us-ascii?Q?Juvwb+gr+lk5Cpwp3Kbj8Fw2ckJe5Uc8vni09GuThRRWfysJPSPSQTYHuiOT?= =?us-ascii?Q?Jbw=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR10MB7933.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?VzvL4M0t2ekfAA1G3kXhLUr9RLOPLEepOiRZWiqefzPkytXeXEevGdobGWCZ?= =?us-ascii?Q?3cg04lL92Xllmdiot3o/g42QfJ5A9GNwQrhmEfFT6l7ifujrMz1dDpBCpYlR?= =?us-ascii?Q?TpNByF0N8NjManwV+VSY72d1f2s/umwJeueNnZjx8Xv97OylR63lwRCL9mCi?= =?us-ascii?Q?4xlw5xS6+hwSJoFjICIXjmdRSU2wy5j1OkRJwwy1L1sVpVm8EGgwfZPkcC7N?= =?us-ascii?Q?RmBZazpGIlSxAnUuWtkhj3xUPNEc+mYvZ8eGGBGs4ZPfqRZebsmITl+dgQiH?= =?us-ascii?Q?atEFQkYHybFDsPUj/0SeXz2a/ENPuPXDXYJzMV/IcSdLEgyUrNYQi1NF73kG?= =?us-ascii?Q?ET50DPydXcoUH3jymvLqyusxwM3LBLQhS32jwoaaD6vzfLE+r5NF9DjvcJQ5?= =?us-ascii?Q?R20mi1A//PgjJAX1b4jJ+uNvqsPmlwmM1BMzjAsWq70rd2nLJ1G1i8SVBhZj?= =?us-ascii?Q?pDFmlol9cFcW6YhndUaxnjF68plxZ6IGTRR6hymmnMxMZtDAiR7bXt9AB+h1?= =?us-ascii?Q?MxXQG1l6oFBub6OXhz+aByOqu6nYeiPjSBlcAeXoV+y+ZpsL6TZTjkB3+fMY?= =?us-ascii?Q?f07lZH7WX0nu6LuiwleMK6CcRPQWaIx7DgzQHGkuYD8SXUyrpZqHTXkyj+ya?= =?us-ascii?Q?qZzs2Nko+Pnlbol8qobCon8TFGFjStJQjPBS68Eii4U0JHIaDQKH9Dy7tj8q?= =?us-ascii?Q?2sa85utATJPdxXZjzD4USK2pkhJ6nabEfZC7M4BvP2z/Ug6m5i350eo6RwFf?= =?us-ascii?Q?GQ7yiI9JAZYyc6jhzExFgmXETnH3ruXJRBz9ydbQkdn0wlZFyV9iZ9LBEjr3?= =?us-ascii?Q?Zu0udgu3ddK5g/DE0SDQcpZfldQ86ZNA90NPtrcM4A5qovDv9av5UGGAa9z2?= =?us-ascii?Q?Gln1WPtuTX2uxUw3TTNJF0iwoVGTmQjFt40+SSobniGgN10AebgalvI7JFtf?= =?us-ascii?Q?/4Gh8LwaVFVHvLyvydd+nqMZHM7o50ews7K6bJorX9dQW60ek5U0Jg8ymCHH?= =?us-ascii?Q?XFXRUpt4z4+SNA3MY/Jc/CTzL3lgZKQre9OLy3ckxFOxh1pkAcIGbsw586HW?= =?us-ascii?Q?6XD2VI1cnnPUVQ0mr2CklZNMSmfZVYDYDktXaRTY2koQ+YLDGAW6MKv6OOfb?= =?us-ascii?Q?zDfSlGOhaB2davRuVJetVx/W/2gadD3szzW3JiiPNI8PiblSRsqWcikj74ZX?= =?us-ascii?Q?UXbEAJ2UtooNkwhDEwfNkqOPhWl6x+pRYLpYrf359aUHqy5f+3uFifTplvV6?= =?us-ascii?Q?pZZEFyXjDEPN1SMJDI7g7n7nVWhQazIwHPs9yX161Ta+s7hQZ10hu77467d+?= =?us-ascii?Q?MTXMTbsJ8/u3XMMjTi8KR8mqarz2HSApc7RQ2jTi98JNDLdbA+76LtHke3Rs?= =?us-ascii?Q?YvqQ3sss05hitlShVhI0JadrE/ek/dXfJ7uqSlxftk2yg3GVcQEaNHDIkQto?= =?us-ascii?Q?CbChExdxIVvlLu9IjuC7UV60lAw7Y2u984EE9zLioaGUpr4jbSTUaXCzz8FF?= =?us-ascii?Q?j7o0yIiOrnOSaI8n/n9VY13pE7/rXTjC8h/d1A1xAtybBi1JtAdhcPZNfZNH?= =?us-ascii?Q?/tTVt3rt5sH/pO35+ufvebPfoVVBAhppNz2P6i7HxY2fly93yHdrhkufw35A?= =?us-ascii?Q?CA=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 8Xrr1xm/neJcQGRPWuQKzva8x+ZIpVJ41pxFuK6aAn8S1hc/OgrjrQ3k270UAuQl/0Xv2GdtFx1WvUl14paTJHWcMW9rZff1DuzNtrltkKwq4Pil15GfEen8LeNB2EgYGdm0Nkk+bLCJl5CvZ1BldJQfQnfBk3BVm5WmJsvSSCcX/JsweOady6cY44emaKYjYTmx3ZsjEzKmSh4qwKi/iJas5srAqE962WQi/JonVzvLtFFthDjt4OZcVlYL3x4v7/ye1Sjg5u1qc10IBMVE2pjtA0EMUy/swRv6ioEGf//H87m6xz+bjcVCzsWraslKnaBXg2L51lww5mifhQI8PFl2tyk57PMsxyRAw8/KwJfI9WJsL5tM0bLY+gvUbU3t/XN1YPTa06ViObr36H3SSSIwQR4c+Pkm1Yf+MKV26WGVGUj4he/bbddg3lnOhRXtiYWN9NhgKAPrnfJ7SS7RznqAIvoD7wYkOhD1XoOpdbS1vbA3sTvEHKMZurq8WB9HuKEOAzGN8tqG0pCZyy+f3lLQBfi2yq/bHeGbMo6RlbLqi8Uep1dQB2ZXP+mUmi+cYOJ2TkISYEk3p0DDTccrfBj2Oi5JcFlfCmJxsXHcwLE= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4fc35e3d-0414-444d-6b48-08dcc8aa61c5 X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB7933.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Aug 2024 04:15:29.1376 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: eiIqKM2oB/5KpIdDGN3s8JhZ5W+ovgyrzaj+2CVQf7cSJu46o56XZXl5EUvPn+my6ygLut9eykTNS9AZ+NhK5g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR10MB7752 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-08-30_02,2024-08-29_02,2024-05-17_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxlogscore=999 adultscore=0 mlxscore=0 spamscore=0 malwarescore=0 phishscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2407110000 definitions=main-2408300029 X-Proofpoint-GUID: 3bwoD1aJPN8ygRRe_OI7X4FErfj2xQfC X-Proofpoint-ORIG-GUID: 3bwoD1aJPN8ygRRe_OI7X4FErfj2xQfC X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: AAEDB120009 X-Stat-Signature: 7wdkrqhy6ofro5bpiksbo8xgfehsi4pb X-Rspam-User: X-HE-Tag: 1724991335-121459 X-HE-Meta: U2FsdGVkX1/DtdgSVlKmnLWsUXTKNrjUqRuKdsE2Z7GobKVYsTR8pu2JD+k/J+1EbWKdAwpikg7EdA5FwImuYZNKekNXHbBdg5A9J3/c6s37HKi6EM9H7OUniR0C0hHtivs+paTQJHAnbaqOwOmEl98c8nMdGQ70DNJMxIG4+EiVxMh9jIQU0YHpWpmHU6AKqentOeAzoj2PQBGA9wj2UsKrMm6gugB5w01vng4Tkrhp1ur8fXZak+KD/RbHvZoVDo7EyjTHDzf3HB2XLJRk15or5foJUVmRMfcZR6bS/CsI627HvHQVPFB1WDvxjZk0YRv3nKhVSSOEJpwO896Gtvm5ZI96yUVHU74k3C0M9WSdlQKccnxh5DaovFNxZl6WTseyEmkQPXmCUU+6+KKyEFgeT7Vg+jsiuNbicMUer+BI7ciEC1+cScoiL8DkkPZPCXjlLxXUkbOeG4DXc9dZyUrVEXyf6o31H5fhaWrkM0Ca6almdnyno7rokw6/Om53DRhd9bXJQiCLUTT0HzvHaj8WaYCfhR+D3Db7wX06n25rz6LyxjRMMp4khBP5xj5V9ySgn8LXreegu+0/esWJOOBCpWBk6b6FhO8CTxbq9aTtUxbPbNLAzdLBSzEo5U0CaupFQeTE25jXfuv+l3D1k9+nIuFoLVuLiFkVu4x8id9wM/y+2Qnj3EPDSZ8GYmoYajM7QxW/Zb3FATWjQrqw5cCtCIs0Po16D4+HNU0hQNUMtZ/7G+cJ7vNVoiUJy6sbxaQVoF0Rt4MfaVrSYTd9pK0xIg9B2P8/KpTmFUs5iqtfaA1fBsyBIfvTQ4egcKPLhlWJkezo39rLByMW5e8tHsnyOafxdRNEqnKSHvbVYnFGEx/U/0iby1VTU+V3NTuKb24yPwNqdbo8M+dH2Ewp3wrFuZFmEq4X5+OVZaGeiuaUyMydTtpeK6b8KD3V1H7Dgr6fiSbCrWjy/jbz4Rz 2foHQlDj fnzeCLkdvjJbhnnHGjoAxhEtrYBa8bsZSvWfGFvfl6Ld67y0/p94fBl5mWEZU73GAe4aMwxCKQjYqUgNB5JM2A+UkTHJFKnJ/TUIpOvnvv1i5l1NNMMUJFmdcN9dPJMYFuRvZOx9x9JFoGXq9RTp/T6jAR5kBK4imT6cMnr8q00SYzxMVlW73FncWJEwU6Ppakm0mMysF7pVxFSPlB+XjFFlrmEYbURUO2hVSGiimBs1EChJLxeV5TFjiCbv+i5TZ8nbdQsZyTA9jap1//OEhdQBW8KpnPrxGxf/V/zTiSdqhxRGKkN6p/NrRGuIA4qxmaEno2im9o2xrJQ4otpQJlfe/z3pigJjCARsCm9PxDrN8Sj21n2VjR7v44jaC04tS2NbmUCdsuuULXKhr+ZuozdS9nEN7HAFyywQMNWmDr5RxYF919oxShUYpaNOFn9lb5E4PtWSAyOUk7iFX7TXo+0T7w/kSj9H/jY0fO96i4Yn1mlJsk1Zbc16LyxWc2Av8SkBTUWDDf2oaURfneufA3zqM9J7wSg6gHGYuBotEWNuHme68OsIcyLeuwn1ECqn3+s/avzYRf0OeXtDomu8kVOxyLRx+5lkzQfBHidgBloyUTTVX2hgy7xMyDHz09O728B1ZQWcYeGbpKYZAHzz2rN/Mj9G4kMelujj3iyWO4gWmwpqWSoQHP5v9nO6hshdXJg84M8egDGc+cPMRPQHWm7Zz/+wDVn7eOeTR X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: * Liam R. Howlett [240830 00:12]: > * Wei Yang [240829 22:57]: > > This patch tries to cleanup some interface description: > > > > * function name mismatch > > * parameter name mismatch > > * parameter all end up with ':' > > * not prefix '*' if parameter is a pointer > > Why not use * if the parameter is a pointer? > > > > > There is still some missing description of parameters, I didn't add them > > since I am not sure the exact meaning. > > > > Signed-off-by: Wei Yang > > --- > > v2: > > * not change them to kernel doc since they are internal interface > > Thanks, since they are not internal interfaces, could you also change > the patch description to state that? Sorry, the description says "interface description" but these are inline functions; so not an interface. > > > --- > > lib/maple_tree.c | 105 +++++++++++++++++++++-------------------------- > > 1 file changed, 47 insertions(+), 58 deletions(-) > > > > diff --git a/lib/maple_tree.c b/lib/maple_tree.c > > index 43e184f91461..a2367564f627 100644 > > --- a/lib/maple_tree.c > > +++ b/lib/maple_tree.c > > @@ -474,6 +474,7 @@ enum maple_type mas_parent_type(struct ma_state *mas, struct maple_enode *enode) > > > > /* > > * mas_set_parent() - Set the parent node and encode the slot > > + * @mas: The maple state > > * @enode: The encoded maple node. > > * @parent: The encoded maple node that is the parent of @enode. > > * @slot: The slot that @enode resides in @parent. > > @@ -534,7 +535,7 @@ unsigned int mte_parent_slot(const struct maple_enode *enode) > > > > /* > > * mte_parent() - Get the parent of @node. > > - * @node: The encoded maple node. > > + * @enode: The encoded maple node. > > * > > * Return: The parent maple node. > > */ > > @@ -641,8 +642,8 @@ static inline unsigned int mas_alloc_req(const struct ma_state *mas) > > > > /* > > * ma_pivots() - Get a pointer to the maple node pivots. > > - * @node - the maple node > > - * @type - the node type > > + * @node: the maple node > > + * @type: the node type > > * > > * In the event of a dead node, this array may be %NULL > > * > > @@ -665,8 +666,8 @@ static inline unsigned long *ma_pivots(struct maple_node *node, > > > > /* > > * ma_gaps() - Get a pointer to the maple node gaps. > > - * @node - the maple node > > - * @type - the node type > > + * @node: the maple node > > + * @type: the node type > > * > > * Return: A pointer to the maple node gaps > > */ > > @@ -880,8 +881,6 @@ static inline void ma_set_meta(struct maple_node *mn, enum maple_type mt, > > * @mt: The maple tree > > * @mn: The maple node > > * @type: The maple node type > > - * @offset: The offset of the highest sub-gap in this node. > > - * @end: The end of the data in this node. > > */ > > static inline void mt_clear_meta(struct maple_tree *mt, struct maple_node *mn, > > enum maple_type type) > > @@ -939,7 +938,7 @@ static inline unsigned char ma_meta_gap(struct maple_node *mn) > > /* > > * ma_set_meta_gap() - Set the largest gap location in a nodes metadata > > * @mn: The maple node > > - * @mn: The maple node type > > + * @mt: The maple node type > > * @offset: The location of the largest gap. > > */ > > static inline void ma_set_meta_gap(struct maple_node *mn, enum maple_type mt, > > @@ -953,8 +952,8 @@ static inline void ma_set_meta_gap(struct maple_node *mn, enum maple_type mt, > > > > /* > > * mat_add() - Add a @dead_enode to the ma_topiary of a list of dead nodes. > > - * @mat - the ma_topiary, a linked list of dead nodes. > > - * @dead_enode - the node to be marked as dead and added to the tail of the list > > + * @mat: the ma_topiary, a linked list of dead nodes. > > + * @dead_enode: the node to be marked as dead and added to the tail of the list > > * > > * Add the @dead_enode to the linked list in @mat. > > */ > > @@ -977,8 +976,8 @@ static void mt_destroy_walk(struct maple_enode *enode, struct maple_tree *mt, > > bool free); > > /* > > * mas_mat_destroy() - Free all nodes and subtrees in a dead list. > > - * @mas - the maple state > > - * @mat - the ma_topiary linked list of dead nodes to free. > > + * @mas: the maple state > > + * @mat: the ma_topiary linked list of dead nodes to free. > > * > > * Destroy walk a dead list. > > */ > > @@ -999,7 +998,7 @@ static void mas_mat_destroy(struct ma_state *mas, struct ma_topiary *mat) > > } > > /* > > * mas_descend() - Descend into the slot stored in the ma_state. > > - * @mas - the maple state. > > + * @mas: the maple state. > > * > > * Note: Not RCU safe, only use in write side or debug code. > > */ > > @@ -1462,7 +1461,7 @@ static inline unsigned char mas_data_end(struct ma_state *mas) > > > > /* > > * mas_leaf_max_gap() - Returns the largest gap in a leaf node > > - * @mas - the maple state > > + * @mas: the maple state > > * > > * Return: The maximum gap in the leaf. > > */ > > @@ -1544,7 +1543,7 @@ static unsigned long mas_leaf_max_gap(struct ma_state *mas) > > * @node: The maple node > > * @gaps: The pointer to the gaps > > * @mt: The maple node type > > - * @*off: Pointer to store the offset location of the gap. > > + * @off: Pointer to store the offset location of the gap. > > * > > * Uses the metadata data end to scan backwards across set gaps. > > * > > @@ -1648,7 +1647,7 @@ static inline void mas_parent_gap(struct ma_state *mas, unsigned long new) > > > > /* > > * mas_update_gap() - Update a nodes gaps and propagate up if necessary. > > - * @mas - the maple state. > > + * @mas: the maple state. > > */ > > static inline void mas_update_gap(struct ma_state *mas) > > { > > @@ -1664,8 +1663,8 @@ static inline void mas_update_gap(struct ma_state *mas) > > /* > > * mas_adopt_children() - Set the parent pointer of all nodes in @parent to > > * @parent with the slot encoded. > > - * @mas - the maple state (for the tree) > > - * @parent - the maple encoded node containing the children. > > + * @mas: the maple state (for the tree) > > + * @parent: the maple encoded node containing the children. > > */ > > static inline void mas_adopt_children(struct ma_state *mas, > > struct maple_enode *parent) > > @@ -1687,8 +1686,8 @@ static inline void mas_adopt_children(struct ma_state *mas, > > /* > > * mas_put_in_tree() - Put a new node in the tree, smp_wmb(), and mark the old > > * node as dead. > > - * @mas - the maple state with the new node > > - * @old_enode - The old maple encoded node to replace. > > + * @mas: the maple state with the new node > > + * @old_enode: The old maple encoded node to replace. > > */ > > static inline void mas_put_in_tree(struct ma_state *mas, > > struct maple_enode *old_enode) > > @@ -1716,8 +1715,8 @@ static inline void mas_put_in_tree(struct ma_state *mas, > > * mas_replace_node() - Replace a node by putting it in the tree, marking it > > * dead, and freeing it. > > * the parent encoding to locate the maple node in the tree. > > - * @mas - the ma_state with @mas->node pointing to the new node. > > - * @old_enode - The old maple encoded node. > > + * @mas: the ma_state with @mas->node pointing to the new node. > > + * @old_enode: The old maple encoded node. > > */ > > static inline void mas_replace_node(struct ma_state *mas, > > struct maple_enode *old_enode) > > @@ -1782,7 +1781,6 @@ static inline void mab_shift_right(struct maple_big_node *b_node, > > /* > > * mab_middle_node() - Check if a middle node is needed (unlikely) > > * @b_node: the maple_big_node that contains the data. > > - * @size: the amount of data in the b_node > > * @split: the potential split location > > * @slot_count: the size that can be stored in a single node being considered. > > * > > @@ -1830,6 +1828,7 @@ static inline int mab_no_null_split(struct maple_big_node *b_node, > > /* > > * mab_calc_split() - Calculate the split location and if there needs to be two > > * splits. > > + * @mas: The maple state > > * @bn: The maple_big_node with the data > > * @mid_split: The second split, if required. 0 otherwise. > > * > > @@ -2156,7 +2155,8 @@ static inline bool mas_next_sibling(struct ma_state *mas) > > } > > > > /* > > - * mte_node_or_none() - Set the enode and state. > > + * mas_node_or_none() - Set the enode and state. > > + * @mas: the maple state > > * @enode: The encoded maple node. > > * > > * Set the node to the enode and the status. > > @@ -2207,7 +2207,6 @@ static inline void mas_wr_node_walk(struct ma_wr_state *wr_mas) > > /* > > * mast_rebalance_next() - Rebalance against the next node > > * @mast: The maple subtree state > > - * @old_r: The encoded maple node to the right (next node). > > */ > > static inline void mast_rebalance_next(struct maple_subtree_state *mast) > > { > > @@ -2221,7 +2220,6 @@ static inline void mast_rebalance_next(struct maple_subtree_state *mast) > > /* > > * mast_rebalance_prev() - Rebalance against the previous node > > * @mast: The maple subtree state > > - * @old_l: The encoded maple node to the left (previous node) > > */ > > static inline void mast_rebalance_prev(struct maple_subtree_state *mast) > > { > > @@ -2372,9 +2370,9 @@ static inline unsigned char mas_mab_to_node(struct ma_state *mas, > > /* > > * mab_set_b_end() - Add entry to b_node at b_node->b_end and increment the end > > * pointer. > > - * @b_node - the big node to add the entry > > - * @mas - the maple state to get the pivot (mas->max) > > - * @entry - the entry to add, if NULL nothing happens. > > + * @b_node: the big node to add the entry > > + * @mas: the maple state to get the pivot (mas->max) > > + * @entry: the entry to add, if NULL nothing happens. > > */ > > static inline void mab_set_b_end(struct maple_big_node *b_node, > > struct ma_state *mas, > > @@ -2393,11 +2391,11 @@ static inline void mab_set_b_end(struct maple_big_node *b_node, > > * mas_set_split_parent() - combine_then_separate helper function. Sets the parent > > * of @mas->node to either @left or @right, depending on @slot and @split > > * > > - * @mas - the maple state with the node that needs a parent > > - * @left - possible parent 1 > > - * @right - possible parent 2 > > - * @slot - the slot the mas->node was placed > > - * @split - the split location between @left and @right > > + * @mas: the maple state with the node that needs a parent > > + * @left: possible parent 1 > > + * @right: possible parent 2 > > + * @slot: the slot the mas->node was placed > > + * @split: the split location between @left and @right > > */ > > static inline void mas_set_split_parent(struct ma_state *mas, > > struct maple_enode *left, > > @@ -2417,11 +2415,11 @@ static inline void mas_set_split_parent(struct ma_state *mas, > > > > /* > > * mte_mid_split_check() - Check if the next node passes the mid-split > > - * @**l: Pointer to left encoded maple node. > > - * @**m: Pointer to middle encoded maple node. > > - * @**r: Pointer to right encoded maple node. > > + * @l: Pointer to left encoded maple node. > > + * @m: Pointer to middle encoded maple node. > > + * @r: Pointer to right encoded maple node. > > * @slot: The offset > > - * @*split: The split location. > > + * @split: The split location. > > * @mid_split: The middle split. > > */ > > static inline void mte_mid_split_check(struct maple_enode **l, > > @@ -2445,10 +2443,10 @@ static inline void mte_mid_split_check(struct maple_enode **l, > > /* > > * mast_set_split_parents() - Helper function to set three nodes parents. Slot > > * is taken from @mast->l. > > - * @mast - the maple subtree state > > - * @left - the left node > > - * @right - the right node > > - * @split - the split location. > > + * @mast: the maple subtree state > > + * @left: the left node > > + * @right: the right node > > + * @split: the split location. > > */ > > static inline void mast_set_split_parents(struct maple_subtree_state *mast, > > struct maple_enode *left, > > @@ -2482,7 +2480,6 @@ static inline void mast_set_split_parents(struct maple_subtree_state *mast, > > /* > > * mas_topiary_node() - Dispose of a single node > > * @mas: The maple state for pushing nodes > > - * @enode: The encoded maple node > > * @in_rcu: If the tree is in rcu mode > > * > > * The node will either be RCU freed or pushed back on the maple state. > > @@ -2614,7 +2611,7 @@ static inline void mas_topiary_replace(struct ma_state *mas, > > /* > > * mas_wmb_replace() - Write memory barrier and replace > > * @mas: The maple state > > - * @old: The old maple encoded node that is being replaced. > > + * @old_enode: The old maple encoded node that is being replaced. > > * > > * Updates gap as necessary. > > */ > > @@ -3505,10 +3502,7 @@ static inline void mas_store_root(struct ma_state *mas, void *entry) > > /* > > * mas_is_span_wr() - Check if the write needs to be treated as a write that > > * spans the node. > > - * @mas: The maple state > > - * @piv: The pivot value being written > > - * @type: The maple node type > > - * @entry: The data to write > > + * @wr_mas: The maple write state > > * > > * Spanning writes are writes that start in one node and end in another OR if > > * the write of a %NULL will cause the node to end with a %NULL. > > @@ -4173,10 +4167,7 @@ static inline void mas_wr_modify(struct ma_wr_state *wr_mas) > > > > /* > > * mas_wr_store_entry() - Internal call to store a value > > - * @mas: The maple state > > - * @entry: The entry to store. > > - * > > - * Return: The contents that was stored at the index. > > + * @wr_mas: The maple write state > > */ > > static inline void mas_wr_store_entry(struct ma_wr_state *wr_mas) > > { > > @@ -4415,9 +4406,8 @@ static int mas_prev_node(struct ma_state *mas, unsigned long min) > > * mas_prev_slot() - Get the entry in the previous slot > > * > > * @mas: The maple state > > - * @max: The minimum starting range > > + * @min: The minimum starting range > > * @empty: Can be empty > > - * @set_underflow: Set the @mas->node to underflow state on limit. > > * > > * Return: The entry in the previous slot which is possibly NULL > > */ > > @@ -4500,6 +4490,7 @@ static void *mas_prev_slot(struct ma_state *mas, unsigned long min, bool empty) > > /* > > * mas_next_node() - Get the next node at the same level in the tree. > > * @mas: The maple state > > + * @node: The maple node > > * @max: The maximum pivot value to check. > > * > > * The next value will be mas->node[mas->offset] or the status will have > > @@ -4590,8 +4581,6 @@ static int mas_next_node(struct ma_state *mas, struct maple_node *node, > > * @mas: The maple state > > * @max: The maximum starting range > > * @empty: Can be empty > > - * @set_overflow: Should @mas->node be set to overflow when the limit is > > - * reached. > > * > > * Return: The entry in the next slot which is possibly NULL > > */ > > @@ -5125,9 +5114,9 @@ EXPORT_SYMBOL_GPL(mas_empty_area_rev); > > > > /* > > * mte_dead_leaves() - Mark all leaves of a node as dead. > > - * @mas: The maple state > > + * @enode: the encoded node > > + * @mt: the maple tree > > * @slots: Pointer to the slot array > > - * @type: The maple node type > > * > > * Must hold the write lock. > > * > > -- > > 2.34.1 > > > > -- > maple-tree mailing list > maple-tree@lists.infradead.org > https://lists.infradead.org/mailman/listinfo/maple-tree