From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 412BDC48BEB for ; Thu, 15 Feb 2024 10:22:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 912D08D0012; Thu, 15 Feb 2024 05:22:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8C0C98D0001; Thu, 15 Feb 2024 05:22:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7886B8D0012; Thu, 15 Feb 2024 05:22:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 603008D0001 for ; Thu, 15 Feb 2024 05:22:11 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id EAE50A2733 for ; Thu, 15 Feb 2024 10:22:10 +0000 (UTC) X-FDA: 81793648020.22.4FB2103 Received: from mout-p-101.mailbox.org (mout-p-101.mailbox.org [80.241.56.151]) by imf20.hostedemail.com (Postfix) with ESMTP id 20ADC1C0026 for ; Thu, 15 Feb 2024 10:22:08 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=vZX1wpbm; spf=pass (imf20.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.151 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707992529; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5NnZTNxId4HvhxligzacqMgIgq+kndcvJz1yu+v6yYk=; b=q4YmVTK9VLeOJgR1CnaXoxStWZZoz4AxW25xJpsg2MmidD2DmvoAE/XLfjNiT2t1nDnuKD p2+rO+VB9ECBUie0RA1khIeIxDnz2sz8aP9wdl0dwm2Rf/Ho3vZaM+nMfutaAeLS8hVfUJ c6WGiTJbNauKmXdQcfFG1RyRRdJZLVA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707992529; a=rsa-sha256; cv=none; b=k1ZGZHQwZHtnsaYEBkGA1oTff4SaI+Blj+arRK1bfwAY/3Abup7e0/La1g7tNweiyXvV7u R9Chp+QVkjBbViv/V/cnTtAl351IMVdAHbLZUyrU0Mnif638VDmWdsUNEdH1VkNTsAOhVA y85V7JrI+i2rkfovclpv6FLNJldsk9I= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=vZX1wpbm; spf=pass (imf20.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.151 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com; dmarc=none Received: from smtp102.mailbox.org (smtp102.mailbox.org [IPv6:2001:67c:2050:b231:465::102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4TbB235Ksfz9sFp; Thu, 15 Feb 2024 11:22:03 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pankajraghav.com; s=MBO0001; t=1707992523; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5NnZTNxId4HvhxligzacqMgIgq+kndcvJz1yu+v6yYk=; b=vZX1wpbmCLAJnNrZn8YjBNNwyEH1MijDqpNW0HmOFv/2dMP2To5fvdAEKKiI25BCKdlU2K ClXREnsKvLn0KWiW3xaaziOE2H4W9e+Lu3O2yGbOCYVZH/Lb/wdQ95AfVX2jW7EfbaRdtt aaYiZ1dl6DqQ3d19wC7B+LrHuEfkdPzIO+IrKwN1jAARaSmb09V3GT6nCyeBN9plKCeP9J USX9UvJJ+1BwbvnqmIa3hsZQpJTvGkLBLysBufbyDmWPRDmhrG6sKEhb5FeJzlfH1d29Qh bZxjewjRaW+zwxwSq/KWdQfo1GVCAQEXrs+qis1WwGuUSBhLECBBJqSzK4g7Sw== Date: Thu, 15 Feb 2024 11:21:58 +0100 From: "Pankaj Raghav (Samsung)" To: Matthew Wilcox Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, mcgrof@kernel.org, gost.dev@samsung.com, akpm@linux-foundation.org, kbusch@kernel.org, djwong@kernel.org, chandan.babu@oracle.com, p.raghav@samsung.com, linux-kernel@vger.kernel.org, hare@suse.de, linux-mm@kvack.org, david@fromorbit.com Subject: Re: [RFC v2 01/14] fs: Allow fine-grained control of folio sizes Message-ID: <7tarfabbkcpxseonoakpirh7kxu6z4jnxwe7lpeyam6ujqfoxu@vkwgt4ykhfwp> References: <20240213093713.1753368-1-kernel@pankajraghav.com> <20240213093713.1753368-2-kernel@pankajraghav.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: g4agkdspr9jjgjjydfo6138ziyo7p591 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 20ADC1C0026 X-Rspam-User: X-HE-Tag: 1707992528-720871 X-HE-Meta: U2FsdGVkX1+0TbjJhurJIwXucfRmktAGIYbfIunyMKUMYzi888K8brUo5zP3VTO2HTTireK8+8TnKD9azJiW7xNlQD6Pc4kL13i4Zx//OAFnWv6qtbzzyF6HNbZE4pxeq7gsg9JUgwTt08ckaKBYEFB9Zm68kgkCA9NEz2KcnLOmnP/jZH59ScqYdCyu3GSHwg2bzioIdX9gHToNyAbWUM/qTZHgAXTtZPF6jIIcsnPlWhlSij5fn4kBazUrO0Q1e0cGBIyuOel+H09q5oMRCxx0wuxgxmC1BTYzd3KHZ9FGQ16eosb1TA5OaN47X1YO7nqfm/t4ciRpftgrskdtmF4TJIJiZZnE8pRV+e3AueTkCFOeSBLD7byGbyYcGvvCpA4UMDq0yVOTRG9i+JmWle5eajlSNOCx883s5tanAbHUXthFkpMooHnE0EnXYPIc1mYusoIbXVZVQIyQb1+ekbmn18AmOIdEWfh6gtCn5NHqaknxHTJRQ8KZYEM/5IoEsG8WwdRoXljCKerE/kvWZzWCvYl9mxU235UvnRu/EgSzc2CNtkJpy/mozZ5eOZsl0ks85t+ezzRu6d+Ed45gQe0xoxVr/Fat5m+HMvC3l3QJZGPo6Jp0ztUI3fx0eUP+BuFS5RX9vp6tROrIZMI9fRNxaUCtMuMy41/Caii3DcxAkXuOhrVEtbn/AXXMbcCj+yDIooeboZ8b49qcwab1KB4Q18uECXvuoOfzMhGM+mjaAy+mM1q5sFm3KotPAR0WSYr8DJIDegCpxGyH533oMwxHO1vjjVbWtA905bd2we4TT0RgeR6Ncdwfw6YD4kyPqjbpv7kuaqp07TXvY+IQo58izHqgqM1a X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Feb 14, 2024 at 06:49:49PM +0000, Matthew Wilcox wrote: > On Tue, Feb 13, 2024 at 10:37:00AM +0100, Pankaj Raghav (Samsung) wrote: > > +static inline void mapping_set_folio_orders(struct address_space *mapping, > > + unsigned int min, unsigned int max) > > +{ > > + if (min == 1) > > + min = 2; > > If you order the "support order-1 folios" patch first, you can drop > these two lines. > Thanks for pointing this out. I actually forgot to update this later in my series. The only failure I was noticing for LBS in 8k block sizes (generic/630) gets fixed by this change as well :) . > > +static inline unsigned int mapping_min_folio_nrpages(struct address_space *mapping) > > I'm not sure if you need this, but it should return unsigned long, not > unsigned int. With 64KiB pages on Arm, a PMD page is 512MiB (order 13) > and a PUD page will be order 26, which is far too close to 2^32 for > my comfort. There were some suggestions from Chinner which might make this function go away. But in case I need it, I will update it to unsigned long to be on the safe side.