From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1A93C02198 for ; Wed, 5 Feb 2025 18:46:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 28E9A280013; Wed, 5 Feb 2025 13:46:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 21804280004; Wed, 5 Feb 2025 13:46:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 06BA1280013; Wed, 5 Feb 2025 13:46:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id D1D7F280004 for ; Wed, 5 Feb 2025 13:46:30 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 3CB0A12091F for ; Wed, 5 Feb 2025 18:46:30 +0000 (UTC) X-FDA: 83086771740.13.AC1AF20 Received: from out-181.mta1.migadu.com (out-181.mta1.migadu.com [95.215.58.181]) by imf06.hostedemail.com (Postfix) with ESMTP id 64D88180017 for ; Wed, 5 Feb 2025 18:46:28 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=LDMufWY0; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf06.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.181 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738781188; a=rsa-sha256; cv=none; b=6pBLCfe1qPFL+ZgkEEiGK+tKjABOs9wpU/akaac3WbWC52wZJk9k3bjA20vEfx4kYLV9Wx pJKMsbNUfpkxrOaBGybQiqK44cdYefC22m3GwJ/wHi+aauaD+ZG2GRz37XoWGW1Zh8ZtNJ Qoj/dSYl7PWnBtWWWoFmEI9lq9MYbcI= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=LDMufWY0; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf06.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.181 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738781188; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3B9HQgB2lIvdMoF93udk/hVUhWsuTPXwL/Y7LyVovXo=; b=IHfncW/cHpPc9ZXY7+xkIPivTwf3QFMVgmK0WAFbUYKRNydxCIvUFEsu7TLCb6P8hT3TMH Lopp7kIrZkh0Ksu5H6b9pSyCW1q+DjvE7AE7bD7N/zgBWxjC+2tgyrDUkSL+Gs/gB6eaIK yjQdXTf8fj0I5iz5+HLVlZX6hwFIXPs= Date: Wed, 5 Feb 2025 10:46:18 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1738781186; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3B9HQgB2lIvdMoF93udk/hVUhWsuTPXwL/Y7LyVovXo=; b=LDMufWY0oZe5avAFVRX64ZYoQyVuQVUR2X6Wdfc81YHSt0wFIuqtPi9ncq36PayNjrTtKE DgmwR1AtGgEtZR0ZKSVqiB8OoYCEPfIxIqcv1967BzVGcWFFPldHbrPaJ0cRyY/MiTKM/B bT8OX7JwOnHt33s3irUY8nZabDq9wYs= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Johannes Weiner Cc: Hamza Mahfooz , linux-mm@kvack.org, Roman Gushchin , Andrew Morton , cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Tejun Heo , Michal =?utf-8?Q?Koutn=C3=BD?= , Michal Hocko , Muchun Song , Allen Pais , Yosry Ahmed Subject: Re: A path forward to cleaning up dying cgroups? Message-ID: <7nqk5crpp7wi65745uiqgpvlomy3cyg3oaimaoz4fg2h4mf7jp@zclymjsovknp> References: <20250205180842.GC1183495@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250205180842.GC1183495@cmpxchg.org> X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 64D88180017 X-Stat-Signature: mpb55h7keydfqjkp697kxe14omksphy5 X-HE-Tag: 1738781188-515109 X-HE-Meta: U2FsdGVkX1//qn5xlmOQHeP0ymzWuiX3SeK82Rn8e7AhWcergvf8Z1pdPhpU53mbjVQrGXuPgmbHq7d59P7VxCDqXyZ8E6vAcaJQMllxEowuuhA4vKBgd78PeoJhTB0hK71JQyL/pbYgGtbVTW6fngryiFFk2yMl2CwN5V96A8JaeBCcZaqjL7tbMgdAVdNLt7ll8yYBl/ya/rfKp18YuGJ3jEeZNwlHY6yjwUg7AW5unBfFfHEuITmVe/tuWB0T9o1GcAMhfva/04wdKtAsyq6RuYq14p9qyoFkhjQL2i3+M+ZFRBOwEQBIiAdtUS+9CXAh05qN4IVdN8wkzon7mYp4eriXEJFis80BykY1e4X82jE3M+vpK1nYMw9UHHCOEZm+d67ffi+Iu93ONW7nE95Dou9miiaY0B0YGM6wwwlZjA/H3A74PpOx1yTA0P0KSj7qPlXnTJyIaAdg+nfqneLs3qM1PJsI2ubpqf4dDu9Kihd4SyowosbITEkNFUYmEatDwrsHtHyRpI5XNzcfLty7ZEzZQ2mCfA0jiR9191EltNJTiKG5nWsyhYGDmasUKa+UgEkQbk9QaDhozCMwS34OVZhEUxJSMBzdOrSyedzCQtlhCq5A34DlGfqOLvNBgWVFtFpprsHx+1JnZ3I1rSkP+aAMQMZLTEToJ08DVmc6h39eocxghAG1sBnqXuKYYkEv7Vs1KgcPD4DRMfs61v8wBTzz0Qm+jVTtv1lS6ZYJSqLdhtN7ufSVRs+16NZjjmTtGdy2+dCNCz37CIu81vcZFg/tAkXchxF4W4Q1c+1NMjqBbjfyrLxYdCMTYguILwiBRDAEhFJC38SeqWx5CGRg/cYYy3M5YsFxv1XEubAqYhrvRulOVUCXk2xHxyDXAVxvP8t72UZt8WBdYRAARF9JzNlBluZbiS4Buuy9uDLLcgMDGYwOA0prTAE3O8kbIKGGBSsHBmjw6IyfXHj f/wFzPRw yjQ8W1AfFsFn1cFHkK4M+c+YJxkreNS+ac5SvH7As5TRIC9Ekw+SJWLTx2QwrFOgoP6NOpIM5gdkCsPMsDD9i8KPM+f6yFu7MCQ761J4Vd0RqAgLN85bFcA4NIbQf0ZsK9KTiLv+gaylSkVzeU9tzIFzrPI34KMn4Oy2cSCCqbGddif6POoDammQVgwVhRGH2Qie9GQgf2jgICpQiZJ7sxjmcz+A6e3CyEOKO X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Feb 05, 2025 at 01:08:42PM -0500, Johannes Weiner wrote: > On Wed, Feb 05, 2025 at 12:50:19PM -0500, Hamza Mahfooz wrote: > > Cc: Shakeel Butt > > > > On 2/5/25 12:48, Hamza Mahfooz wrote: > > > I was just curious as to what the status of the issue described in [1] > > > is. It appears that the last time someone took a stab at it was in [2]. > > If memory serves, the sticking point was whether pages should indeed > be reparented on cgroup death, or whether they could be moved > arbitrarily to other cgroups that are still using them. > > It's a bit unfortunate, because the reparenting patches were tested > and reviewed, and the arbitrary recharging was just an idea that > ttbomk nobody seriously followed up on afterwards. > > We also recently removed the charge moving code from cgroup1, along > with the subtle page access/locking/accounting rules it imposed on the > rest of the MM. I'm doubtful there is much appetite in either camp for > bringing this back. > > So I would still love to see Muchun's patches merged. They fix a > seemingly universally experienced operational issue in memcg, and we > shouldn't hold it up unless somebody actually posts alternative code. > > Thoughts? I think the recharging (or whatever the alternative) can be a followup to this. I agree this is a good change.