From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 476B0C0218F for ; Fri, 31 Jan 2025 17:47:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7A26C6B0092; Fri, 31 Jan 2025 12:47:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 751646B0095; Fri, 31 Jan 2025 12:47:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 57D4F6B0096; Fri, 31 Jan 2025 12:47:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 3AF876B0092 for ; Fri, 31 Jan 2025 12:47:53 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 3456F4757F for ; Fri, 31 Jan 2025 17:47:37 +0000 (UTC) X-FDA: 83068479354.21.2116A4C Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf21.hostedemail.com (Postfix) with ESMTP id D1AEE1C000B for ; Fri, 31 Jan 2025 17:47:33 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=js0mY7nB; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=GpzjCv98; dmarc=pass (policy=reject) header.from=oracle.com; spf=pass (imf21.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1738345653; a=rsa-sha256; cv=pass; b=KNdhfUh+z8BZv0sqbswslNM70hKYzzdWkmVCNI6hsQfVqTIVJ/dqDv100jD1ORzG5dhhYs kcNggDh3VFuG/pivQmvr5s3tIUXhMaMRS3+c4sCutb1o5grq5ZT1MrAOSeQYly7XXbVjXO 5ZIZt/E7Djz/wCB+d4/3Sl/jygy8zaY= ARC-Authentication-Results: i=2; imf21.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=js0mY7nB; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=GpzjCv98; dmarc=pass (policy=reject) header.from=oracle.com; spf=pass (imf21.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738345653; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QY1AaRUWsEUdCXIoPpndBRD6bkmJRPNcOcozCY6/Tl8=; b=u7bzgXZHmzKbcFbf44HDu7SzeiWj7RJE1wBJoJ0bXHBtV8Ix6gHMRQgud42uj/3SVn3GCs 5+kzQlXnFibHvx92sN7lZUIyjiowtbWUHVx2hqXLTBYuhOw3q6bwymSSkzk7Yb8UUO6rg2 npYnxVXNcZrGvkTjXhfp5K23MD/HiLc= Received: from pps.filterd (m0333520.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 50VHBmaO022165; Fri, 31 Jan 2025 17:47:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2023-11-20; bh=QY1AaRUWsEUdCXIoPp ndBRD6bkmJRPNcOcozCY6/Tl8=; b=js0mY7nBshNN8Fe+fkOGL0L/edhFySst1l 7hkGxVgpXJ04s+ZsyPp369VgT2ZwangROp+c2ROxWLSTMiKyL/1qonTcuL/pDX8C 0OqwtqDVFe3bVsKYtcrb36Bd/wNbEWskfl4122E+9xGXLheqETzE/obdAFyWKn0E NeBRKKOAGCO0d4lFYWth8VdK9hGVXz14O241H8J37i/GM8R1yQ6FEwr9k6sUflm1 ChgFlIUwwAxybEko6rw1U+oLiMo9Ae3DJqL2RJz/hP1TyydO1YPaNz4V7NzfmWAW fBaAvje7QLvkz1u1HpEyKRwhn+hJ3kpXfASETVtLZZMM1PbZZdcg== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 44h15t8atm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 31 Jan 2025 17:47:30 +0000 (GMT) Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 50VGnwxw004260; Fri, 31 Jan 2025 17:47:29 GMT Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2171.outbound.protection.outlook.com [104.47.58.171]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 44gfe57u17-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 31 Jan 2025 17:47:29 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=D+yDPjwWXxf55PH0jYGcccDU3L8pJnc2ACjgbs+gDoF/+wEgBghP8QIiojvzczwoMtarOS9cIA/39/eBMHpX1VbEvTGLzglaOumSTg4NHjOsLEXlbkLlk5waa3TYmil6dhTveUj/6BihykNMJmFg3Op8U0ocMns92o69lIz6QqXjFITQB339ZIrq68i35dWEf+ZU+11PyNXjuSQG/RHSribqvr6EkEFIseevDsZGy6JGlxNrVtYgdtXG8Poz+upS5B/K/30+Iwq0RcKUgptVEhdcJjYOC1fXDgv1TmyWUfAZdRS1ObiKO7aM/4qLvG2txwWAWwmlERaoPfau7I6qMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QY1AaRUWsEUdCXIoPpndBRD6bkmJRPNcOcozCY6/Tl8=; b=ncxvwjAVQhLqVOfIm5CjNZxSd3ROC8lvIbb5n6QCi5T9dux5oPF2+sEeiFqStUTnnjx3IrdAXityTzNKI6LTIU7o3Caoqnw7zRsvh1CY/uplNvF7CIojLnSGcWLesohRI6k2gGDFIGe2h1Kd5NkbBwRvgH4xTniOUPEBtG2NjZ/YKUcykyMyXtEURIBkRE3x4Su1tLLiil6HE78Ruaq5ruQ191FpdaDLM+4C7VlG1N3ZN7aFf2XvPIi88/qOhZYRHa4KzyVGV1PbuzSy71CRD7WPLLb5teM6ZtivnSiwnIMfRkTvhYvu/79V4rd4+LOXHhY3SgfubwrnH2SLoQZeOQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QY1AaRUWsEUdCXIoPpndBRD6bkmJRPNcOcozCY6/Tl8=; b=GpzjCv98nXUixZfNVIcIjbBE1bHrX41cb6Jwe3iDewUy85dc47TUfKtxD3aUyTT/q1umIdNJPoTV9iJYLFzp0ZJY6Qv2fe+l3K86wcG6Fk2n9nZZOPhOYHqX4jrb4eEQMAfnygGXd6B1synZawLluCKc6Hz2ReNYRQYDaA0yXuk= Received: from PH0PR10MB5777.namprd10.prod.outlook.com (2603:10b6:510:128::16) by PH7PR10MB7694.namprd10.prod.outlook.com (2603:10b6:510:2e5::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8398.18; Fri, 31 Jan 2025 17:47:27 +0000 Received: from PH0PR10MB5777.namprd10.prod.outlook.com ([fe80::75a8:21cc:f343:f68c]) by PH0PR10MB5777.namprd10.prod.outlook.com ([fe80::75a8:21cc:f343:f68c%4]) with mapi id 15.20.8398.018; Fri, 31 Jan 2025 17:47:27 +0000 Date: Fri, 31 Jan 2025 12:47:24 -0500 From: "Liam R. Howlett" To: Davidlohr Bueso Cc: Lorenzo Stoakes , SeongJae Park , Andrew Morton , David Hildenbrand , Shakeel Butt , Vlastimil Babka , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [RFC PATCH v2 4/4] mm/madvise: remove redundant mmap_lock operations from process_madvise() Message-ID: <7k2gs6xmx2q7la6kle5xpn2p2f6bccbiv5lrdowp5hnecxpijx@rzwxdhcl6mc2> Mail-Followup-To: "Liam R. Howlett" , Davidlohr Bueso , Lorenzo Stoakes , SeongJae Park , Andrew Morton , David Hildenbrand , Shakeel Butt , Vlastimil Babka , linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20250117013058.1843-1-sj@kernel.org> <20250117013058.1843-5-sj@kernel.org> <20250131173132.uqjwrzj7e5vx2sbv@offworld> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250131173132.uqjwrzj7e5vx2sbv@offworld> User-Agent: NeoMutt/20240425 X-ClientProxiedBy: YT4PR01CA0023.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:d1::19) To PH0PR10MB5777.namprd10.prod.outlook.com (2603:10b6:510:128::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR10MB5777:EE_|PH7PR10MB7694:EE_ X-MS-Office365-Filtering-Correlation-Id: 4a78f176-be9f-4b2f-7e23-08dd421f53e8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?kqiZysQvbwwdwPmdqCr1yNOzNnHJwfc8u6WnbU3hHMfzGyy3U/wCYEG9p/gh?= =?us-ascii?Q?ewiqXWTCem5vMsERrjziCgejbUc+N2mVHs8GHD0FF1BJotrBl27B1EFNwqIF?= =?us-ascii?Q?KWoPmdEIwsvbBMaid5r6RurrY+wNcEa66cQuN6vH3Yx0WdOV6O7hFOXJpfIK?= =?us-ascii?Q?fJGC1KVqPffLiEGaeeLZbA3desb1AQxpfa1uejY/LVQlrXbMGnmgkiNjmrHf?= =?us-ascii?Q?qRin0AGmTz+CDrls5LiLuKI9Zp5/NmuutPFcpbMG2y9oQp+G6M0gmG5xHFnN?= =?us-ascii?Q?rhnzSBTwUNRjwclC630O2la0qvgxpvTT30WNhY6ph3/0zm5bfOjBodq+TyZS?= =?us-ascii?Q?FhMfx1hiHMnrjcdF1tP0D7RNR2Jc1Ap1Nctfx19I8oFxM6n9f2Qb70Rd03d+?= =?us-ascii?Q?i80y/v6WjQ+EW5PJ9UnHe8M4BrJRkqEpF/gPcVl1NIFnRdulqkIktpeWYrZF?= =?us-ascii?Q?H6v47+E/heD/8NOOujHPdBapZhP7xLX0dyeArvazn76pSiWpmz9/ld7ZhiJg?= =?us-ascii?Q?+BhZFbj4GQ3HauwqZhbqfBMaia5+q/WpNJ0y0gMIX6j88ClxTLcju8h7zY6U?= =?us-ascii?Q?pWH3VFWWiQb3aBJ9Q7DewmNqVJjQ/GMHNFDaFTFpflwOXO6ZWG7IoevYB/x/?= =?us-ascii?Q?BXElwMyYoetTySWYZg2V937Y0f7DoN5xO89eGVeC5/Sk+mA6dCZ0+TCzjQLQ?= =?us-ascii?Q?8O+BjC33MZcAbGcL+lA2n/o3thxrC35P1EOdRGds41HyBh1yMRc/ofSzHNL2?= =?us-ascii?Q?Zllm3Ob0J1MViYTh5ijt5XBdDlBgrcMK90zM6dFnmyNZ/fFEb84Ak7746QJf?= =?us-ascii?Q?PXZtGXKtCZ3+GQj6CyapzRU7M0QOo+pMpLi01S6lW2Ccxj+WTjLAF+BqY7YT?= =?us-ascii?Q?k2vBQeUbMsOhEPjcIoAtP2RDYVKEjNnr1bItC8L+n48Ba8X/fAFDGqQf64TM?= =?us-ascii?Q?orlgyvv7mn/Lr6oPLNEGF5aQSg4bsI3Eie+ulfdOSe84tkQo0C7SK2BBSED9?= =?us-ascii?Q?0M7IGxc7Cgu71EXj0sIbxcEEnI7nk8njGO+lBHAirZpE/0l9pZNUJ1ejZziI?= =?us-ascii?Q?M6YZtQiagythoKkUC1YysljpQSrRGB9fd0CzBSz5pciFBL0Q02AhbfwucBNu?= =?us-ascii?Q?irhGjWR2LvttZiwUYk+XrWN1E62NFIx2hF0jLZCeJoMGCe8As1yruVZgqcbG?= =?us-ascii?Q?5klL9qoNjLuZ0Swdzzmw/b7a2f1t69LApH/BTdk+SetWuZ52f+GRoLg32mj5?= =?us-ascii?Q?RoPFcXPNsgJ7Tprv2Z6nw4LwZb1KTnLww62TDY6m84v69GpPXy5ZQ8TdYcQr?= =?us-ascii?Q?6Me+ME7joEXnPUUjFiZNXb59KtRo2aY6BYT0xU3431gmaTdEsuw9cJbu3LZd?= =?us-ascii?Q?a8FsAcOKEAc1oxAZidbDBv36EZAq?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR10MB5777.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?/nT7rTsXK76AzgEGDAiR6IaZH/R5Upe18gRqvv/zipwrX84bhlrKsp0UCvig?= =?us-ascii?Q?8v0B/Y8QeFuYxsAfvEuuMPxBbuMBuS6uYQobZiKh9jXXJXFRCWgKfVwy52f/?= =?us-ascii?Q?JuWVHKgIedok8xTVue7SAOI/kjXtWAzJldKrxYTSa59kwI5cVc4A+k13mxee?= =?us-ascii?Q?+rV3q2gQJhRSqamsF8IkMA98Lepd4uXJk0I7liJRse5EIjgCNrZ5Zhg0qpwF?= =?us-ascii?Q?ZHNkzP5+2xilnpoMvenr/q/jkbmCGCT+C56PkKQcQq5BJOT8/o6BpezKDsvK?= =?us-ascii?Q?98t63mtdzChKqSR97mcs/Cx6cYMPug0nKWCgWNZPNcOPkOBNloPUZZBccC7U?= =?us-ascii?Q?D8LPPPOQJzYCybqc4KA3oVaqt2y/3B9W6iasZVgeVMhXfnK0buJzlAD8ihOY?= =?us-ascii?Q?2vRnPdqAIn/dcbaANrV5FARlSNEE/PjSG0PzL4cOROIw6/S18UKRbJVYN/Aw?= =?us-ascii?Q?lwILhJ2xoWpsNjAcmNo5XnhhBRjS11lsfOdrYygwCP/bt+A4rGJui6ZSpOOY?= =?us-ascii?Q?02bIHjoHm0WRshhBB8AQ8061AWwL45+WJnmQe95zKEVoOeoyrA30RDgmK5A3?= =?us-ascii?Q?LSHBvqLQtxgP+LzXrUmZxftl2NT9ZspiTFsLHcoXXjGiVU5J3e6VxZBRnxVK?= =?us-ascii?Q?lRQWrOwAvN4tCQo92LcOdCJAQVqUTPtxPDXrKZtjmHZkggXK7DgoDjS2lfhK?= =?us-ascii?Q?PXk+7ulg8J4zx5GwcMBjnR4IYwzDfqoi6i7yo6BGkHz+4Zb8tpdmGBYbmUAa?= =?us-ascii?Q?yof+aFQLPgZfxxJdEzxoADaNDrp3yx+rQsxba3zAsXzXAEUyXIcGX+L74FNQ?= =?us-ascii?Q?CqbOIAo5U4hPkGSAhx+4ciINlQ8zhmq6QoXuRlBtHwCTCOPYAOBN3MOy9+GA?= =?us-ascii?Q?VaZVyszF3rihQTVHHIA+FE5S+dSeYIXHmtLl5pC3rUVsMwmwx14JyAvmKhv7?= =?us-ascii?Q?OY/R8TA0ucfpe1vfH7cksIviXViKcTHy3I3wIyKvL3affDFmoaj/vLWoKVqV?= =?us-ascii?Q?RDPZYf0jP4sdLvHy5U+0B76a1SkD6a8DCrWzXcOm41S50mX63WWxcIHQxUqQ?= =?us-ascii?Q?c7yggf4BJPd+J+W3xOJ3kzVHtacGw3WavYTYWop9QvXKxBTGXzWlomdea/OJ?= =?us-ascii?Q?US/bP40L1aLRBF31QgxAyAJpgi+31PFfH4kPWv4yT4ErBjL+L3ynWutsS5VL?= =?us-ascii?Q?+GVOumirn1G7R3U7sKxyppksvEgIqOORIkmTMaUbMef66D8U6yBPSIObnu95?= =?us-ascii?Q?NArLs8sKd1vs9vSbnq1PB7CfL3M8+txxRgy3OwOIIzTBrOqnZVmEk5oriLJ1?= =?us-ascii?Q?jL69e88JkLGKStDAl7453PwAhCF4+vlnYBgzjtgtbTnFuuQ7G/oCkU+j4Hkz?= =?us-ascii?Q?H6GnRVbwvQ/0uQmli1L4cfR+mrgtPZWyfADyvUK1I9coGItwPB7LgtVRBhme?= =?us-ascii?Q?q/1LFx5NUTNmtY2zQkNrGiAedFbFpuP6Qx4RaPQOkwRAK9d3OXDC7lCA/iOU?= =?us-ascii?Q?JtUiQG7wxno6cag5F3Cwed4nEkTIPdlJYzE6F4CfjyFAX8O1rTTJOdWuOJBS?= =?us-ascii?Q?ChSwZ7DnFnn8ok3G080Y6Fl655ie2S/OukuxB9F1?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: tm50Wx403Kv++PthJYHrz4hUyOL84EHmyS4vihTLm1tYKMRHdTMacmb/iv0m5EagoQzIc9oobOExaOHiuhd8UOHbA5EyCXVXnxlhDkFjWrfzaCjaB6Kwv8Dp9OIagNJZh5Wx4fg7t02zXaTEe1wR1FY9lFEU1XH25O78FLVEuOwCzKTB+n9czeIFCuRGV968+1fLIZ3LwB5jonnX6GkJNF0o/MEfwnhavXrb8JK7DdHLotVrmojRc2T7H+E7AUhX5XYxqvQ5fw5M0IR60hGSsV3ybwwIgUxPe89HmTZ6v8Rmb2f02Q6tyt7cr0W/ob7kznsVtNOlUVm26WD62fIWkacN5IS9MUgalJ+6brpSSD7CAV9fm/9A/WHlfbrzFtycmURVSsoHIb6nmTDNM356j4n+NRguxw/0daFQN0ZRUDkV85V3HMURwHM2iQuKBKxyIeCkADsig/eYRO5zarVwS0AIE1DzU0BPYq7m/8rxGB3QlVjOhnNtFQay+WEeT1AQdiNXEXZEDkgelp8fsAYQYdrerWakMSrBTmBZMStiozdUo5pBKaHik6FmIiO8xqhCD8Orqt1UvqmY1BsXUkKvy+1Q2qPRFJVMVemNKHlxVdI= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4a78f176-be9f-4b2f-7e23-08dd421f53e8 X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB5777.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2025 17:47:27.7457 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FbrT0XBmJPEv8NhMVw3GxMw9NgJ5N2rNvbqMTOd9kpVgHFTlS+di7uZzchYzDhQT3qVc0p2OzhUZVLbqf/xWYw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB7694 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-01-31_06,2025-01-31_02,2024-11-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 malwarescore=0 spamscore=0 phishscore=0 suspectscore=0 mlxscore=0 mlxlogscore=999 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2501170000 definitions=main-2501310135 X-Proofpoint-GUID: jtT3rOLJAH97lylBMH6N32ibkIWdGV0c X-Proofpoint-ORIG-GUID: jtT3rOLJAH97lylBMH6N32ibkIWdGV0c X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: D1AEE1C000B X-Stat-Signature: pap16s96kbr5jpp54xtq7zrqaxeiaaf1 X-Rspam-User: X-HE-Tag: 1738345653-677819 X-HE-Meta: U2FsdGVkX1+OFdeTPAEfXXaGg6gzFIl1un8RLIefs7GJK/h3iraJFyEMiYU+V8FaRYcmmrdL6rD3m1bttz1RJ+wjVj7ASXCcp9A7yHY45o2RfPNf8NxwH16v/pR+xMNL+lD8OzP0PdQ3UuliIdna+stWrhDlHpjgDYCW9YZOvR0UQ0k0JZGRziWpfUJCJ+8AZ/5Ayg1hilpmoc6uE3dreZxpj8KvlxEdB8s7haWgcAnUdH1d4ggtB6DX1QhaL3af7F6nSY7Iymd9lByP7MmagI5nTMaiEHMeYUREdAmen7eCk1jpzDM3q/klmb+vUNtYDBj3Id35V3DhMb5nMCccxvYaGnKIR/vTeINVxYo3/anp82ApJnI/XOsWr7Q2vr1KvYsH1iE0YoaDm2fbGp0Bzt5BvoqJH2P838dyeyF+mQociISsxpaBEVB875jxcFB+0uqswCYzwc6uC33kB0if+K7KnqGgY572teR+7EbHQZ6smVsGRmN8Ze1d5CL+CU3VsNCuSL6RvmwIWkns7q9xprg+CuXwfIPEHGQkOoXJmBEy8AwLmK4/b1MCkF8PiiatPyfXjF9eyxL3E58FfxqVwr/R6D5yJM9Q44+geaRIHgdlAWny5UBlhRhJsGxxOPl2e1WkTOPZXTcvPOiCtz7SnxbJIRozQzVacblpdVvoQWLf5J/TAZ1sD9SpOPPlNw5qFpMNC39L12nY9f7zbkRBUNrNPV9p/nmfBVgRcV77xw+u5epVcVYR4MIQ/lnQ9qi/U4NtRxkPKi/xk2Oza7beMw81cbxsk1et3yNA5shXGHmclbmkAosJCd4AoSRkwtkyt+ASPYwPb1tNiri5bElDDGjTrfzlSxuXigZC8b2b1vjG3/2uJIGg5nlpJANlLfkAcTxv0AmUJsPmXKKtUoviWzigJVXtvm0eKc3OCX48OubC1On4uVUuomm/nmyDayKAHfC1dA49Xo7qYqnECgj XoV0753S 5E29c04EgDGdJTYjoQg8fQug5O3ECjNWN2V+gy8ylgbzFTFupW7gwYP3JrW+tV4/GivFFnhoLxse5SJj0rRV/21AYFM/LXP2laX34UPC90U/utXPB2kCC2CJ5MfOT2d7i7yoF/D043Mih8qA9+/xiKTYLzm+HJ2mYNWi1W8VKEyXSy7poBbJuj8p1ZvepRHIdy1cFVQbxkpBpmrnmP+QCTDoax58xMyxIaktvVwJ8jkQCpciF9vX3I5oFk2zSuBeTIO6VDBrsRU2ZL9vLRRmyfEXUXuWfa7UfYZ60gmNmODrBHxjaMjoyDsXk4IY+k1BX+0RHE76gIeIsNNbO8t3Xa+qL73SwU+XnXHBnzByShBUTeeyBN3H8wZxjpU0lv4lhspNXBUi8XPSD0c0T9J5ejnzhGkh8qJL0wmLdV1Z6snB7I1JEeXSAZSMICMkT5+H30cbRspxA9ih0EFEjVJ8BAJR8P/hEPolCYJ0l0mGkmBvpuvb4iuY/9svKvSMb8CLd2a/gTNT6FKXjiZ5kvEcC4KhBrOJfmfZ17u7p3JYmCxSOQ3I/3LfFgpYsGutMhDQLupeVofJ/8njmFko8hxYkj//mnBtQZVRdz6+bU4b3Pm9RMoW8cqAca7L25HBKrlyH1CwD6p+dF/J73f3PPCqNyHyqb+yPAB7PTGt/wLk++nnBTHNcj0G7WBoYeg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: * Davidlohr Bueso [250131 12:31]: > On Fri, 31 Jan 2025, Lorenzo Stoakes wrote: > > > On Thu, Jan 16, 2025 at 05:30:58PM -0800, SeongJae Park wrote: > > > Optimize redundant mmap lock operations from process_madvise() by > > > directly doing the mmap locking first, and then the remaining works for > > > all ranges in the loop. > > > > > > Signed-off-by: SeongJae Park > > > > I wonder if this might increase lock contention because now all of the > > vector operations will hold the relevant mm lock without releasing after > > each operation? > > That was exactly my concern. While afaict the numbers presented in v1 > are quite nice, this is ultimately a micro-benchmark, where no other > unrelated threads are impacted by these new hold times. Indeed, I was also concerned about this scenario. But this method does have the added advantage of keeping the vma space in the same state as it was expected during the initial call - although the race does still exist on looking vs acting on the data. This would just remove the intermediate changes. > > > Probably it's ok given limited size of iov, but maybe in future we'd want > > to set a limit on the ranges before we drop/reacquire lock? > > imo, this should best be done in the same patch/series. Maybe extend > the benchmark to use IOV_MAX and find a sweet spot? Are you worried this is over-engineering for a problem that may never be an issue, or is there a particular usecase you have in mind? It is probably worth investigating, and maybe a potential usecase would help with the targeted sweet spot? Thanks, Liam