From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BF10C3601E for ; Thu, 10 Apr 2025 23:58:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 54D00280144; Thu, 10 Apr 2025 19:58:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4F9F9280138; Thu, 10 Apr 2025 19:58:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3C265280144; Thu, 10 Apr 2025 19:58:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 1D529280138 for ; Thu, 10 Apr 2025 19:58:46 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 6F1FF12160B for ; Thu, 10 Apr 2025 23:58:47 +0000 (UTC) X-FDA: 83319801894.19.47D143D Received: from out-173.mta1.migadu.com (out-173.mta1.migadu.com [95.215.58.173]) by imf27.hostedemail.com (Postfix) with ESMTP id 96EBC40009 for ; Thu, 10 Apr 2025 23:58:45 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=p0BYxoby; spf=pass (imf27.hostedemail.com: domain of roman.gushchin@linux.dev designates 95.215.58.173 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744329525; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zS1yfxeRokA8cnGRHyUwOOHvMnk8CAc9VfSUbBB1V4A=; b=7Pus87YOCeruOrsumZiUiEESEz2fe9H8vhXkzuR7VR2Iqr9iKIU/v2jAG9gJAJssXKbCEL A+N9WH5Q2g60TB4ZqNmIGxImp6hhpe9q0jueRXrRhHzzwUKgo2rDx/fZIPvn4PHHazvfy3 n/+NGaLa7IwFE24rjTlfZp4zBocGi9I= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=p0BYxoby; spf=pass (imf27.hostedemail.com: domain of roman.gushchin@linux.dev designates 95.215.58.173 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744329525; a=rsa-sha256; cv=none; b=UIESoXNPUlswkCNZ8QPOlQh/CTKxhshwrSxF3Tuqvn9pSTEiImrwTFGEQTKPjVTAvSptmr 5L7IyoQBJDYX50pbfJXBhBoSBxv1250UZr6tt/ORLEW+y7kqEScMmFYXdf6GiZFIZ06UK6 So0QQAWCLoQk0Pw9rkqhClsnVbXFMQ4= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1744329523; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zS1yfxeRokA8cnGRHyUwOOHvMnk8CAc9VfSUbBB1V4A=; b=p0BYxobykot/O1wR2GbeCtnrfajU9GwzxJ8f8GwbgEBhEu2j91HvknQrz3WTAEJGWGQY6g zi3s3n8fF5qVBdC3Rpfl5HWOFP1d7OnKNrksEfFWnqgk0uXCEgxnOQ92nThJjdQaotRnKG 8ECyojXys5nIuJMOyEDyZaOu/QdiDEA= From: Roman Gushchin To: Muchun Song Cc: hannes@cmpxchg.org, mhocko@kernel.org, shakeel.butt@linux.dev, muchun.song@linux.dev, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] mm: memcontrol: fix swap counter leak from offline cgroup In-Reply-To: <20250410081812.10073-1-songmuchun@bytedance.com> (Muchun Song's message of "Thu, 10 Apr 2025 16:18:12 +0800") References: <20250410081812.10073-1-songmuchun@bytedance.com> Date: Thu, 10 Apr 2025 23:58:38 +0000 Message-ID: <7ia4cydj1scx.fsf@castle.c.googlers.com> MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 96EBC40009 X-Stat-Signature: bcob86uaztwtiby6f35fpcpefxm9ozmn X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1744329525-137526 X-HE-Meta: U2FsdGVkX191bCJjbLxZdUWRjqy0RdwZjQHdlYr72fSSkpYbaNVCmUo+X81ldGSzu7IuV2ZrBTzj/ghwt3Cbg4Dn9kJAtBn5panSQncDAtdq8YQWwlJ9P7ZGTR+XpJNZ1bijSSw2Ls4zsdJMQtC4rEr5RO6tNd7edC8dmXGIaW36/vgmf6sVEiXE7pLInD9s1AN4tXbr0sHpfIQ31g2cN5+7ja9QDyksAV95RDigJ9XsYGIqYLHyJtcGKMPQVwPLk9mniX3L2cRcUEO1mhndeBneqXc/RkTJAuFyvqRxFGgWYa4oJu5T17AGPlps9QJhPn2Ciq4mdjauFn1ZD3+g+8r0RXeGOCwbInt/oB2W8MYdRVmZGDgBTQaCxdcAxPgdiMFjwMhQhsj8++sTkS3Nk2wak2/2NjAukzMBFFV1H+nR2U+zy8jg/Wx/V/ChySi9jRUw8+3An9DFY+oO9CSkIX9FVgVaLhtilJsxQ5BI84G7jIRxxqIdd1P7vWHGgAR511grhUqkYyOEQ/11uYtOG61wSj89liOHqMd+9Uxsuvxm60hXj0CaO2eXLwdrInwDDgvg0Ou9+b3CFLncKoOGQ2ksiYlt/5oTZ1FoeLEa+pw/hhPYVf5O1QgPxyG6aoXRBZRlAqfs4G4gV099tseiSf1X0wPUNXHU3ZIVud5npdkOKEMCncI+Vko/uo5bv7sqQA/PQQt4euBYyj361UiWu3lxzckHStcdF9D9OCfOTZFBGA8gq1y9e2nOHwRARw8FzHQKD0Nx0kXdoMNlrrUXo5+OVsIeutqwdSEVPPt+gRkb2jRvlsEXY7UuSM9nSGy27an8WHkO1E//uNX1XKoDensZGC1J/C9ekd2JmEGNmkXDjsKJoVt4MBHshXWqP5TvlLqKGdVpx5mXWzEb8LZ9WdRpMc6vAPlOKSuyQ/vqOg51x1ZfmcjDLhaX1Q/Xih9NbIVWNKEELbRPQBh3Jjq HUVTD6ju F29IobUhzI/muJ1l/kPZdEjYtovzUMFcDBQulak9CndWgqCj81Ch8xrROxaYs3r2/fvh9WaXgWGhs0dx925gAV8AF9TpJ7mIepUsFEAlE874Y1mNHBnLM2HR/fr8QkRjOzYK50qLo3euvplFF+v6litj9Nw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Muchun Song writes: > The commit 73f839b6d2ed addressed an issue regarding the swap > counter leak that occurred from an offline cgroup. However, the > commit 89ce924f0bd4 modified the parameter from @swap_memcg to > @memcg (presumably this alteration was introduced while resolving > conflicts). Fix this problem by reverting this minor change. > > Fixes: 89ce924f0bd4 ("mm: memcontrol: move memsw charge callbacks to v1") > Signed-off-by: Muchun Song Acked-by: Roman Gushchin Thanks!