From: Dev Jain <dev.jain@arm.com>
To: Pedro Falcato <pfalcato@suse.de>
Cc: akpm@linux-foundation.org, Liam.Howlett@oracle.com,
lorenzo.stoakes@oracle.com, shuah@kernel.org, vbabka@suse.cz,
jannh@google.com, pulehui@huawei.com, linux-mm@kvack.org,
linux-kselftest@vger.kernel.org, aishwarya.tcv@arm.com,
broonie@kernel.org, ryan.roberts@arm.com
Subject: Re: [PATCH] selftests/mm: Add CONFIG_FTRACE to config
Date: Thu, 12 Jun 2025 11:58:21 +0530 [thread overview]
Message-ID: <7ffffef8-d2ff-42ee-8a1a-da208109ac2b@arm.com> (raw)
In-Reply-To: <b46324o3b6rwmda7fu5mc3edv5hy2vow32jeksnjjzotgcbmft@ccxqapirzo7t>
On 11/06/25 6:00 pm, Pedro Falcato wrote:
> On Wed, Jun 11, 2025 at 05:40:11PM +0530, Dev Jain wrote:
>> If CONFIG_UPROBES is not set, a merge subtest fails:
>>
>> Failure log:
>>
>> 7151 12:46:54.627936 # # # RUN merge.handle_uprobe_upon_merged_vma ...
>> 7152 12:46:54.639014 # # f /sys/bus/event_source/devices/uprobe/type
>> 7153 12:46:54.639306 # # fopen: No such file or directory
>> 7154 12:46:54.650451 # # # merge.c:473:handle_uprobe_upon_merged_vma:Expected read_sysfs("/sys/bus/event_source/devices/uprobe/type", &type) (1) == 0 (0)
>> 7155 12:46:54.650730 # # # handle_uprobe_upon_merged_vma: Test terminated by assertion
>> 7156 12:46:54.661750 # # # FAIL merge.handle_uprobe_upon_merged_vma
>> 7157 12:46:54.662030 # # not ok 8 merge.handle_uprobe_upon_merged_vma
>>
>> CONFIG_UPROBES is enabled by CONFIG_UPROBE_EVENTS, which gets enabled by
>> CONFIG_FTRACE. Therefore add this config to selftests/mm/config so that
>> CI systems can include this config in the kernel build.
> While I did consider this before sending my patch, not every architecture
> supports uprobes :/ So this isn't a complete fix.
>
> Also, does every architecture support ftrace? If not (and it does not seem so,
> e.g there's an ARM variant that does not), I would guess this config fragment
> blows up.
Sorry forgot to reply.
What do you mean by "config fragment blows up"? I think scripts will just pull
these configs and build the kernel, and if the config is not supported, it will
be thrown out of .config, and after applying your patch, the test will be skipped,
so everyone is happy I guess?
>
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
next prev parent reply other threads:[~2025-06-12 6:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-11 12:10 Dev Jain
2025-06-11 12:26 ` Aishwarya
2025-06-11 12:30 ` Pedro Falcato
2025-06-12 6:28 ` Dev Jain [this message]
2025-06-12 10:04 ` Pedro Falcato
2025-06-11 12:35 ` Lorenzo Stoakes
2025-06-11 12:51 ` Dev Jain
2025-06-11 12:39 ` Mark Brown
2025-06-11 12:50 ` Dev Jain
2025-06-11 14:01 ` Donet Tom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ffffef8-d2ff-42ee-8a1a-da208109ac2b@arm.com \
--to=dev.jain@arm.com \
--cc=Liam.Howlett@oracle.com \
--cc=aishwarya.tcv@arm.com \
--cc=akpm@linux-foundation.org \
--cc=broonie@kernel.org \
--cc=jannh@google.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=pfalcato@suse.de \
--cc=pulehui@huawei.com \
--cc=ryan.roberts@arm.com \
--cc=shuah@kernel.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox