From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43A57C54798 for ; Fri, 23 Feb 2024 16:43:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CDAA96B0085; Fri, 23 Feb 2024 11:43:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C63716B0087; Fri, 23 Feb 2024 11:43:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AB6C86B0088; Fri, 23 Feb 2024 11:43:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 955546B0085 for ; Fri, 23 Feb 2024 11:43:36 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 60443A1597 for ; Fri, 23 Feb 2024 16:43:36 +0000 (UTC) X-FDA: 81823639632.13.316E4B9 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf07.hostedemail.com (Postfix) with ESMTP id 0B6EE40007 for ; Fri, 23 Feb 2024 16:43:33 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=2OT+Qh3D; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=wLxSkZPx; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=2OT+Qh3D; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=wLxSkZPx; spf=pass (imf07.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708706614; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GE2URHICWI/LHH1AjYAsqoMojZ4QR/fYwJKrudMYFC4=; b=fNEYhnw3EEL1pqvx31wXgBzgDKGhDFfAjOMegYdpu2Jq+cK7S2n3nSmCNKTwB0EdnvCqDf X6MjKPb8yN9/y/K9lhpraDVHwYd+c3elYOxAaSHnlaj75MqlynAeWa6O4ZHxM1r2Mki7uK lJmdK7HRehFkW7N5fi5huNBmdZYU0U0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708706614; a=rsa-sha256; cv=none; b=MYw9MSGUXEVpKmRRCaM/8vUylWsXF34hQMat4j/2rJOAdWr6ZBHtRod8I8IImb8TVZBHYB UrhIVy9IpQgr56q3g4mVEYMgxSL9T0kvEZhMowGd9aYWdf1nG0w7/8cVyurVbfUgVgWbHB GYE+kFyTI+M5y2Nz1GnWdBvjHPMPXXo= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=2OT+Qh3D; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=wLxSkZPx; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=2OT+Qh3D; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=wLxSkZPx; spf=pass (imf07.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 3B54B1FC2A; Fri, 23 Feb 2024 16:43:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1708706612; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GE2URHICWI/LHH1AjYAsqoMojZ4QR/fYwJKrudMYFC4=; b=2OT+Qh3Dw1l1IialP8VVIQUGpW+45Dr2oNVISSa6VKeFNYL3mfP3ALzB+hsc3tNR/lIqwa w5v9s0VnVUo+t8Bx54UHPgBrcGDXgDyqqoqFzYf0XGfJbPC4exZrVd4iooXAm1eytC2X34 tDSVsSqIKDOu3YeZUxocDpN1insDFHM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1708706612; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GE2URHICWI/LHH1AjYAsqoMojZ4QR/fYwJKrudMYFC4=; b=wLxSkZPxuzyDRsvvZZzVgNfBCO5HRlbysOxG3Sit8bfKp6K3JXsozoF++0od0GBzSLKOpi ohpmmz3AbAsqUhAQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1708706612; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GE2URHICWI/LHH1AjYAsqoMojZ4QR/fYwJKrudMYFC4=; b=2OT+Qh3Dw1l1IialP8VVIQUGpW+45Dr2oNVISSa6VKeFNYL3mfP3ALzB+hsc3tNR/lIqwa w5v9s0VnVUo+t8Bx54UHPgBrcGDXgDyqqoqFzYf0XGfJbPC4exZrVd4iooXAm1eytC2X34 tDSVsSqIKDOu3YeZUxocDpN1insDFHM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1708706612; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GE2URHICWI/LHH1AjYAsqoMojZ4QR/fYwJKrudMYFC4=; b=wLxSkZPxuzyDRsvvZZzVgNfBCO5HRlbysOxG3Sit8bfKp6K3JXsozoF++0od0GBzSLKOpi ohpmmz3AbAsqUhAQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 01059133DC; Fri, 23 Feb 2024 16:43:31 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id iOK0OjPL2GWUNAAAD6G6ig (envelope-from ); Fri, 23 Feb 2024 16:43:31 +0000 Message-ID: <7ff66c6a-4127-417b-a71f-a10ab47090b4@suse.cz> Date: Fri, 23 Feb 2024 17:43:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] mm, slab: use an enum to define SLAB_ cache creation flags Content-Language: en-US To: "Christoph Lameter (Ampere)" Cc: Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Zheng Yejian , Xiongwei Song , Chengming Zhou , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com References: <20240220-slab-cleanup-flags-v1-0-e657e373944a@suse.cz> <20240220-slab-cleanup-flags-v1-2-e657e373944a@suse.cz> <8bc31ec7-5d6e-b4c0-9d6e-42849673f35f@linux.com> From: Vlastimil Babka In-Reply-To: <8bc31ec7-5d6e-b4c0-9d6e-42849673f35f@linux.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spamd-Bar: + X-Stat-Signature: s1dmfobkbq3jyhuryft8kp7wm64xatqk X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 0B6EE40007 X-Rspam-User: X-HE-Tag: 1708706613-698207 X-HE-Meta: U2FsdGVkX1/LZYQVbzbTpLWd2K6YDKiwz5wtR7NzBbjtjTG1xLG3h/ICt9KKmTDGSIhts5l2srLckq4HgbFzqcPo2GbZS/gvE+2QVUNJPKzDKxoZtQVNp0Fi8IYSbDdjIUc+aY7q/MNPf7MkqDU65yAl28xBCJDIe9MW3F0SQtaIXrdGG21jVbD+3RsU6vwTQ5wVmO2deRRPx6NK4Gf6ampQFaiU6uq1yH+LffRAbmqvl1LY+Ljn56CZeMK3FgcTvxHdcH7Yy3vqvdRvNLqW3P3IQMKMgkyNl6+LBIjol3ImTmf2VyJhs73370NcGko4z4BZmWRmuTAtbN4hYTZ+0y0aHkSHDiuw0SXoL0rbj3YTrHpBJOMkECXsPcSZz7rrfSIVs6qj6BiAcdoXOIURYngVjm5HNS0aiB1IUKFHEdXd5o9y5EBHFB8bk/qRZKrtzqP1+m0YjYTllG27THTtJgRjNyv0hfroMm4qIfs2t89mGY0VL91ncNG1G8Pl9Xg28FGzNSHUsN3DKyYXCAPS1cNokJdhdXlTo7UIm0XAOdaEzx06zSlTkME0yZEqd5R/GJ7gkk5TlZqcEbcGqGu0NPGEEEiK34Y3d9v1cRe5G/FJjGReas4gDxTRyraCbVlEL3GZ2z+LsdCLp+XtPbg/H6gT8Vm3Eo3RzouC+KcIemNtqIS8HsccJZ99h63X0F9U0UlIjNzkRvHDTAsVSJk5/uCT4f62Kf477E8zVc2Xb21SV/CRhUmsmyvbaGF1vf5H8FXurhMX7Qljvr9MsbsZlg0yYTT8Go/xoQgYcPhqCVcxlGesxOcjscNNHlhS8hoICX32CIZSddlGVN9SpgOyH2Rtpxdt72hVMUGK45rbmBxWeRWY5i8CkqEWMq6IqSghCNEB28cay6XEQ0jm4PcWGGjCtaVaaG+QyoAqNLAkE8/tBwRd545QsuDueGT8pDH2LOdRbAK2Y4wsJovUomH DTvouHzM cKpkV1HjdYk1yiUqugHUjVZk+ape9UcMLGHKRJ03lB87Ly/cFZgQb/K2OoMkKyAjokZ7XGbxlyMRGrprSneKunSMLUA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/23/24 04:12, Christoph Lameter (Ampere) wrote: > On Tue, 20 Feb 2024, Vlastimil Babka wrote: > >> diff --git a/mm/slub.c b/mm/slub.c >> index 2ef88bbf56a3..a93c5a17cbbb 100644 >> --- a/mm/slub.c >> +++ b/mm/slub.c >> @@ -306,13 +306,13 @@ static inline bool kmem_cache_has_cpu_partial(struct kmem_cache *s) >> >> /* Internal SLUB flags */ >> /* Poison object */ >> -#define __OBJECT_POISON ((slab_flags_t __force)0x80000000U) >> +#define __OBJECT_POISON __SF_BIT(_SLAB_OBJECT_POISON) >> /* Use cmpxchg_double */ >> >> #ifdef system_has_freelist_aba >> -#define __CMPXCHG_DOUBLE ((slab_flags_t __force)0x40000000U) >> +#define __CMPXCHG_DOUBLE __SF_BIT(_SLAB_CMPXCHG_DOUBLE) >> #else >> -#define __CMPXCHG_DOUBLE ((slab_flags_t __force)0U) >> +#define __CMPXCHG_DOUBLE 0 >> #endif > > Maybe its good to put these internal flags together with the other flags. > After all there is no other slab allocator available anymore and having > them all together avoids confusion. Good poiint, will do. Then I can also #undef the helper macro after the last flag.