From: Vlastimil Babka <vbabka@suse.cz>
To: Harry Yoo <harry.yoo@oracle.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org, cl@gentwo.org,
rientjes@google.com, surenb@google.com, hao.li@linux.dev,
kernel test robot <oliver.sang@intel.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] mm/slab: avoid allocating slabobj_ext array from its own slab
Date: Mon, 26 Jan 2026 10:10:31 +0100 [thread overview]
Message-ID: <7ff42564-9c21-41b4-88fa-9733387fe4f4@suse.cz> (raw)
In-Reply-To: <aXcsjyKFsmeVggp5@hyeyoo>
On 1/26/26 09:57, Harry Yoo wrote:
>>
>> Maybe start with something like "We can't simply compare s with
>> obj_exts_cache, because..."
>>
>> > * is selected by the caller address. Since caller address may differ
>> > * between kmalloc_slab() and actual allocation, bump size when both
>> > * are normal kmalloc caches of same size.
>>
>> As we don't test the other for normal kmalloc(), anymore this now reads as
>> if we forgot to.
>
> Ok, something like this:
>
> "We can't simply compare s with obj_exts_cache, because random kmalloc
> caches have multiple caches per size, selected by caller address.
> Since caller address may differ between kmalloc_slab() and actual
> allocation, bump size when sizes are equal."
LGTM!
prev parent reply other threads:[~2026-01-26 9:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-24 10:46 Harry Yoo
2026-01-24 10:53 ` Harry Yoo
2026-01-26 0:51 ` Hao Li
2026-01-26 13:00 ` Harry Yoo
2026-01-26 14:31 ` Hao Li
2026-01-26 7:36 ` Vlastimil Babka
2026-01-26 8:30 ` Harry Yoo
2026-01-26 8:37 ` Vlastimil Babka
2026-01-26 8:57 ` Harry Yoo
2026-01-26 9:10 ` Vlastimil Babka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ff42564-9c21-41b4-88fa-9733387fe4f4@suse.cz \
--to=vbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=cl@gentwo.org \
--cc=hao.li@linux.dev \
--cc=harry.yoo@oracle.com \
--cc=linux-mm@kvack.org \
--cc=oliver.sang@intel.com \
--cc=rientjes@google.com \
--cc=stable@vger.kernel.org \
--cc=surenb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox