From: Tarun Sahu <tsahu@linux.ibm.com>
To: Axel Rasmussen <axelrasmussen@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Shuah Khan <shuah@kernel.org>
Cc: "Zach O'Keefe" <zokeefe@google.com>,
linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org, aneesh.kumar@linux.ibm.com
Subject: Re: [PATCH] selftest: vm: remove orphaned references to local_config.{h,mk}
Date: Thu, 01 Sep 2022 14:43:31 +0530 [thread overview]
Message-ID: <7fec6d15f69751422de1e20cf13b5a3f839da2d1.camel@linux.ibm.com> (raw)
In-Reply-To: <20220831211526.2743216-1-axelrasmussen@google.com>
On Wed, 2022-08-31 at 14:15 -0700, Axel Rasmussen wrote:
> Note: this commit is intended to apply to mm-unstable, the commit
> being
> fixed only exists in that branch for now.
>
> Commit b4efb234e53cc60ccdc855190be9f35918687412 ("Kselftests: remove
> support of libhugetlbfs from kselftests") removed the rule describing
> how to build local_config.{h,mk}, but it left two references to these
> files lingering around. The result is, none of the selftests could be
> built due to dependencies with no rule for how to build them.
>
> Signed-off-by: Axel Rasmussen <axelrasmussen@google.com>
> ---
> tools/testing/selftests/vm/Makefile | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/tools/testing/selftests/vm/Makefile
> b/tools/testing/selftests/vm/Makefile
> index b52f2cc51482..4ae879f70f4c 100644
> --- a/tools/testing/selftests/vm/Makefile
> +++ b/tools/testing/selftests/vm/Makefile
> @@ -1,9 +1,7 @@
> # SPDX-License-Identifier: GPL-2.0
> # Makefile for vm selftests
>
> -LOCAL_HDRS += $(selfdir)/vm/local_config.h
> $(top_srcdir)/mm/gup_test.h
> -
> -include local_config.mk
> +LOCAL_HDRS += $(top_srcdir)/mm/gup_test.h
>
> uname_M := $(shell uname -m 2>/dev/null || echo not)
> MACHINE ?= $(shell echo $(uname_M) | sed -e 's/aarch64.*/arm64/' -e
> 's/ppc64.*/ppc64/')
Thanks, Alex. When I looked why it built in my case, The local_config
was part of .gitignore which "git clean" ignored and they resided there
and source was built without any problem.
I have submitted a new patch for updated .gitignore.
prev parent reply other threads:[~2022-09-01 9:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-31 21:15 Axel Rasmussen
2022-08-31 21:24 ` Zach O'Keefe
2022-09-01 9:13 ` Tarun Sahu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7fec6d15f69751422de1e20cf13b5a3f839da2d1.camel@linux.ibm.com \
--to=tsahu@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=axelrasmussen@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shuah@kernel.org \
--cc=zokeefe@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox