From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E205C3ABBC for ; Tue, 6 May 2025 21:44:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BC1A26B0082; Tue, 6 May 2025 17:44:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B72376B0083; Tue, 6 May 2025 17:44:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A3BBC6B0085; Tue, 6 May 2025 17:44:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 837A36B0082 for ; Tue, 6 May 2025 17:44:32 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 4A4111C95BA for ; Tue, 6 May 2025 21:44:33 +0000 (UTC) X-FDA: 83413812426.25.4CA91D5 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) by imf22.hostedemail.com (Postfix) with ESMTP id 73EA6C000A for ; Tue, 6 May 2025 21:44:31 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=RMi6ExhV; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf22.hostedemail.com: domain of hughd@google.com designates 209.85.216.50 as permitted sender) smtp.mailfrom=hughd@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746567871; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YTOg8ZZYR+z/ies4Nu7D9sk00RCPkm3jPkcu/QULkfI=; b=5SbZubftTsbo0KFdH/3ww62r1oT9joEdwuQouJJy8v3Q+nkx6utj05edmLWislsb+utnMI B52b1Z5eoXt6l1QyJmE8FOSnsjec9hMCJP9RhyZtah0buafAwLPHHqBqmRWUDVkdZmMT01 EO2b07J6yyhxtaEmQPHFODL4mk/1I70= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=RMi6ExhV; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf22.hostedemail.com: domain of hughd@google.com designates 209.85.216.50 as permitted sender) smtp.mailfrom=hughd@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746567871; a=rsa-sha256; cv=none; b=eXHYTclXFAQyGlrKI6AudCqF/d/eAbRPWbu3f7ssy72RYmizhxSLAb2HNcYc1PSI0JA6Ud 0H/FtNIusU+IXwdm1Q/Xp9LbxHpHaHzUe3ghjWhKP5aBxCE/Z6cPMH2OsMjo53C9Rt97l/ jSp5sfq6fIq9rk03yetW6RijoqN2OYE= Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-30aa79ee726so532416a91.2 for ; Tue, 06 May 2025 14:44:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1746567870; x=1747172670; darn=kvack.org; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=YTOg8ZZYR+z/ies4Nu7D9sk00RCPkm3jPkcu/QULkfI=; b=RMi6ExhVJV3b/XQJPsE2nJlELCyEriIPea5kusVBX2bFgLtDiu8Zy5GIUBNrFICO1z WAD7KRQSRnqquvXsSMtt5RaS7YsjeRvOdSZYiSefylVA9/EYePUXbTGwKHCIZYmu62Qg lSGhv8X1a3alxn6nqI5B56rlrY2l1nxFC6TLsTG6zNdLXcYe6uV4ienJmIl+U31XFaIy 0kheqEDMbh/q9yV+C9pn1Lmo09ywRff8xGjnkYx7uCYBg4SkVEd8ozw+28ua/i+PyTWS ZIdhR2HI3dY9+mGzGsJP5ofDPXmYPoowrJAf++VenRD9Iwf2T6S74bgG2JIMgeLuG31y hhJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746567870; x=1747172670; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YTOg8ZZYR+z/ies4Nu7D9sk00RCPkm3jPkcu/QULkfI=; b=UixWoFKFAOFKucqa82GkTKOSuYN+mtcmZiOHVDganqvz/hV78WbeL3rF5ETHsNP9uh k4OgNIfGLKPHW8nV2ls3Cj9UPi3PnZ2GA1FhuUUY44MXc94/AuMKyr5t4hdhaLTNaG8O Wl5FOQu55c+wqNU5ybFxR4lgp11ILonoXcdfRdQ4AnxcpULqUXxddn+7QN46B+I/6k5C pPtW64PJqJ+tciAr1Hgr+qhqyXQfOC3IJ/DBZNwjGYgxASxRHKtPyv5y0rd4l50Ampno GheaUnot3xZ3XRgLKlP2ISv77bL6GnQF9UilFjHE0UX6fZNUEDcenTSLPRtTa2PqYaa2 SmcQ== X-Forwarded-Encrypted: i=1; AJvYcCXUWNRAGADMFBBH6AU7FEuLOzmLlzgyAHRkCeLtFgmjvOwPdyNcZjGNWA2egLBRAkdmBvsJ4D2Ntg==@kvack.org X-Gm-Message-State: AOJu0YxnPop9rZMdufBeX4SUHfiVPzZnZpPpuKfQZ0Np3KQTxAHwCoqi dCeqXQoFssyxasX23tppeUuwbj4MveRqi5hrvD57a2LVVFkL8mr6BxF00+nGFQ== X-Gm-Gg: ASbGnctdFGWY0lzbQwhxp56VkbiBp4fGLLazAUshzYDqnFLTk0mMY3tSWbuIRnYmQax peVlEAoabVZPc044YjvkW7vNngn51hlVEc82FQNA6SrEqrBwXxWtDUgRYH1ddzkjfn+0CIB/QNb N2WJoVy1CJ6DHeJgVVviWOHLAW7FdYlO/Jyz2DJG2f2RVK+nuzSNK0YVLseX3scM49Z4VGwgevl DAI/lTk5NNOVeA2dIKFz1YRA2Rm/lsmYiAw8eQj55MeMqtRZrFHT7TCDY4oflgeZMg4ZeQClWjE ySHFLhacA4K8AoUv8EwvG7ePzmTGUr5XCcqQD9JQs5S2dVz6921fh9ILduq+fxuAZyPcfoZyn/d VWhDRxG/bJAagvulQ5IUcCQ/Z X-Google-Smtp-Source: AGHT+IEXV+gmD2T9yZ9R6KnZkKIBOA06T83p7bG1KcJi94KBGZ/Zy1rFnlaiIlKAL2hyzBil4lmXqg== X-Received: by 2002:a17:90b:1d88:b0:30a:4906:c20c with SMTP id 98e67ed59e1d1-30aac296e97mr1388750a91.35.1746567869993; Tue, 06 May 2025 14:44:29 -0700 (PDT) Received: from darker.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-30aaeae485csm338621a91.44.2025.05.06.14.44.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 May 2025 14:44:28 -0700 (PDT) Date: Tue, 6 May 2025 14:44:17 -0700 (PDT) From: Hugh Dickins To: Muchun Song cc: Johannes Weiner , mhocko@kernel.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, akpm@linux-foundation.org, david@fromorbit.com, zhengqi.arch@bytedance.com, yosry.ahmed@linux.dev, nphamcs@gmail.com, chengming.zhou@linux.dev, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, hamzamahfooz@linux.microsoft.com, apais@linux.microsoft.com, Hugh Dickins Subject: Re: [PATCH RFC 07/28] mm: thp: use folio_batch to handle THP splitting in deferred_split_scan() In-Reply-To: <235f2616-99dd-abfa-f6d1-c178d8ffb363@google.com> Message-ID: <7fd0262d-ff36-d621-191e-4f623a2038c0@google.com> References: <20250415024532.26632-1-songmuchun@bytedance.com> <20250415024532.26632-8-songmuchun@bytedance.com> <20250430143714.GA2020@cmpxchg.org> <235f2616-99dd-abfa-f6d1-c178d8ffb363@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Stat-Signature: uybbwc7pan6zju67kex17f74qinecgzu X-Rspamd-Queue-Id: 73EA6C000A X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1746567871-267710 X-HE-Meta: U2FsdGVkX184TS5mihScyDHixX2EDXk01Q94VPU89aeUr7j7plhYHPLBQBEGWqIEIbOkwgIN60UDI+BnVPBDxhTdde+6ia2oYZgTzaWr3657AUvd1JPQoARB+Q1fB8YVO0tR8OUxYZudoGYK5ZORCmzZbuZm9NIydzcO0fbxFp2rp6y8i5kwueX/lAyP+Hnpllk3u1p01NTam0CA5uky1a90i2tOs16GVBEajckqBhTXlF4sRnBDQkqB611rp9T+gC+nbSiLZi8KZnULT/yoT2R16h33LWdjL1c8X63Q5CWa77qRzkG6W9WWSoQSEWw0FntMRYJF+DYy5JO3XNAFJGGlpvJCT9TWr0JVtUZ5QyQP2Vj7f/MfY5Vc6VpDMVsWffb6AqFyhbk5as3OlaV59kg5NaQZC2Vi/abPoGzycnT3kIqCnJdgb4t+Tl3Qw6Dyd21ONkCEsuyI6b6dwvI4JgJIqNHCjQILtL9dF8+PPMOk4UDkjKkS57CTAEYlepQ3LZRKCw6wZy6rr1t+i078CowRX+pqnWfGBNHZuwXU5t3rpxRZnDOueYwEasRRiAlc6bavhTmjVzxRLiiom9xOc57/Rt5+VSJkZP8DQ698Mw9398dWNYmh2ZeoyUJgECHBzigFCrJH8kQ2nUicAWnr1YCRC3EKyF10l0M8iqDq/Ii3D2vg9STwmM+aCpej5VVUxgsTkauen7q6s51tWsAXs4Pw363jiClDM2g1BXXQ/6HjE+jjZLOg0hwKTTAacgkufol3i5ndgGEovO9C3Nhn5muipfCrbu5Of/kSGL1/yud5J0JQQtdLSM/BcE4ME981fUDFD+husYpFY0+9oK+jCtNUL9n2bv1lb/0gZfsfMQiR4eK8BbCnmY5JAoCkHc7Kd9ge3QS8u32SAGVtAGASHdW1u4Q9ue3BcWUWgQnqEcAD9IaQtTuGa2vqN8R0IafkHLwkECOTu3uzXOALXQX WkBVF0yr lR5cIKiZfH/JcaHucR+WfiFC9NRxiCO8zrW3h5xDm5/dlfAWURkuIiP47ar6IZ+f4wx1JBIJlS0vOXvVW0UzbE73CWsO8XKAO6lyyN2OGzu/hd9K9+c2lDHAwmtE0dCC71HBGNqJyFWxS5UrfAlzy8eg+Tm0BdLZUheQWwiKpU6CRwAmLUUm1fNCjLH2UhJvJu3PiCDSiQ2RbzCvsZYpCVhtcMz0UIujkBPGDilBREHvGuHa+rfBQOdoolNsFQSMGREJo0HCUx0vTXYxiceOj/3aq6LGGT6tQdDSFR5IVFEUC7AOXOYeVLAgfcNebCtgu9XPmcQYfVAamyO8LklYPi/RWCXScZvzT/o3RxfpomyJXwRQArcmy8evL1K7FulwuFlDselA/YKz0PnOtRst8J9n097X9RWhCx/Wc X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 5 May 2025, Hugh Dickins wrote: ... > > However... I was intending to run it for 12 hours on the workstation, > but after 11 hours and 35 minutes, that crashed with list_del corruption, > kernel BUG at lib/list_debug.c:65! from deferred_split_scan()'s > list_del_init(). > > I've not yet put together the explanation: I am deeply suspicious of > the change to when list_empty() becomes true (the block Hannes shows > above is not the only such: (__)folio_unqueue_deferred_split() and > migrate_pages_batch() consult it too), but each time I think I have > the explanation, it's ruled out by folio_try_get()'s reference. > > And aside from the crash (I don't suppose 6.15-rc5 is responsible, > or that patches 08-28/28 would fix it), I'm not so sure that this > patch is really an improvement (folio reference held for longer, and > list lock taken more often when split fails: maybe not important, but > I'm also not so keen on adding in fbatch myself). I didn't spend very > long looking through the patches, but maybe this 07/28 is not essential? The BUG would be explained by deferred_split_folio(): that is still using list_empty(&folio->_deferred_list) to decide whether the folio needs to be added to the _deferred_list (else is already there). With the 07/28 mods, it's liable to add THP to the _deferred_list while deferred_split_scan() holds that THP in its local fbatch. I haven't tried to go through all the ways in which that may go horribly wrong (or be harmless), but one of them is deferred_split_scan() after failed split doing a second list_add_tail() on that THP: no! I won't think about fixes, I'll move on to other tasks. Or does that get changed in 08-28/28? I've not looked. Hugh