Re: [kbuild-all] Re: [linux-stable-rc:linux-4.19.y 1441/2773] drivers/base/node.c:429:5: warning: no previous prototype for function 'register_mem_block_under_node_early'

[Rong Chen <rong.a.chen@intel.com>]

On 1/13/21 3:31 AM, Greg Kroah-Hartman wrote:
> On Tue, Jan 12, 2021 at 08:30:16PM +0100, Greg Kroah-Hartman wrote:
>> On Wed, Jan 13, 2021 at 12:49:52AM +0530, Souptick Joarder wrote:
>>> On Tue, Jan 12, 2021 at 1:32 AM Greg Kroah-Hartman
>>> <gregkh@linuxfoundation.org> wrote:
>>>> On Tue, Jan 12, 2021 at 12:48:22AM +0530, Souptick Joarder wrote:
>>>>> On Sun, Jan 10, 2021 at 6:33 AM kernel test robot <lkp@intel.com> wrote:
>>>>>> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
>>>>>> head:   610bdbf6a174c9a91e34e276a9594114b44bef74
>>>>>> commit: b6f69f72c15d7f973f5709c5351f378f235b3654 [1441/2773] mm: don't rely on system state to detect hot-plug operations
>>>>>> config: x86_64-randconfig-a001-20210110 (attached as .config)
>>>>>> compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project bc556e5685c0f97e79fb7b3c6f15cc5062db8e36)
>>>>>> reproduce (this is a W=1 build):
>>>>>>          wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>>>>>>          chmod +x ~/bin/make.cross
>>>>>>          # install x86_64 cross compiling tool for clang build
>>>>>>          # apt-get install binutils-x86-64-linux-gnu
>>>>>>          # https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?id=b6f69f72c15d7f973f5709c5351f378f235b3654
>>>>>>          git remote add linux-stable-rc https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
>>>>>>          git fetch --no-tags linux-stable-rc linux-4.19.y
>>>>>>          git checkout b6f69f72c15d7f973f5709c5351f378f235b3654
>>>>>>          # save the attached .config to linux build tree
>>>>>>          COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
>>>>>>
>>>>>> If you fix the issue, kindly add following tag as appropriate
>>>>>> Reported-by: kernel test robot <lkp@intel.com>
>>>>>>
>>>>>> All warnings (new ones prefixed by >>):
>>>>>>
>>>>>>>> drivers/base/node.c:429:5: warning: no previous prototype for function 'register_mem_block_under_node_early' [-Wmissing-prototypes]
>>>>>>     int register_mem_block_under_node_early(struct memory_block *mem_blk, void *arg)
>>>>>>         ^
>>>>>>     drivers/base/node.c:429:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
>>>>>>     int register_mem_block_under_node_early(struct memory_block *mem_blk, void *arg)
>>>>>>     ^
>>>>>>     static
>>>>>>     1 warning generated.
>>>>> It is fixed in the mainline. Will stable tree pick it from there ?
>>>> What is the git commit id for this?
>>> commit  f85086f95fa3 (mm: don't rely on system state to detect
>>> hot-plug operations)
>>> which marks this function as static.
>> Ah, that's not ok for stable trees.  Don't worry about this, sparse
>> issues for stuff like this is not a big deal for stable releases.
> And it's already in the 4.19 tree, so I have no idea why 0-day is
> complaining...

Hi Greg,

The function isn't marked as static in the 4.19 tree.

# commit in mainline is "f85086f95fa3 (mm: don't rely on system state to 
detect hot-plug operations)"
$ git show f85086f95fa3 | grep register_mem_block_under_node_early\(
+static int register_mem_block_under_node_early(struct memory_block 
*mem_blk,

# commit in linux-stable-rc/linux-4.19.y is "b6f69f72c15d (mm: don't 
rely on system state to detect hot-plug operations)"
$ git show b6f69f72c15d | grep register_mem_block_under_node_early\(
+int register_mem_block_under_node_early(struct memory_block *mem_blk, 
void *arg)

Best Regards,
Rong Chen